[Lldb-commits] [lldb] r371491 - [LLDB] FreeBSD fix new SetFile call.

Author: devnexen Date: Tue Sep 10 00:33:39 2019 New Revision: 371491 URL: http://llvm.org/viewvc/llvm-project?rev=371491&view=rev Log: [LLDB] FreeBSD fix new SetFile call. Modified: lldb/trunk/source/Host/freebsd/HostInfoFreeBSD.cpp Modified: lldb/trunk/source/Host/freebsd/HostInfoFreeBSD.cp

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk created this revision. kwk added a reviewer: labath. Herald added subscribers: lldb-commits, MaskRay, arichardson, emaste. Herald added a reviewer: espindola. Herald added a reviewer: alexshap. Herald added a project: LLDB. This change ensures that the .dynsym section will be parsed even when

[Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

aleksandr.urakov added a comment. It's a good point, thank you! I had the same thoughts when I done it, but I'm not completely sure. The problem is that an object file can't be completely responsible for choosing an unwind plan, because some plans are produced by symbol files (and an object fil

[Lldb-commits] [PATCH] D67376: [DWARF] Evaluate DW_OP_entry_value

aprantl added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3752 +LocationInCaller = parse_simple_location(i); +break; + } vsk wrote: > aprantl wrote: > > default? > I don't believe any action is needed

[Lldb-commits] [PATCH] D67369: Implement DW_OP_convert

aprantl marked an inline comment as done. aprantl added inline comments. Comment at: lldb/include/lldb/Utility/Scalar.h:107 + /// Return the most efficient Scalar::Type for the requested size. + static Type GetBestType(size_t bit_size, bool sign); + vsk wrote:

[Lldb-commits] [PATCH] D67369: Implement DW_OP_convert

aprantl marked 5 inline comments as done. aprantl added inline comments. Comment at: lldb/source/Expression/DWARFExpression.cpp:2571 + if (stack.size() < 1) { +if (error_ptr) + error_ptr->SetErrorString( vsk wrote: > JDevlieghere wrote: > >

[Lldb-commits] [lldb] r371532 - Implement DW_OP_convert

Author: adrian Date: Tue Sep 10 09:17:38 2019 New Revision: 371532 URL: http://llvm.org/viewvc/llvm-project?rev=371532&view=rev Log: Implement DW_OP_convert This patch adds basic support for DW_OP_convert[1] for integer types. Recent versions of LLVM's optimizer may insert this opcode into DWARF

[Lldb-commits] [PATCH] D67369: Implement DW_OP_convert

This revision was automatically updated to reflect the committed changes. Closed by commit rL371532: Implement DW_OP_convert (authored by adrian, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D67369?vs=21

[Lldb-commits] [PATCH] D67376: [DWARF] Evaluate DW_OP_entry_value

vsk updated this revision to Diff 219573. vsk marked an inline comment as done. vsk edited the summary of this revision. vsk added a comment. - Addressed review feedback, split out unrelated changes, and improved test coverage. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67376/new/ h

[Lldb-commits] [PATCH] D67376: [DWARF] Evaluate DW_OP_entry_value

vsk marked an inline comment as done. vsk added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3752 +LocationInCaller = parse_simple_location(i); +break; + } aprantl wrote: > vsk wrote: > > aprantl wrote

[Lldb-commits] [lldb] r371544 - [lldbtest] Add an "expected_cmd_failure" option to the filecheck helper

Author: vedantk Date: Tue Sep 10 11:36:53 2019 New Revision: 371544 URL: http://llvm.org/viewvc/llvm-project?rev=371544&view=rev Log: [lldbtest] Add an "expected_cmd_failure" option to the filecheck helper Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py Modified: lldb/trunk/p

[Lldb-commits] [lldb] r371543 - [Function] Factor out GetCallEdgeForReturnAddress, NFC

Author: vedantk Date: Tue Sep 10 11:36:50 2019 New Revision: 371543 URL: http://llvm.org/viewvc/llvm-project?rev=371543&view=rev Log: [Function] Factor out GetCallEdgeForReturnAddress, NFC Finding the call edge in a function which corresponds to a particular return address is a generic/useful ope

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

JDevlieghere added inline comments. Comment at: lldb/lit/Modules/ELF/load-from-dynsym-alone.test:24 +# Remove functionInDynsym symbol from .symtab (will leave symbol in .dynsym intact) +# RUN: llvm-strip --strip-symbol=functionInDynsym %t.binary + Please also ad

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk updated this revision to Diff 219587. kwk added a comment. - Added llvm-strip to the list of support tools Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67390/new/ https://reviews.llvm.org/D67390 Files: lldb/lit/Modules/ELF/Inputs/load-from-

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk marked an inline comment as done. kwk added a comment. @JDevlieghere I change the support tool. It was @labath who requested (D66791#inline-601050 ) to outsource this patch. In that change you can find the whole reason which is somewhat more lo

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk updated this revision to Diff 219594. kwk marked an inline comment as done. kwk added a comment. - update comment for .symtab section with minidebuginfo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67390/new/ https://reviews.llvm.org/D67390 F

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk added a comment. Fixed the comment as per request. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67390/new/ https://reviews.llvm.org/D67390 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D67376: [DWARF] Evaluate DW_OP_entry_value

grandinj added inline comments. Comment at: lldb/include/lldb/Symbol/Function.h:258 + +using CallSiteParameterArray = std::unique_ptr>; + the way this is being used seems to indicate it can be std::vector no need for unique_ptr CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks! This LGTM with the comment on line 2660 rephrased and the motivation as part of the summary/commit message. Comment at: lldb/source/Plugins/ObjectFile/EL

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk updated this revision to Diff 219605. kwk added a comment. - Rephrase comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67390/new/ https://reviews.llvm.org/D67390 Files: lldb/lit/Modules/ELF/Inputs/load-from-dynsym-alone.c lldb/lit/Mod

[Lldb-commits] [PATCH] D67111: Adding caching to libc++ std::function formatter for lookups that require scanning symbols

shafik updated this revision to Diff 219604. shafik marked an inline comment as done. shafik added a comment. - Refactored test to use a function to do repetitive task CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67111/new/ https://reviews.llvm.org/D67111 Files: packages/Python/lld

[Lldb-commits] [lldb] r371560 - Fix a thinko in handling the QSetLogging packet.

Author: jingham Date: Tue Sep 10 14:58:22 2019 New Revision: 371560 URL: http://llvm.org/viewvc/llvm-project?rev=371560&view=rev Log: Fix a thinko in handling the QSetLogging packet. The comparison against LOG_MEMORY shortcut all the LOG_MEMORY_* log channels. It has to come last. Modified:

[Lldb-commits] [PATCH] D67111: Adding caching to libc++ std::function formatter for lookups that require scanning symbols

aprantl added inline comments. Comment at: source/Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.cpp:248 + if (CallableLookupCache.count(func_to_match)) +return CallableLookupCache[func_to_match]; This is performing the lookup twice. ``` auto it = Ca

[Lldb-commits] [PATCH] D67111: Adding caching to libc++ std::function formatter for lookups that require scanning symbols

friss added inline comments. Comment at: packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/function/TestLibCxxFunction.py:31 +self.expect("log timers dump", + patterns=["(?!lldb_private::Module::FindSymbolsMatching

[Lldb-commits] [PATCH] D67376: [DWARF] Evaluate DW_OP_entry_value

vsk planned changes to this revision. vsk marked an inline comment as done. vsk added a comment. While tightening up the test case I think I found an issue with the way inlined frames are handled. I need to take a closer look. Comment at: lldb/include/lldb/Symbol/Function.h:25

[Lldb-commits] [PATCH] D67376: [DWARF] Evaluate DW_OP_entry_value

aprantl added inline comments. Comment at: lldb/include/lldb/Symbol/Function.h:258 + +using CallSiteParameterArray = std::unique_ptr>; + vsk wrote: > grandinj wrote: > > the way this is being used seems to indicate it can be > >std::vector > > no need for un

[Lldb-commits] [PATCH] D67111: Adding caching to libc++ std::function formatter for lookups that require scanning symbols

shafik updated this revision to Diff 219621. shafik marked 2 inline comments as done. shafik added a comment. - Fixing test based on comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67111/new/ https://reviews.llvm.org/D67111 Files: packages/Python/lldbsuite/test/functionalitie

[Lldb-commits] [PATCH] D67111: Adding caching to libc++ std::function formatter for lookups that require scanning symbols

shafik added inline comments. Comment at: packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/function/TestLibCxxFunction.py:31 +self.expect("log timers dump", + patterns=["(?!lldb_private::Module::FindSymbolsMatchin

[Lldb-commits] [PATCH] D67111: Adding caching to libc++ std::function formatter for lookups that require scanning symbols

shafik updated this revision to Diff 219633. shafik marked 3 inline comments as done. shafik added a comment. Changes based on comments: - Removed extra lookup - Refactored redundant code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67111/new/ https://reviews.llvm.org/D67111 Files:

[Lldb-commits] [PATCH] D67427: [Plugins/Process] Remove direct use of ClangASTContext from InferiorCallPOSIX

xiaobai created this revision. xiaobai added reviewers: JDevlieghere, compnerd, davide, clayborg. Herald added a project: LLDB. InferiorCallPOSIX directly grabs a ClangASTContext from the Target it has and does no error checking. I don't think these functions have a reason to know about clang spec

[Lldb-commits] [lldb] r371582 - Skip a test in TestProcessIO.py when running against ios devices.

Author: jmolenda Date: Tue Sep 10 18:02:30 2019 New Revision: 371582 URL: http://llvm.org/viewvc/llvm-project?rev=371582&view=rev Log: Skip a test in TestProcessIO.py when running against ios devices. Modified: lldb/trunk/packages/Python/lldbsuite/test/python_api/process/io/TestProcessIO.py

[Lldb-commits] [lldb] r371583 - Ah, only skip this for embedded darwin targets.

Author: jmolenda Date: Tue Sep 10 18:03:24 2019 New Revision: 371583 URL: http://llvm.org/viewvc/llvm-project?rev=371583&view=rev Log: Ah, only skip this for embedded darwin targets. Modified: lldb/trunk/packages/Python/lldbsuite/test/python_api/process/io/TestProcessIO.py Modified: lldb/t

[Lldb-commits] [PATCH] D67376: [DWARF] Evaluate DW_OP_entry_value

vsk updated this revision to Diff 219646. vsk marked 4 inline comments as done. vsk added a comment. - Fix return address lookup when the immediate parent frame is inlined. - Tighten the test so that it actually verifies that tail calls, inlining, etc. occur, instead of assuming :). - Add/move va

[Lldb-commits] [PATCH] D67376: [DWARF] Evaluate DW_OP_entry_value

vsk added inline comments. Comment at: lldb/include/lldb/Symbol/Function.h:258 + +using CallSiteParameterArray = std::unique_ptr>; + aprantl wrote: > vsk wrote: > > grandinj wrote: > > > the way this is being used seems to indicate it can be > > >std::vector

[Lldb-commits] [PATCH] D67376: [DWARF] Evaluate DW_OP_entry_value

vsk added inline comments. Comment at: lldb/include/lldb/Symbol/Function.h:258 + +using CallSiteParameterArray = std::unique_ptr>; + vsk wrote: > aprantl wrote: > > vsk wrote: > > > grandinj wrote: > > > > the way this is being used seems to indicate it can be >

[Lldb-commits] [PATCH] D67376: [DWARF] Evaluate DW_OP_entry_value

vsk updated this revision to Diff 219648. vsk marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67376/new/ https://reviews.llvm.org/D67376 Files: lldb/include/lldb/Symbol/Function.h lldb/packages/Python/lldbsuite/test/decorators.py lldb/packages/Pytho