[Lldb-commits] [lldb] r372946 - [lldb][NFC] Use AppendEmptyArgument in CompletionRequest constructor

Author: teemperor Date: Thu Sep 26 00:06:05 2019 New Revision: 372946 URL: http://llvm.org/viewvc/llvm-project?rev=372946&view=rev Log: [lldb][NFC] Use AppendEmptyArgument in CompletionRequest constructor We now have a utility function for this purpose. (Also fixing the typo in the related comme

[Lldb-commits] [lldb] r372952 - SystemInitializer: Use Targets.def to selectively initialize ABI plugins

Author: labath Date: Thu Sep 26 02:47:32 2019 New Revision: 372952 URL: http://llvm.org/viewvc/llvm-project?rev=372952&view=rev Log: SystemInitializer: Use Targets.def to selectively initialize ABI plugins This avoids having to define additional macros in the cmake file, and and also makes the lo

[Lldb-commits] [lldb] r372961 - Don't stop execution in batch mode when process stops with SIGINT or SIGSTOP

Author: tkrasnukha Date: Thu Sep 26 03:57:11 2019 New Revision: 372961 URL: http://llvm.org/viewvc/llvm-project?rev=372961&view=rev Log: Don't stop execution in batch mode when process stops with SIGINT or SIGSTOP Summary: Usually, SIGINT and SIGSTOP don't imply a crash, e.g. SIGSTOP is sent on

[Lldb-commits] [PATCH] D67776: Don't stop execution in batch mode when process stops with SIGINT or SIGSTOP

This revision was automatically updated to reflect the committed changes. Closed by commit rL372961: Don't stop execution in batch mode when process stops with SIGINT or SIGSTOP (authored by tkrasnukha, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[Lldb-commits] [PATCH] D68048: [WIP][RFC] Improve fetching the process list on the android platform

labath added reviewers: srhines, danalbert. labath added a comment. I think we should take a step back first. What is the behavior we expect from the "platform process list" command ? I think the current expectation is (and this is consistent with @clayborg's comment in https://reviews.llvm.or

[Lldb-commits] [PATCH] D67994: [WIP] Modify lldb-test to print out ASTs from symbol file

labath added a comment. In D67994#1683440 , @shafik wrote: > I believe this is due to us being lazy as to when we import. Yes, but doesn't calling `Module::ParseAllDebugSymbols` force us to parse everything? "image dump ast" does dump only the things t

[Lldb-commits] [lldb] r372965 - [lldb][modern-type-lookup] Add test for using the ClangModulesDeclVendor

Author: teemperor Date: Thu Sep 26 04:30:41 2019 New Revision: 372965 URL: http://llvm.org/viewvc/llvm-project?rev=372965&view=rev Log: [lldb][modern-type-lookup] Add test for using the ClangModulesDeclVendor Added: lldb/trunk/packages/Python/lldbsuite/test/functionalities/modern-type-lookup

[Lldb-commits] [lldb] r372971 - [lldb][www] Update bot links

Author: teemperor Date: Thu Sep 26 04:48:45 2019 New Revision: 372971 URL: http://llvm.org/viewvc/llvm-project?rev=372971&view=rev Log: [lldb][www] Update bot links Modified: lldb/trunk/docs/resources/bots.rst Modified: lldb/trunk/docs/resources/bots.rst URL: http://llvm.org/viewvc/llvm-pro

[Lldb-commits] [PATCH] D68069: Explicitly set entry point arch when it's thumb

labath added a comment. This sounds like a reasonable thing to do, but it seems to me we make that more generic. Having a symbol for the entry point would help in other cases too, and we already go through a lot of trouble to track down various symbol addresses (plt parsing, eh_frame parsing, .

[Lldb-commits] [PATCH] D67996: Convert FileSystem::Open() to return Expected

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. looks good to me, a extra couple of small comments inline. Thank you for taking your time to do this. Comment at: lldb/include/lldb/Core/StreamFile.h:38 + StreamFile(std

[Lldb-commits] [lldb] r372974 - [lldb][modern-type-lookup] Fix crash when activating modern-type-lookup on Linux

Author: teemperor Date: Thu Sep 26 05:33:48 2019 New Revision: 372974 URL: http://llvm.org/viewvc/llvm-project?rev=372974&view=rev Log: [lldb][modern-type-lookup] Fix crash when activating modern-type-lookup on Linux There is no ClangModulesDeclVendor on Linux so that cast is triggering an asser

[Lldb-commits] [PATCH] D68083: Simplify SBCommandReturnObject

jankratochvil created this revision. jankratochvil added reviewers: labath, jingham, clayborg. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. A simplification for D67589 . `m_opaque_up` can never be `nullptr` (unless one calls a ctor

[Lldb-commits] [PATCH] D68083: Simplify SBCommandReturnObject

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. cool Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68083/new/ https://reviews.llvm.org/D68083 ___ lldb-commits

[Lldb-commits] [lldb] r372976 - [lldb] Code cleanup: Simplify SBCommandReturnObject

Author: jankratochvil Date: Thu Sep 26 06:31:59 2019 New Revision: 372976 URL: http://llvm.org/viewvc/llvm-project?rev=372976&view=rev Log: [lldb] Code cleanup: Simplify SBCommandReturnObject A simplification for D67589. m_opaque_up can never be nullptr (unless one calls a ctor with nullptr or on

[Lldb-commits] [PATCH] D68083: Simplify SBCommandReturnObject

This revision was automatically updated to reflect the committed changes. Closed by commit rL372976: [lldb] Code cleanup: Simplify SBCommandReturnObject (authored by jankratochvil, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: ht

[Lldb-commits] [PATCH] D67965: Have ABI plugins vend llvm MCRegisterInfo data

sylvestre.ledru added a comment. @labath I am building with AVR as experimental target and this change probably broke the build. In file included from /home/sylvestre/dev/debian/pkg-llvm/llvm-toolchain/branches/llvm-toolchain-snapshot_10~svn372978/tools/lldb/source/API/SystemInitializerFull.

[Lldb-commits] [PATCH] D68088: Set eRegisterKindEHFrame register numbers for 32 bit ARM register contexts in minidumps

clayborg created this revision. clayborg added reviewers: labath, aadsm, dvlahovski. Herald added a subscriber: kristof.beyls. Stack unwinding was sometimes failing when trying to unwind stacks in 32 bit ARM. I discovered this was because the EH frame register numbers were not set. This patch fi

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk updated this revision to Diff 221968. kwk added a comment. - Adjust other occurrence of AddSymbol where ELF plays a role - Working tests - Use unordered_set for storing unique elf symbols Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67390/new/

[Lldb-commits] [PATCH] D66451: [ClangExpressionParser] Add ClangDeclVendor

shafik added inline comments. Herald added a subscriber: usaxena95. Comment at: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp:110 do { - DeclVendor *modules_decl_vendor = - m_target->GetClangModulesDeclVendor(); + auto *modules_decl_

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

clayborg added a comment. So overall approach is good. See inline comments for issue and questions. Comment at: lldb/source/Plugins/ObjectFile/ELF/ELFHeader.cpp:371-373 + r.st_name = st_name; + return elf::ELFSymbol::operator==(r) && + st_name_string == rhs.st_name_st

[Lldb-commits] [PATCH] D67966: Use llvm for dumping DWARF expressions

clayborg added a comment. nice! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67966/new/ https://reviews.llvm.org/D67966 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r372998 - SystemInitializer: Define macros for experimental targets too

Author: labath Date: Thu Sep 26 10:15:18 2019 New Revision: 372998 URL: http://llvm.org/viewvc/llvm-project?rev=372998&view=rev Log: SystemInitializer: Define macros for experimental targets too Modified: lldb/trunk/source/API/SystemInitializerFull.cpp lldb/trunk/tools/lldb-test/SystemIni

[Lldb-commits] [PATCH] D67965: Have ABI plugins vend llvm MCRegisterInfo data

labath added a comment. In D67965#1684297 , @sylvestre.ledru wrote: > @labath > I am building with AVR as experimental target and this change probably broke > the build. > > Could you please have a look? > thanks Thanks for the heads up. r372998 ough

[Lldb-commits] [PATCH] D67996: Convert FileSystem::Open() to return Expected

lawrence_danna added a comment. done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67996/new/ https://reviews.llvm.org/D67996 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [PATCH] D67996: Convert FileSystem::Open() to return Expected

lawrence_danna updated this revision to Diff 221985. lawrence_danna marked 3 inline comments as done. lawrence_danna added a comment. fixed the remaining comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67996/new/ https://reviews.llvm.org/D67

[Lldb-commits] [PATCH] D67996: Convert FileSystem::Open() to return Expected

This revision was automatically updated to reflect the committed changes. Closed by commit rL373003: Convert FileSystem::Open() to return Expected (authored by lawrence_danna, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D66451: [ClangExpressionParser] Add ClangDeclVendor

xiaobai marked an inline comment as done. xiaobai added inline comments. Comment at: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp:110 do { - DeclVendor *modules_decl_vendor = - m_target->GetClangModulesDeclVendor(); + auto *modules_

[Lldb-commits] [PATCH] D68096: Add Linux signal support to ProcessMinidump

JosephTremoulet created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Set the UnixSignals object when isOSLinux is true, and force a SIGSTOP if there's no other signal when loading a core dump (the same as ProcessElfCore::DoLoadCore does) since the loading p

[Lldb-commits] [PATCH] D68096: Add Linux signal support to ProcessMinidump

JosephTremoulet added a comment. I'm trying to fix an issue where opening a minidump created by breakpad in lldb just hangs, but if I use breakpad's minidump-2-core on that same dump then opening the core dump works fine. From debugging the two cases I can see that the critical logic that Proc

[Lldb-commits] [PATCH] D68048: [WIP][RFC] Improve fetching the process list on the android platform

clayborg added a comment. We were discussing things over here and were wondering if we even need the lldb-server in order to connect to the platform, or if we should just implement everything through command line commands like "adb", or link against a ADB shared library (is there one?), or anot

[Lldb-commits] [PATCH] D67589: Fix crash on SBCommandReturnObject & assignment

jankratochvil updated this revision to Diff 222021. jankratochvil edited the summary of this revision. jankratochvil added a comment. Changed @clayborg's `lldb_private::CommandReturnObjectImpl` to `lldb_private::SBCommandReturnObjectImpl` - both variants are used in LLDB `SB*.cpp` and the `SB*`

[Lldb-commits] [lldb] r373016 - [lldb-vscode] correctly handle multiple sourceMap entries

Author: xiaobai Date: Thu Sep 26 14:18:37 2019 New Revision: 373016 URL: http://llvm.org/viewvc/llvm-project?rev=373016&view=rev Log: [lldb-vscode] correctly handle multiple sourceMap entries Summary: `lldb-vscode` concatenates a string of sourceMap entries specified in the config, but fails to p

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk updated this revision to Diff 222029. kwk added a comment. - Cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67390/new/ https://reviews.llvm.org/D67390 Files: lldb/lit/Modules/ELF/Inputs/load-from-dynsym-alone.c lldb/lit/Modules/ELF/

[Lldb-commits] [PATCH] D68106: Fix a crasher due to an assert when two files have the same UUID but different paths.

clayborg updated this revision to Diff 222032. clayborg added a comment. Remove printf that was left in. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68106/new/ https://reviews.llvm.org/D68106 Files: lldb/packages/Python/lldbsuite/test/functio

[Lldb-commits] [PATCH] D68106: Fix a crasher due to an assert when two files have the same UUID but different paths.

clayborg created this revision. clayborg added reviewers: labath, aadsm, dvlahovski. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. clayborg updated this revision to Diff 222032. clayborg added a comment. Remove printf that was left in. The PlaceholderObjectFile has an as

[Lldb-commits] [PATCH] D68069: Explicitly set entry point arch when it's thumb

aadsm marked an inline comment as done. aadsm added a comment. > For the test, what would you say to writing that as a lit test instead > (testing the address class deduction via the disassemble command you > mentioned)? I was actually keen on this since lit is the only type of test I haven't u

[Lldb-commits] [PATCH] D68069: Explicitly set entry point arch when it's thumb

aadsm updated this revision to Diff 222063. aadsm added a comment. Use GetNextSyntheticSymbolName() to generate the symbol name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68069/new/ https://reviews.llvm.org/D68069 Files: lldb/source/Plugins/O

[Lldb-commits] [PATCH] D67891: remove File::SetStream(), make new files instead.

lawrence_danna added a comment. @labath how's this one looking? need any changes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67891/new/ https://reviews.llvm.org/D67891 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk updated this revision to Diff 222073. kwk added a comment. - Cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67390/new/ https://reviews.llvm.org/D67390 Files: lldb/lit/Modules/ELF/Inputs/load-from-dynsym-alone.c lldb/lit/Modules/ELF/

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk updated this revision to Diff 222075. kwk marked 10 inline comments as done. kwk added a comment. - Change order of compare members to match order of member definitions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67390/new/ https://reviews.l

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk added a comment. Not all is answered now but please respect: https://reviews.llvm.org/D67390#1683705 Comment at: lldb/source/Plugins/ObjectFile/ELF/ELFHeader.cpp:371-373 + r.st_name = st_name; + return elf::ELFSymbol::operator==(r) && + st_name_string == rhs.st_n

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk updated this revision to Diff 222076. kwk added a comment. - make the section name part of NamedELFSymbol Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67390/new/ https://reviews.llvm.org/D67390 Files: lldb/lit/Modules/ELF/Inputs/load-from-d

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk marked 9 inline comments as done. kwk added a comment. I think I've finished the implementation now and should have answered all your comments and concerns. I run tests now. I would appreciate if you (@clayborg , @labath , @jankratochvil ) can take a look at this patch again.

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk updated this revision to Diff 222080. kwk marked an inline comment as done. kwk added a comment. - Use symbol name including @VERSION suffix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67390/new/ https://reviews.llvm.org/D67390 Files: lld

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk added a comment. Interesting. It looks like we indeed have a test (the only one failing atm.) that wants a symbol to be added twice: [ RUN ] MangledTest.NameIndexes_FindFunctionSymbols /home/kkleine/llvm/lldb/unittests/Core/MangledTest.cpp:186: Failure Expected: 1 To be eq