[Lldb-commits] [PATCH] D68069: Explicitly set entry point arch when it's thumb

labath added a comment. In D68069#1686199 , @aadsm wrote: > > Not everyone has both of these things enabled (particularly having lld is > > less common), but they are things that one _can_ enable no matter what is > > his host or target architecture, s

[Lldb-commits] [PATCH] D68171: Remove unused "append" parameter from FindTypes API

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Nuke it from orbit. It's the only way to be sure. I'd also consider removing the size_t return value. If some user really needs that, he can always implement the counting himself. CHANGES SI

[Lldb-commits] [PATCH] D68179: [lldb] Fix JSON parser to allow empty arrays

labath added a comment. In D68179#1686893 , @davide wrote: > This needs a test. You can either write a python one as the ones in > `test/testcases` or a lit-style based as the ones in `lit/`. Another option might be a c++ unit test for the JSON class (s

[Lldb-commits] [PATCH] D67793: new api class: SBFile

labath added a comment. Thanks. This looks good to me, but given that this is going to become a stable api that well need to maintain for a looong time, I'd like to get signoff from someone else as well. @jingham maybe ? Comment at: lldb/include/lldb/API/SBDefines.h:95 class

[Lldb-commits] [PATCH] D68134: [LLDB] Use the llvm microsoft demangler instead of the windows dbghelp api

labath added a comment. (See CPlusPlusLanguage::MethodName for one such parsing instance.) Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68134/new/ https://reviews.llvm.org/D68134 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D68134: [LLDB] Use the llvm microsoft demangler instead of the windows dbghelp api

labath added a comment. In D68134#1687031 , @mstorsjo wrote: > In D68134#1686970 , @thakis wrote: > > > We can add flags for omitting access specifiers etc if it's critical for > > lldb. Or maybe we can just change

[Lldb-commits] [PATCH] D68134: [LLDB] Use the llvm microsoft demangler instead of the windows dbghelp api

mstorsjo updated this revision to Diff 222358. mstorsjo edited the summary of this revision. mstorsjo added a reviewer: thakis. mstorsjo added a comment. I tried to update the testcases based on the log output (http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/9306/steps/test/logs/s

[Lldb-commits] [PATCH] D68181: SBDebugger::SetInputFile, SetOutputFile, etc.

labath added a comment. Looks mostly fine to me. Just a couple of questions inline... Comment at: lldb/packages/Python/lldbsuite/test/python_api/file_handle/TestFileHandle.py:243-244 +status = debugger.SetOutputFile(outsbf) +if status.Fail(): +

[Lldb-commits] [PATCH] D68134: [LLDB] Use the llvm microsoft demangler instead of the windows dbghelp api

mstorsjo reopened this revision. mstorsjo added a comment. This revision is now accepted and ready to land. In D68134#1687500 , @labath wrote: > In D68134#1687031 , @mstorsjo wrote: > > > In D68134#1686970

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

labath added a comment. I haven't looked at the patch in detail, but I have one high-level question. It seems to be that instead of subclassing a fully-functional File class, it would be better to create an abstract class, that both `File` and the new python thingy could implement. That would a

[Lldb-commits] [lldb] r373193 - [lldb][clang][modern-type-lookup] Use ASTImporterSharedState in ExternalASTMerger

Author: teemperor Date: Mon Sep 30 01:52:16 2019 New Revision: 373193 URL: http://llvm.org/viewvc/llvm-project?rev=373193&view=rev Log: [lldb][clang][modern-type-lookup] Use ASTImporterSharedState in ExternalASTMerger Summary: The ExternalASTMerger should use the ASTImporterSharedState. This all

[Lldb-commits] [PATCH] D68140: [lldb][clang][modern-type-lookup] Use ASTImporterSharedState in ExternalASTMerger

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL373193: [lldb][clang][modern-type-lookup] Use ASTImporterSharedState in… (authored by teemperor, committed by ). Herald ad

[Lldb-commits] [lldb] r373194 - [lldb] Partly revert 370734: Test 'frame select -r' and fix that INT32_MIN breaks the option parser

Author: teemperor Date: Mon Sep 30 02:00:23 2019 New Revision: 373194 URL: http://llvm.org/viewvc/llvm-project?rev=373194&view=rev Log: [lldb] Partly revert 370734: Test 'frame select -r' and fix that INT32_MIN breaks the option parser This somehow caused that 'frame select X' ends up being inte

[Lldb-commits] [PATCH] D68140: [lldb][clang][modern-type-lookup] Use ASTImporterSharedState in ExternalASTMerger

teemperor marked 2 inline comments as done. teemperor added inline comments. Comment at: clang/include/clang/AST/ExternalASTMerger.h:92 ImporterTarget Target; + std::shared_ptr SharedState; shafik wrote: > Can you add a comment explaining what this is and w

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk marked 8 inline comments as done. kwk added a comment. In D67390#1685484 , @labath wrote: > This looks fairly ok to me, but it could use a more explicit test of the > symbol uniqueing code. Right, now I believe the two tests you added check > that th

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk updated this revision to Diff 222387. kwk marked an inline comment as done. kwk added a comment. - typo: dynmic -> dynamic - Applied changes requested in review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67390/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D68096: ProcessMinidump: inject SIGSTOP on Linux if no thread has a signal

labath added a comment. Thanks for cleaning this up, and for sending the minidump. Looking at the dump, I am pretty sure that the problem is the lack of proper exception stream support in yaml2obj. The stream contains a reference to a thread context, and since yaml2obj does not understand this,

[Lldb-commits] [PATCH] D68210: Object/minidump: Add support for the MemoryInfoList stream

labath created this revision. labath added reviewers: amccarth, jhenderson, clayborg. Herald added a project: LLVM. This patch adds the definitions of the constants and structures necessary to interpret the MemoryInfoList minidump stream, as well as the object::MinidumpFile interface to access the

[Lldb-commits] [lldb] r373201 - [lldb] Reland 370734: Test 'frame select -r' and fix that INT32_MIN breaks the option parser

Author: teemperor Date: Mon Sep 30 05:49:32 2019 New Revision: 373201 URL: http://llvm.org/viewvc/llvm-project?rev=373201&view=rev Log: [lldb] Reland 370734: Test 'frame select -r' and fix that INT32_MIN breaks the option parser The problem with r370734 was that it removed the code for resetting

[Lldb-commits] [PATCH] D68134: [LLDB] Use the llvm microsoft demangler instead of the windows dbghelp api

labath accepted this revision. labath added a comment. In D68134#1687518 , @mstorsjo wrote: > In D68134#1687500 , @labath wrote: > > > I'm not sure what failed here exactly, but there are some places in lldb > > th

[Lldb-commits] [PATCH] D67589: Fix crash on SBCommandReturnObject & assignment

labath added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/api/command-return-object/Makefile:1 +MAKE_DSYM := NO + jankratochvil wrote: > jankratochvil wrote: > > labath wrote: > > > I'm pretty sure this line is not needed. > > Removed in curr

[Lldb-commits] [PATCH] D67222: [Windows] Added support of watchpoints to `NativeProcessWindows`

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Cool, maybe we should have a setting/environment variable/something to control which plugin is used. That would make it easier to switch between the two implementations. Repository: rLLDB

[Lldb-commits] [lldb] r373206 - [lldb][NFC][modern-type-lookup] Remove while(false) behind if() {}

Author: teemperor Date: Mon Sep 30 06:08:08 2019 New Revision: 373206 URL: http://llvm.org/viewvc/llvm-project?rev=373206&view=rev Log: [lldb][NFC][modern-type-lookup] Remove while(false) behind if() {} This was originally a 'do { ... } while (false);' like in the rest of the function, but the do

[Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

labath added a comment. I'm afraid I don't have much to add beyond what I've already said. I think @jasonmolenda should make the call as to how to move forward here. If the chosen direction requires any changes in how the breakpad unwind info handled, I'm happy to give you a hand there. Repos

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk added a comment. @labath I did prepare some YAML file but apparently `yaml2obj` isn't meant to deal with this properly. Instead I get an Error like this: `yaml2obj: error: repeated symbol name: 'main'`. It looks like symbols from the `Symbols:` part of the YAML file are just added by name t

[Lldb-commits] [lldb] r373208 - Use llvm for dumping DWARF expressions

Author: labath Date: Mon Sep 30 06:44:17 2019 New Revision: 373208 URL: http://llvm.org/viewvc/llvm-project?rev=373208&view=rev Log: Use llvm for dumping DWARF expressions Summary: It uses the new ability of ABI plugins to vend llvm::MCRegisterInfo structs (which is what is needed to turn dwarf r

[Lldb-commits] [PATCH] D67966: Use llvm for dumping DWARF expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rL373208: Use llvm for dumping DWARF expressions (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk updated this revision to Diff 222427. kwk added a comment. - Added YAML test to merge symbols Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67390/new/ https://reviews.llvm.org/D67390 Files: lldb/lit/Modules/ELF/Inputs/load-from-dynsym-alone.

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk updated this revision to Diff 222441. kwk added a comment. - include test code in .c test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67390/new/ https://reviews.llvm.org/D67390 Files: lldb/lit/Modules/ELF/load-from-dynsym-alone.c ll

[Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

amccarth added a comment. I'm just back from vacation. I agree with Pavel that we need to hear more from Jason at this point. I'm still very interested in helping this land in some form. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67347/new/ https://revie

[Lldb-commits] [PATCH] D68096: ProcessMinidump: inject SIGSTOP on Linux if no thread has a signal

JosephTremoulet updated this revision to Diff 222444. JosephTremoulet added a comment. - Review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68096/new/ https://reviews.llvm.org/D68096 Files: lldb/source/Plugins/Process/minidump/Process

[Lldb-commits] [PATCH] D68096: ProcessMinidump: Suppress reporting stop for signal '0'

JosephTremoulet marked 2 inline comments as done. JosephTremoulet added a comment. In D68096#1687790 , @labath wrote: > It doesn't look like it should be too hard to add yaml support for the > exceptions stream -- it should only be a matter of adapting th

[Lldb-commits] [PATCH] D68169: Fix a regression in FindTypes

aprantl planned changes to this revision. aprantl added a comment. Pavel suggested to just remove the return value altogether, which would be even better. I'll give that a try. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68169/new/ https://revie

[Lldb-commits] [PATCH] D68171: Remove unused "append" parameter from FindTypes API

JDevlieghere accepted this revision. JDevlieghere added a comment. 🥳 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68171/new/ https://reviews.llvm.org/D68171 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/c

[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Make the RedirectingFileSystem hold on to its own working directory.

JDevlieghere added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65677/new/ https://reviews.llvm.org/D65677 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi

[Lldb-commits] [PATCH] D68007: [lldb] Move swig call from python code to cmake

JDevlieghere added inline comments. Comment at: lldb/trunk/scripts/CMakeLists.txt:5 + ${LLDB_SOURCE_DIR}/include/lldb/API/*.h + ${LLDB_SOURCE_DIR}/include/lldb/*.h ) xiaobai wrote: > hhb wrote: > > xiaobai wrote: > > > Doesn't this now include the `lldb-privat

[Lldb-commits] [lldb] r373224 - Remove unused "append" parameter from FindTypes API

Author: adrian Date: Mon Sep 30 09:42:28 2019 New Revision: 373224 URL: http://llvm.org/viewvc/llvm-project?rev=373224&view=rev Log: Remove unused "append" parameter from FindTypes API I noticed that SymbolFileDWARFDebugMap::FindTypes was implementing it incorrectly (passing append=false in a for

[Lldb-commits] [PATCH] D68171: Remove unused "append" parameter from FindTypes API

This revision was automatically updated to reflect the committed changes. Closed by commit rL373224: Remove unused "append" parameter from FindTypes API (authored by adrian, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

[Lldb-commits] [lldb] r373229 - [lldb][NFC] Updating test to reflect made by D67966

Author: shafik Date: Mon Sep 30 09:57:35 2019 New Revision: 373229 URL: http://llvm.org/viewvc/llvm-project?rev=373229&view=rev Log: [lldb][NFC] Updating test to reflect made by D67966 Summary: D67966 changes the output when dumping DWARF expressions and this updates basic_entry_values_x86_64 te

[Lldb-commits] [lldb] r373233 - [test] Make TestBasicEntryValuesX86_64 run on Linux as well as Darwin

Author: vedantk Date: Mon Sep 30 10:11:46 2019 New Revision: 373233 URL: http://llvm.org/viewvc/llvm-project?rev=373233&view=rev Log: [test] Make TestBasicEntryValuesX86_64 run on Linux as well as Darwin I think a reasonable plan here is to add support for OSes following the SysV ABI one by one,

[Lldb-commits] [PATCH] D68179: [lldb] Fix JSON parser to allow empty arrays

jingham added a comment. It would be good as Pavel and Davide suggest to write a test directly for the JSON parser. Doing so in the C++ Unit test seems the most convenient, but that's up to you. But it would also be good to add a test for the particular "breakpoint write" -> "breakpoint read"

[Lldb-commits] [PATCH] D68160: File::Clear() -> File::TakeStreamAndClear()

lawrence_danna updated this revision to Diff 222459. lawrence_danna added a comment. review fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68160/new/ https://reviews.llvm.org/D68160 Files: lldb/include/lldb/Host/File.h lldb/scripts/Python/p

[Lldb-commits] [PATCH] D68160: File::Clear() -> File::TakeStreamAndClear()

lawrence_danna marked 2 inline comments as done. lawrence_danna added inline comments. Comment at: lldb/source/Host/common/File.cpp:166-167 +FILE *File::TakeStreamAndClear() { + GetStream(); + FILE *stream = m_stream; + m_stream = NULL; labath wrote: > `FILE *

[Lldb-commits] [PATCH] D67793: new api class: SBFile

jingham added a comment. This looks fine to me, it doesn't look like you are leaving out anything useful. Note, I think just to enforce the "default constructor" discipline, there's a test in the test suite (python_api/default-constructor/TestDefaultConstructorForAPIObjects.py) that has a file

[Lldb-commits] [PATCH] D68169: Remove size_t return parameter from FindTypes

aprantl updated this revision to Diff 222473. aprantl retitled this revision from "Fix a regression in FindTypes" to "Remove size_t return parameter from FindTypes". aprantl edited the summary of this revision. aprantl added a reviewer: labath. Herald added subscribers: dexonsmith, mehdi_amini. C

[Lldb-commits] [PATCH] D68169: Remove size_t return parameter from FindTypes

aprantl updated this revision to Diff 222476. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68169/new/ https://reviews.llvm.org/D68169 Files: lldb/include/lldb/Core/Module.h lldb/include/lldb/Core/ModuleList.h lldb/include/lldb/Symbol/SymbolFile.h lldb/include/lldb/Symbol/TypeLis

[Lldb-commits] [lldb] r373250 - Try to update Windows unit test for API change.

Author: adrian Date: Mon Sep 30 12:38:52 2019 New Revision: 373250 URL: http://llvm.org/viewvc/llvm-project?rev=373250&view=rev Log: Try to update Windows unit test for API change. Modified: lldb/trunk/unittests/SymbolFile/PDB/SymbolFilePDBTests.cpp Modified: lldb/trunk/unittests/SymbolFile/

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk updated this revision to Diff 222479. kwk added a comment. - Fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67390/new/ https://reviews.llvm.org/D67390 Files: lldb/lit/Modules/ELF/load-from-dynsym-alone.c lldb/lit/Modules/ELF/loa

[Lldb-commits] [PATCH] D68069: Explicitly set entry point arch when it's thumb

aadsm updated this revision to Diff 222490. aadsm added a comment. Add lit test to check dissassembly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68069/new/ https://reviews.llvm.org/D68069 Files: lldb/lit/SymbolFile/dissassemble-entry-point.s

[Lldb-commits] [lldb] r373267 - [StackFrameList][DFS] Turn a few raw pointers into references, NFC

Author: vedantk Date: Mon Sep 30 14:20:14 2019 New Revision: 373267 URL: http://llvm.org/viewvc/llvm-project?rev=373267&view=rev Log: [StackFrameList][DFS] Turn a few raw pointers into references, NFC Modified: lldb/trunk/source/Symbol/Function.cpp lldb/trunk/source/Target/StackFrameList.

[Lldb-commits] [PATCH] D68248: [JSON] Use LLVM's library for encoding JSON

JDevlieghere created this revision. JDevlieghere added reviewers: labath, mgorny, xiaobai, aprantl, clayborg. Herald added a subscriber: abidh. Herald added a project: LLDB. This patch replaces the hand-rolled JSON emission with LLVM's JSON library. Repository: rLLDB LLDB https://reviews.llvm

[Lldb-commits] [PATCH] D67793: new api class: SBFile

lawrence_danna added a comment. addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67793/new/ https://reviews.llvm.org/D67793 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [PATCH] D67793: new api class: SBFile

lawrence_danna updated this revision to Diff 222516. lawrence_danna marked 7 inline comments as done. lawrence_danna added a comment. fixed according to reviewer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67793/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D68248: [JSON] Use LLVM's library for encoding JSON

shafik added inline comments. Comment at: lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp:387 std::string expected_packet1 = - R"(jTraceStart:{"buffersize" : 8192,"metabuffersize" : 8192,"params" :)"; + R"(jTraceStart:{"buffersize":8192,"metab

[Lldb-commits] [PATCH] D68248: [JSON] Use LLVM's library for encoding JSON

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp:387 std::string expected_packet1 = - R"(jTraceStart:{"buffersize" : 8192,"metabuffersize" : 8192,"params"

[Lldb-commits] [PATCH] D68181: SBDebugger::SetInputFile, SetOutputFile, etc.

lawrence_danna updated this revision to Diff 222520. lawrence_danna added a comment. propagated updates from parent Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68181/new/ https://reviews.llvm.org/D68181 Files: lldb/include/lldb/API/SBDebugger.

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna marked 2 inline comments as done. lawrence_danna added inline comments. Comment at: lldb/include/lldb/API/SBFile.h:16-21 +/* These tags make no difference at the c++ level, but + * when the constructors are called from python they control + * how python files are c

[Lldb-commits] [PATCH] D67793: new api class: SBFile

lawrence_danna updated this revision to Diff 222522. lawrence_danna added a comment. flush fix for python2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67793/new/ https://reviews.llvm.org/D67793 Files: lldb/include/lldb/API/LLDB.h lldb/includ

[Lldb-commits] [lldb] r373277 - [Docs] Document lldb-instr

Author: jdevlieghere Date: Mon Sep 30 17:12:47 2019 New Revision: 373277 URL: http://llvm.org/viewvc/llvm-project?rev=373277&view=rev Log: [Docs] Document lldb-instr This adds some information on how to instrument the API classes. Modified: lldb/trunk/docs/resources/sbapi.rst Modified: lldb

[Lldb-commits] [PATCH] D68248: [JSON] Use LLVM's library for encoding JSON

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Sweet! Does this 'automatically' fix the 'llvm-argdumper has issues escaping JSON-ified input' issue we discussed in person? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [lldb] r373280 - Allow the internal-state-thread free access to the TargetAPI mutex.

Author: jingham Date: Mon Sep 30 17:47:25 2019 New Revision: 373280 URL: http://llvm.org/viewvc/llvm-project?rev=373280&view=rev Log: Allow the internal-state-thread free access to the TargetAPI mutex. It is always doing work on behalf of another thread that presumably has the mutex, so if it is

[Lldb-commits] [PATCH] D68174: Allow private-state-thread to call SB API's that take the TargetAPI mutex

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL373280: Allow the internal-state-thread free access to the TargetAPI mutex. (authored by jingham, committed by ). Herald a

[Lldb-commits] [PATCH] D67793: new api class: SBFile

lawrence_danna updated this revision to Diff 222528. lawrence_danna added a comment. add reproducer instrumentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67793/new/ https://reviews.llvm.org/D67793 Files: lldb/include/lldb/API/LLDB.h l

[Lldb-commits] [PATCH] D67793: new api class: SBFile

lawrence_danna marked an inline comment as done. lawrence_danna added inline comments. Comment at: lldb/scripts/Python/python-typemaps.swig:464 } + +// These two pybuffer macros are copied out of swig/Lib/python/pybuffer.i, `swig/LICENSE` says the following, so

[Lldb-commits] [lldb] r373285 - File::Clear() -> File::TakeStreamAndClear()

Author: lawrence_danna Date: Mon Sep 30 18:05:02 2019 New Revision: 373285 URL: http://llvm.org/viewvc/llvm-project?rev=373285&view=rev Log: File::Clear() -> File::TakeStreamAndClear() Summary: File::Clear() is an ugly function. It's only used in one place, which is the swig typemaps for FILE*.

[Lldb-commits] [PATCH] D68160: File::Clear() -> File::TakeStreamAndClear()

This revision was automatically updated to reflect the committed changes. lawrence_danna marked an inline comment as done. Closed by commit rL373285: File::Clear() -> File::TakeStreamAndClear() (authored by lawrence_danna, committed by ). Herald added a project: LLVM. Herald added a subscriber: ll

[Lldb-commits] [PATCH] D68181: SBDebugger::SetInputFile, SetOutputFile, etc.

lawrence_danna updated this revision to Diff 222537. lawrence_danna added a comment. pushed validity checks out to the SB layer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68181/new/ https://reviews.llvm.org/D68181 Files: lldb/include/lldb/API

[Lldb-commits] [PATCH] D68181: SBDebugger::SetInputFile, SetOutputFile, etc.

lawrence_danna updated this revision to Diff 222538. lawrence_danna added a comment. assertions instead of exceptions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68181/new/ https://reviews.llvm.org/D68181 Files: lldb/include/lldb/API/SBDebugge

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna added a comment. In D68188#1687532 , @labath wrote: > It seems to be that instead of subclassing a fully-functional File class, it > would be better to create an abstract class, that both `File` and the new > python thingy could implement.

[Lldb-commits] [PATCH] D68171: Remove unused "append" parameter from FindTypes API

stella.stamenova added a comment. This broke the windows bot. A couple of other issues have shown up and been fixed since, but this change is still causing a break: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/9373 Repository: rL LLVM CHANGES SINCE LAST ACTION https://r

[Lldb-commits] [PATCH] D68258: [Windows] Introduce a switch for the `lldb-server` mode on Windows

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: labath, amccarth, asmith, stella.stamenova. aleksandr.urakov added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieghere, abidh. This patch introduces a switch, based on the environment variable `LLDB_USE_LL

[Lldb-commits] [lldb] r373300 - [Windows] Added support of watchpoints to `NativeProcessWindows`

Author: aleksandr.urakov Date: Mon Sep 30 22:52:16 2019 New Revision: 373300 URL: http://llvm.org/viewvc/llvm-project?rev=373300&view=rev Log: [Windows] Added support of watchpoints to `NativeProcessWindows` Summary: This patch adds support of watchpoints to the new `NativeProcessWindows` plugin

[Lldb-commits] [PATCH] D67222: [Windows] Added support of watchpoints to `NativeProcessWindows`

This revision was automatically updated to reflect the committed changes. Closed by commit rL373300: [Windows] Added support of watchpoints to `NativeProcessWindows` (authored by aleksandr.urakov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[Lldb-commits] [PATCH] D67222: [Windows] Added support of watchpoints to `NativeProcessWindows`

aleksandr.urakov added a comment. Thank you! I've added a switch in a manner similar to one that Zachary has chosen for SymbolFilePDB/NativePDB plugins here: D68258 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67222/new/ htt

[Lldb-commits] [PATCH] D68096: ProcessMinidump: Suppress reporting stop for signal '0'

labath marked an inline comment as done. labath added inline comments. Comment at: lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp:258-265 +uint32_t signo = m_active_exception->exception_record.exception_code; + +if (signo == 0) { + // Artifically inject a S

[Lldb-commits] [PATCH] D68169: Remove size_t return parameter from FindTypes

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. cool CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68169/new/ https://reviews.llvm.org/D68169 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D68134: [LLDB] Use the llvm microsoft demangler instead of the windows dbghelp api

mstorsjo added a comment. In D68134#1687865 , @labath wrote: > In D68134#1687518 , @mstorsjo wrote: > > > In D68134#1687500 , @labath wrote: > > > > > I'm not sure what faile

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

labath added inline comments. Comment at: lldb/lit/Modules/ELF/merge-symbols.yaml:51 +# Symbol all_same2 will be renamed to all_same1 and should therefore +# disappear from the dumped smymtab because all fields are equal. + - Name:all_same2 s