[Lldb-commits] [PATCH] D69014: [LLDB] bugfix: command script add -f doesn't work for some callables

labath added a comment. I also think we shouldn't go out of our way (and I consider any kind of introspection as "going out of our way") to forbid calling with a "deprecated" signature for some callables even though there's technically no backward compatibility to worry about (because it was no

[Lldb-commits] [PATCH] D68995: clean up the implementation of PythonCallable::GetNumArguments

labath added a comment. In D68995#1711831 , @lawrence_danna wrote: > In D68995#1710594 , @labath wrote: > > > Thanks for jumping onto this. Apart from the inline comments, I have one > > high level question: What

[Lldb-commits] [PATCH] D68995: clean up the implementation of PythonCallable::GetNumArguments

lawrence_danna marked 3 inline comments as done. lawrence_danna added a comment. In D68995#1712387 , @labath wrote: > In D68995#1711831 , @lawrence_danna > wrote: > > > In D68995#1710594

[Lldb-commits] [PATCH] D68995: clean up the implementation of PythonCallable::GetNumArguments

lawrence_danna updated this revision to Diff 225372. lawrence_danna marked 3 inline comments as done. lawrence_danna added a comment. fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68995/new/ https://reviews.llvm.org/D68995 Files: lldb/sour

[Lldb-commits] [PATCH] D68995: clean up the implementation of PythonCallable::GetNumArguments

lawrence_danna added a comment. fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68995/new/ https://reviews.llvm.org/D68995 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [PATCH] D69014: [LLDB] bugfix: command script add -f doesn't work for some callables

lawrence_danna updated this revision to Diff 225373. lawrence_danna added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69014/new/ https://reviews.llvm.org/D69014 Files: lldb/packages/Python/lldbsuite/test/commands/command/sc

[Lldb-commits] [PATCH] D68968: [android/process info] Introduce bundle id

labath added a comment. In D68968#1712018 , @jingham wrote: > I don't think it would be good to make it hard to see the actual path (if you > have it) as well as the bundle ID. If you are working on system components, > you want to know that you are run

[Lldb-commits] [PATCH] D69080: eliminate one form of PythonObject::Reset()

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I like where this is going. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:235-245 PythonObject &operator=(const PythonObject &other) {

[Lldb-commits] [PATCH] D68995: clean up the implementation of PythonCallable::GetNumArguments

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D68995#1712396 , @lawrence_danna wrote: > >> Looks like the old implementation also doesn't work for class or static > >> methods, or for objects w

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

kwk abandoned this revision. kwk added a comment. Abandoning for D69041 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68943/new/ https://reviews.llvm.org/D68943 ___ ll

[Lldb-commits] [PATCH] D69100: COFF: Create a separate "section" for the file header

labath created this revision. labath added reviewers: amccarth, mstorsjo. In an attempt to ensure that every part of the module's memory image is accounted for, D56537 created a special "container section" spanning the entire image. While that seemed reasonable a

[Lldb-commits] [PATCH] D69035: minidump: Refactor memory region computation code

labath requested review of this revision. labath added a comment. With some additional COFF tweaks (D69100 , D69102 ), the next patch doesn't turn out that bad (though I'm still happy to accept "unwinder should just check section

[Lldb-commits] [PATCH] D69102: COFF: Set section permissions

labath created this revision. labath added reviewers: amccarth, mstorsjo. labath added a parent revision: D69100: COFF: Create a separate "section" for the file header. labath marked an inline comment as done. labath added inline comments. Comment at: source/Plugins/ObjectFile/P

[Lldb-commits] [PATCH] D69102: COFF: Set section permissions

labath marked an inline comment as done. labath added inline comments. Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:800 /*flags*/ 0); +header_sp->SetPermissions(ePermissionsReadable); m_sections_up->AddSection(header_sp); Ar

[Lldb-commits] [PATCH] D69105: minidump: Create memory regions from the sections of loaded modules

labath created this revision. labath added reviewers: amccarth, clayborg. Herald added a subscriber: mgrang. labath added parent revisions: D69102: COFF: Set section permissions, D69035: minidump: Refactor memory region computation code. Not all minidumps contain information about memory permissi

[Lldb-commits] [PATCH] D69106: MemoryRegion: Print "don't know" permission values as such

labath created this revision. labath added reviewers: clayborg, jingham. labath added a parent revision: D69105: minidump: Create memory regions from the sections of loaded modules. The permissions in a memory region have ternary states (yes, no, don't know), but the memory region command only pr

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha updated this revision to Diff 225432. tatyana-krasnukha added a comment. Herald added a subscriber: wuzish. Removed any ARC-specific logic from the ProcessGDBRemote.cpp. It seems, there is nothing to test now;) Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D55724: [ARC] Add SystemV ABI

tatyana-krasnukha updated this revision to Diff 225433. tatyana-krasnukha added a comment. Herald added a subscriber: JDevlieghere. Rebased on the current trunk. Updated according to the last revision of D55718 . Repository: rLLDB LLDB CHANGES SINCE LAST ACT

[Lldb-commits] [lldb] r375122 - [ARC] Basic support in gdb-remote process plugin

Author: tkrasnukha Date: Thu Oct 17 08:16:21 2019 New Revision: 375122 URL: http://llvm.org/viewvc/llvm-project?rev=375122&view=rev Log: [ARC] Basic support in gdb-remote process plugin Differential Revision: https://reviews.llvm.org/D55718 Modified: lldb/trunk/include/lldb/Utility/ArchSpec.

[Lldb-commits] [lldb] r375123 - [ARC] Add SystemV ABI

Author: tkrasnukha Date: Thu Oct 17 08:18:03 2019 New Revision: 375123 URL: http://llvm.org/viewvc/llvm-project?rev=375123&view=rev Log: [ARC] Add SystemV ABI Differential Revision: https://reviews.llvm.org/D55724 Added: lldb/trunk/source/Plugins/ABI/SysV-arc/ lldb/trunk/source/Plugins/A

[Lldb-commits] [PATCH] D69106: MemoryRegion: Print "don't know" permission values as such

clayborg added a comment. Looks good. Do we maybe want to use "unknown" instead of "don't know" when printing out the long for of a MemoryRegionInfo::OptionalBool? Or maybe "???"? Comment at: test/Shell/Minidump/memory-region-from-module.yaml:22 # CHECK1: [0x4000-

[Lldb-commits] [PATCH] D55724: [ARC] Add SystemV ABI

This revision was automatically updated to reflect the committed changes. Closed by commit rG92e498d58cf4: [ARC] Add SystemV ABI (authored by tatyana-krasnukha). Changed prior to commit: https://reviews.llvm.org/D55724?vs=225433&id=225438#toc Repository: rG LLVM Github Monorepo CHANGES SINC

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

This revision was automatically updated to reflect the committed changes. Closed by commit rGfaf6b2543e47: [ARC] Basic support in gdb-remote process plugin (authored by tatyana-krasnukha). Changed prior to commit: https://reviews.llvm.org/D55718?vs=225432&id=225437#toc Repository: rG LLVM Gi

[Lldb-commits] [PATCH] D69100: COFF: Create a separate "section" for the file header

jankratochvil added inline comments. Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:797 +m_coff_header_opt.header_size, +/*file_offset*/ 0, m_coff_header_opt.header_size, +m_coff_header_opt.sect_alignment, dropped ///*fi

[Lldb-commits] [lldb] r375127 - Fix an inverted condition in test.

Author: adrian Date: Thu Oct 17 08:41:17 2019 New Revision: 375127 URL: http://llvm.org/viewvc/llvm-project?rev=375127&view=rev Log: Fix an inverted condition in test. Modified: lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py Modified: lldb/trunk/packages/

[Lldb-commits] [PATCH] D69100: COFF: Create a separate "section" for the file header

clayborg added inline comments. Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:794 +SectionSP header_sp = std::make_shared( +module_sp, this, ~user_id_t(0), ConstString("header"), +eSectionTypeOther, m_coff_header_opt.image_base, ---

[Lldb-commits] [PATCH] D69105: minidump: Create memory regions from the sections of loaded modules

clayborg added inline comments. Comment at: source/Plugins/Process/minidump/ProcessMinidump.cpp:348-349 + bool is_complete; + std::tie(*m_memory_regions, is_complete) = + m_minidump_parser->BuildMemoryRegions(); + Might be nice to just assign memory region

[Lldb-commits] [PATCH] D68293: [android/process list] support showing process arguments

stella.stamenova added a comment. This is causing a failure on the Windows Bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/9920 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68293/new/ https://reviews.llvm.org/D68293 __

[Lldb-commits] [PATCH] D69114: Disable TestProcessList on windows

wallace created this revision. wallace added a reviewer: stella.stamenova. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. wallace edited the summary of this revision. wallace added reviewers: clayborg, aadsm, labath. `platform process list -v` on windows doesn't show all th

[Lldb-commits] [PATCH] D69031: [LLDB] [test] Use %clang_cl instead of build.py in a few tests

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. The tests passed in my setup. After you commit this, please monitor the windows Buildbot (it currently has a couple of failures, so you will have to check it and not rely o

[Lldb-commits] [PATCH] D69114: Disable TestProcessList on windows

stella.stamenova requested changes to this revision. stella.stamenova added a comment. This revision now requires changes to proceed. Please also file a bug and reference it in the skip statement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69114/

[Lldb-commits] [PATCH] D69114: Disable TestProcessList on windows

wallace added a comment. oh girl, i need to get a bugzilla account. I hope i can get it soon. If it takes too long I can send another patch with the updated comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69114/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D69114: Disable TestProcessList on windows

teemperor added a comment. I filed a bug for you, please reference it and submit: https://bugs.llvm.org/show_bug.cgi?id=43702 (we can update the bug description later). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69114/new/ https://reviews.llvm

Re: [Lldb-commits] [PATCH] D68968: [android/process info] Introduce bundle id

> On Oct 17, 2019, at 1:35 AM, Pavel Labath via Phabricator > wrote: > > labath added a comment. > > In D68968#1712018 , @jingham wrote: > >> I don't think it would be good to make it hard to see the actual path (if >> you have it) as well as the bun

[Lldb-commits] [PATCH] D68657: Update MinidumpYAML to use minidump::Exception for exception stream

JosephTremoulet updated this revision to Diff 225459. JosephTremoulet marked an inline comment as done. JosephTremoulet added a comment. - Rebase - Use Twine instead of formatv Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68657/new/ https://review

[Lldb-commits] [PATCH] D68657: Update MinidumpYAML to use minidump::Exception for exception stream

JosephTremoulet marked an inline comment as done. JosephTremoulet added inline comments. Comment at: llvm/lib/ObjectYAML/MinidumpYAML.cpp:389 + for (size_t Index = 0; Index < Exception.MaxParameters; ++Index) { +SmallString<16> Name = formatv("Parameter {0}", Index); +su

[Lldb-commits] [PATCH] D69119: Modernize the rest of the Find.* API (NFC)

teemperor added a comment. +1 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69119/new/ https://reviews.llvm.org/D69119 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r375144 - Disable TestProcessList on windows

Author: wallace Date: Thu Oct 17 10:53:44 2019 New Revision: 375144 URL: http://llvm.org/viewvc/llvm-project?rev=375144&view=rev Log: Disable TestProcessList on windows Summary: `platform process list -v` on windows doesn't show all the process arguments, making this test useless for that platfo

[Lldb-commits] [PATCH] D69114: Disable TestProcessList on windows

wallace updated this revision to Diff 225466. wallace added a comment. added bug link in the comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69114/new/ https://reviews.llvm.org/D69114 Files: lldb/packages/Python/lldbsuite/test/commands/pl

[Lldb-commits] [PATCH] D69114: Disable TestProcessList on windows

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGe19dfa6745f6: Disable TestProcessList on windows (authored by wallace). Repository: rG LLVM Github Monorepo CHANGES SI

[Lldb-commits] [lldb] r375146 - [Reproducer] Surface error if setting the cwd fails

Author: jdevlieghere Date: Thu Oct 17 10:58:44 2019 New Revision: 375146 URL: http://llvm.org/viewvc/llvm-project?rev=375146&view=rev Log: [Reproducer] Surface error if setting the cwd fails Make sure that we surface an error if setting the current working directory fails during replay. Modified

[Lldb-commits] [PATCH] D69080: eliminate one form of PythonObject::Reset()

lawrence_danna marked 2 inline comments as done. lawrence_danna added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:235-245 PythonObject &operator=(const PythonObject &other) { Reset(PyRefType::Borrowed, other.get());

[Lldb-commits] [PATCH] D69119: Modernize the rest of the Find.* API (NFC)

labath accepted this revision. labath added a comment. yay Comment at: lldb/tools/lldb-test/lldb-test.cpp:439-448 +List.Clear(); +Symfile.FindFunctions(RE, true, List); } else { Expected ContextOr = getDeclContext(Symfile); if (!ContextOr) return Con

[Lldb-commits] [lldb] r375151 - [lldb] Don't emit artificial constructor declarations as global functions

Author: teemperor Date: Thu Oct 17 11:16:50 2019 New Revision: 375151 URL: http://llvm.org/viewvc/llvm-project?rev=375151&view=rev Log: [lldb] Don't emit artificial constructor declarations as global functions Summary: When we have a artificial constructor DIE, we currently create from that a gl

[Lldb-commits] [PATCH] D68995: clean up the implementation of PythonCallable::GetNumArguments

lawrence_danna updated this revision to Diff 225477. lawrence_danna marked an inline comment as done. lawrence_danna added a comment. char * -> char[] Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68995/new/ https://reviews.llvm.org/D68995 Files:

[Lldb-commits] [PATCH] D68130: [lldb] Don't emit artificial constructor declarations as global functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG6237c9fe6ce9: [lldb] Don't emit artificial constructor declarations as global functions (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D68995: clean up the implementation of PythonCallable::GetNumArguments

lawrence_danna added a comment. fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68995/new/ https://reviews.llvm.org/D68995 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [PATCH] D69080: eliminate one form of PythonObject::Reset()

labath added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:235-245 PythonObject &operator=(const PythonObject &other) { Reset(PyRefType::Borrowed, other.get()); return *this; } - void Reset(PythonObject &&other)

[Lldb-commits] [PATCH] D69080: eliminate one form of PythonObject::Reset()

lawrence_danna marked 3 inline comments as done. lawrence_danna added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:235-245 PythonObject &operator=(const PythonObject &other) { Reset(PyRefType::Borrowed, other.get());

[Lldb-commits] [PATCH] D69080: eliminate one form of PythonObject::Reset()

labath added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:235-245 PythonObject &operator=(const PythonObject &other) { Reset(PyRefType::Borrowed, other.get()); return *this; } - void Reset(PythonObject &&other)

[Lldb-commits] [PATCH] D69080: eliminate one form of PythonObject::Reset()

lawrence_danna marked 2 inline comments as done. lawrence_danna added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:235-245 PythonObject &operator=(const PythonObject &other) { Reset(PyRefType::Borrowed, other.get());

[Lldb-commits] [PATCH] D69080: eliminate one form of PythonObject::Reset()

labath added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:235-245 PythonObject &operator=(const PythonObject &other) { Reset(PyRefType::Borrowed, other.get()); return *this; } - void Reset(PythonObject &&other)

[Lldb-commits] [PATCH] D69080: eliminate one form of PythonObject::Reset()

lawrence_danna marked 2 inline comments as done. lawrence_danna added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:235-245 PythonObject &operator=(const PythonObject &other) { Reset(PyRefType::Borrowed, other.get());

[Lldb-commits] [PATCH] D69080: eliminate one form of PythonObject::Reset()

lawrence_danna updated this revision to Diff 225492. lawrence_danna added a comment. universal assignment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69080/new/ https://reviews.llvm.org/D69080 Files: lldb/source/Plugins/ScriptInterpreter/Pytho

[Lldb-commits] [lldb] r375156 - [LLDB] [test] Use %clang_cl instead of build.py in a few tests

Author: mstorsjo Date: Thu Oct 17 12:22:50 2019 New Revision: 375156 URL: http://llvm.org/viewvc/llvm-project?rev=375156&view=rev Log: [LLDB] [test] Use %clang_cl instead of build.py in a few tests This allows explicitly specifying the intended target architecture, for tests that aren't supposed

[Lldb-commits] [PATCH] D69031: [LLDB] [test] Use %clang_cl instead of build.py in a few tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG95980409e653: [LLDB] [test] Use %clang_cl instead of build.py in a few tests (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69031/new/

[Lldb-commits] [PATCH] D68968: [android/process info] Introduce bundle id

danalbert added a subscriber: enh. danalbert added a comment. In D68968#1710520 , @labath wrote: > Independently, I am wondering if there's a better way to link the process id > to a bundle. Using argv[0] might be ok if we're using it just for display >

[Lldb-commits] [PATCH] D69133: eliminate nontrivial Reset(...) from TypedPythonObject

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, clayborg, labath, jingham. Herald added a project: LLDB. lawrence_danna added a parent revision: D69080: eliminate one form of PythonObject::Reset(). This deletes `Reset(...)`, except for the no-argument form `Res

[Lldb-commits] [PATCH] D69031: [LLDB] [test] Use %clang_cl instead of build.py in a few tests

aprantl added a comment. Either this or https://reviews.llvm.org/D69076 broke the lldb-cmake bot: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/2706/ Script: -- : 'RUN: at line 4'; /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/bin/clang --driver-mode=cl -isysroot

[Lldb-commits] [PATCH] D69031: [LLDB] [test] Use %clang_cl instead of build.py in a few tests

aprantl added a comment. Probably this commit. Can you please revert or fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69031/new/ https://reviews.llvm.org/D69031 ___ lldb-commits mailing list lldb-

[Lldb-commits] [lldb] r375163 - Revert "[LLDB] [test] Use %clang_cl instead of build.py in a few tests"

Author: mstorsjo Date: Thu Oct 17 13:14:19 2019 New Revision: 375163 URL: http://llvm.org/viewvc/llvm-project?rev=375163&view=rev Log: Revert "[LLDB] [test] Use %clang_cl instead of build.py in a few tests" This reverts SVN r375156, as it seems to have broken tests when run on macOS: http://green

[Lldb-commits] [PATCH] D69058: [test] Add a .clang-format file for the shell test.

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69058/new/ https://reviews.llvm.org/D69058 _

[Lldb-commits] [PATCH] D68130: [lldb] Don't emit artificial constructor declarations as global functions

stella.stamenova added a comment. Unfortunately, this is failing on the windows bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/9961 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68130/new/ https://reviews.llvm.org/D68130 _

[Lldb-commits] [PATCH] D69031: [LLDB] [test] Use %clang_cl instead of build.py in a few tests

mstorsjo added a comment. In D69031#1713532 , @aprantl wrote: > Probably this commit. Can you please revert or fix? Sorry about this, reverted it for now. I think the reason might be that %clang_cl ends up expanding to something (maybe `-isysroot`) tha

[Lldb-commits] [PATCH] D68961: Add support for DW_AT_export_symbols for anonymous structs

shafik updated this revision to Diff 225508. shafik added a comment. Minor fixes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68961/new/ https://reviews.llvm.org/D68961 Files: include/lldb/Symbol/ClangASTContext.h packages/Python/lldbsuite/test/python_api/type/TestTypeList.py p

[Lldb-commits] [PATCH] D68961: Add support for DW_AT_export_symbols for anonymous structs

shafik added a comment. In D68961#1711537 , @labath wrote: > In D68961#1711407 , @shafik wrote: > > > In D68961#1709708 , @clayborg > > wrote: > > > > > Have many compilers

Re: [Lldb-commits] [PATCH] D68968: [android/process info] Introduce bundle id

nothing i know of. +yabinc might have dealt with this with simpleperf... On Thu, Oct 17, 2019 at 12:54 PM Dan Albert via Phabricator wrote: > > danalbert added a subscriber: enh. > danalbert added a comment. > > In D68968#1710520 , @labath wrote: > > > Ind

[Lldb-commits] [lldb] r375170 - Adapt Windows test to API change.

Author: adrian Date: Thu Oct 17 13:51:55 2019 New Revision: 375170 URL: http://llvm.org/viewvc/llvm-project?rev=375170&view=rev Log: Adapt Windows test to API change. Modified: lldb/trunk/unittests/SymbolFile/PDB/SymbolFilePDBTests.cpp Modified: lldb/trunk/unittests/SymbolFile/PDB/SymbolFile

[Lldb-commits] [PATCH] D69031: [LLDB] [test] Use %clang_cl instead of build.py in a few tests

mstorsjo added a comment. In D69031#1713060 , @stella.stamenova wrote: > The tests passed in my setup. After you commit this, please monitor the > windows Buildbot (it currently has a couple of failures, so you will have to > check it and not rely on an

[Lldb-commits] [PATCH] D68130: [lldb] Don't emit artificial constructor declarations as global functions

teemperor added a comment. Yeah, seems like constructing objects in expressions isn't implemented on Windows. I'm not sure if there is a reliable way to test that constructors aren't shadowed by these global functions if constructors themselves don't work on Windows, but I filed llvm.org/pr4370

Re: [Lldb-commits] [PATCH] D68968: [android/process info] Introduce bundle id

simpleperf reads argv[0] from /proc//cmdline for display purposes. If not for display, a package name is expected from user inputs. On Thu, Oct 17, 2019 at 1:33 PM enh wrote: > nothing i know of. +yabinc might have dealt with this with simpleperf... > > On Thu, Oct 17, 2019 at 12:54 PM Dan Alber

[Lldb-commits] [PATCH] D69119: Modernize the rest of the Find.* API (NFC)

saugustine added a comment. This breaks the build due to lldb/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:1355:8: error: unused variable 'old_size' [-Werror,-Wunused-variable] I will check in a fix shortly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[Lldb-commits] [lldb] r375172 - [test] Add a .clang-format file for the shell test.

Author: jdevlieghere Date: Thu Oct 17 14:23:35 2019 New Revision: 375172 URL: http://llvm.org/viewvc/llvm-project?rev=375172&view=rev Log: [test] Add a .clang-format file for the shell test. The API tests have a .clang-format file that disables formatting altogether. While this is needed for some

[Lldb-commits] [lldb] r375173 - [lldb] X-fail tests that use constructors in expressions on Windows

Author: teemperor Date: Thu Oct 17 14:27:26 2019 New Revision: 375173 URL: http://llvm.org/viewvc/llvm-project?rev=375173&view=rev Log: [lldb] X-fail tests that use constructors in expressions on Windows These tests were testing a bug related to constructors. It seems that on Windows the expressi

[Lldb-commits] [PATCH] D69058: [test] Add a .clang-format file for the shell test.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa0f6c6434cc4: [test] Add a .clang-format file for the shell test. (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69058/new/ https

[Lldb-commits] [lldb] r375174 - (NFC) Delete variable made unused by llvm-svn: 375160

Author: saugustine Date: Thu Oct 17 14:40:12 2019 New Revision: 375174 URL: http://llvm.org/viewvc/llvm-project?rev=375174&view=rev Log: (NFC) Delete variable made unused by llvm-svn: 375160 Reviewers: aprantl Subscribers: llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.or

[Lldb-commits] [PATCH] D69143: (NFC) Delete variable made unused by llvm-svn: 375160

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGbbbc873f83e4: (NFC) Delete variable made unused by llvm-svn: 375160 (authored by saugustine). Herald added a project: LLDB

[Lldb-commits] [PATCH] D69143: (NFC) Delete variable made unused by llvm-svn: 375160

aprantl added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69143/new/ https://reviews.llvm.org/D69143 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.or

[Lldb-commits] [lldb] r375181 - clean up the implementation of PythonCallable::GetNumArguments

Author: lawrence_danna Date: Thu Oct 17 15:22:06 2019 New Revision: 375181 URL: http://llvm.org/viewvc/llvm-project?rev=375181&view=rev Log: clean up the implementation of PythonCallable::GetNumArguments Summary: The current implementation of PythonCallable::GetNumArguments is not exception safe,

[Lldb-commits] [lldb] r375182 - eliminate one form of PythonObject::Reset()

Author: lawrence_danna Date: Thu Oct 17 15:22:09 2019 New Revision: 375182 URL: http://llvm.org/viewvc/llvm-project?rev=375182&view=rev Log: eliminate one form of PythonObject::Reset() Summary: I'd like to eliminate all forms of Reset() and all public constructors on these objects, so the only wa

[Lldb-commits] [PATCH] D68995: clean up the implementation of PythonCallable::GetNumArguments

This revision was automatically updated to reflect the committed changes. Closed by commit rGc86a6acaee55: clean up the implementation of PythonCallable::GetNumArguments (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6899

[Lldb-commits] [PATCH] D69080: eliminate one form of PythonObject::Reset()

This revision was automatically updated to reflect the committed changes. Closed by commit rG03819d1c80ad: eliminate one form of PythonObject::Reset() (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69080/new/ https://rev

[Lldb-commits] [PATCH] D68968: [android/process info] Introduce bundle id

wallace added a comment. Thanks for your feedback and to @clayborg for an offline discussion we had. I'm going to add three new attributes to the ProcessInfo class, with corresponding parameters in the gdb-remote packet - display_name: This is a custom display name that the server can set for

[Lldb-commits] [lldb] r375187 - [lldb][NFC] Fix typo in DWARFASTParserClang.cpp

Author: teemperor Date: Thu Oct 17 16:11:32 2019 New Revision: 375187 URL: http://llvm.org/viewvc/llvm-project?rev=375187&view=rev Log: [lldb][NFC] Fix typo in DWARFASTParserClang.cpp Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp Modified: lldb/trunk/source/Plu

[Lldb-commits] [PATCH] D69148: Disable exit-on-SIGPIPE in lldb

vsk created this revision. vsk added reviewers: jfb, nickdesaulniers, friss, JDevlieghere. Herald added subscribers: dexonsmith, hiraditya, mgorny. Herald added a project: LLVM. Occasionally, during test teardown, there is a write to a closed pipe in of LLDB's handful of IPC channels. Sometimes th

[Lldb-commits] [PATCH] D69148: Disable exit-on-SIGPIPE in lldb

jfb added inline comments. Comment at: lldb/tools/driver/Driver.cpp:864 + // in LLDB leaves behind temporary objects). + llvm::sys::SetExitOnFailedPipeWrite(/*ExitOnFailedWrite=*/false); + Could this instead pass a lambda, like other signal handlers? So sigpipe

[Lldb-commits] [PATCH] D69148: Disable exit-on-SIGPIPE in lldb

vsk planned changes to this revision. vsk marked an inline comment as done. vsk added inline comments. Comment at: lldb/tools/driver/Driver.cpp:864 + // in LLDB leaves behind temporary objects). + llvm::sys::SetExitOnFailedPipeWrite(/*ExitOnFailedWrite=*/false); + -

[Lldb-commits] [PATCH] D69148: Disable exit-on-SIGPIPE in lldb

vsk updated this revision to Diff 225546. vsk edited the summary of this revision. vsk added a comment. - Allow setting a SIGPIPE handler. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69148/new/ https://reviews.llvm.org/D69148 Files: lldb/tools/driver/Driver.cpp llvm/include/llvm/

[Lldb-commits] [PATCH] D69031: [LLDB] [test] Use %clang_cl instead of build.py in a few tests

aprantl added a comment. Check out `lldb/test/Shell/helper/toolchain.py`, you probably need to filter out some options for clang_cl specifically. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69031/new/ https://reviews.llvm.org/D69031

[Lldb-commits] [PATCH] D69148: Disable exit-on-SIGPIPE in lldb

jfb accepted this revision. jfb added a subscriber: jordan_rose. jfb added a comment. This revision is now accepted and ready to land. More of an FYI, @jordan_rose might be interested in this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69148/new/ https://reviews.llvm.org/D69148 __

[Lldb-commits] [PATCH] D69148: Disable exit-on-SIGPIPE in lldb

jordan_rose added inline comments. Comment at: llvm/lib/Support/Unix/Signals.inc:372 if (Sig == SIGPIPE) -exit(EX_IOERR); +if (SignalHandlerFunctionType CurrentPipeFunction = PipeSignalFunction) + CurrentPipeFunction(); Should it b

[Lldb-commits] [PATCH] D69153: convert LLDBSwigPythonCallTypeScript to ArgInfo::max_positional_args

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, clayborg, labath, jingham. Herald added a project: LLDB. lawrence_danna added a parent revision: D69014: [LLDB] bugfix: command script add -f doesn't work for some callables. This patch converts another user of Ar

[Lldb-commits] [PATCH] D67793: new api class: SBFile

lawrence_danna added a comment. In D67793#1692544 , @labath wrote: > BTW, I've had to add (or rather, extend) a fairly ugly hack in r373573 in > order to get the new tests running on non-darwin platforms. The reason for > that is that the FILE* out typem