[Lldb-commits] [PATCH] D69230: RFC: specialized Optional for T that can represent its own invalid state

dblaikie added a comment. In D69230#1717675 , @serge-sans-paille wrote: > On a personal note, as much as I like the idea (and I really do like it), I'd > rather have llvm::optional sticking to std::optional interface. (short-ish reply, while busy with

[Lldb-commits] [PATCH] D69230: RFC: specialized Optional for T that can represent its own invalid state

serge-sans-paille added a comment. (keeping the ball rolling) lYou want to exploit the presence of a sentinel in the domain of values of a given type. Maybe make that explicit through the method naming instead of using the `isValid` theme. Some bibliography on the subject: https://groups.googl

[Lldb-commits] [PATCH] D68856: convert SBDebugger::***FileHandle() wrappers to native files.

mgorny added a comment. In D68856#1717332 , @lawrence_danna wrote: > I spoke too soon, I don't have a *usable* netbsd VM. > > @mgorny, Do you have a machine you can debug on yourself? Yes. > Do those errors happen if you run the same test on an interac

[Lldb-commits] [lldb] d602e0d - fix PythonDataObjectsTest.TestExceptions on windows

Author: Lawrence D'Anna Date: 2019-10-22T04:00:37Z New Revision: d602e0d0cab270761553c79d2e42b8ac6b756157 URL: https://github.com/llvm/llvm-project/commit/d602e0d0cab270761553c79d2e42b8ac6b756157 DIFF: https://github.com/llvm/llvm-project/commit/d602e0d0cab270761553c79d2e42b8ac6b756157.diff LO

[Lldb-commits] [PATCH] D69214: remove multi-argument form of PythonObject::Reset()

This revision was automatically updated to reflect the committed changes. Closed by commit rG04edd1893c2d: remove multi-argument form of PythonObject::Reset() (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69214/new/ htt

[Lldb-commits] [lldb] 04edd18 - remove multi-argument form of PythonObject::Reset()

Author: Lawrence D'Anna Date: 2019-10-22T02:32:37Z New Revision: 04edd1893c2d0f35880fd5f81e78dc23979df0b9 URL: https://github.com/llvm/llvm-project/commit/04edd1893c2d0f35880fd5f81e78dc23979df0b9 DIFF: https://github.com/llvm/llvm-project/commit/04edd1893c2d0f35880fd5f81e78dc23979df0b9.diff LO

[Lldb-commits] [PATCH] D68856: convert SBDebugger::***FileHandle() wrappers to native files.

lawrence_danna added a comment. @mgorny can you at least point me at the setup scripts buildbot us using for netbsd? What dependencies are installed? How is cmake invoked? I'm getting a ton on unrelated problems just trying to build it. Repository: rG LLVM Github Monorepo CHANGES SINC

[Lldb-commits] [PATCH] D69230: RFC: specialized Optional for T that can represent its own invalid state

lawrence_danna updated this revision to Diff 225983. lawrence_danna added a comment. add a comment explaining OptionalInfo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69230/new/ https://reviews.llvm.org/D69230 Files: llvm/include/llvm/ADT/Opti

[Lldb-commits] [PATCH] D69230: RFC: specialized Optional for T that can represent its own invalid state

lawrence_danna updated this revision to Diff 225984. lawrence_danna added a comment. edit comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69230/new/ https://reviews.llvm.org/D69230 Files: llvm/include/llvm/ADT/Optional.h llvm/unittests/A

[Lldb-commits] [PATCH] D69230: RFC: specialized Optional for T that can represent its own invalid state

lawrence_danna added a comment. In D69230#1717364 , @labath wrote: > > The thing I would like to see here is to have this behaviour be configurable > via a traits argument of the Optional class, similarly to how DenseMap allows > the type to specify

[Lldb-commits] [PATCH] D69148: Disable exit-on-SIGPIPE in lldb

vsk marked an inline comment as done. vsk added a comment. I admit I hadn't paid enough attention to the order in which signal handlers were registered in lldb. Comment at: lldb/tools/driver/Driver.cpp:850 #if !defined(_MSC_VER) signal(SIGPIPE, SIG_IGN); signal(SIGWINCH

[Lldb-commits] [PATCH] D69230: RFC: specialized Optional for T that can represent its own invalid state

lawrence_danna updated this revision to Diff 225980. lawrence_danna added a comment. call the traits struct OptionalInfo for consistency with DenseMap Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69230/new/ https://reviews.llvm.org/D69230 Files:

[Lldb-commits] [PATCH] D69273: ValueObject: Fix a crash related to children address type computation

jingham added a comment. Except for the comment comment this looks fine. I think the Host -> Load address code isn't quite right, though it looks like that's not your doing. The main reason why you would copy a ValueObject into Host memory it is to freeze-dry it as a ConstResult. Since that i

[Lldb-commits] [PATCH] D69148: Disable exit-on-SIGPIPE in lldb

labath added a comment. In D69148#1717453 , @labath wrote: > I'm not too worried about adding those tests here. I'm not too worried about *not* adding those tests here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D69230: RFC: specialized Optional for T that can represent its own invalid state

lawrence_danna updated this revision to Diff 225975. lawrence_danna added a comment. fix some silly bugs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69230/new/ https://reviews.llvm.org/D69230 Files: llvm/include/llvm/ADT/Optional.h llvm/unit

[Lldb-commits] [PATCH] D69148: Disable exit-on-SIGPIPE in lldb

labath added a comment. In D69148#1717361 , @vsk wrote: > A problem I'm encountering with this is that the static initializer from > Signals.inc don't appear to be re-run between death tests. This makes the > death tests pretty brittle, imo, as swapping

[Lldb-commits] [PATCH] D69286: I implemented the features listed in this document: http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2017/p0616r0.pdf and built libc++ using ninja without any errors/w

Afadyfarag created this revision. Afadyfarag added reviewers: clayborg, aprantl, JDevlieghere. Herald added subscribers: libcxx-commits, ldionne, christof, mgorny. Herald added a reviewer: EricWF. Herald added a project: libc++. 1. Changes: libcxx/include/numeric Repository: rG LLVM Github

[Lldb-commits] [PATCH] D69285: minidump: Rename some architecture constants

labath created this revision. labath added reviewers: amccarth, clayborg. Herald added subscribers: fedor.sergeev, hiraditya, kristof.beyls. Herald added projects: LLDB, LLVM. The architecture enum contains two kinds of contstants: the "official" ones defined by Microsoft, and unofficial constants

[Lldb-commits] [PATCH] D69230: RFC: specialized Optional for T that can represent its own invalid state

lawrence_danna updated this revision to Diff 225967. lawrence_danna added a comment. ugh I edited the wrong revision, reverted. Sorry for the noise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69230/new/ https://reviews.llvm.org/D69230 Files:

[Lldb-commits] [PATCH] D69214: remove multi-argument form of PythonObject::Reset()

lawrence_danna updated this revision to Diff 225969. lawrence_danna added a comment. removed blank lines from python-wrapper.swig Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69214/new/ https://reviews.llvm.org/D69214 Files: lldb/include/lldb/I

[Lldb-commits] [lldb] e57fe85 - whitespace cleanup

Author: Adrian Prantl Date: 2019-10-21T22:48:27Z New Revision: e57fe85a599a8cc4990d6f4605f86b89dcb952b3 URL: https://github.com/llvm/llvm-project/commit/e57fe85a599a8cc4990d6f4605f86b89dcb952b3 DIFF: https://github.com/llvm/llvm-project/commit/e57fe85a599a8cc4990d6f4605f86b89dcb952b3.diff LOG:

[Lldb-commits] [PATCH] D69230: RFC: specialized Optional for T that can represent its own invalid state

lawrence_danna updated this revision to Diff 225965. lawrence_danna added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. remove empty lines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69230/new/ https://reviews.

[Lldb-commits] [PATCH] D69230: RFC: specialized Optional for T that can represent its own invalid state

labath added a reviewer: dblaikie. labath added a subscriber: dblaikie. labath added a comment. Lets loop in @dblaikie for start, and see how it goes from there. You can also check who modified/reviewed changes to this file lately.. I am a very big opponent of IsValid() methods, and so I am very

[Lldb-commits] [PATCH] D69148: Disable exit-on-SIGPIPE in lldb

vsk marked an inline comment as done. vsk added a comment. In D69148#1715532 , @labath wrote: > In D69148#1714785 , @vsk wrote: > > > The death tests are flaky. I've noticed two issues: > > > > 1. When run under lit

[Lldb-commits] [lldb] 667c2eb - Factor out common test functionality into a helper class. (NFC)

Author: Adrian Prantl Date: 2019-10-21T22:46:53Z New Revision: 667c2eb08b92907b260aee64a25250f610fcdc30 URL: https://github.com/llvm/llvm-project/commit/667c2eb08b92907b260aee64a25250f610fcdc30 DIFF: https://github.com/llvm/llvm-project/commit/667c2eb08b92907b260aee64a25250f610fcdc30.diff LOG:

[Lldb-commits] [PATCH] D68856: convert SBDebugger::***FileHandle() wrappers to native files.

lawrence_danna added a comment. I spoke too soon, I don't have a *usable* netbsd VM. @mgorny, Do you have a machine you can debug on yourself? Do those errors happen if you run the same test on an interactive terminal? It could be the stdin stream is not set to a valid file descriptor for th

[Lldb-commits] [lldb] 3434472 - XFAIL TestLocalVariables.py on Windows

Author: Jonas Devlieghere Date: 2019-10-21T22:16:28Z New Revision: 3434472ed74141848634b5eb3cd625d651e22562 URL: https://github.com/llvm/llvm-project/commit/3434472ed74141848634b5eb3cd625d651e22562 DIFF: https://github.com/llvm/llvm-project/commit/3434472ed74141848634b5eb3cd625d651e22562.diff

[Lldb-commits] [PATCH] D68856: convert SBDebugger::***FileHandle() wrappers to native files.

lawrence_danna added a comment. In D68856#1717257 , @mgorny wrote: > In D68856#1717247 , @lawrence_danna > wrote: > > > sure, um do you have a netbsd machine handy? > > > If you mean one I could you access to, then

[Lldb-commits] [PATCH] D69100: COFF: Create a separate "section" for the file header

labath added a comment. In D69100#1717251 , @amccarth wrote: > I'm OK with this. I'm just wondering whether it would be a good idea to make > it clear that these header sections are "not considered to be a section in > the strictest sense." Is the dist

[Lldb-commits] [PATCH] D68961: Add support for DW_AT_export_symbols for anonymous structs

labath added a comment. In D68961#1717197 , @shafik wrote: > When the I added the feature to the front end tests were added to verify that > `DW_AT_export_symbols` is being generated for anonymous structs in D66605 > and

[Lldb-commits] [lldb] ed870cc - Found more timeouts to unify.

Author: Adrian Prantl Date: 2019-10-21T20:50:45Z New Revision: ed870cce676ec873d5d0c9e084744ffba0eb67fc URL: https://github.com/llvm/llvm-project/commit/ed870cce676ec873d5d0c9e084744ffba0eb67fc DIFF: https://github.com/llvm/llvm-project/commit/ed870cce676ec873d5d0c9e084744ffba0eb67fc.diff LOG:

[Lldb-commits] [PATCH] D68856: convert SBDebugger::***FileHandle() wrappers to native files.

mgorny added a comment. In D68856#1717247 , @lawrence_danna wrote: > sure, um do you have a netbsd machine handy? If you mean one I could you access to, then I'm afraid not. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[Lldb-commits] [PATCH] D69100: COFF: Create a separate "section" for the file header

amccarth accepted this revision. amccarth added a comment. I'm OK with this. I'm just wondering whether it would be a good idea to make it clear that these header sections are "not considered to be a section in the strictest sense." Is the distinction going to be important to future code read

[Lldb-commits] [PATCH] D69214: remove multi-argument form of PythonObject::Reset()

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/scripts/Python/python-wrapper.swig:226 { -using namespace lldb_private; if (python_class_name == NULL || python_class_name[0] == '\0' || !se

[Lldb-commits] [PATCH] D68856: convert SBDebugger::***FileHandle() wrappers to native files.

lawrence_danna added a comment. In D68856#1717207 , @mgorny wrote: > I'm afraid this causes a few test failures on NetBSD, e.g.: > http://lab.llvm.org:8011/builders/netbsd-amd64/builds/22255/steps/run%20unit%20tests/logs/FAIL%3A%20lldb-api%3A%3ATestDefaul

[Lldb-commits] [PATCH] D68968: [android/process info] Introduce display_name

wallace updated this revision to Diff 225947. wallace retitled this revision from "[android/process info] Introduce bundle id" to "[android/process info] Introduce display_name". wallace edited the summary of this revision. wallace added a comment. Herald added a subscriber: kristof.beyls. now us

[Lldb-commits] [PATCH] D69100: COFF: Create a separate "section" for the file header

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. I've happened to poke around a bit more in this piece of code now recently, and it does indeed seem reasonable. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69100/new/ https://r

[Lldb-commits] [PATCH] D68856: convert SBDebugger::***FileHandle() wrappers to native files.

mgorny added a comment. I'm afraid this causes a few test failures on NetBSD, e.g.: http://lab.llvm.org:8011/builders/netbsd-amd64/builds/22255/steps/run%20unit%20tests/logs/FAIL%3A%20lldb-api%3A%3ATestDefaultConstructorForAPIObjects.py Could you help me debugging it? I haven't been working on t

[Lldb-commits] [PATCH] D69214: remove multi-argument form of PythonObject::Reset()

lawrence_danna added inline comments. Comment at: lldb/scripts/Python/python-extensions.swig:683-686 if (desc_len > 0) -return lldb_private::PythonString(llvm::StringRef(desc, desc_len)).release(); +return PythonString(llv

[Lldb-commits] [PATCH] D69214: remove multi-argument form of PythonObject::Reset()

lawrence_danna updated this revision to Diff 225942. lawrence_danna marked 14 inline comments as done. lawrence_danna added a comment. fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69214/new/ https://reviews.llvm.org/D69214 Files: lldb/inc

[Lldb-commits] [PATCH] D68961: Add support for DW_AT_export_symbols for anonymous structs

shafik added a comment. In D68961#1714241 , @labath wrote: > In D68961#1713566 , @shafik wrote: > > > We also have the lldb-cmake-matrix > > bot whi

[Lldb-commits] [PATCH] D68961: Add support for DW_AT_export_symbols for anonymous structs

shafik added a comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68961/new/ https://reviews.llvm.org/D68961 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D69210: [Disassembler] Simplify MCInst predicates

clayborg added a comment. In D69210#1717042 , @vsk wrote: > In D69210#1716861 , @clayborg wrote: > > > In D69210#1715679 , @vsk wrote: > > > > > Hm, this patch is bugging me.

[Lldb-commits] [PATCH] D69210: [Disassembler] Simplify MCInst predicates

vsk marked an inline comment as done. vsk added a comment. In D69210#1716861 , @clayborg wrote: > In D69210#1715679 , @vsk wrote: > > > Hm, this patch is bugging me. > > > > It looks a bit like instructions are stil

[Lldb-commits] [PATCH] D69273: ValueObject: Fix a crash related to children address type computation

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69273/new/ https://reviews.llvm.org/D69273 ___ lldb-commits mailing list l

[Lldb-commits] [PATCH] D69273: ValueObject: Fix a crash related to children address type computation

labath created this revision. labath added reviewers: jingham, clayborg. Herald added a subscriber: aprantl. This patch fixes a crash encountered when debugging optimized code. If some variable has been completely optimized out, but it's value is nonetheless known, the compiler can replace it with

[Lldb-commits] [lldb] 5827a82 - Unify timeouts in gdbserver tests and ensure they are larger if ASAN is enabled.

Author: Adrian Prantl Date: 2019-10-21T17:19:42Z New Revision: 5827a82a5870fcb59a9fb34e6891ca0f009d282a URL: https://github.com/llvm/llvm-project/commit/5827a82a5870fcb59a9fb34e6891ca0f009d282a DIFF: https://github.com/llvm/llvm-project/commit/5827a82a5870fcb59a9fb34e6891ca0f009d282a.diff LOG:

[Lldb-commits] [PATCH] D69210: [Disassembler] Simplify MCInst predicates

clayborg added a comment. In D69210#1715679 , @vsk wrote: > Hm, this patch is bugging me. > > It looks a bit like instructions are still decoded multiple times in > different ways (e.g. in the `Decode` and > `CalculateMnemonicOperandsAndComment` methods,

[Lldb-commits] [lldb] 7a79e10 - [lldb] Add test for executing static initializers in expression command

Author: Raphael Isemann Date: 2019-10-21T16:07:45Z New Revision: 7a79e10a82e0d5f84385566493823959dc1697b3 URL: https://github.com/llvm/llvm-project/commit/7a79e10a82e0d5f84385566493823959dc1697b3 DIFF: https://github.com/llvm/llvm-project/commit/7a79e10a82e0d5f84385566493823959dc1697b3.diff LO

[Lldb-commits] [PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

echristo added a comment. I kinda want the option to be encoded in the triple for earlier testing of linking issues, but for now this is probably OK. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66795/new/ https://reviews.llvm.org/D66795

[Lldb-commits] [PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

atanasyan added a comment. In D66795#1706011 , @mbrkusanin wrote: > @echristo @craig.topper @tstellar @dylanmckay @petecoup > If there are no objections then I'll split this into llvm, clang and lldb > patches and commit them next week. Mirko, I think

[Lldb-commits] [PATCH] D69254: [lldb] drop .symtab removal in minidebuginfo tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG9129a281cd5b: [lldb] drop .symtab removal in minidebuginfo tests (authored by kwk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69254/new/ https://reviews

[Lldb-commits] [lldb] 9129a28 - [lldb] drop .symtab removal in minidebuginfo tests

Author: Konrad Kleine Date: 2019-10-21T14:11:21Z New Revision: 9129a281cd5b8b1fb804be1de396de4a42676570 URL: https://github.com/llvm/llvm-project/commit/9129a281cd5b8b1fb804be1de396de4a42676570 DIFF: https://github.com/llvm/llvm-project/commit/9129a281cd5b8b1fb804be1de396de4a42676570.diff LOG:

[Lldb-commits] [PATCH] D69214: remove multi-argument form of PythonObject::Reset()

labath added inline comments. Comment at: lldb/scripts/Python/python-extensions.swig:683-686 if (desc_len > 0) -return lldb_private::PythonString(llvm::StringRef(desc, desc_len)).release(); +return PythonString(llvm::Strin

[Lldb-commits] [PATCH] D69254: [lldb] drop .symtab removal in minidebuginfo tests

grimar accepted this revision. grimar added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69254/new/ https://reviews.llvm.org/D69254 __

[Lldb-commits] [PATCH] D69254: [lldb] drop .symtab removal in minidebuginfo tests

kwk requested review of this revision. kwk added subscribers: grimar, labath. kwk added a comment. @grimar @labath tests did pass locally. Are you fine with this change then? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69254/new/ https://reviews

[Lldb-commits] [PATCH] D69254: [lldb] drop .symtab removal in minidebuginfo tests

kwk created this revision. Herald added subscribers: lldb-commits, MaskRay, arichardson, emaste. Herald added a reviewer: espindola. Herald added a reviewer: alexshap. Herald added a project: LLDB. kwk planned changes to this revision. kwk added a comment. Still tests are running locally... Afte

[Lldb-commits] [PATCH] D69254: [lldb] drop .symtab removal in minidebuginfo tests

kwk planned changes to this revision. kwk added a comment. Still tests are running locally... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69254/new/ https://reviews.llvm.org/D69254 ___ lldb-commits m

[Lldb-commits] [PATCH] D69226: [LLDB] [Windows] Initial support for ARM register contexts

This revision was automatically updated to reflect the committed changes. Closed by commit rGa59444a35608: [LLDB] [Windows] Initial support for ARM register contexts (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69226/new/ ht

[Lldb-commits] [lldb] a59444a - [LLDB] [Windows] Initial support for ARM register contexts

Author: Martin Storsjo Date: 2019-10-21T08:02:34Z New Revision: a59444a35608988e727fe3761e34f1fad6097617 URL: https://github.com/llvm/llvm-project/commit/a59444a35608988e727fe3761e34f1fad6097617 DIFF: https://github.com/llvm/llvm-project/commit/a59444a35608988e727fe3761e34f1fad6097617.diff LOG