[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

mgorny added a comment. I'm sorry but I won't be able to test it until later today. Visually, looks good though. Comment at: lldb/packages/Python/lldbsuite/test/python_api/file_handle/TestFileHandle.py:854 files = list(i(sbf)) +# delete them in

[Lldb-commits] [PATCH] D69469: [LLDB][formatters] ArgInfo::count -> ArgInfo::max_positional_args

This revision was automatically updated to reflect the committed changes. Closed by commit rG40b0fa7ef212: [LLDB][formatters] ArgInfo::count - ArgInfo::max_positional_args (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

lawrence_danna updated this revision to Diff 226599. lawrence_danna added a comment. and another Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69488/new/ https://reviews.llvm.org/D69488 Files:

[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

lawrence_danna updated this revision to Diff 226597. lawrence_danna added a comment. found another one Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69488/new/ https://reviews.llvm.org/D69488 Files:

[Lldb-commits] [PATCH] D69019: [lldb] move package generation from python to cmake

hhb added a comment. In D69019#1722063 , @labath wrote: > Right. I see what you mean. > > But... does this have to happen at build time? Since the list of files is > already known at configuration time, you should be able to generate the files > in the

[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

lawrence_danna updated this revision to Diff 226595. lawrence_danna added a comment. py2_const_cast shouldn't be static as a free function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69488/new/ https://reviews.llvm.org/D69488 Files:

[Lldb-commits] [lldb] 40b0fa7 - [LLDB][formatters] ArgInfo::count -> ArgInfo::max_positional_args

Author: Lawrence D'Anna Date: 2019-10-27T16:01:46-07:00 New Revision: 40b0fa7ef2123866b2252ef6990040c2707cabe4 URL: https://github.com/llvm/llvm-project/commit/40b0fa7ef2123866b2252ef6990040c2707cabe4 DIFF:

[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

lawrence_danna created this revision. lawrence_danna added reviewers: labath, mgorny. Herald added a subscriber: krytarowski. Herald added a project: LLDB. Here's another instance where we were calling fflush on an input stream, which is illegal on NetBSD. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D68737: SBFile::GetFile: convert SBFile back into python native files.

mgorny added a comment. Great, thanks! So it's not just my computer going crazy after all ;-). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68737/new/ https://reviews.llvm.org/D68737 ___ lldb-commits

[Lldb-commits] [PATCH] D68737: SBFile::GetFile: convert SBFile back into python native files.

lawrence_danna added a comment. In D68737#1722620 , @mgorny wrote: > In D68737#1722575 , @lawrence_danna > wrote: > > > In D68737#1722255 , @mgorny wrote: > > > > >

[Lldb-commits] [PATCH] D68737: SBFile::GetFile: convert SBFile back into python native files.

mgorny added a comment. In D68737#1722575 , @lawrence_danna wrote: > In D68737#1722255 , @mgorny wrote: > > > However, I think this is only a symptom of a more generic problem. I don't > > think we should really

[Lldb-commits] [PATCH] D68737: SBFile::GetFile: convert SBFile back into python native files.

lawrence_danna added a comment. In D68737#1722255 , @mgorny wrote: > However, I think this is only a symptom of a more generic problem. I don't > think we should really be creating a second system of file objects outside > Python, and injecting it into

[Lldb-commits] [PATCH] D68737: SBFile::GetFile: convert SBFile back into python native files.

mgorny added a comment. I've just tried on Linux and it seems that Python closes the same descriptors. So somehow closing stdin works here on Linux, and fails on NetBSD. Curious enough, with a simple test I can verify that both NetBSD and Linux return EBADF when trying to close stdin twice. So

[Lldb-commits] [PATCH] D69468: [LLDB][breakpoints] ArgInfo::count -> ArgInfo::max_positional_args

lawrence_danna marked an inline comment as done. lawrence_danna added inline comments. Comment at: lldb/scripts/Python/python-wrapper.swig:64 +unsigned max_positional_args = PythonCallable::ArgInfo::UNBOUNDED; +if (auto arg_info = pfunc.GetArgInfo()) {

[Lldb-commits] [PATCH] D68737: SBFile::GetFile: convert SBFile back into python native files.

mgorny added a comment. Which Python version are you using? I've just hacked Python 2.7 a bit and found that the failing `close()` is actually `fclose()` on `FILE*` object with fd=0. I can reproduce `EBADF` only when the same fd is closed twice, so I suspect that something else is closing

[Lldb-commits] [PATCH] D69468: [LLDB][breakpoints] ArgInfo::count -> ArgInfo::max_positional_args

labath added inline comments. Comment at: lldb/scripts/Python/python-wrapper.swig:64 +unsigned max_positional_args = PythonCallable::ArgInfo::UNBOUNDED; +if (auto arg_info = pfunc.GetArgInfo()) { Is there any case where fetching the argument info will