[Lldb-commits] [PATCH] D69230: RFC: specialized Optional for T that can represent its own invalid state

lawrence_danna abandoned this revision. lawrence_danna added a comment. thanks for the feedback, I'll come back with a "Dense" version of this at some point Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69230/new/ https://reviews.llvm.org/D69230

[Lldb-commits] [PATCH] D69532: [LLDB][PythonFile] fix dangerous borrow semantics on python2

lawrence_danna added a comment. @labath looks like you were right, just not flushing seems to work fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69532/new/ https://reviews.llvm.org/D69532 ___

[Lldb-commits] [PATCH] D69535: build: improve python check for Windows

compnerd marked an inline comment as done. compnerd added a comment. Yeah, doing an incremental rollout makes sense. Comment at: lldb/cmake/modules/LLDBConfig.cmake:225 + if(CMAKE_VERSION VERSION_GREATER_EQUAL 3.13 AND CMAKE_SYSTEM_NAME STREQUAL Windows) +

[Lldb-commits] [PATCH] D69532: [LLDB][PythonFile] fix dangerous borrow semantics on python2

lawrence_danna updated this revision to Diff 227009. lawrence_danna added a comment. fix the test too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69532/new/ https://reviews.llvm.org/D69532 Files:

[Lldb-commits] [PATCH] D69532: [LLDB][PythonFile] fix dangerous borrow semantics on python2

lawrence_danna updated this revision to Diff 227007. lawrence_danna added a comment. just don't even flush Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69532/new/ https://reviews.llvm.org/D69532 Files:

[Lldb-commits] [PATCH] D69468: [LLDB][breakpoints] ArgInfo::count -> ArgInfo::max_positional_args

This revision was automatically updated to reflect the committed changes. Closed by commit rGa69bbe02a235: [LLDB][breakpoints] ArgInfo::count - ArgInfo::max_positional_args (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 5cc2e06 - [lldbsuite] Remove unused support files

Author: Jonas Devlieghere Date: 2019-10-29T16:56:59-07:00 New Revision: 5cc2e0651fed7764f02421db1ba1719a10f17d25 URL: https://github.com/llvm/llvm-project/commit/5cc2e0651fed7764f02421db1ba1719a10f17d25 DIFF:

[Lldb-commits] [lldb] 8a82000 - [lldbsuite] Remove pre_kill_hook package

Author: Jonas Devlieghere Date: 2019-10-29T16:56:59-07:00 New Revision: 8a82000e486afe472519d288f2206399ada95aca URL: https://github.com/llvm/llvm-project/commit/8a82000e486afe472519d288f2206399ada95aca DIFF:

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

hhb created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. This makes all dependencies correct. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69589 Files: lldb/CMakeLists.txt lldb/scripts/CMakeLists.txt Index:

[Lldb-commits] [lldb] a69bbe0 - [LLDB][breakpoints] ArgInfo::count -> ArgInfo::max_positional_args

Author: Lawrence D'Anna Date: 2019-10-29T15:03:02-07:00 New Revision: a69bbe02a2352271e8b14542073f177e24c499c1 URL: https://github.com/llvm/llvm-project/commit/a69bbe02a2352271e8b14542073f177e24c499c1 DIFF:

[Lldb-commits] [PATCH] D69468: [LLDB][breakpoints] ArgInfo::count -> ArgInfo::max_positional_args

lawrence_danna marked 4 inline comments as done. lawrence_danna added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:76-79 +#pragma clang diagnostic push +#pragma clang diagnostic ignored "-Wreturn-type-c-linkage" + +extern

[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

guiandrade updated this revision to Diff 226958. guiandrade edited the summary of this revision. guiandrade added a comment. Moving to a single config, use-g-packet-for-reading, that forces the use of 'g' packets for reading, but does not force 'G' for writing. The latter only ends up being

[Lldb-commits] [lldb] d46c655 - [ValueObjectDisplay] Generalize the description of an option.

Author: Davide Italiano Date: 2019-10-29T13:05:56-07:00 New Revision: d46c65592e3ac6a78c54514e4919d505c1f0c74a URL: https://github.com/llvm/llvm-project/commit/d46c65592e3ac6a78c54514e4919d505c1f0c74a DIFF:

[Lldb-commits] [lldb] e658178 - [LLDB] Fix for windows bots broken by unsupported tests

Author: shafik Date: 2019-10-29T11:33:11-07:00 New Revision: e6581783f767b7dcaf84223aeae05d2467106113 URL: https://github.com/llvm/llvm-project/commit/e6581783f767b7dcaf84223aeae05d2467106113 DIFF: https://github.com/llvm/llvm-project/commit/e6581783f767b7dcaf84223aeae05d2467106113.diff LOG:

[Lldb-commits] [PATCH] D69532: [LLDB][PythonFile] fix dangerous borrow semantics on python2

lawrence_danna added a comment. In D69532#1724806 , @labath wrote: > So, if I understand correctly. The problem here is the final call to > `fflush`, which can end up referencing a closed FILE*. Can we just not call > `fflush` then? Hrm, maybe. I'll

Re: [Lldb-commits] [PATCH] D68961: Add support for DW_AT_export_symbols for anonymous structs

Stella, Thank you for the heads up, I am looking at it now. -Shafik > On Oct 29, 2019, at 11:04 AM, Stella Stamenova via Phabricator > wrote: > > stella.stamenova added a comment. > > This is broken on Windows. I moved the Buildbot to staging to resolve some of > the issues with the move

[Lldb-commits] [PATCH] D68961: Add support for DW_AT_export_symbols for anonymous structs

stella.stamenova added a comment. This is broken on Windows. I moved the Buildbot to staging to resolve some of the issues with the move to the monorepo, so you can see the failures here: http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/0/steps/test/logs/stdio Repository: rG

[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rG6a93a12a8dd9: [LLDB][Python] fix another fflush issue on NetBSD (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69488/new/

[Lldb-commits] [PATCH] D69555: [zorg] Fix LLDBCmakeBuildFactory

stella.stamenova accepted this revision. stella.stamenova added a comment. Thanks @labath CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69555/new/ https://reviews.llvm.org/D69555 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] 6a93a12 - [LLDB][Python] fix another fflush issue on NetBSD

Author: Lawrence D'Anna Date: 2019-10-29T09:41:22-07:00 New Revision: 6a93a12a8dd98291225a282b5b8f3c97e68ebe49 URL: https://github.com/llvm/llvm-project/commit/6a93a12a8dd98291225a282b5b8f3c97e68ebe49 DIFF:

[Lldb-commits] [lldb] e56ba37 - build: make standalone builds work again

Author: Saleem Abdulrasool Date: 2019-10-29T08:24:10-07:00 New Revision: e56ba3743bcc344c51be9d919c32ec8f88ddef44 URL: https://github.com/llvm/llvm-project/commit/e56ba3743bcc344c51be9d919c32ec8f88ddef44 DIFF:

[Lldb-commits] [lldb] 55eec2b - build: workaround stale caches (NFC)

Author: Saleem Abdulrasool Date: 2019-10-29T08:20:58-07:00 New Revision: 55eec2ba96bd9c19ccb5d4d13cb8c88d4abcebc6 URL: https://github.com/llvm/llvm-project/commit/55eec2ba96bd9c19ccb5d4d13cb8c88d4abcebc6 DIFF:

[Lldb-commits] [lldb] 3011c7e - [lldb][NFC] Make LLVMUserExpression::DoExecute return early

Author: Raphael Isemann Date: 2019-10-29T15:38:35+01:00 New Revision: 3011c7eb31c58526066841e84e7f0a6b9b733b57 URL: https://github.com/llvm/llvm-project/commit/3011c7eb31c58526066841e84e7f0a6b9b733b57 DIFF:

[Lldb-commits] [PATCH] D69555: [zorg] Fix LLDBCmakeBuildFactory

jankratochvil accepted this revision. jankratochvil added a comment. This revision is now accepted and ready to land. It does run now, I did not test it with a slave. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69555/new/ https://reviews.llvm.org/D69555

[Lldb-commits] [PATCH] D69502: [LLDB] [PECOFF] Don't crash in ReadImageDataByRVA for addresses out of range

mstorsjo added a comment. In D69502#1725146 , @labath wrote: > In D69502#1723715 , @mstorsjo wrote: > > > In D69502#1723549 , @labath wrote: > > > > > Any way to get a test

[Lldb-commits] [PATCH] D69502: [LLDB] [PECOFF] Don't crash in ReadImageDataByRVA for addresses out of range

labath added a comment. In D69502#1723715 , @mstorsjo wrote: > In D69502#1723549 , @labath wrote: > > > Any way to get a test for this? Maybe creating a object file with a bogus > > unwind RVA via yaml2obj ? > > >

[Lldb-commits] [PATCH] D69366: [LLDB] [PECOFF] Use FindSectionByID to associate symbols to sections

This revision was automatically updated to reflect the committed changes. Closed by commit rG4394b5bee615: [LLDB] [PECOFF] Use FindSectionByID to associate symbols to sections (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D69555: [zorg] Fix LLDBCmakeBuildFactory

labath updated this revision to Diff 226872. labath added a comment. import FileDoesNotExist CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69555/new/ https://reviews.llvm.org/D69555 Files: zorg/buildbot/builders/LLDBBuilder.py Index: zorg/buildbot/builders/LLDBBuilder.py

[Lldb-commits] [PATCH] D68130: [lldb] Don't emit artificial constructor declarations as global functions

teemperor added a comment. Whoops, I meant skipIf'ing, not x-failing. Anyway, I can reproduce the SIBABRT fail on my Arch Linux CI, so it seems that Stella's ubuntu failure isn't at fault here but instead some other issue. If I disable unwind-on-error I get this: lldb version 10.0.0

[Lldb-commits] [PATCH] D69555: [zorg] Fix LLDBCmakeBuildFactory

jankratochvil requested changes to this revision. jankratochvil added a comment. This revision now requires changes to proceed. 2019-10-29 11:38:04+0100 [-] error while parsing config file 2019-10-29 11:38:04+0100 [-] Unhandled Error Traceback (most recent call last): File

[Lldb-commits] [PATCH] D69555: [zorg] Fix LLDBCmakeBuildFactory

labath created this revision. labath added reviewers: jankratochvil, stella.stamenova, gkistanova. The attempt in D69341 was not complete, as in the monorepo world, we also need to pass LLVM_ENABLE_PROJECTS in order to build lldb (and clang and lld). This also

[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

labath added a comment. In D62931#1724433 , @guiandrade wrote: > In D62931#1719948 , @labath wrote: > > > I'm sorry, this dropped off my radar. The code looks fine, but it could use > > some more tests. For

[Lldb-commits] [PATCH] D69532: [LLDB][PythonFile] fix dangerous borrow semantics on python2

labath added a comment. So, if I understand correctly. The problem here is the final call to `fflush`, which can end up referencing a closed FILE*. Can we just not call `fflush` then? It shouldn't be really needed -- if everything goes through the same FILE* object, the C library will make

[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

labath accepted this revision. labath added a comment. Ok, let's get this thing fixed. We can continue the discussion on the other patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69488/new/ https://reviews.llvm.org/D69488

[Lldb-commits] [PATCH] D69535: build: improve python check for Windows

labath added subscribers: aleksandr.urakov, amccarth, ted, labath. labath added a comment. Yeah, I'd still like to avoid having multiple paths for configuring python, as one of them is bound to end up broken sooner or later. However, given that there's already talk about bumping the minimum

[Lldb-commits] [PATCH] D69468: [LLDB][breakpoints] ArgInfo::count -> ArgInfo::max_positional_args

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks fine, though I'd try to remove the `extern "C"` thingy to avoid the need to supress warnings and stuff... Comment at: