[Lldb-commits] [PATCH] D69612: [lldb-vscod] fix build with NDEBUG on windows

SquallATF created this revision. SquallATF added a reviewer: mstorsjo. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. _setmode in assert will not run when build with NDEBUG Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69612 Files: lldb/tools/lldb-vs

[Lldb-commits] [PATCH] D69612: [lldb-vscod] fix build with NDEBUG on windows

mstorsjo added reviewers: labath, amccarth. mstorsjo added a comment. Good catch, thanks! But would we need to add something like `(void)result;` to silence potential compiler warnings about an unused (or set but not read) variable? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

labath added reviewers: labath, mgorny, sgraenitz. labath added a comment. This looks reasonable to me. I'm just wondering, now that these are separate targets, I guess that means they can be run in random order, right? Will that cause any problems, for instance when creating a package and its s

[Lldb-commits] [PATCH] D69503: [LLDB] [Windows] Don't crash if the debugged process is unable to start up

mstorsjo added a comment. Yes, this definitely is a race condition. Without any changes, I triggered this condition on arm64, but not on x86_64. The issue is in the subclass ProcessWindows, where OnExitProcess does this: void ProcessWindows::OnDebuggerError(const Status &error, uint32_t type)

[Lldb-commits] [PATCH] D69031: [LLDB] [test] Use %clang_cl instead of build.py in a few tests

mstorsjo added a comment. In D69031#1714143 , @labath wrote: > In D69031#1714107 , @mstorsjo wrote: > > > In D69031#1713900 , @aprantl wrote: > > > > > Check out `lldb/test/

[Lldb-commits] [PATCH] D69612: [lldb-vscod] fix build with NDEBUG on windows

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. LGTM, modulo the `(void) result` stuff. Do you need someone to commit this for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69612/new/ ht

[Lldb-commits] [PATCH] D69532: [LLDB][PythonFile] fix dangerous borrow semantics on python2

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D69532#1725772 , @lawrence_danna wrote: > > It shouldn't be really needed -- if everything goes through the same FILE* > > object, the C library wi

[Lldb-commits] [PATCH] D69503: [LLDB] [Windows] Don't crash if the debugged process is unable to start up

labath added a comment. In D69503#1726823 , @mstorsjo wrote: > What's the correct course of action here? Remove the `m_session_data.reset()` > from ProcessWindows::OnExitProcess, concluding that it's up to some other > class to clear `m_session_data` in

[Lldb-commits] [PATCH] D69612: [lldb-vscod] fix build with NDEBUG on windows

SquallATF added a comment. In D69612#1726829 , @labath wrote: > LGTM, modulo the `(void) result` stuff. Do you need someone to commit this > for you? Yes I need. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D69502: [LLDB] [PECOFF] Don't crash in ReadImageDataByRVA for addresses out of range

mstorsjo added a comment. In D69502#1725155 , @mstorsjo wrote: > In D69502#1725146 , @labath wrote: > > > In D69502#1723715 , @mstorsjo > > wrote: > > > > > In D69502#172354

[Lldb-commits] [PATCH] D69031: [LLDB] [test] Use %clang_cl instead of build.py in a few tests

labath added a comment. I'm afraid I haven't been able to write a single line of code since I got back from the devmtg, but I have this on my radar, and I fully intend to get back to it. :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69031/new/

[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This looks fine to me. Thanks for your patience. Do you still need someone to commit this for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D69555: [zorg] Fix LLDBCmakeBuildFactory

This revision was automatically updated to reflect the committed changes. Closed by commit rZORGa342b84f8576: [zorg] Fix LLDBCmakeBuildFactory (authored by labath). Repository: rZORG LLVM Github Zorg CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69555/new/ https://reviews.llvm.org/D69

[Lldb-commits] [PATCH] D69502: [LLDB] [PECOFF] Don't crash in ReadImageDataByRVA for addresses out of range

labath added a comment. Try this for patch for size: F10586804: a.patch . It needs to me moved into a separate test case, and cleaned up a bit, but I believe it should trigger the bug you're fixing here. The tricky part about unwind info is that you currentl

[Lldb-commits] [lldb] f1e0ae3 - COFF: Set section permissions

Author: Pavel Labath Date: 2019-10-30T14:13:21+01:00 New Revision: f1e0ae3420b6cd554a240274c5ec77ccc4392ad3 URL: https://github.com/llvm/llvm-project/commit/f1e0ae3420b6cd554a240274c5ec77ccc4392ad3 DIFF: https://github.com/llvm/llvm-project/commit/f1e0ae3420b6cd554a240274c5ec77ccc4392ad3.diff

[Lldb-commits] [lldb] 2dbcfad - [lldb-vscod] fix build with NDEBUG on windows

Author: SquallATF Date: 2019-10-30T14:20:22+01:00 New Revision: 2dbcfad35de6a1c86e794d911304ed50257d6d87 URL: https://github.com/llvm/llvm-project/commit/2dbcfad35de6a1c86e794d911304ed50257d6d87 DIFF: https://github.com/llvm/llvm-project/commit/2dbcfad35de6a1c86e794d911304ed50257d6d87.diff LOG

[Lldb-commits] [PATCH] D69102: COFF: Set section permissions

This revision was automatically updated to reflect the committed changes. Closed by commit rGf1e0ae3420b6: COFF: Set section permissions (authored by labath). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D69102?vs=225403&id=227077#toc Repository: rG LLVM Gi

[Lldb-commits] [PATCH] D69612: [lldb-vscod] fix build with NDEBUG on windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG2dbcfad35de6: [lldb-vscod] fix build with NDEBUG on windows (authored by SquallATF, committed by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69612

[Lldb-commits] [lldb] 2d1a0df - lldb-vscode: Add a forgotten cast to void

Author: Pavel Labath Date: 2019-10-30T14:27:55+01:00 New Revision: 2d1a0dfe4c7c470ad8792eaba669115dfe8eff06 URL: https://github.com/llvm/llvm-project/commit/2d1a0dfe4c7c470ad8792eaba669115dfe8eff06 DIFF: https://github.com/llvm/llvm-project/commit/2d1a0dfe4c7c470ad8792eaba669115dfe8eff06.diff

[Lldb-commits] [PATCH] D69612: [lldb-vscod] fix build with NDEBUG on windows

mstorsjo added a comment. I presume you applied the patch with `arc patch`? It seems to apply the Phabricator username as git user, which is a bit odd, as it is customary to use realnames in the git author field. Earlier, when everything ended up mangled by svn, everything ended up normalized t

[Lldb-commits] [PATCH] D69612: [lldb-vscod] fix build with NDEBUG on windows

labath added a comment. Yes, I used "arc patch". I did check that it preserved the authorship information, but I did not go into the details of what's in the author field TBH. I agree it would be better to have the full name there, but I don't know if there's a way to change that (short of peop

[Lldb-commits] [lldb] 83a55c6 - minidump: Rename some architecture constants

Author: Pavel Labath Date: 2019-10-30T14:46:00+01:00 New Revision: 83a55c6a575806eec78062dfe128c095c26ab5e2 URL: https://github.com/llvm/llvm-project/commit/83a55c6a575806eec78062dfe128c095c26ab5e2 DIFF: https://github.com/llvm/llvm-project/commit/83a55c6a575806eec78062dfe128c095c26ab5e2.diff

[Lldb-commits] [PATCH] D69285: minidump: Rename some architecture constants

This revision was automatically updated to reflect the committed changes. Closed by commit rG83a55c6a5758: minidump: Rename some architecture constants (authored by labath). Changed prior to commit: https://reviews.llvm.org/D69285?vs=225971&id=227084#toc Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D69535: build: improve python check for Windows

amccarth added a comment. In D69535#1724797 , @labath wrote: > .. Given that this code is python3 specific and other platforms still support > python2, maybe we can make this bump windows-specific at first, and then > extend it to other platforms once we

[Lldb-commits] [PATCH] D69031: [LLDB] [test] Use %clang_cl instead of build.py in a few tests

labath added a comment. BTW, as I started working on this patch, I realized that there is a (somewhat surprising) workaround for this problem. If we change the isysroot argument to be passed as `-isysroot/foo` (instead of `-isysroot /foo`), then clang-cl will properly ignore this argument (as i

[Lldb-commits] [PATCH] D69619: [lldb/lit] Introduce %clang_host substitutions

labath created this revision. labath added reviewers: JDevlieghere, aprantl, mstorsjo. Herald added subscribers: jfb, MaskRay, arichardson, emaste. Herald added a reviewer: espindola. Herald added a project: LLDB. This patch addresses an ambiguity in how our existing tests invoke the compiler. Rou

[Lldb-commits] [PATCH] D69230: RFC: specialized Optional for T that can represent its own invalid state

labath added a comment. BTW, I was bored on the plane, so I created this proof of concept F10589216: dense.cc . It needs a lot of cleanup of course, but it demonstrates one way to generically store some extra data with some type. It gives each type the option

[Lldb-commits] [PATCH] D68130: [lldb] Don't emit artificial constructor declarations as global functions

labath added a comment. That is interesting. Can you send me the binary produced by this test? I'd like to compare it with what I get locally. (I can also send you mine if you're interested) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68130/new/

[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

guiandrade added a comment. In D62931#1726865 , @labath wrote: > This looks fine to me. Thanks for your patience. Do you still need someone to > commit this for you? Np. Yes, I do. Could you please do it for me? Thanks! Repository: rG LLVM Github M

[Lldb-commits] [PATCH] D69619: [lldb/lit] Introduce %clang_host substitutions

aprantl added a comment. this looks like a reasonable incremental improvement. That said, I'm wondering how useful `clang_host` is as a concept in the LIT tests. In my own mental model the tests are grouped into 1. end-to-end tests that test lldb against a variety of user-configurable compiler

[Lldb-commits] [lldb] 3071ebf - [LLDB][PythonFile] fix dangerous borrow semantics on python2

Author: Lawrence D'Anna Date: 2019-10-30T09:46:51-07:00 New Revision: 3071ebf7b38341e89be04aa64c257c4643e0648c URL: https://github.com/llvm/llvm-project/commit/3071ebf7b38341e89be04aa64c257c4643e0648c DIFF: https://github.com/llvm/llvm-project/commit/3071ebf7b38341e89be04aa64c257c4643e0648c.dif

[Lldb-commits] [lldb] fb01c01 - [LLDB][Python] warning fix for LLDBSwigPythonBreakpointCallbackFunction

Author: Lawrence D'Anna Date: 2019-10-30T09:47:27-07:00 New Revision: fb01c01bf3f60d1d229126ea4088519adae5c015 URL: https://github.com/llvm/llvm-project/commit/fb01c01bf3f60d1d229126ea4088519adae5c015 DIFF: https://github.com/llvm/llvm-project/commit/fb01c01bf3f60d1d229126ea4088519adae5c015.dif

[Lldb-commits] [PATCH] D69532: [LLDB][PythonFile] fix dangerous borrow semantics on python2

This revision was automatically updated to reflect the committed changes. Closed by commit rG3071ebf7b383: [LLDB][PythonFile] fix dangerous borrow semantics on python2 (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69532/

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

hhb marked an inline comment as done. hhb added a comment. In D69589#1726812 , @labath wrote: > This looks reasonable to me. I'm just wondering, now that these are separate > targets, I guess that means they can be run in random order, right? Will that >

[Lldb-commits] [PATCH] D69630: [lldb] Record framework build path and use it everywhere

hhb created this revision. hhb added a reviewer: labath. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. This avoids config time dependencies on liblldb. And enables other refactoring. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69630 Files:

[Lldb-commits] [PATCH] D69612: [lldb-vscod] fix build with NDEBUG on windows

amccarth added a comment. In D69612#1726849 , @SquallATF wrote: > In D69612#1726829 , @labath wrote: > > > LGTM, modulo the `(void) result` stuff. Do you need someone to commit this > > for you? > > > Yes I need.

[Lldb-commits] [PATCH] D69619: [lldb/lit] Introduce %clang_host substitutions

labath added a comment. Yes, I understand what you're saying, but I am afraid the situation is not as clear-cut as that. I would be very happy if it was, but it's definitely not the current situation, and given the complexities involved, I'm not sure if we should even aim for that goal. I mean,

[Lldb-commits] [PATCH] D69630: [lldb] Record framework build path and use it everywhere

hhb updated this revision to Diff 227145. hhb added a comment. Update one more place Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69630/new/ https://reviews.llvm.org/D69630 Files: lldb/CMakeLists.txt lldb/cmake/modules/AddLLDB.cmake lldb/cm

[Lldb-commits] [PATCH] D69612: [lldb-vscod] fix build with NDEBUG on windows

labath added a comment. It ended up being a separate commit (2d1a0dfe ) because I don't know how to use git. :P As far as change attribution is concerned, that may be even for the better. :) Repository: rG LLVM Github Mono

[Lldb-commits] [PATCH] D69503: [LLDB] [Windows] Don't crash if the debugged process is unable to start up

amccarth added a comment. In D69503#1726841 , @labath wrote: > (Ideally, I'd just delete ProcessWindows entirely, and move everything to > lldb-server based model -- it's much easier to reason about threads there) I believe there are people working on m

[Lldb-commits] [lldb] 5e029c4 - DebugServer: be more lenient about the target triple

Author: Saleem Abdulrasool Date: 2019-10-30T12:08:29-07:00 New Revision: 5e029c4cfd7b8db269b6db475ecd420311fbd7d1 URL: https://github.com/llvm/llvm-project/commit/5e029c4cfd7b8db269b6db475ecd420311fbd7d1 DIFF: https://github.com/llvm/llvm-project/commit/5e029c4cfd7b8db269b6db475ecd420311fbd7d1.

[Lldb-commits] [PATCH] D69619: [lldb/lit] Introduce %clang_host substitutions

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. > The one barrier we have right now is that it is not possible to run the "lit" > suite with a different compiler, and that's something I think we should keep. Very much agreed. > For the t

[Lldb-commits] [PATCH] D69619: [lldb/lit] Introduce %clang_host substitutions

JDevlieghere accepted this revision. JDevlieghere added a comment. All my thoughts have already been brought up and discussed. :-) LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69619/new/ https://reviews.llvm.org/D69619 __

[Lldb-commits] [PATCH] D68868: Fix build under musl

JDevlieghere added a comment. Let me know if you want me to commit this for you. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68868/new/ https://reviews.llvm.org/D68868 ___ lldb-commits mailing list lldb-commits@l

[Lldb-commits] [PATCH] D69630: [lldb] Record framework build path and use it everywhere

hhb updated this revision to Diff 227172. hhb added a comment. Fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69630/new/ https://reviews.llvm.org/D69630 Files: lldb/CMakeLists.txt lldb/cmake/modules/AddLLDB.cmake lldb/cmake/modules/LLDBCo

[Lldb-commits] [PATCH] D69641: [Symbol] Change ClangASTContext::GetCXXClassName return type

xiaobai created this revision. xiaobai added reviewers: JDevlieghere, labath, compnerd. Herald added a project: LLDB. Instead of filling out a std::string and returning a bool to indicate success, returning a std::string directly and testing to see if it's empty seems like a cleaner solution overa

[Lldb-commits] [PATCH] D69641: [Symbol] Change ClangASTContext::GetCXXClassName return type

teemperor added a comment. Could this return an `Optional` or `Expected`? It's not clear from a `std::string` return value that the method can fail and it will return an empty string on error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69641/ne

[Lldb-commits] [PATCH] D69641: [Symbol] Change ClangASTContext::GetCXXClassName return type

xiaobai added a comment. In D69641#1727787 , @teemperor wrote: > Could this return an `Optional` or `Expected`? It's > not clear from a `std::string` return value that the method can fail and it > will return an empty string on error. That sounds like

[Lldb-commits] [PATCH] D69502: [LLDB] [PECOFF] Don't crash in ReadImageDataByRVA for addresses out of range

mstorsjo updated this revision to Diff 227183. mstorsjo added a comment. Added a testcase based on @labath 's patch. (Thanks! That managed to trigger the condition!) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69502/new/ https://reviews.llvm.org/D69502 Files: lldb/source/Plugins/O

[Lldb-commits] [PATCH] D69555: [zorg] Fix LLDBCmakeBuildFactory

stella.stamenova added a comment. Sadly, I think this broke the windows bot now (assuming it got applied to staging, otherwise I have to figure out what did): http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/46/steps/cmake-configure/logs/stdio Repository: rZORG LLVM Github Zor

[Lldb-commits] [PATCH] D69646: [LLDB] [PECOFF] Fix error handling for executables that object::createBinary error out on

mstorsjo created this revision. mstorsjo added reviewers: labath, amccarth, aleksandr.urakov. Herald added subscribers: JDevlieghere, abidh. Herald added a project: LLDB. llvm::object::createBinary returns an Expected<>, which requires not only checking the object for success, but also requires c

[Lldb-commits] [PATCH] D69641: [Symbol] Change ClangASTContext::GetCXXClassName return type

xiaobai updated this revision to Diff 227188. xiaobai added a comment. Use llvm::Optional Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69641/new/ https://reviews.llvm.org/D69641 Files: lldb/include/lldb/Symbol/ClangASTContext.h lldb/source/Co

[Lldb-commits] [PATCH] D69641: [Symbol] Change ClangASTContext::GetCXXClassName return type

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69641/new/ https://reviews.llvm.org/D69641

[Lldb-commits] [lldb] a925974 - Run clang-format on lldb/source/Commands (NFC)

Author: Adrian Prantl Date: 2019-10-30T16:03:00-07:00 New Revision: a925974bf166a83cfd45b0ca89c5c65d17f275cc URL: https://github.com/llvm/llvm-project/commit/a925974bf166a83cfd45b0ca89c5c65d17f275cc DIFF: https://github.com/llvm/llvm-project/commit/a925974bf166a83cfd45b0ca89c5c65d17f275cc.diff

[Lldb-commits] [PATCH] D69503: [LLDB] [Windows] Don't crash if the debugged process is unable to start up

amccarth requested changes to this revision. amccarth added a comment. This revision now requires changes to proceed. Thanks for identifying this race condition. After some poking around, I think there's a cleaner way to address it. First, `m_session_state`'s lifetime is currently managed mostly

[Lldb-commits] [PATCH] D69555: [zorg] Fix LLDBCmakeBuildFactory

gkistanova added a comment. The cmake command redefinition effectively is not supported any more, but the 'cmake' arg is left behind. + inline comments. These have been addressed by https://reviews.llvm.org/rZORG425eeb1bf21b. Comment at: zorg/buildbot/builders/LLDBBuilder.py:

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

hhb updated this revision to Diff 227204. hhb added a comment. When creating symlink, make the target depends on relative target path. So that if the target file doesn't exist, the build will fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6958

[Lldb-commits] [lldb] 29d5e27 - Only ask once if we have no commands. NFC.

Author: Jim Ingham Date: 2019-10-30T18:04:03-07:00 New Revision: 29d5e275f28723b3b36b00e91b535d776f5aa281 URL: https://github.com/llvm/llvm-project/commit/29d5e275f28723b3b36b00e91b535d776f5aa281 DIFF: https://github.com/llvm/llvm-project/commit/29d5e275f28723b3b36b00e91b535d776f5aa281.diff LO

[Lldb-commits] [PATCH] D69230: RFC: specialized Optional for T that can represent its own invalid state

dblaikie added a comment. In D69230#1727209 , @labath wrote: > BTW, I was bored on the plane, so I created this proof of concept F10589216: > dense.cc . It needs a lot of cleanup of > course, but it demonstrates one wa