[Lldb-commits] [lldb] b30dabf - [lldb] Don't enable expression log in TestEmptyStdModule.py

Author: Raphael Isemann Date: 2019-11-22T08:34:08+01:00 New Revision: b30dabfe905b714b9161422b58199e2aa8938481 URL: https://github.com/llvm/llvm-project/commit/b30dabfe905b714b9161422b58199e2aa8938481 DIFF:

[Lldb-commits] [PATCH] D70580: Register Objective-C property accessors with their property decls.

aprantl created this revision. aprantl added reviewers: shafik, JDevlieghere, jingham, teemperor. This is a correctness fix for the Clang DWARF parser that primarily matters for swift-lldb's ability to import Clang types that were reconstructed from DWARF into Swift. Thanks to Shafik for

[Lldb-commits] [PATCH] D69880: [lldb] Fix exception breakpoint not being resolved when set on dummy target

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Ack, sorry about that! This looks fine, thanks for chasing it down. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69880/new/

[Lldb-commits] [PATCH] D69880: [lldb] Fix exception breakpoint not being resolved when set on dummy target

poya added a comment. @jingham I think this might have slipped through the cracks, do you think you'll have time to help me review and commit this one, or advice on a suitable alternate reviewer? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69880/new/

[Lldb-commits] [PATCH] D70574: [lldb-server] Verify 'g' is supported before relying on them

jasonmolenda added a comment. Hi, sorry I haven't had time to get back to this one. I wanted to look into the m_avoid_g_packets ivar in GDBRemoteCommunicationClient and GDBRemoteCommunicationClient::AvoidGPackets. It looks like it was written to specifically avoid the g packet with arm64

[Lldb-commits] [PATCH] D70574: [lldb-server] Verify 'g' is supported before relying on them

guiandrade created this revision. guiandrade added reviewers: jasonmolenda, labath. guiandrade added a project: LLDB. Herald added a subscriber: lldb-commits. This ensures that 'g' packets are only used if the config plugin.process.gdb-remote.use-g-packet-for-reading = true and we get a normal

[Lldb-commits] [lldb] bc8e88e - Early-exitify ClangASTContext::AddObjCClassProperty() (NFC)

Author: Adrian Prantl Date: 2019-11-21T15:41:22-08:00 New Revision: bc8e88e974550dc7a8000d526df6dadb12b54bc0 URL: https://github.com/llvm/llvm-project/commit/bc8e88e974550dc7a8000d526df6dadb12b54bc0 DIFF: https://github.com/llvm/llvm-project/commit/bc8e88e974550dc7a8000d526df6dadb12b54bc0.diff

[Lldb-commits] [lldb] b26d9e4 - [Reproducer] Instruct users to replay reproducer

Author: Jonas Devlieghere Date: 2019-11-21T13:25:53-08:00 New Revision: b26d9e417d2d4dbb47f6e967926dbb31f6d7a4b4 URL: https://github.com/llvm/llvm-project/commit/b26d9e417d2d4dbb47f6e967926dbb31f6d7a4b4 DIFF:

[Lldb-commits] [lldb] bb090bb - [Reproducer] Make 'reproducer xcrash' behave the same during capture & replay

Author: Jonas Devlieghere Date: 2019-11-21T13:34:04-08:00 New Revision: bb090bb1cad28cef1ad74c8ca986f3f5643eb6d9 URL: https://github.com/llvm/llvm-project/commit/bb090bb1cad28cef1ad74c8ca986f3f5643eb6d9 DIFF:

[Lldb-commits] [PATCH] D70100: [DWARF] Handle call sites with indirect call targets

vsk marked an inline comment as done. vsk added inline comments. Comment at: lldb/include/lldb/Symbol/Function.h:453 /// PC addresses (in increasing order). - llvm::MutableArrayRef GetCallEdges(); + llvm::ArrayRef> GetCallEdges(); aprantl wrote: > Since

[Lldb-commits] [PATCH] D70324: [lldb][test] Prevent \n in calls to lldb's expect() test helper.

davide added a comment. In D70324#1755704 , @labath wrote: > [This is probably not the right patch, as the last run on that bot still > doesn't have this commit.] > > My understanding is that all pexpect tests are failing on that bot and are > skipped

[Lldb-commits] [lldb] 44fe1f0 - [test] Mark TestEditline as skipped with ASan.

Author: Jonas Devlieghere Date: 2019-11-21T13:09:40-08:00 New Revision: 44fe1f024d542bb7d286f9dd03ef35ad474399bd URL: https://github.com/llvm/llvm-project/commit/44fe1f024d542bb7d286f9dd03ef35ad474399bd DIFF:

[Lldb-commits] [PATCH] D70100: [DWARF] Handle call sites with indirect call targets

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: lldb/include/lldb/Symbol/Function.h:453 /// PC addresses (in increasing order). - llvm::MutableArrayRef GetCallEdges(); + llvm::ArrayRef>

[Lldb-commits] [PATCH] D70324: [lldb][test] Prevent \n in calls to lldb's expect() test helper.

labath added a subscriber: teemperor. labath added a comment. [This is probably not the right patch, as the last run on that bot still doesn't have this commit.] My understanding is that all pexpect tests are failing on that bot and are skipped with `@skipIfAsan`. Probably this one needs to be

[Lldb-commits] [PATCH] D70100: [DWARF] Handle call sites with indirect call targets

vsk added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70100/new/ https://reviews.llvm.org/D70100 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] f5759d5 - [Test] Split up TestIntegerTypes.py

Author: Jonas Devlieghere Date: 2019-11-21T11:24:14-08:00 New Revision: f5759d5dbc441f1fe956757408f46e65611b94e5 URL: https://github.com/llvm/llvm-project/commit/f5759d5dbc441f1fe956757408f46e65611b94e5 DIFF:

Re: [Lldb-commits] [PATCH] D70324: [lldb][test] Prevent \n in calls to lldb's expect() test helper.

I'm not at a computer right now, so feel free to revert this commit now and I'll take a look at then failures later. Thanks! On Thu, Nov 21, 2019, 11:09 AM Jonas Devlieghere via Phabricator < revi...@reviews.llvm.org> wrote: > JDevlieghere added a comment. > > Looks like we happened to be

[Lldb-commits] [PATCH] D70324: [lldb][test] Prevent \n in calls to lldb's expect() test helper.

JDevlieghere added a comment. Looks like we happened to be looking at this at the same time :D Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70324/new/ https://reviews.llvm.org/D70324 ___ lldb-commits

[Lldb-commits] [PATCH] D70324: [lldb][test] Prevent \n in calls to lldb's expect() test helper.

JDevlieghere added a comment. Hey Jordan, the test is failing on the sanitized bot on GreenDragon. The error is `Could not terminate the child`. Could you have a look? http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-sanitized/541/console Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D70324: [lldb][test] Prevent \n in calls to lldb's expect() test helper.

davide added a comment. Hey Jordan, it looks like some of the changes to TestEditLine [or adjacent to it] broke the sanitized build on macOS. Can I ask you to take a look? Thanks http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-sanitized/539/console Repository: rG LLVM Github

[Lldb-commits] [PATCH] D70415: Complete complete types early when importing types from Clang module DWARF.

aprantl marked an inline comment as done. aprantl added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:236 + if (pcm_type.IsDefined()) +GetClangASTImporter().RequireCompleteType(ClangUtil::GetQualType(type)); + vsk

[Lldb-commits] [PATCH] D70415: Complete complete types early when importing types from Clang module DWARF.

aprantl marked an inline comment as done. aprantl added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:236 + if (pcm_type.IsDefined()) +GetClangASTImporter().RequireCompleteType(ClangUtil::GetQualType(type)); +

[Lldb-commits] [PATCH] D70448: [LLDB] Fix wrong argument in CommandObjectThreadStepWithTypeAndScope

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Looks right, thanks for catching this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70448/new/ https://reviews.llvm.org/D70448 ___

[Lldb-commits] [PATCH] D70415: Complete complete types early when importing types from Clang module DWARF.

vsk added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:236 + if (pcm_type.IsDefined()) +GetClangASTImporter().RequireCompleteType(ClangUtil::GetQualType(type)); + AIUI, when RequireCompleteType returns false,

[Lldb-commits] [PATCH] D70514: [Docs] Generate the LLDB man page with Sphinx

This revision was automatically updated to reflect the committed changes. Closed by commit rGbb775bee2125: [Docs] Generate the LLDB man page with Sphinx (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70514/new/

[Lldb-commits] [PATCH] D70514: [Docs] Generate the LLDB man page with Sphinx

JDevlieghere added a comment. In D70514#1754690 , @labath wrote: > LGTM. Unless you're interested in tablegening the command line option list, > that is. :) I considered it, but maybe that's something for the thanksgiving break ;-) CHANGES SINCE LAST

[Lldb-commits] [lldb] 3b69f0c - [NFC] Refactor and improve comments in CommandObjectTarget

Author: Adrian McCarthy Date: 2019-11-21T08:37:35-08:00 New Revision: 3b69f0c5550a229dd6d39e361182cdd7cecc36a4 URL: https://github.com/llvm/llvm-project/commit/3b69f0c5550a229dd6d39e361182cdd7cecc36a4 DIFF:

[Lldb-commits] [PATCH] D70022: [lldb] [Process/NetBSD] Improve threading support

mgorny updated this revision to Diff 230466. mgorny added a comment. Herald added a subscriber: dexonsmith. @labath, finally implemented the new tests. Covered two good (signal to one thread and to all threads) and two bad cases (signal to 1https://reviews.llvm.org/D70022/new/

[Lldb-commits] [PATCH] D70448: [LLDB] Fix wrong argument in CommandObjectThreadStepWithTypeAndScope

aganea added a comment. This is a trivial change, unless you have any objections, I'll go forward with this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70448/new/ https://reviews.llvm.org/D70448 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D69309: Support template instantiation in the expression evaluator

friss added a comment. In D69309#1754659 , @labath wrote: > In D69309#1754593 , @jarin wrote: > > > In D69309#1752738 , @friss wrote: > > > > > Sorry that I haven't reviewed

[Lldb-commits] [lldb] 8cf8ec4 - [lldb][NFC] Modernize string handling in ClangExpressionDeclMap::FindExternalVisibleDecl

Author: Raphael Isemann Date: 2019-11-21T14:59:47+01:00 New Revision: 8cf8ec40a1fee9706237d30385e78e1de214d8f7 URL: https://github.com/llvm/llvm-project/commit/8cf8ec40a1fee9706237d30385e78e1de214d8f7 DIFF:

[Lldb-commits] [PATCH] D70458: [NFC] Refactor and improve comments in CommandObjectTarget

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:4059 if (!module_spec.GetFileSpec() && !module_spec.GetPlatformFileSpec()) -

[Lldb-commits] [lldb] 5fb7dd8 - [lldb][NFC] Move searching functions in ClangExpressionDeclMap to own function

Author: Raphael Isemann Date: 2019-11-21T14:31:31+01:00 New Revision: 5fb7dd8a40d2f35eea47b9c280722bd735e387a0 URL: https://github.com/llvm/llvm-project/commit/5fb7dd8a40d2f35eea47b9c280722bd735e387a0 DIFF:

[Lldb-commits] [lldb] 24e9886 - [lldb][NFC] Reduce scope of some variables in ClangExpressionDeclMap::FindExternalVisibleDecls

Author: Raphael Isemann Date: 2019-11-21T13:43:48+01:00 New Revision: 24e98867937d5bb89605fd7be7e9ebdd3d5fb935 URL: https://github.com/llvm/llvm-project/commit/24e98867937d5bb89605fd7be7e9ebdd3d5fb935 DIFF:

[Lldb-commits] [PATCH] D70532: [lldb] Improve/fix base address selection in location lists

labath created this revision. labath added reviewers: JDevlieghere, aprantl, clayborg. Herald added a project: LLDB. Lldb support base address selection entries in location lists was broken for a long time. This wasn't noticed until llvm started producing these kinds of entries more frequently

[Lldb-commits] [lldb] ffc4ff8 - [lldb][NFC] Remove test directory completely

Author: Tatyana Krasnukha Date: 2019-11-21T15:03:37+03:00 New Revision: ffc4ff868fcca29080dcc90e223b582c4ccfc574 URL: https://github.com/llvm/llvm-project/commit/ffc4ff868fcca29080dcc90e223b582c4ccfc574 DIFF:

[Lldb-commits] [lldb] 7fa976d - [lldb][NFC] Move searching local variables into own function

Author: Raphael Isemann Date: 2019-11-21T12:45:38+01:00 New Revision: 7fa976d57a1e2ab735212e5d9fc13cc38c4c81e9 URL: https://github.com/llvm/llvm-project/commit/7fa976d57a1e2ab735212e5d9fc13cc38c4c81e9 DIFF:

[Lldb-commits] [lldb] a0408ab - [lldb][NFC] Move searching the ClangModulesDeclVendor into own function

Author: Raphael Isemann Date: 2019-11-21T12:04:43+01:00 New Revision: a0408ab7f9863954b9d978d78761ed7b893f13b1 URL: https://github.com/llvm/llvm-project/commit/a0408ab7f9863954b9d978d78761ed7b893f13b1 DIFF:

[Lldb-commits] [lldb] 337151f - [lldb][NFC] Move searching for the local variable namespace into own function

Author: Raphael Isemann Date: 2019-11-21T11:03:24+01:00 New Revision: 337151f41e78f42df1eedbb86479888a2c5d0a04 URL: https://github.com/llvm/llvm-project/commit/337151f41e78f42df1eedbb86479888a2c5d0a04 DIFF:

[Lldb-commits] [PATCH] D70514: [Docs] Generate the LLDB man page with Sphinx

labath accepted this revision. labath added a comment. LGTM. Unless you're interested in tablegening the command line option list, that is. :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70514/new/ https://reviews.llvm.org/D70514 ___

[Lldb-commits] [lldb] 2cada1e - [lldb][NFC] Early exit in ClangExpressionDeclMap::FindExternalVisibleDecls

Author: Raphael Isemann Date: 2019-11-21T10:29:50+01:00 New Revision: 2cada1e4da9d55b54a06b240cc061605729d50f4 URL: https://github.com/llvm/llvm-project/commit/2cada1e4da9d55b54a06b240cc061605729d50f4 DIFF:

[Lldb-commits] [PATCH] D69309: Support template instantiation in the expression evaluator

teemperor added reviewers: rsmith, v.g.vassilev. teemperor added a comment. I think this approach looks already much more feasible than the last iteration. +Richard because he knows better how `FindClassTemplateSpecialization` should look like to fit into the other lookup mechanisms we have in

[Lldb-commits] [PATCH] D69309: Support template instantiation in the expression evaluator

labath added a comment. In D69309#1754593 , @jarin wrote: > In D69309#1752738 , @friss wrote: > > > Sorry that I haven't reviewed the patch, but there's something I'd like to > > point out before anyone invests a

[Lldb-commits] [PATCH] D69309: Support template instantiation in the expression evaluator

jarin added a comment. In D69309#1752738 , @friss wrote: > Sorry that I haven't reviewed the patch, but there's something I'd like to > point out before anyone invests a lot of time into plugin holes in our > current template support code. > > It would

[Lldb-commits] [PATCH] D70517: [lldb][DataFormatters] Support pretty printing std::string when built with -funsigned-char.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Adding a basic_string formatter seems reasonable, though I have to say that I was very surprised that adding -funsinged-char should cause the type name of the variable to come out different.