[Lldb-commits] [PATCH] D71306: [RFC] Change how we deal with optional dependencies

mgorny added inline comments. Comment at: lldb/cmake/modules/LLDBConfig.cmake:497 if (LLDB_ENABLE_CURSES) -find_package(Curses REQUIRED) find_library(CURSES_PANEL_LIBRARY NAMES panel DOC "The curses panel library") if (NOT CURSES_PANEL_LIBRARY)

[Lldb-commits] [PATCH] D71234: [lldb/Lua] Implement a Simple Lua Script Interpreter Prototype

JDevlieghere added inline comments. Comment at: lldb/unittests/ScriptInterpreter/Lua/LuaTests.cpp:53 +TEST_F(ScriptInterpreterTest, ExecuteOneLine) { + DebuggerSP debugger_sp = Debugger::CreateInstance(); + ASSERT_TRUE(debugger_sp); labath wrote: > I'm not

[Lldb-commits] [PATCH] D71235: [lldb/Lua] Generate Lua Bindings and Make Them Available to the Script Interpreter

JDevlieghere updated this revision to Diff 234799. JDevlieghere added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71235/new/ https://reviews.llvm.org/D71235 Files: lldb/CMakeLists.txt lldb/scripts/CMakeLists.txt lldb/scripts/lldb_lua.swig

[Lldb-commits] [PATCH] D71234: [lldb/Lua] Implement a Simple Lua Script Interpreter Prototype

JDevlieghere updated this revision to Diff 234798. JDevlieghere marked 12 inline comments as done. JDevlieghere added a comment. - Rebase - Feedback Pavel CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71234/new/ https://reviews.llvm.org/D71234 Files:

[Lldb-commits] [PATCH] D71487: [LLDB] Fix address computation for inline function

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good, thanks for tracking this down! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71487/new/ https://reviews.llvm.org/D71487

[Lldb-commits] [PATCH] D71487: [LLDB] Fix address computation for inline function

johannes marked an inline comment as done. johannes added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2285 -if (addr.IsValid()) { +if (addr.IsSectionOffset()) { sc_list.Append(sc); clayborg wrote: >

[Lldb-commits] [PATCH] D71487: [LLDB] Fix address computation for inline function

johannes updated this revision to Diff 234795. johannes edited the summary of this revision. johannes added a comment. check if the function's section is executable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71487/new/

[Lldb-commits] [PATCH] D71235: [lldb/Lua] Generate Lua Bindings and Make Them Available to the Script Interpreter

clayborg added a comment. Very cool BTW! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71235/new/ https://reviews.llvm.org/D71235 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D71306: [RFC] Change how we deal with optional dependencies

JDevlieghere updated this revision to Diff 234789. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71306/new/ https://reviews.llvm.org/D71306 Files: lldb/cmake/modules/FindCursesAndPanel.cmake lldb/cmake/modules/LLDBConfig.cmake lldb/test/CMakeLists.txt Index:

[Lldb-commits] [PATCH] D71306: [RFC] Change how we deal with optional dependencies

JDevlieghere updated this revision to Diff 234788. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. - Extract finding curses and panel into FindCursesAndPanel - Include LZMA CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71306/new/

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

clayborg added a comment. In D70840#1783351 , @labath wrote: > I am strongly opposed to ArchSpec owing an Architecture object. The latter is > far more complicated -- it reads bytes from target memory and disassembles > them -- whereas ArchSpec just

[Lldb-commits] [PATCH] D71487: [LLDB] Fix address computation for inline function

clayborg added a comment. BTW: is used to be that both DW_AT_low_pc and DW_AT_high_pc would be set to zero when a function was dead stripped. This was back when both the low and high pc used DW_FORM_addr (a file address). But then DWARF changed such that DW_AT_high_pc could be encoded as a

[Lldb-commits] [PATCH] D71487: [LLDB] Fix address computation for inline function

clayborg added a comment. It is sad that we can't tell if a DW_AT_low_pc with a value of zero is valid or not. Some shared libraries might be able to have a function at address zero, so we need to be careful here. My proposed fix above will check the section that contains the low PC to see if

[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71372/new/ https://reviews.llvm.org/D71372

[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

jingham added a comment. This looks fine to me. We should let Greg have a final chance to weigh in and then I'll check it in. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71372/new/ https://reviews.llvm.org/D71372

[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

mossberg added a comment. I believe all the comments should be addressed at this point; thanks very much for your reviews so far. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71372/new/ https://reviews.llvm.org/D71372

[Lldb-commits] [PATCH] D71575: [LLDB] Add ObjectFileWasm plugin for WebAssembly debugging

aprantl added inline comments. Comment at: lldb/source/Plugins/ObjectFile/wasm/ObjectFileWasm.cpp:45 + +/// Reads a LEB128 variable-length unsigned integer, limited to 7 bits. +llvm::Optional GetVaruint7(DataExtractor _header_data, The LLVM coding style requests

[Lldb-commits] [PATCH] D71378: Modifying ImportDeclContext(...) to ensure that we complete each FieldDecl of a RecordDecl when we are importing the definiton

This revision was automatically updated to reflect the committed changes. Closed by commit rG6a7df3a3f940: [ASTImporter][LLDB] Modifying ImportDeclContext(...) to ensure that we complete… (authored by shafik). Herald added projects: clang, LLDB. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [lldb] 6a7df3a - [ASTImporter][LLDB] Modifying ImportDeclContext(...) to ensure that we complete each FieldDecl of a RecordDecl when we are importing the definiton

Author: shafik Date: 2019-12-19T11:16:54-08:00 New Revision: 6a7df3a3f940473088b1db1ccadafe52bb274b62 URL: https://github.com/llvm/llvm-project/commit/6a7df3a3f940473088b1db1ccadafe52bb274b62 DIFF: https://github.com/llvm/llvm-project/commit/6a7df3a3f940473088b1db1ccadafe52bb274b62.diff LOG:

[Lldb-commits] [PATCH] D71232: [lldb/Lua] Add Boilerplate for a Lua Script Interpreter

This revision was automatically updated to reflect the committed changes. Closed by commit rG67de896229c0: [lldb/Lua] Add Boilerplate for a Lua Script Interpreter (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71232/new/

[Lldb-commits] [lldb] 67de896 - [lldb/Lua] Add Boilerplate for a Lua Script Interpreter

Author: Jonas Devlieghere Date: 2019-12-19T10:13:51-08:00 New Revision: 67de896229c0f1918f50a48973b7ce0007a181a9 URL: https://github.com/llvm/llvm-project/commit/67de896229c0f1918f50a48973b7ce0007a181a9 DIFF:

[Lldb-commits] [PATCH] D71630: [lldb] Add a SubsystemRAII that takes care of calling Initialize and Terminate in the unit tests

shafik added inline comments. Comment at: lldb/unittests/TestingSupport/SubsystemRAII.h:57 +/// @endcode +template class SubsystemRAII { + /// RAII for a single subsystem. Should we write a test for this? CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D70458: [NFC] Refactor and improve comments in CommandObjectTarget

amccarth closed this revision. amccarth added a comment. This landed in 3b69f0c5550a229dd6d39e361182cdd7cecc36a4 , but there was a typo in the patch description so the tools didn't automatically close this. CHANGES SINCE

[Lldb-commits] [PATCH] D71487: [LLDB] Fix address computation for inline function

johannes updated this revision to Diff 234736. johannes added a comment. - Use `addr.IsSectionOffset()` as suggested. - Add test that links two copies of a compilation unit and makes sure that lldb only resolves it once. The fix seems to work when linking an executable, but it does not when

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

mstorsjo added a comment. @clayborg - can you follow up on @labath's reply here? And irrespectively if the ArchSpec vs Architecture design, can you (either of you) comment on the updated form of the patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70840/new/

[Lldb-commits] [PATCH] D71630: [lldb] Add a SubsystemRAII that takes care of calling Initialize and Terminate in the unit tests

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Yep, looks good. Comment at: lldb/unittests/TestingSupport/SubsystemRAII.h:59 + /// RAII for a single subsystem. + template struct SubsystemRAIICase { +

[Lldb-commits] [PATCH] D71630: [lldb] Add a SubsystemRAII that takes care of calling Initialize and Terminate in the unit tests

teemperor updated this revision to Diff 234711. teemperor added a comment. - Added SFINAE spaghetti to handle llvm::Error return types. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71630/new/ https://reviews.llvm.org/D71630 Files: lldb/unittests/Core/MangledTest.cpp

[Lldb-commits] [PATCH] D71699: [lldb] Increase the rate at which ConstString's memory allocator scales the memory chunks it allocates

teemperor created this revision. teemperor added a reviewer: llunak. Herald added subscribers: lldb-commits, JDevlieghere, abidh. Herald added a project: LLDB. teemperor added a parent revision: D71654: [llvm] Add a way to speed up the speed in which BumpPtrAllocator increases slab sizes. We

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols with the same address range but different binding

jankratochvil planned changes to this revision. jankratochvil added a comment. In D63540#1791017 , @labath wrote: > then this for example means that the "less global" symbols will not be > reported through the Symtab::ForEachSymbolContainingFileAddress

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols with the same address range but different binding

labath added a comment. Defining some sort of a preference based on symbol type seems like a good idea, but I don't think this is a good way to implement it. If I read this patch correctly, then this for example means that the "less global" symbols will not be reported through the

[Lldb-commits] [PATCH] D71306: [RFC] Change how we deal with optional dependencies

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. I like where this is going, but I think this still needs some work wrt. the panel library (and being able to customize the dependency search more). Comment at:

[Lldb-commits] [PATCH] D71234: [lldb/Lua] Implement a Simple Lua Script Interpreter Prototype

labath added a comment. This is starting to look pretty good. I think that pretty soon you'll have to come up with some way of having a more persistent lua context (instead of creating a fresh one for each command), but that doesn't have to happen now. Does the "multiline" script command do

[Lldb-commits] [lldb] 200cce3 - [lldb][NFC] Change if statements in ClangASTImporter to follow LLVM code style

Author: Raphael Isemann Date: 2019-12-19T10:55:54+01:00 New Revision: 200cce345dcf114a1b1012bc9c68adef6c99a595 URL: https://github.com/llvm/llvm-project/commit/200cce345dcf114a1b1012bc9c68adef6c99a595 DIFF:

[Lldb-commits] [PATCH] D71232: [lldb/Lua] Add Boilerplate for a Lua Script Interpreter

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Given the positive response to the RFC, I think we can start landing this stuff. Comment at: lldb/cmake/modules/LLDBConfig.cmake:28 set(default_disable_python OFF)

[Lldb-commits] [PATCH] D71630: [lldb] Add a SubsystemRAII that takes care of calling Initialize and Terminate in the unit tests

labath added a comment. We have at least one Initialize function (Socket::Initialize) which can return an llvm::Error (and it is used in some unit tests). What's your plan to handle that? Assuming we can come up with something there, I think this would be a great utility. I wouldn't be

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

jankratochvil updated this revision to Diff 234672. jankratochvil added a comment. Herald added subscribers: MaskRay, emaste. Herald added a reviewer: espindola. Changing the size of symbols turned out to be too invasive. Let's keep it intact. Rather choose the best symbols from those which have

[Lldb-commits] [PATCH] D71306: [RFC] Change how we deal with optional dependencies

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Besides missing LZMA, looks good to me. However, I suspect you may want to wait for a second opinion ;-). Comment at: lldb/cmake/modules/LLDBConfig.cmake:410