[Lldb-commits] [lldb] fb170fd - tests: XFAIL/UNSUPPORTED tests on Windows

2020-01-01 Thread Saleem Abdulrasool via lldb-commits
Author: Saleem Abdulrasool Date: 2020-01-01T14:22:49-08:00 New Revision: fb170fd652bf2fcc4c2cd54aaf384591d8df266b URL: https://github.com/llvm/llvm-project/commit/fb170fd652bf2fcc4c2cd54aaf384591d8df266b DIFF: https://github.com/llvm/llvm-project/commit/fb170fd652bf2fcc4c2cd54aaf384591d8df266b.

[Lldb-commits] [lldb] 8dbe2f0 - [lldb][NFC] Simplify CompilerType constructors/destructors and fix unused variable warning

2020-01-01 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2020-01-01T22:56:16+01:00 New Revision: 8dbe2f02c6d300e7222b5064b28c4d82a031647d URL: https://github.com/llvm/llvm-project/commit/8dbe2f02c6d300e7222b5064b28c4d82a031647d DIFF: https://github.com/llvm/llvm-project/commit/8dbe2f02c6d300e7222b5064b28c4d82a031647d.dif

[Lldb-commits] [lldb] 8dc7b98 - [NFC] Fixes -Wrange-loop-analysis warnings

2020-01-01 Thread Mark de Wever via lldb-commits
Author: Mark de Wever Date: 2020-01-01T20:01:37+01:00 New Revision: 8dc7b982b4556c243e0502e6e230bdd53ddd65ff URL: https://github.com/llvm/llvm-project/commit/8dc7b982b4556c243e0502e6e230bdd53ddd65ff DIFF: https://github.com/llvm/llvm-project/commit/8dc7b982b4556c243e0502e6e230bdd53ddd65ff.diff

[Lldb-commits] [lldb] 9b24dad - [lldb][NFC] Make some checks more readable in Variable::PrivateAutoComplete

2020-01-01 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2020-01-01T18:47:44+01:00 New Revision: 9b24dad6c06bba771b805ffd9bd047af25317e52 URL: https://github.com/llvm/llvm-project/commit/9b24dad6c06bba771b805ffd9bd047af25317e52 DIFF: https://github.com/llvm/llvm-project/commit/9b24dad6c06bba771b805ffd9bd047af25317e52.dif

[Lldb-commits] [PATCH] D71857: Fixes -Wrange-loop-analysis warnings

2020-01-01 Thread Dávid Bolvanský via Phabricator via lldb-commits
xbolva00 added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptx86ABIFixups.cpp:22 #include "lldb/Target/Process.h" #include "lldb/Utility/Log.h" NFC patch? Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D71857: Fixes -Wrange-loop-analysis warnings

2020-01-01 Thread Aaron Ballman via Phabricator via lldb-commits
aaron.ballman added a comment. It seems like some of the deductions are not spelling out the qualifiers or pointer/references explicitly in some cases, at least from my spot-checking. Can you go back through this patch to make sure we're getting those correct? Comment at: cla

[Lldb-commits] [PATCH] D71857: [NFC] Fixes -Wrange-loop-analysis warnings

2020-01-01 Thread Mark de Wever via Phabricator via lldb-commits
Mordante updated this revision to Diff 235763. Mordante retitled this revision from "Fixes -Wrange-loop-analysis warnings" to "[NFC] Fixes -Wrange-loop-analysis warnings". Mordante added a comment. Reviewed the types and added a `*` for pointers and added a `const` when applicable. CHANGES SIN

[Lldb-commits] [PATCH] D71857: [NFC] Fixes -Wrange-loop-analysis warnings

2020-01-01 Thread Mark de Wever via Phabricator via lldb-commits
Mordante marked 8 inline comments as done. Mordante added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptx86ABIFixups.cpp:22 #include "lldb/Target/Process.h" #include "lldb/Utility/Log.h" xbolva0

[Lldb-commits] [PATCH] D71857: [NFC] Fixes -Wrange-loop-analysis warnings

2020-01-01 Thread Aaron Ballman via Phabricator via lldb-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71857/new/ https://reviews.llvm.org/D71857 ___ lldb-commits

[Lldb-commits] [PATCH] D71857: [NFC] Fixes -Wrange-loop-analysis warnings

2020-01-01 Thread Mark de Wever via Phabricator via lldb-commits
Mordante marked 2 inline comments as done. Mordante added a comment. Thanks for the review! I'll commit all the -Wrange-loop-analysis patches later today. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71857/new/ https://reviews.llvm.org/D71857 ___