[Lldb-commits] [PATCH] D72489: [DWARF] Emit DW_AT_call_return_pc as an address

dblaikie added a comment. Thanks for looking into this! Could you measure the size of the object files of, for example, the clang binary before/after this change - and, if possible, on Linux (where relocations are required to fixup these addresses)? I'm concerned this might increase the size

[Lldb-commits] [PATCH] D72489: [DWARF] Emit DW_AT_call_return_pc as an address

vsk created this revision. vsk added reviewers: aprantl, labath, dblaikie. Herald added a subscriber: hiraditya. Herald added a reviewer: JDevlieghere. Herald added a project: LLVM. This reverts D53469 , which changed llvm's DWARF emission to emit

[Lldb-commits] [lldb] 0211391 - When reading Aux file in chunks, read consecutive byte ranges

Author: Jason Molenda Date: 2020-01-09T16:05:38-08:00 New Revision: 02113918ed6b5e514afd7d1e007131d36ac13f1d URL: https://github.com/llvm/llvm-project/commit/02113918ed6b5e514afd7d1e007131d36ac13f1d DIFF: https://github.com/llvm/llvm-project/commit/02113918ed6b5e514afd7d1e007131d36ac13f1d.diff

[Lldb-commits] [lldb] b81c8c6 - [lldb] Remove spurious file

Author: Jonas Devlieghere Date: 2020-01-09T15:32:09-08:00 New Revision: b81c8c6976b987a25fc54fa2bf3524919759a898 URL: https://github.com/llvm/llvm-project/commit/b81c8c6976b987a25fc54fa2bf3524919759a898 DIFF:

[Lldb-commits] [PATCH] D70238: [lldb] Allow loading of minidumps with no process id

clayborg added a comment. The pid usually comes from the MinidumpMiscInfoFlags::ProcessID right? This is a minidump supported directory entry. We don't actually rely on /proc/%d/status right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D70238: [lldb] Allow loading of minidumps with no process id

clayborg added a comment. I would prefer that we just pick a PID of 1 for minidumps if they are missing and we have minidump files that don't have PIDs. Then no other logic needs to change? Have you seen real minidumps that have memory and threads and no process ID? Repository: rG LLVM

[Lldb-commits] [lldb] 58b3dec - [lldb/Lua] Add lua typemaps for INOUT params

Author: Jonas Devlieghere Date: 2020-01-09T14:51:13-08:00 New Revision: 58b3dec6c108eb9ae4af2cde5c831743d5605c79 URL: https://github.com/llvm/llvm-project/commit/58b3dec6c108eb9ae4af2cde5c831743d5605c79 DIFF:

[Lldb-commits] [PATCH] D72413: Add missing nullptr checks.

davide added a comment. @teemperor what do you think? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72413/new/ https://reviews.llvm.org/D72413 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

ted added a comment. In D71372#1811594 , @labath wrote: > In D71372#1810687 , @ted wrote: > > > I've got another failure case for this. If the remote gdbserver doesn't > > implement qMemoryRegionInfo or

[Lldb-commits] [PATCH] D72413: Add missing nullptr checks.

davide added a comment. In D72413#1812464 , @aprantl wrote: > Should we merge this like that, or is there a better way of doing this? We should merge it like this, IMHO. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72413/new/

[Lldb-commits] [PATCH] D72437: [lldb/Bindings] Move bindings into their own subdirectory

jingham added a comment. This is a great cleanup. Thanks for doing it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72437/new/ https://reviews.llvm.org/D72437 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D72391: [lldb] Add a display name to ClangASTContext instances

shafik added a comment. In D72391#1811589 , @teemperor wrote: > @clayborg We can easily append the ptr value to the display name. All names > should always be unique as long as there is one target, but in the off-chance > that one isn't unique it might

[Lldb-commits] [PATCH] D72391: [lldb] Add a display name to ClangASTContext instances

shafik added a comment. In D72391#1809751 , @teemperor wrote: > I don't know if this needs a unit test where we call the constructor and > explicitly check the name is the one we passed in. Let me know if you think > this would make sense. I think we

[Lldb-commits] [PATCH] D72391: [lldb] Add a display name to ClangASTContext instances

shafik added a comment. Perhaps it makes sense to modify the `dump()` method to also display the new name? Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:609 + m_ast_context.reset(new ClangASTContext( + "Expression AST for '" +

[Lldb-commits] [PATCH] D72359: [lldb] Fix TestClangASTContext.TestFunctionTemplateInRecordConstruction in Debug builds

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72359/new/ https://reviews.llvm.org/D72359 ___

[Lldb-commits] [lldb] 7bbd407 - [lldb/SWIG] Undo incorrect substitution

Author: Jonas Devlieghere Date: 2020-01-09T09:55:39-08:00 New Revision: 7bbd4076c1984165568c978ff15b77dbfe52b6f0 URL: https://github.com/llvm/llvm-project/commit/7bbd4076c1984165568c978ff15b77dbfe52b6f0 DIFF:

[Lldb-commits] [PATCH] D72413: Add missing nullptr checks.

aprantl added a comment. Should we merge this like that, or is there a better way of doing this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72413/new/ https://reviews.llvm.org/D72413 ___ lldb-commits mailing list

[Lldb-commits] [lldb] 5e0bf67 - [lldb/SWIG] Fix capitalization for case sensitive file systems.

Author: Jonas Devlieghere Date: 2020-01-09T09:23:01-08:00 New Revision: 5e0bf6772e2ca450d3433fca8b47ce7bac5a6cc7 URL: https://github.com/llvm/llvm-project/commit/5e0bf6772e2ca450d3433fca8b47ce7bac5a6cc7 DIFF:

[Lldb-commits] [PATCH] D72447: [lldb] Mark several tests as not dependent on debug info

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. I believe that all of these make sense. Comment at: lldb/packages/Python/lldbsuite/test/python_api/rdar-12481949/Test-rdar-12481949.py:12 class

[Lldb-commits] [PATCH] D70846: Expression eval lookup speedup by not returning methods in ManualDWARFIndex::GetFunctions

shafik added a comment. In D70846#1809837 , @labath wrote: > This looks fine to me. @shafik, @teemperor, do you have any more comments? Just a minor comment. Comment at: lldb/test/Shell/SymbolFile/DWARF/find-basic-function.cpp:67 +

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols with the same address range but different binding

jankratochvil updated this revision to Diff 237103. jankratochvil added a comment. This patch is now on top of D72460 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63540/new/ https://reviews.llvm.org/D63540

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols with the same address range but different binding

jankratochvil added a comment. In D63540#1809725 , @labath wrote: > - make the RangeMap constructor take a `const Compare &` instead of a > template pack. The std containers do the same, and I don't see a reason to > diverge.. Done. I have mistaken it

[Lldb-commits] [PATCH] D72437: [lldb/Bindings] Move bindings into their own subdirectory

This revision was automatically updated to reflect the committed changes. Closed by commit rG6498aff249a1: [lldb/Bindings] Move bindings into their own subdirectory (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D72437?vs=236968=237102#toc Repository: rG LLVM

[Lldb-commits] [PATCH] D72460: RangeDataVector: Support custom sorting for D63540

jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: lldb/include/lldb/Utility/RangeMap.h:602 RangeData(B base, S size, DataType d) : Range(base, size), data(d) {} - - bool operator<(const RangeData ) const { -if (this->base ==

[Lldb-commits] [PATCH] D72460: RangeDataVector: Support custom sorting for D63540

jankratochvil created this revision. jankratochvil added a reviewer: labath. jankratochvil added a project: LLDB. jankratochvil marked an inline comment as done. jankratochvil added inline comments. jankratochvil added a child revision: D63540: Fix lookup of symbols with the same address range

[Lldb-commits] [lldb] 6498aff - [lldb/Bindings] Move bindings into their own subdirectory

Author: Jonas Devlieghere Date: 2020-01-09T08:44:34-08:00 New Revision: 6498aff249a1c3c6bad33137df3b90e2973722d6 URL: https://github.com/llvm/llvm-project/commit/6498aff249a1c3c6bad33137df3b90e2973722d6 DIFF:

[Lldb-commits] [PATCH] D71801: [lldb/Lua] Make lldb.debugger et al available to Lua

This revision was automatically updated to reflect the committed changes. Closed by commit rG45c971f7eef1: [lldb/Lua] Make lldb.debugger et al available to Lua (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D71801?vs=236846=237093#toc Repository: rG LLVM

[Lldb-commits] [lldb] 45c971f - [lldb/Lua] Make lldb.debugger et al available to Lua

Author: Jonas Devlieghere Date: 2020-01-09T08:15:41-08:00 New Revision: 45c971f7eef18ef2b77a5f64133dbd7bd5939d5f URL: https://github.com/llvm/llvm-project/commit/45c971f7eef18ef2b77a5f64133dbd7bd5939d5f DIFF:

[Lldb-commits] [lldb] 93a1e9c - [lldb/SWIG] Add missing '\' in macros again

Author: Jonas Devlieghere Date: 2020-01-09T08:15:41-08:00 New Revision: 93a1e9c90c96a9130352bf358df0379ebb48 URL: https://github.com/llvm/llvm-project/commit/93a1e9c90c96a9130352bf358df0379ebb48 DIFF:

[Lldb-commits] [PATCH] D71825: [lldb/Lua] Support loading Lua modules.

JDevlieghere marked an inline comment as done. JDevlieghere added a comment. In D71825#1811587 , @labath wrote: > Now back to the current patch: I see that you've dropped the part which > assigns the result of evaluating the module to a global variable

[Lldb-commits] [PATCH] D71825: [lldb/Lua] Support loading Lua modules.

JDevlieghere updated this revision to Diff 237088. JDevlieghere added a comment. - Remove unused dense map. - Set the global variable. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71825/new/ https://reviews.llvm.org/D71825 Files: lldb/source/Plugins/ScriptInterpreter/Lua/Lua.cpp

[Lldb-commits] [PATCH] D72437: [lldb/Bindings] Move bindings into their own subdirectory

JDevlieghere added a comment. In D72437#1811474 , @labath wrote: > I think this is a great idea. I'm not convinced of the need to pluralize > "interfaces" (header files are in "include", even though that folder usually > contains more than one file),

[Lldb-commits] [PATCH] D71905: [lldb][tests] Take into account all parent's categories when traverse folders upwards

tatyana-krasnukha updated this revision to Diff 237079. tatyana-krasnukha added a comment. Stop iterating when reach the top-level test folder Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71905/new/ https://reviews.llvm.org/D71905 Files:

[Lldb-commits] [PATCH] D71770: [lldb] Don't process symlinks deep inside DWARFUnit

labath requested review of this revision. labath edited reviewers, added: jingham; removed: jdoerfert. labath added a comment. Herald added a reviewer: jdoerfert. Re-requesting review, as this is essentially a different patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D71770: [lldb] Don't process symlinks deep inside DWARFUnit

labath updated this revision to Diff 237076. labath added a comment. Use a slightly different approach as the previous one didn't work on macos (the reason for that is that each .o file gets a separate module -- the patch populated the path map of the .o modules, but the remapping was being done

[Lldb-commits] [PATCH] D72447: [lldb] Mark several tests as not dependent on debug info

labath added a comment. These all seem fine to me... Comment at: lldb/packages/Python/lldbsuite/test/commands/gui/basic/TestGuiBasic.py:13 mydir = TestBase.compute_mydir(__file__) +NO_DEBUG_INFO_TESTCASE = True This shouldn't be needed as all

[Lldb-commits] [PATCH] D72086: [lldb] Fix that SBThread.GetStopDescription is returning strings with uninitialized memory at the end.

teemperor added a comment. Ah, seems like we match in the type map by function signature and GetSTDOUT matches the signature by accident CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72086/new/ https://reviews.llvm.org/D72086 ___

[Lldb-commits] [PATCH] D72447: [lldb] Mark several tests as not dependent on debug info

teemperor added a comment. Herald added a subscriber: dexonsmith. Some of the tests technically touch debug information but don't test features specific to it. If anyone thinks some of these tests are worthwhile to run with all debug information variants then let me know. Repository: rLLDB

[Lldb-commits] [PATCH] D72447: [lldb] Mark several tests as not dependent on debug info

teemperor created this revision. teemperor added reviewers: labath, jingham, aprantl, mib. Herald added a reviewer: jfb. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. This just adds `NO_DEBUG_INFO_TESTCASE` to tests that don't really exercise anything debug

[Lldb-commits] [PATCH] D72086: [lldb] Fix that SBThread.GetStopDescription is returning strings with uninitialized memory at the end.

teemperor added a comment. For reasons that are beyond my understanding this change seems to break `SBProcess.GetSTDOUT` in random tests like this: == ERROR: test_change_value_dwarf

[Lldb-commits] [lldb] 5c4661b - [lldb] Modernize OptionValue::SetValueChangedCallback

Author: Pavel Labath Date: 2020-01-09T14:17:17+01:00 New Revision: 5c4661b7784115cb330996b3a6461c5927339aef URL: https://github.com/llvm/llvm-project/commit/5c4661b7784115cb330996b3a6461c5927339aef DIFF: https://github.com/llvm/llvm-project/commit/5c4661b7784115cb330996b3a6461c5927339aef.diff

[Lldb-commits] [PATCH] D71750: [lldb/DWARF] Add is_dwo member to DWARFUnit

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG9bb01efa49ca: [lldb/DWARF] Add is_dwo member to DWARFUnit (authored by labath). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D71751: [lldb/DWARF] Fix mixed v4+v5 location lists

This revision was automatically updated to reflect the committed changes. Closed by commit rGcd5da94d80b2: [lldb/DWARF] Fix mixed v4+v5 location lists (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71751/new/

[Lldb-commits] [lldb] 9bb01ef - [lldb/DWARF] Add is_dwo member to DWARFUnit

Author: Pavel Labath Date: 2020-01-09T13:19:29+01:00 New Revision: 9bb01efa49ca7f069bc7acba7e4c9bf64d972e79 URL: https://github.com/llvm/llvm-project/commit/9bb01efa49ca7f069bc7acba7e4c9bf64d972e79 DIFF: https://github.com/llvm/llvm-project/commit/9bb01efa49ca7f069bc7acba7e4c9bf64d972e79.diff

[Lldb-commits] [lldb] cd5da94 - [lldb/DWARF] Fix mixed v4+v5 location lists

Author: Pavel Labath Date: 2020-01-09T13:19:29+01:00 New Revision: cd5da94d80b2b0f2bdb2d0157e24705a4cbd2a4e URL: https://github.com/llvm/llvm-project/commit/cd5da94d80b2b0f2bdb2d0157e24705a4cbd2a4e DIFF: https://github.com/llvm/llvm-project/commit/cd5da94d80b2b0f2bdb2d0157e24705a4cbd2a4e.diff

[Lldb-commits] [lldb] 782ad91 - [lldb] Fix that TestNoSuchArch.py was passing for the wrong reason

Author: Raphael Isemann Date: 2020-01-09T12:09:48+01:00 New Revision: 782ad91cc423bf602718e2bf9ffc59e55350463f URL: https://github.com/llvm/llvm-project/commit/782ad91cc423bf602718e2bf9ffc59e55350463f DIFF:

[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

labath added a comment. In D71372#1810687 , @ted wrote: > I've got another failure case for this. If the remote gdbserver doesn't > implement qMemoryRegionInfo or qXfer:memory-map:read, thread step-out will > fail. > That's a good point Ted. I

[Lldb-commits] [PATCH] D71825: [lldb/Lua] Support loading Lua modules.

labath added a comment. Thanks. For posterity, I'm going to summarize my thoughts from that discussion. I was arguing that "require" is not a good thing to be using here, because it's hard for it to guarantee that it will load a specific file. Now, that does not matter for "normal" uses of

[Lldb-commits] [PATCH] D72086: [lldb] Fix that SBThread.GetStopDescription is returning strings with uninitialized memory at the end.

teemperor updated this revision to Diff 236986. teemperor added a comment. - Just removed the result parameter. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72086/new/ https://reviews.llvm.org/D72086 Files: lldb/packages/Python/lldbsuite/test/python_api/thread/TestThreadAPI.py

[Lldb-commits] [PATCH] D72437: [lldb/Bindings] Move bindings into their own subdirectory

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Herald added a subscriber: dexonsmith. I think this is a great idea. I'm not convinced of the need to pluralize "interfaces" (header files are in "include", even though that folder usually

[Lldb-commits] [PATCH] D71801: [lldb/Lua] Make lldb.debugger et al available to Lua

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thanks for your patience. Looks fine to me, just remove the dead code.. Comment at: lldb/source/Plugins/ScriptInterpreter/Lua/Lua.cpp:29-38 + +llvm::Error