[Lldb-commits] [lldb] d1e3b23 - [lldb/Utility] Add std::move to make placate clang 3.8

Author: Jonas Devlieghere Date: 2020-01-13T18:25:23-08:00 New Revision: d1e3b23be46ac3ada8f5fe844629ad5bc233c24d URL: https://github.com/llvm/llvm-project/commit/d1e3b23be46ac3ada8f5fe844629ad5bc233c24d DIFF:

[Lldb-commits] [lldb] fb51ce1 - [LanguageRuntime] Retire an unused member function. NFCI.

Author: Davide Italiano Date: 2020-01-13T17:38:04-08:00 New Revision: fb51ce10d7dcab9209d0cd059d907810dbd0197d URL: https://github.com/llvm/llvm-project/commit/fb51ce10d7dcab9209d0cd059d907810dbd0197d DIFF:

[Lldb-commits] [PATCH] D72662: dotest.py: Add option to pass extra lldb settings to dotest

JDevlieghere added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/configuration.py:52 +# Any overridden settings. +settings = [] + To initialize settings to a empty dictionary this should be `{}` or `dict()`. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D72662: dotest.py: Add option to pass extra lldb settings to dotest

aprantl created this revision. aprantl added reviewers: JDevlieghere, labath. aprantl added a project: LLDB. The primary motivation for this is to add another dimension to the Swift LLDB test matrix, but this seems generally useful. https://reviews.llvm.org/D72662 Files:

[Lldb-commits] [lldb] 6d57511 - [lldb-server] Prefer target_include_directories

Author: Alex Langford Date: 2020-01-13T14:54:57-08:00 New Revision: 6d57511e0b6f95a369efe7274923a36de3489e7b URL: https://github.com/llvm/llvm-project/commit/6d57511e0b6f95a369efe7274923a36de3489e7b DIFF: https://github.com/llvm/llvm-project/commit/6d57511e0b6f95a369efe7274923a36de3489e7b.diff

[Lldb-commits] [PATCH] D72650: [LLDB] Add SymbolVendorWasm plugin for WebAssembly debugging

paolosev created this revision. paolosev added reviewers: clayborg, labath, aprantl, sbc100, teemperor. paolosev added a project: LLDB. Herald added subscribers: lldb-commits, sunfish, aheejin, jgravelle-google, mgorny. Add plugin class SymbolVendorWasm, with the logic to manage debug symbols

[Lldb-commits] [PATCH] D69820: [Symbol] Add TypeSystem::GetClassName

clayborg added a comment. if this wasn't just getting a fully qualified class name then ignore my comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69820/new/ https://reviews.llvm.org/D69820

[Lldb-commits] [PATCH] D69820: [Symbol] Add TypeSystem::GetClassName

clayborg added a comment. Or do we In D69820#1817768 , @xiaobai wrote: > In D69820#1817621 , @clayborg wrote: > > > Let me know what everyone thinks of adding a "fully_qualified" argument to > > the

[Lldb-commits] [PATCH] D72447: [lldb] Mark several tests as not dependent on debug info

teemperor added a comment. In D72447#1817559 , @stella.stamenova wrote: > This introduced a failure on the Windows LLDB bot (there were already other > failing tests though, so maybe you missed it): > >

[Lldb-commits] [PATCH] D72597: [lldb][DWARF] Added support for new forms in DWARFv5 macro.

aprantl added inline comments. Comment at: lldb/test/Shell/Commands/dwarf5-macro.test:1 +# REQUIRES: x86 +# This test checks lldb macro expansion when macro section shafik wrote: > Is there a reason why we would only want to test this feature on x86? Presumably

[Lldb-commits] [lldb] 577efd0 - [lldb] Revert ddf044290ede for TestProcessAPI.py

Author: Raphael Isemann Date: 2020-01-13T22:09:20+01:00 New Revision: 577efd09e3b7b3a1ec7fcf0597397f137da99843 URL: https://github.com/llvm/llvm-project/commit/577efd09e3b7b3a1ec7fcf0597397f137da99843 DIFF:

[Lldb-commits] [PATCH] D72597: [lldb][DWARF] Added support for new forms in DWARFv5 macro.

shafik added a reviewer: shafik. shafik added inline comments. Comment at: lldb/test/Shell/Commands/dwarf5-macro.test:1 +# REQUIRES: x86 +# This test checks lldb macro expansion when macro section Is there a reason why we would only want to test this feature on

[Lldb-commits] [PATCH] D72595: Fix lookup of symbols at the same address with no size vs. size

jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: lldb/source/Symbol/Symtab.cpp:898-900 +if (i == num_entries - 1 || +m_file_addr_to_index.GetMutableEntryAtIndex(i + 1) +->GetRangeBase() !=

[Lldb-commits] [PATCH] D69820: [Symbol] Add TypeSystem::GetClassName

xiaobai added a comment. In D69820#1817621 , @clayborg wrote: > Let me know what everyone thinks of adding a "fully_qualified" argument to > the TypeSystem::GetClassName()? I think that you would have to add more than a `fully_qualified` argument to

[Lldb-commits] [lldb] 2bb1545 - [lldb-server] Remove dead CMake code

Author: Alex Langford Date: 2020-01-13T11:41:30-08:00 New Revision: 2bb154591fab6c1d3a99d63ef03c234f0a363410 URL: https://github.com/llvm/llvm-project/commit/2bb154591fab6c1d3a99d63ef03c234f0a363410 DIFF: https://github.com/llvm/llvm-project/commit/2bb154591fab6c1d3a99d63ef03c234f0a363410.diff

[Lldb-commits] [PATCH] D71770: [lldb] Don't process symlinks deep inside DWARFUnit

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/include/lldb/Core/Module.h:972 + ModuleList::GetGlobalModuleListProperties() + .GetSymlinkMappings(); ///< Module

[Lldb-commits] [PATCH] D67793: new api class: SBFile

lawrence_danna marked an inline comment as done. lawrence_danna added inline comments. Comment at: lldb/trunk/scripts/Python/python-typemaps.swig:481 + PyBuffer_Release(); + $1 = ($1_ltype) buf; + $2 = ($2_ltype) (size/sizeof($*1_type)); labath wrote: >

[Lldb-commits] [PATCH] D69820: [Symbol] Add TypeSystem::GetClassName

clayborg added a comment. Let me know what everyone thinks of adding a "fully_qualified" argument to the TypeSystem::GetClassName()? Comment at: lldb/include/lldb/Symbol/TypeSystem.h:200-201 + virtual llvm::Optional + GetClassName(const CompilerType _type) = 0; +

[Lldb-commits] [PATCH] D72595: Fix lookup of symbols at the same address with no size vs. size

clayborg added inline comments. Comment at: lldb/source/Symbol/Symtab.cpp:898-900 +if (i == num_entries - 1 || +m_file_addr_to_index.GetMutableEntryAtIndex(i + 1) +->GetRangeBase() != curr_base_addr) { So if we have N

[Lldb-commits] [PATCH] D72447: [lldb] Mark several tests as not dependent on debug info

stella.stamenova added a comment. This introduced a failure on the Windows LLDB bot (there were already other failing tests though, so maybe you missed it): http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/12554 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D72597: [lldb][DWARF] Added support for new forms in DWARFv5 macro.

clayborg added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugMacro.cpp:62 +const DWARFDataExtractor _str_offset_data, const DWARFDataExtractor _str_data, const bool offset_is_64_bit, lldb::offset_t *offset, SymbolFileDWARF

[Lldb-commits] [PATCH] D72593: [lldb][NFC] Rewrite python_api/rdar-12481949 test

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Awesome. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72593/new/ https://reviews.llvm.org/D72593 ___

[Lldb-commits] [lldb] 9d30d76 - [lldb/Docs] Extend description section of the main page

Author: Jonas Devlieghere Date: 2020-01-13T09:32:02-08:00 New Revision: 9d30d769041b14c0ff29770d59027e679e6b7edc URL: https://github.com/llvm/llvm-project/commit/9d30d769041b14c0ff29770d59027e679e6b7edc DIFF:

[Lldb-commits] [PATCH] D72539: [lldb/Scripts] Remove SWIG bot

This revision was automatically updated to reflect the committed changes. Closed by commit rGf2bbe8ede057: [lldb/Scripts] Remove SWIG bot (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D72539?vs=237430=237713#toc Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D71761: [lldb] Add a setting to not install the main executable

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71761/new/ https://reviews.llvm.org/D71761

[Lldb-commits] [PATCH] D72624: [WIP] TargetMachine Hook for Module Metadata

lenary created this revision. lenary added reviewers: tejohnson, dblaikie, khchen, dsanders, echristo. Herald added subscribers: llvm-commits, lldb-commits, cfe-commits, liufengdb, herhut, lucyrfox, mgester, arpith-jacob, csigg, nicolasvasilache, antiagainst, shauheen, burmako, jpienaar,

[Lldb-commits] [lldb] f2bbe8e - [lldb/Scripts] Remove SWIG bot

Author: Jonas Devlieghere Date: 2020-01-13T09:23:48-08:00 New Revision: f2bbe8ede057af13b56949f24bbfb436f8a55f97 URL: https://github.com/llvm/llvm-project/commit/f2bbe8ede057af13b56949f24bbfb436f8a55f97 DIFF:

[Lldb-commits] [lldb] c1fbede - [lldb][NFC] Remove debug print statement from TestExprDiagnostics.py

Author: Raphael Isemann Date: 2020-01-13T14:17:55+01:00 New Revision: c1fbede984ec1eb87b35218d3b8161d3a6e92318 URL: https://github.com/llvm/llvm-project/commit/c1fbede984ec1eb87b35218d3b8161d3a6e92318 DIFF:

[Lldb-commits] [PATCH] D72597: [lldb][DWARF] Added support for new forms in DWARFv5 macro.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61782 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[Lldb-commits] [PATCH] D72597: [lldb][DWARF] Added support for new forms in DWARFv5 macro.

SouraVX marked an inline comment as done. SouraVX added inline comments. Comment at: lldb/test/Shell/Commands/Inputs/dwarf5-macro.s:1 + .text + .file "test.c" This file is generated via clang/llvm with macro section support. -- will upstream that

[Lldb-commits] [PATCH] D72597: [lldb][DWARF] Added support for new forms in DWARFv5 macro.

SouraVX created this revision. SouraVX added reviewers: JDevlieghere, clayborg, labath. SouraVX added a project: LLDB. Herald added subscribers: lldb-commits, aprantl. Herald added a reviewer: jdoerfert. This patch adds support for DWARFv5 new forms: DW_MACRO_define_strx, DW_MACRO_undef_strx.

[Lldb-commits] [PATCH] D72596: [lldb] Don't defend against internal LLVM errors in IRInterpreter

teemperor created this revision. teemperor added reviewers: labath, mib. Herald added subscribers: lldb-commits, JDevlieghere, abidh. Herald added a project: LLDB. teemperor edited the summary of this revision. Whenever we cast an LLVM instruction to one of its subclasses, we do a double check

[Lldb-commits] [PATCH] D72595: Fix lookup of symbols at the same address with no size vs. size

jankratochvil created this revision. jankratochvil added reviewers: labath, omjavaid. jankratochvil added a project: LLDB. Herald added a subscriber: kristof.beyls. jankratochvil planned changes to this revision. jankratochvil added a parent revision: D63540: Fix lookup of symbols with the same

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols with the same address range but different binding

This revision was automatically updated to reflect the committed changes. jankratochvil marked an inline comment as done. Closed by commit rGbf7225888a99: [lldb] Fix lookup of symbols with the same address range but different binding (authored by jankratochvil). Changed prior to commit:

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols with the same address range but different binding

jankratochvil marked 2 inline comments as done. jankratochvil added inline comments. Comment at: lldb/include/lldb/Symbol/Symtab.h:159-161 + else if (symbol.IsWeak()) +return 2; + else if (symbol.IsDebug()) labath wrote: > [[

[Lldb-commits] [lldb] bf72258 - [lldb] Fix lookup of symbols with the same address range but different binding

Author: Jan Kratochvil Date: 2020-01-13T12:05:26+01:00 New Revision: bf7225888a99f49afac0b95a8996d0a942b6b0e3 URL: https://github.com/llvm/llvm-project/commit/bf7225888a99f49afac0b95a8996d0a942b6b0e3 DIFF:

[Lldb-commits] [PATCH] D67793: new api class: SBFile

labath added inline comments. Comment at: lldb/trunk/scripts/Python/python-typemaps.swig:481 + PyBuffer_Release(); + $1 = ($1_ltype) buf; + $2 = ($2_ltype) (size/sizeof($*1_type)); vadimcn wrote: > Sorry for being late to the party, but I just stumbled upon

[Lldb-commits] [PATCH] D72593: [lldb][NFC] Rewrite python_api/rdar-12481949 test

teemperor created this revision. teemperor added reviewers: labath, aprantl. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. This renames the test `rdar-12481949` to `get-value-32bit-int` as it just tests that we return the correct result get calling

[Lldb-commits] [lldb] af4adb0 - [lldb][NFC] Use range-based for loops in IRInterpreter

Author: Raphael Isemann Date: 2020-01-13T11:58:45+01:00 New Revision: af4adb07cd18b7081ec5818aee385654c8454356 URL: https://github.com/llvm/llvm-project/commit/af4adb07cd18b7081ec5818aee385654c8454356 DIFF:

[Lldb-commits] [PATCH] D72513: Don't fail step out if remote server doesn't implement qMemoryRegionInfo

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This seems fine to me, though I do get a feeling that without the testcase, some refactor will break this sooner or later. Making a test case for this would be tricky (though not impossible)

[Lldb-commits] [PATCH] D70846: Expression eval lookup speedup by not returning methods in ManualDWARFIndex::GetFunctions

PatriosTheGreat updated this revision to Diff 237604. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70846/new/ https://reviews.llvm.org/D70846 Files: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp

[Lldb-commits] [PATCH] D70846: Expression eval lookup speedup by not returning methods in ManualDWARFIndex::GetFunctions

PatriosTheGreat added a comment. Made clang-format with last update of diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70846/new/ https://reviews.llvm.org/D70846 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols with the same address range but different binding

labath accepted this revision. labath added a comment. This looks great now. Thanks for persisting. Comment at: lldb/include/lldb/Symbol/Symtab.h:159-161 + else if (symbol.IsWeak()) +return 2; + else if (symbol.IsDebug()) [[

[Lldb-commits] [PATCH] D72086: [lldb] Fix that SBThread.GetStopDescription is returning strings with uninitialized memory at the end.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Overall, I think it would be nice to introduce some consistency into the return values of functions which fill out a user-provided buffer, but the thing which convinced me that a separate

[Lldb-commits] [PATCH] D70846: Expression eval lookup speedup by not returning methods in ManualDWARFIndex::GetFunctions

PatriosTheGreat marked an inline comment as done. PatriosTheGreat added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/find-basic-function.cpp:67 + +// FULL: Found 0 functions: shafik wrote: > You don't actually run a `FULL` test, is this

[Lldb-commits] [lldb] 96b8e1a - [lldb] Fix eh-frame-small-fde test for changes in lld

Author: Pavel Labath Date: 2020-01-13T11:17:34+01:00 New Revision: 96b8e1ac4674dd3035b6cc7b1b7ed8b946208ab1 URL: https://github.com/llvm/llvm-project/commit/96b8e1ac4674dd3035b6cc7b1b7ed8b946208ab1 DIFF: https://github.com/llvm/llvm-project/commit/96b8e1ac4674dd3035b6cc7b1b7ed8b946208ab1.diff

[Lldb-commits] [PATCH] D72447: [lldb] Mark several tests as not dependent on debug info

This revision was automatically updated to reflect the committed changes. Closed by commit rGddf044290ede: [lldb] Mark several tests as not dependent on debug info (authored by teemperor). Changed prior to commit: https://reviews.llvm.org/D72447?vs=237047=237594#toc Repository: rG LLVM

[Lldb-commits] [lldb] ddf0442 - [lldb] Mark several tests as not dependent on debug info

Author: Raphael Isemann Date: 2020-01-13T10:40:29+01:00 New Revision: ddf044290ede7d7fd47f4f673e3e628f551a8aac URL: https://github.com/llvm/llvm-project/commit/ddf044290ede7d7fd47f4f673e3e628f551a8aac DIFF:

[Lldb-commits] [PATCH] D72086: [lldb] Fix that SBThread.GetStopDescription is returning strings with uninitialized memory at the end.

teemperor added a comment. I made a new typemap now that is only for GetStopDescription and it's snprintf semantics. This keeps all the other functions working. I kept the old behavior of requiring a >0 buffer size etc. in tact for now. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D72086: [lldb] Fix that SBThread.GetStopDescription is returning strings with uninitialized memory at the end.

teemperor updated this revision to Diff 237590. teemperor added a comment. - Move to use a new typemap for GetStopDescription. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72086/new/ https://reviews.llvm.org/D72086 Files: lldb/bindings/interface/SBThread.i

[Lldb-commits] [PATCH] D72510: [lldb/Expression] Improve interpreter error message with a non-running target

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. To give this more context: The IRInterpreter can interpret function calls but only on Hexagon (see D9404 ). The reason why we essentially

[Lldb-commits] [PATCH] D72489: [DWARF] Emit DW_AT_call_return_pc as an address

djtodoro added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp:990 +assert(PCAddr && "Missing return PC information for a call"); +addLabelAddress(CallSiteDIE, dwarf::DW_AT_call_return_pc, PCAddr); } Why don't we use the

[Lldb-commits] [PATCH] D72489: [DWARF] Emit DW_AT_call_return_pc as an address

djtodoro added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp:984-991 // from one function to another. if (DD->getDwarfVersion() == 4 && DD->tuneForGDB()) { assert(PCAddr && "Missing PC information for a call");