[Lldb-commits] [lldb] 546f8f4 - [lldb/testsuite] Modernize 2 test Makefiles

Author: Fred Riss Date: 2020-01-17T20:56:28-08:00 New Revision: 546f8f426463c7c22a3a8731803a501ff044ba20 URL: https://github.com/llvm/llvm-project/commit/546f8f426463c7c22a3a8731803a501ff044ba20 DIFF: https://github.com/llvm/llvm-project/commit/546f8f426463c7c22a3a8731803a501ff044ba20.diff LOG

[Lldb-commits] [lldb] 509b788 - [lldb/Makefile.rules] Force the default target to be 'all'

Author: Fred Riss Date: 2020-01-17T20:34:16-08:00 New Revision: 509b78883d4f8fdb13ccc754bba9782d51b477d8 URL: https://github.com/llvm/llvm-project/commit/509b78883d4f8fdb13ccc754bba9782d51b477d8 DIFF: https://github.com/llvm/llvm-project/commit/509b78883d4f8fdb13ccc754bba9782d51b477d8.diff LOG

[Lldb-commits] [PATCH] D72971: [debugserver] Share code between Enable/DisableHardwareWatchpoint (NFC)

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Yep, looks good. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72971/new/ https://reviews.llvm.org/D72971

[Lldb-commits] [PATCH] D72971: [debugserver] Share code between Enable/DisableHardwareWatchpoint (NFC)

JDevlieghere created this revision. JDevlieghere added a reviewer: jasonmolenda. Herald added subscribers: lldb-commits, jfb. Herald added a project: LLDB. This extract the common functionality of enabling and disabling hardware watchpoints into a single function. Repository: rLLDB LLDB http

[Lldb-commits] [PATCH] D72946: [lldb] Remove ClangASTImporter reference from Target

xiaobai added a comment. In D72946#1827301 , @teemperor wrote: > I wish we could do this without a global map. Also the ClangASTImporter > shouldn't have a dependency on Target (I'm actually surprised this compiles > without an additional include). > > I

[Lldb-commits] [PATCH] D72963: When darwin-debug exec's inferior suspended, make debugserver know that suspend count is higher than normal

jasonmolenda created this revision. jasonmolenda added a reviewer: jingham. jasonmolenda added a project: LLDB. Herald added a subscriber: mgorny. darwin-debug is used to launch a binary while setting the current working directory/env vars/architecture, exec'ing it stopped so lldb can attach to i

[Lldb-commits] [PATCH] D72813: Fixes to lldb's eLaunchFlagLaunchInTTY feature on macOS

jasonmolenda abandoned this revision. jasonmolenda added a comment. Taking a different approach to fixing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72813/new/ https://reviews.llvm.org/D72813

Re: [Lldb-commits] [PATCH] D72953: Fix the handling of unnamed bit-fields when parsing DWARF

> On Jan 17, 2020, at 2:24 PM, Raphael Isemann via Phabricator > wrote: > > teemperor added a comment. > > (Just some quick comments, will review this properly during normal working > hours) > > Without this fix debugging Clang with LLDB is essentially impossible, so I'm > in favour of lan

[Lldb-commits] [PATCH] D72953: Fix the handling of unnamed bit-fields when parsing DWARF

teemperor added a comment. (Just some quick comments, will review this properly during normal working hours) Without this fix debugging Clang with LLDB is essentially impossible, so I'm in favour of landing this with as few pre-commit refactorings as possible to make backporting easier and get

[Lldb-commits] [lldb] a93aa53 - [lldb/Docs] Fix formatting for the variable formatting page

Author: Jonas Devlieghere Date: 2020-01-17T14:17:26-08:00 New Revision: a93aa5347641159aa0d2d48dda9e1a51b2273462 URL: https://github.com/llvm/llvm-project/commit/a93aa5347641159aa0d2d48dda9e1a51b2273462 DIFF: https://github.com/llvm/llvm-project/commit/a93aa5347641159aa0d2d48dda9e1a51b2273462.d

[Lldb-commits] [PATCH] D72920: [lldb/DWARF] Simplify DWARFDebugInfoEntry::LookupAddress

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. LGTM. Much cleaner using the newer DWARFDIE code. Not sure if we can unit test this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72920/new

[Lldb-commits] [PATCH] D72748: [lldb/IOHandler] Change the way we manage IO handler

JDevlieghere updated this revision to Diff 238886. JDevlieghere added a comment. Add PExpect test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72748/new/ https://reviews.llvm.org/D72748 Files: lldb/include/lldb/Core/Debugger.h lldb/packages/Python/lldbsuite/test/functionalities/b

[Lldb-commits] [PATCH] D72946: [lldb] Remove ClangASTImporter reference from Target

clayborg added a comment. Is an AST importer specific to a target? Can we just put it into the Clang AST type system subclass and create it lazily? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72946/new/ https://reviews.llvm.org/D72946 ___

[Lldb-commits] [PATCH] D72953: Fix the handling of unnamed bit-fields when parsing DWARF

aprantl added a comment. Very cool. I think we can improve the code quite a bit while we're here. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2427 if (attributes.ExtractFormValueAtIndex(i, form_value)) { +// AT_data_member_location in

[Lldb-commits] [PATCH] D72953: Fix the handling of unnamed bit-fields when parsing DWARF

aprantl added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lang/c/bitfields/TestBitfields.py:155 +'(int:32) = ', +'(unsigned int:20) a =', +]) Why don't we inspect the values of fields, too?

[Lldb-commits] [PATCH] D72953: Fix the handling of unnamed bit-fields when parsing DWARF

shafik created this revision. shafik added reviewers: aprantl, teemperor, jingham. We ran into an assert when debugging clang and performing an expression on a class derived from `DeclContext`. The assert was indicating we were getting the offsets wrong for `RecordDeclBitfields`. We were getting

[Lldb-commits] [lldb] 510758d - debugserver: Pass -arch flags to mig invocation as needed

Author: Vedant Kumar Date: 2020-01-17T13:11:54-08:00 New Revision: 510758dae2a8fa4b0b26dea89d4d1efd576b8ad6 URL: https://github.com/llvm/llvm-project/commit/510758dae2a8fa4b0b26dea89d4d1efd576b8ad6 DIFF: https://github.com/llvm/llvm-project/commit/510758dae2a8fa4b0b26dea89d4d1efd576b8ad6.diff

[Lldb-commits] [PATCH] D72946: [lldb] Remove ClangASTImporter reference from Target

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. I wish we could do this without a global map. Also the ClangASTImporter shouldn't have a dependency on Target (I'm actually surprised this compiles without an additional includ

[Lldb-commits] [lldb] c17aee6 - Revert "Rename DW_AT_LLVM_isysroot to DW_AT_LLVM_sysroot"

Author: Adrian Prantl Date: 2020-01-17T12:52:36-08:00 New Revision: c17aee67f1007426fb12f4081183bb8ec5dc3d15 URL: https://github.com/llvm/llvm-project/commit/c17aee67f1007426fb12f4081183bb8ec5dc3d15 DIFF: https://github.com/llvm/llvm-project/commit/c17aee67f1007426fb12f4081183bb8ec5dc3d15.diff

[Lldb-commits] [PATCH] D72823: [Reproducers] Add a tool to transparently capture and replay lldb sessions

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/tools/lldb-repro/lldb-repro.h.cmake:12 + +#cmakedefine LLDB_TEST_EXECUTABLE "${LLDB_TEST_EXECUTABLE}" + labath wrote: > JDevlieghere wrote: > > labath wrote: > > >

[Lldb-commits] [PATCH] D72946: [lldb] Remove ClangASTImporter reference from Target

xiaobai created this revision. xiaobai added reviewers: JDevlieghere, teemperor, labath, clayborg. Herald added a reviewer: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: LLDB. Target is one of the classes responsible for vending ClangASTImpor

[Lldb-commits] [PATCH] D72823: [Reproducers] Add a tool to transparently capture and replay lldb sessions

JDevlieghere updated this revision to Diff 238837. JDevlieghere marked 11 inline comments as done. JDevlieghere added a comment. - Remove environment variables CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72823/new/ https://reviews.llvm.org/D72823 Files: lldb/test/Shell/Reproducer/l

Re: [Lldb-commits] LLDB Intel hardware breakpoints patch

Somebody will have to champion this patch for it to get into lldb. It has no test case, so it’s not acceptable as is. It should also be cleaned up so that it shares more code with the watchpoint implementation in the same file (for instance duplicating all the comments and logic to set a hardw

[Lldb-commits] [PATCH] D72880: Fix a buffer-size bug when the first DW_OP_piece is undefined

aprantl marked an inline comment as done. aprantl added inline comments. Comment at: lldb/source/Expression/DWARFExpression.cpp:2077 + // with the expression result, so the debugger can print missing + // members as "" or something. ::memset(curr_piec

[Lldb-commits] [PATCH] D72917: [lldb/DWARF] Change how we construct a llvm::DWARFContext

aprantl added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFContext.cpp:130 -if (m_main_section_list) { - for (auto §ion : *m_main_section_list) -AddSection(*section); -} - -if (m_dwo_section_list) { - for (auto §ion : *m_d

[Lldb-commits] [lldb] ec9a3cc - Update testcase for LLVM IR change (sysroot)

Author: Adrian Prantl Date: 2020-01-17T11:04:55-08:00 New Revision: ec9a3cccd4019e3b371175c7ea7a227e0e737c5b URL: https://github.com/llvm/llvm-project/commit/ec9a3cccd4019e3b371175c7ea7a227e0e737c5b DIFF: https://github.com/llvm/llvm-project/commit/ec9a3cccd4019e3b371175c7ea7a227e0e737c5b.diff

[Lldb-commits] [lldb] c1bc094 - [TestQuoting] Use the fully qualified path for remote platforms.

Author: Davide Italiano Date: 2020-01-17T10:57:35-08:00 New Revision: c1bc094f361beede4e88ace8e9761391707ee30b URL: https://github.com/llvm/llvm-project/commit/c1bc094f361beede4e88ace8e9761391707ee30b DIFF: https://github.com/llvm/llvm-project/commit/c1bc094f361beede4e88ace8e9761391707ee30b.dif

[Lldb-commits] [PATCH] D72694: [lldb] Mark the implicit copy constructor as deleted when a move constructor is provided.

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/packages/Python/lldbsuite/test/commands/expression/deleting-implicit-copy-constructor/main.cpp:14 + // should have propagated to this record and Clang

[Lldb-commits] [lldb] 12e4794 - Rename DW_AT_LLVM_isysroot to DW_AT_LLVM_sysroot

Author: Adrian Prantl Date: 2020-01-17T09:36:48-08:00 New Revision: 12e479475a896f664fb721f98c2d6805185ac352 URL: https://github.com/llvm/llvm-project/commit/12e479475a896f664fb721f98c2d6805185ac352 DIFF: https://github.com/llvm/llvm-project/commit/12e479475a896f664fb721f98c2d6805185ac352.diff

[Lldb-commits] LLDB Intel hardware breakpoints patch

Hi, Jonas Devlieghere asked me to send my patch to this mailing list because of potential licensing issues. It adds hardware breakpoints support for i386 and x86_64 architectures, something that has been missing for a long time. I have written a blogpost about it at https://reverse.put.a

[Lldb-commits] [PATCH] D72684: [lldb][NFC] Rename ClangASTContext to TypeSystemClang

clayborg accepted this revision. clayborg added a comment. Looks good. Making TypeSystem's into real plugins in the future would be great too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72684/new/ https://reviews.llvm.org/D72684 ___ lld

[Lldb-commits] [PATCH] D72684: [lldb][NFC] Rename ClangASTContext to TypeSystemClang

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. It looks like everyone is on board with this... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72684/new/ https://reviews.llvm.org/D72684 ___

[Lldb-commits] [lldb] d035c83 - [lldb] Try to fix writing outside temp dir from 4bafceced6a7641be7b090229c6ccef22cf55bff

Author: Sam McCall Date: 2020-01-17T17:30:12+01:00 New Revision: d035c832c3f9d29eb1d29b6d22cd8d018a6462c6 URL: https://github.com/llvm/llvm-project/commit/d035c832c3f9d29eb1d29b6d22cd8d018a6462c6 DIFF: https://github.com/llvm/llvm-project/commit/d035c832c3f9d29eb1d29b6d22cd8d018a6462c6.diff LO

[Lldb-commits] [PATCH] D72909: Make SymbolFileDWARF::ParseLineTable use std::sort instead of insertion sort

unnar updated this revision to Diff 238771. unnar added a comment. Switched back to std::vector and uploaded the full diff. I don't have commit access so it would be appreciated if you could land this for me, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72909/new/ https://rev

[Lldb-commits] [PATCH] D72920: [lldb/DWARF] Simplify DWARFDebugInfoEntry::LookupAddress

labath created this revision. labath added reviewers: JDevlieghere, aprantl. Herald added a project: LLDB. This method was doing a lot more than it's only caller needed (DWARFDIE::LookupDeepestBlock) needed, so I inline it into the caller, and remove any code which is not actually used. This inclu

[Lldb-commits] [PATCH] D72909: Make SymbolFileDWARF::ParseLineTable use std::sort instead of insertion sort

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Yes, that's looks pretty much like it, but it seems you uploaded the diff incorrectly -- it looks like its based on the previous version of your patch and not master (you should always upload

[Lldb-commits] [PATCH] D72909: Make SymbolFileDWARF::ParseLineTable use std::sort instead of insertion sort

unnar updated this revision to Diff 238759. unnar marked an inline comment as done. unnar added a comment. Herald added a reviewer: jdoerfert. @labath Can you take another look and see if this matches what you had in mind? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72909/new/ https:

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

labath added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/wasm-DYLD/DynamicLoaderWasmDYLD.cpp:90-126 + ModuleList loaded_module_list; + const ModuleList &module_list = m_process->GetTarget().GetImages(); + const size_t num_modules = module_list.GetSize(); +

[Lldb-commits] [PATCH] D72917: [lldb/DWARF] Change how we construct a llvm::DWARFContext

labath created this revision. labath added reviewers: JDevlieghere, aprantl. Herald added a project: LLDB. The goal of this patch is two-fold. First, it fixes a use-after-free in the construction of the llvm DWARFContext. This happened because the construction code was throwing away the lldb DataE

[Lldb-commits] [PATCH] D72748: [lldb/IOHandler] Change the way we manage IO handler

labath added a comment. Not super ideal, but not too bad either. Not clicking accept yet because of the missing test case... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72748/new/ https://reviews.llvm.org/D72748 ___ lldb-commits mailing

[Lldb-commits] [lldb] 791f132 - [lldb] Remove out of order OperatingSystemPython::Terminate call in SystemInitializerFull

Author: Raphael Isemann Date: 2020-01-17T13:02:15+01:00 New Revision: 791f132132b2078cc0171e58332159cd5dafa55e URL: https://github.com/llvm/llvm-project/commit/791f132132b2078cc0171e58332159cd5dafa55e DIFF: https://github.com/llvm/llvm-project/commit/791f132132b2078cc0171e58332159cd5dafa55e.dif

[Lldb-commits] [lldb] f2d41ad - [lldb] Add missing terminate calls to Python/Lua subsystems

Author: Raphael Isemann Date: 2020-01-17T12:49:57+01:00 New Revision: f2d41ad0e7e0b6b44641eafa70ef76df6a618810 URL: https://github.com/llvm/llvm-project/commit/f2d41ad0e7e0b6b44641eafa70ef76df6a618810 DIFF: https://github.com/llvm/llvm-project/commit/f2d41ad0e7e0b6b44641eafa70ef76df6a618810.dif

[Lldb-commits] [PATCH] D72909: Make SymbolFileDWARF::ParseLineTable use std::sort instead of insertion sort

teemperor added inline comments. Comment at: lldb/source/Symbol/LineTable.cpp:172 + LineSequenceImpl *seq_b = reinterpret_cast(sequence_b); + return (*this)(seq_a->m_entries.front(), seq_b->m_entries.front()); +} Nit pick, this would also work without the `rein

[Lldb-commits] [PATCH] D72909: Make SymbolFileDWARF::ParseLineTable use std::sort instead of insertion sort

unnar added a comment. In D72909#1826110 , @labath wrote: > Thanks for the patch. I've been wondering how to improve this, and this > solution is pretty neat. > > I have just one request. Instead of the `ReplaceLineTableWithSequences` > thingy, could you

[Lldb-commits] [PATCH] D72909: Make SymbolFileDWARF::ParseLineTable use std::sort instead of insertion sort

labath added a comment. Thanks for the patch. I've been wondering how to improve this, and this solution is pretty neat. I have just one request. Instead of the `ReplaceLineTableWithSequences` thingy, could you just create a LineTable constructor, which takes an `ArrayRef` or similar. It looks

[Lldb-commits] [PATCH] D72909: Make SymbolFileDWARF::ParseLineTable use std::sort instead of insertion sort

unnar created this revision. unnar added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieghere, mgrang. Motivation: When setting breakpoints in certain projects line sequences are frequently being inserted out of order. Rather than inserting sequences one at a time into a sorted

[Lldb-commits] [lldb] c3ab790 - [lldb][NFC] Resynchronize Init/Terminate calls in SystemInitializerFull/Test.cpp files.

Author: Raphael Isemann Date: 2020-01-17T11:34:59+01:00 New Revision: c3ab790c8f5d2946c3e4e4bf78cedf6be11a6f5a URL: https://github.com/llvm/llvm-project/commit/c3ab790c8f5d2946c3e4e4bf78cedf6be11a6f5a DIFF: https://github.com/llvm/llvm-project/commit/c3ab790c8f5d2946c3e4e4bf78cedf6be11a6f5a.dif

[Lldb-commits] [PATCH] D72823: [Reproducers] Add a tool to transparently capture and replay lldb sessions

labath added inline comments. Comment at: lldb/test/Shell/helper/toolchain.py:13 + +def _lldb_init(config): +return os.path.join(config.test_exec_root, 'Shell', 'lit-lldb-init') Maybe `_get_lldb_init_path`? This way it looks like this function is doing some

[Lldb-commits] [lldb] 6b84083 - [lldb][NFC] Delete unused lldb/source/Plugins/LanguageRuntime/Go/CMakeLists.txt

Author: Raphael Isemann Date: 2020-01-17T09:57:44+01:00 New Revision: 6b840834cd508aa673a30074ebd4649100bc8d9a URL: https://github.com/llvm/llvm-project/commit/6b840834cd508aa673a30074ebd4649100bc8d9a DIFF: https://github.com/llvm/llvm-project/commit/6b840834cd508aa673a30074ebd4649100bc8d9a.dif

[Lldb-commits] [PATCH] D72880: Fix a buffer-size bug when the first DW_OP_piece is undefined

labath added inline comments. Comment at: lldb/source/Expression/DWARFExpression.cpp:2077 + // with the expression result, so the debugger can print missing + // members as "" or something. ::memset(curr_piece.GetBuffer().GetBytes(), 0, piece_byte_siz

[Lldb-commits] [PATCH] D72813: Fixes to lldb's eLaunchFlagLaunchInTTY feature on macOS

labath added a comment. In D72813#1825027 , @jasonmolenda wrote: > If we attach while darwin-debug is executing, then we get the exec mach > exception, Not really my thing, but couldn't you just ensure that you *always* attach while darwin-debu