[Lldb-commits] [PATCH] D72823: [Reproducers] Add a tool to transparently capture and replay lldb sessions

labath accepted this revision. labath added inline comments. Comment at: lldb/tools/lldb-repro/lldb-repro.h.cmake:12 + +#cmakedefine LLDB_TEST_EXECUTABLE "${LLDB_TEST_EXECUTABLE}" + JDevlieghere wrote: > labath wrote: > > JDevlieghere wrote: > > > labath wrote: >

[Lldb-commits] [PATCH] D72748: [lldb/IOHandler] Change the way we manage IO handler

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Let's give this a shot. I'm don't think this is fully right, but I also don't know how to improve that, exactly... Comment at: lldb/packages/Python/lldbsuite/test/functiona

[Lldb-commits] [PATCH] D71732: Move the sysroot attribute from DIModule to DICompileUnit

This revision was automatically updated to reflect the committed changes. Closed by commit rG7b30370e5bcf: Move the sysroot attribute from DIModule to DICompileUnit (authored by aprantl). Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. Changed prior to com

[Lldb-commits] [PATCH] D73016: [lldb/CMake] Make it possible to disable plugins at configuration time

labath added a comment. In principle, I think this is a good idea. We do have many optional components (and even more components that should be optional but aren't), that one may not need/want when building lldb for a specific use case. Also, libLLVM is configurable in a similar way. However:

[Lldb-commits] [PATCH] D73018: [lldb] Add SystemInitializerAllPlugins and delete copy-pasted Init code in SystemInitializerFull and SystemInitializerTest

teemperor created this revision. teemperor added reviewers: labath, JDevlieghere. Herald added subscribers: lldb-commits, s.egerton, abidh, simoncook, fedor.sergeev, aheejin, krytarowski, mgorny, dschuff. Herald added a project: LLDB. teemperor edited the summary of this revision. SystemInitializ

[Lldb-commits] [PATCH] D73018: [lldb] Add SystemInitializerAllPlugins and delete copy-pasted Init code in SystemInitializerFull and SystemInitializerTest

labath added a comment. This seems like a good idea, but I really don't like the AllPlugins name, when it does not, in fact, initialize all plugins. I'm not really sure what to name it because criterion is pretty complex (though reasonable). Another way to achieve something like this would be t

[Lldb-commits] [lldb] 06e73f0 - [lldb/DWARF] Change how we construct a llvm::DWARFContext

Author: Pavel Labath Date: 2020-01-20T11:45:53+01:00 New Revision: 06e73f071ae12dc83c102ddecdb939dea880e588 URL: https://github.com/llvm/llvm-project/commit/06e73f071ae12dc83c102ddecdb939dea880e588 DIFF: https://github.com/llvm/llvm-project/commit/06e73f071ae12dc83c102ddecdb939dea880e588.diff

[Lldb-commits] [PATCH] D72917: [lldb/DWARF] Change how we construct a llvm::DWARFContext

This revision was automatically updated to reflect the committed changes. Closed by commit rG06e73f071ae1: [lldb/DWARF] Change how we construct a llvm::DWARFContext (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72917/new/ https

[Lldb-commits] [PATCH] D72917: [lldb/DWARF] Change how we construct a llvm::DWARFContext

labath marked an inline comment as done. labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFContext.cpp:130 -if (m_main_section_list) { - for (auto §ion : *m_main_section_list) -AddSection(*section); -} - -if (m_dwo_sect

[Lldb-commits] [PATCH] D73024: [lldb] Complete return types of CXXMethodDecls to prevent crashing due to covariant return types

teemperor created this revision. teemperor added reviewers: lhames, shafik. Herald added subscribers: lldb-commits, JDevlieghere, abidh. Herald added a project: LLDB. Currently we crash in Clang's CodeGen when we call functions with covariant return types with this assert: Assertion failed: (D

[Lldb-commits] [PATCH] D72920: [lldb/DWARF] Simplify DWARFDebugInfoEntry::LookupAddress

labath added a comment. In D72920#1827480 , @clayborg wrote: > LGTM. Much cleaner using the newer DWARFDIE code. Not sure if we can unit > test this? "image lookup --address" is sufficiently low level to be considered a unit test. We already have test

[Lldb-commits] [lldb] b7af1bf - [lldb/DWARF] Simplify DWARFDebugInfoEntry::LookupAddress

Author: Pavel Labath Date: 2020-01-20T12:39:59+01:00 New Revision: b7af1bfa6e31a2a896e8a94a7f086914719e7d5d URL: https://github.com/llvm/llvm-project/commit/b7af1bfa6e31a2a896e8a94a7f086914719e7d5d DIFF: https://github.com/llvm/llvm-project/commit/b7af1bfa6e31a2a896e8a94a7f086914719e7d5d.diff

[Lldb-commits] [PATCH] D72920: [lldb/DWARF] Simplify DWARFDebugInfoEntry::LookupAddress

This revision was automatically updated to reflect the committed changes. Closed by commit rGb7af1bfa6e31: [lldb/DWARF] Simplify DWARFDebugInfoEntry::LookupAddress (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72920/new/ https:

[Lldb-commits] [lldb] 39f1335 - Make SymbolFileDWARF::ParseLineTable use std::sort instead of insertion sort

Author: Unnar Freyr Erlendsson Date: 2020-01-20T12:50:58+01:00 New Revision: 39f1335486eae355b2259d59549382e5cee9e38f URL: https://github.com/llvm/llvm-project/commit/39f1335486eae355b2259d59549382e5cee9e38f DIFF: https://github.com/llvm/llvm-project/commit/39f1335486eae355b2259d59549382e5cee9e

[Lldb-commits] [PATCH] D72953: Fix the handling of unnamed bit-fields when parsing DWARF

teemperor added a comment. (Jim pointed out that we land this without expect_expr to make back porting easier but somehow Phabricator didn't add his comment to the review here. `expect_expr` is not yet in the downstream Github branch but it is in the 10 release branch, so that makes sense to me

[Lldb-commits] [PATCH] D72909: Make SymbolFileDWARF::ParseLineTable use std::sort instead of insertion sort

This revision was automatically updated to reflect the committed changes. Closed by commit rG39f1335486ea: Make SymbolFileDWARF::ParseLineTable use std::sort instead of insertion sort (authored by unnar, committed by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[Lldb-commits] [lldb] 27df2d9 - [lldb] Don't process symlinks deep inside DWARFUnit

Author: Pavel Labath Date: 2020-01-20T13:05:00+01:00 New Revision: 27df2d9f556c3199601ecd1f15c1b37cd49ed9df URL: https://github.com/llvm/llvm-project/commit/27df2d9f556c3199601ecd1f15c1b37cd49ed9df DIFF: https://github.com/llvm/llvm-project/commit/27df2d9f556c3199601ecd1f15c1b37cd49ed9df.diff

[Lldb-commits] [PATCH] D71770: [lldb] Don't process symlinks deep inside DWARFUnit

labath marked 2 inline comments as done. labath added inline comments. Comment at: lldb/include/lldb/Core/Module.h:972 + ModuleList::GetGlobalModuleListProperties() + .GetSymlinkMappings(); ///< Module specific source remappings for +

[Lldb-commits] [PATCH] D71770: [lldb] Don't process symlinks deep inside DWARFUnit

This revision was automatically updated to reflect the committed changes. labath marked an inline comment as done. Closed by commit rG27df2d9f556c: [lldb] Don't process symlinks deep inside DWARFUnit (authored by labath). Changed prior to commit: https://reviews.llvm.org/D71770?vs=237076&id=239

[Lldb-commits] [lldb] 468ca49 - [lldb] Allow loading of minidumps with no process id

Author: Pavel Labath Date: 2020-01-20T13:08:58+01:00 New Revision: 468ca490c6030462066f8e731902d81bab11c356 URL: https://github.com/llvm/llvm-project/commit/468ca490c6030462066f8e731902d81bab11c356 DIFF: https://github.com/llvm/llvm-project/commit/468ca490c6030462066f8e731902d81bab11c356.diff

[Lldb-commits] [PATCH] D70238: [lldb] Allow loading of minidumps with no process id

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG468ca490c603: [lldb] Allow loading of minidumps with no process id (authored by labath). Repository: rG LLVM Github Mon

[Lldb-commits] [PATCH] D73024: [lldb] Complete return types of CXXMethodDecls to prevent crashing due to covariant return types

teemperor planned changes to this revision. teemperor added a comment. Actually that seems to be more complicated in case we get the method decl by asking the ASTImporter for a definition (which will skip this code). Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D70847: [lldb] Set executable module when adding modules to the Target

anton.kolesov added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70847/new/ https://reviews.llvm.org/D70847 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [PATCH] D72694: [lldb] Mark the implicit copy constructor as deleted when a move constructor is provided.

teemperor marked 2 inline comments as done. teemperor added a comment. Thanks for the review! Comment at: lldb/packages/Python/lldbsuite/test/commands/expression/deleting-implicit-copy-constructor/main.cpp:14 + // should have propagated to this record and Clang won't crash. +

[Lldb-commits] [PATCH] D72694: [lldb] Mark the implicit copy constructor as deleted when a move constructor is provided.

teemperor updated this revision to Diff 239084. teemperor added a comment. - Added a simple expr evaluation as an additional way to trigger the error. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72694/new/ https://reviews.llvm.org/D72694 Files: lldb/packages/Python/lldbsuite/test/

[Lldb-commits] [lldb] 22447a6 - [lldb] Mark the implicit copy constructor as deleted when a move constructor is provided.

Author: Raphael Isemann Date: 2020-01-20T14:34:07+01:00 New Revision: 22447a61d405a9e279c7dad72b342dcc6e8b1b4b URL: https://github.com/llvm/llvm-project/commit/22447a61d405a9e279c7dad72b342dcc6e8b1b4b DIFF: https://github.com/llvm/llvm-project/commit/22447a61d405a9e279c7dad72b342dcc6e8b1b4b.dif

[Lldb-commits] [PATCH] D72694: [lldb] Mark the implicit copy constructor as deleted when a move constructor is provided.

This revision was automatically updated to reflect the committed changes. Closed by commit rG22447a61d405: [lldb] Mark the implicit copy constructor as deleted when a move constructor is… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [lldb] 65bab53 - [lldb][NFC] Add test for iterator invalidation during code completion.

Author: Raphael Isemann Date: 2020-01-20T15:01:39+01:00 New Revision: 65bab53afb8be61cddae4d8a08dd3d9572de1f66 URL: https://github.com/llvm/llvm-project/commit/65bab53afb8be61cddae4d8a08dd3d9572de1f66 DIFF: https://github.com/llvm/llvm-project/commit/65bab53afb8be61cddae4d8a08dd3d9572de1f66.dif

[Lldb-commits] [PATCH] D73053: [lldb/DataFormatters] Fix the `$$deference$$` synthetic child

friss created this revision. friss added a reviewer: jingham. Herald added a project: LLDB. The ValueObject code checks for a special `$$dereference$$` synthetic child to allow formatter providers to implement a natural dereferencing behavior in `frame variable` for objects like smart pointers. T

[Lldb-commits] [PATCH] D71761: [lldb] Add a setting to not install the main executable

danielkiss updated this revision to Diff 239156. danielkiss added a comment. Patch is rebased due to conflict with the upstream changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71761/new/ https://reviews.llvm.org/D71761 Files: lldb/include/lldb/Target/Target.h lldb/packages/

[Lldb-commits] [PATCH] D72823: [Reproducers] Add a tool to transparently capture and replay lldb sessions

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/utils/lldb-repro/lldb-repro.py:24 +def help(): +print("usage: {}: /path/to/lldb capture|replay [args]".fmt(sys.argv[0])) + labath wrote: > I guess you don't ne

[Lldb-commits] [lldb] 67420f1 - [lldb/Util] Add a utility to run transparently capture and replay tests.

Author: Jonas Devlieghere Date: 2020-01-20T10:30:19-08:00 New Revision: 67420f1b0e9c673ee638f2680fa83f468019004f URL: https://github.com/llvm/llvm-project/commit/67420f1b0e9c673ee638f2680fa83f468019004f DIFF: https://github.com/llvm/llvm-project/commit/67420f1b0e9c673ee638f2680fa83f468019004f.d

[Lldb-commits] [PATCH] D72823: [Reproducers] Add a tool to transparently capture and replay lldb sessions

This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rG67420f1b0e9c: [lldb/Util] Add a utility to run transparently capture and replay tests. (authored by JDevlieghere). Changed prior to commit: https://reviews

[Lldb-commits] [lldb] a17ad35 - [lldb/Test] Check that attribute exists before comparing its value

Author: Jonas Devlieghere Date: 2020-01-20T10:48:42-08:00 New Revision: a17ad3592ff8c69c683c17fa60910ce326a451b0 URL: https://github.com/llvm/llvm-project/commit/a17ad3592ff8c69c683c17fa60910ce326a451b0 DIFF: https://github.com/llvm/llvm-project/commit/a17ad3592ff8c69c683c17fa60910ce326a451b0.d

[Lldb-commits] [lldb] 04de24e - [lldb/IOHandler] Improve synchronization between IO handlers.

Author: Jonas Devlieghere Date: 2020-01-20T11:17:55-08:00 New Revision: 04de24e690d3ff23bf63bc3901765cd8f07723f3 URL: https://github.com/llvm/llvm-project/commit/04de24e690d3ff23bf63bc3901765cd8f07723f3 DIFF: https://github.com/llvm/llvm-project/commit/04de24e690d3ff23bf63bc3901765cd8f07723f3.d

[Lldb-commits] [PATCH] D72748: [lldb/IOHandler] Change the way we manage IO handler

JDevlieghere marked an inline comment as done. JDevlieghere added a comment. In D72748#1823945 , @labath wrote: > I didn't actually try it but I am pretty sure this will deadlock with nested > lldb command files (running `command source` from a file that

[Lldb-commits] [PATCH] D72748: [lldb/IOHandler] Change the way we manage IO handler

This revision was automatically updated to reflect the committed changes. Closed by commit rG04de24e690d3: [lldb/IOHandler] Improve synchronization between IO handlers. (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D72748?vs=238886&id=239178#toc Repository: rG

[Lldb-commits] [lldb] d053b7a - [lldb/Docs] Add lldb-x86_64-fedora to the CI page

Author: Jonas Devlieghere Date: 2020-01-20T11:38:40-08:00 New Revision: d053b7a2978efe72c746fc65044a2dbba192bfe3 URL: https://github.com/llvm/llvm-project/commit/d053b7a2978efe72c746fc65044a2dbba192bfe3 DIFF: https://github.com/llvm/llvm-project/commit/d053b7a2978efe72c746fc65044a2dbba192bfe3.d

[Lldb-commits] [PATCH] D73053: [lldb/DataFormatters] Fix the `$$deference$$` synthetic child

JDevlieghere added inline comments. Comment at: lldb/docs/use/variable.rst:895 + +:: + You can enable syntax highlighting for this snippet by using `.. code-block:: python` instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[Lldb-commits] [PATCH] D73053: [lldb/DataFormatters] Fix the `$$deference$$` synthetic child

friss updated this revision to Diff 239188. friss added a comment. use python formatting in docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73053/new/ https://reviews.llvm.org/D73053 Files: lldb/docs/use/variable.rst lldb/packages/Python/l

[Lldb-commits] [PATCH] D72557: Add pretty printers for llvm::PointerIntPair and llvm::PointerUnion.

csigg updated this revision to Diff 239160. csigg added a comment. Herald added a subscriber: wuzish. Fix base. I'm so terrible at this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72557/new/ https://reviews.llvm.org/D72557 Files: debuginfo-te

[Lldb-commits] [PATCH] D72557: Add pretty printers for llvm::PointerIntPair and llvm::PointerUnion.

csigg added a comment. Hi David. Thanks a lot for you review. I did another pass to switch to factory methods that catch exceptions without spewing common errors on the GDB console. Would you mind taking another quick peek? Thanks a lot for your patience! Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D72557: Add pretty printers for llvm::PointerIntPair and llvm::PointerUnion.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62026 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[Lldb-commits] [PATCH] D72557: Add pretty printers for llvm::PointerIntPair and llvm::PointerUnion.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62026 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by runnin

[Lldb-commits] [PATCH] D73067: [lldb/CMake] Auto-generate the Initialize and Terminate calls for plugins

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/source/API/SystemInitializerFull.cpp:136 +// Some of the plugins have their own namespace. +using namespace lldb_private::breakpad; +using namespace clang; I used

[Lldb-commits] [PATCH] D73067: [lldb/CMake] Auto-generate the Initialize and Terminate calls for plugins

JDevlieghere created this revision. JDevlieghere added reviewers: labath, xiaobai, teemperor, compnerd. Herald added subscribers: s.egerton, jsji, abidh, atanasyan, simoncook, fedor.sergeev, kbarton, aheejin, krytarowski, mgorny, nemanjai, dschuff. Herald added a project: LLDB. JDevlieghere added

[Lldb-commits] [PATCH] D73016: [lldb/CMake] Make it possible to disable plugins at configuration time

JDevlieghere added a comment. - I'm aware of the linker issue when you reconfigure. I've spent quite some time investigating this and this seems related to the way libraries to link are cached by CMake. I verified that we're no longer passing the disabled library to target_link_libraries and ye

[Lldb-commits] [PATCH] D73067: [lldb/CMake] Auto-generate the Initialize and Terminate calls for plugins

compnerd added a comment. Do we need to worry about ordering of the plugins? Comment at: lldb/source/Plugins/Platform/CMakeLists.txt:9 add_subdirectory(MacOSX) -#elseif (CMAKE_SYSTEM_NAME MATCHES "Windows") +elseif (CMAKE_SYSTEM_NAME MATCHES "Windows") add_subdirectory(Wi

[Lldb-commits] [PATCH] D73067: [lldb/CMake] Auto-generate the Initialize and Terminate calls for plugins (WIP)

JDevlieghere updated this revision to Diff 239217. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73067/new/ https://reviews.llvm.org/D73067 Files: lldb/source/API/SystemInitializerFull.cpp lldb/source/Plugins/CMakeLists.txt lldb/source/Plugins/Disassembler

[Lldb-commits] [PATCH] D73067: [lldb/CMake] Auto-generate the Initialize and Terminate calls for plugins (WIP)

JDevlieghere added a comment. In D73067#1830304 , @compnerd wrote: > Do we need to worry about ordering of the plugins? Yes, it appears to matter... I'm still seeing test failures which I need to debug. I'm not sure yet if they're because of missing ini