Re: [Lldb-commits] [lldb] 6990eaf - [lldb/Test] Skip VSCode test on embedded Darwin

On 20/02/2020 02:56, Davide Italiano via lldb-commits wrote: > > >> On Feb 19, 2020, at 17:52, Frédéric Riss > > wrote: >> >> >> >>> On Feb 19, 2020, at 5:44 PM, Davide Italiano via lldb-commits >>> mailto:lldb-commits@lists.llvm.org>> wrote: >>> >>> >>> On Feb 19,

[Lldb-commits] [PATCH] D74859: [lldb] Fix version string when using LLDB_REVISION but not LLDB_REPOSITORY

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. > Aside: I'm not sure we really need all the different versions since we've > moved to the monorepo layout -- I don't think anyone is using different > llvm/clang/lldb revisions, are they?

[Lldb-commits] [PATCH] D74217: Add target.xml support for qXfer request.

omjavaid added a comment. In D74217#1882539 , @PatriosTheGreat wrote: > Hi Muhammad, > Thank you for review. > Could you or Pavel commit this to master, since I don't have commit access? Hi Patrios, There was some problem with our buildbot and it

[Lldb-commits] [lldb] 14fb317 - [lldb/Test] s/skipIfDarwinEmbedded/skipIfRemote/ in VSCode tests.

Author: Jonas Devlieghere Date: 2020-02-19T20:20:36-08:00 New Revision: 14fb31795a4bd25798bc2788dd4d4e38e3ea41c7 URL: https://github.com/llvm/llvm-project/commit/14fb31795a4bd25798bc2788dd4d4e38e3ea41c7 DIFF:

[Lldb-commits] [PATCH] D74798: [lldb-vscode] Use libOption with tablegen to parse command line options.

clayborg accepted this revision. clayborg added a comment. LTGM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74798/new/ https://reviews.llvm.org/D74798 ___ lldb-commits mailing list

Re: [Lldb-commits] [lldb] 6990eaf - [lldb/Test] Skip VSCode test on embedded Darwin

On Wed, Feb 19, 2020 at 5:57 PM Davide Italiano wrote: > > > On Feb 19, 2020, at 17:52, Frédéric Riss wrote: > > > > On Feb 19, 2020, at 5:44 PM, Davide Italiano via lldb-commits < > lldb-commits@lists.llvm.org> wrote: > > > > On Feb 19, 2020, at 17:34, Jonas Devlieghere via lldb-commits < >

Re: [Lldb-commits] [lldb] 6990eaf - [lldb/Test] Skip VSCode test on embedded Darwin

> On Feb 19, 2020, at 17:52, Frédéric Riss wrote: > > > >> On Feb 19, 2020, at 5:44 PM, Davide Italiano via lldb-commits >> wrote: >> >> >> >>> On Feb 19, 2020, at 17:34, Jonas Devlieghere via lldb-commits >>> wrote: >>> >>> >>> Author: Jonas Devlieghere >>> Date:

Re: [Lldb-commits] [lldb] 6990eaf - [lldb/Test] Skip VSCode test on embedded Darwin

> On Feb 19, 2020, at 5:44 PM, Davide Italiano via lldb-commits > wrote: > > > >> On Feb 19, 2020, at 17:34, Jonas Devlieghere via lldb-commits >> wrote: >> >> >> Author: Jonas Devlieghere >> Date: 2020-02-19T17:34:01-08:00 >> New Revision: 6990eaf1fe00e9736fbfbcae160e18c5edbcd1d4 >>

Re: [Lldb-commits] [lldb] 6990eaf - [lldb/Test] Skip VSCode test on embedded Darwin

> On Feb 19, 2020, at 17:34, Jonas Devlieghere via lldb-commits > wrote: > > > Author: Jonas Devlieghere > Date: 2020-02-19T17:34:01-08:00 > New Revision: 6990eaf1fe00e9736fbfbcae160e18c5edbcd1d4 > > URL: >

[Lldb-commits] [lldb] 6990eaf - [lldb/Test] Skip VSCode test on embedded Darwin

Author: Jonas Devlieghere Date: 2020-02-19T17:34:01-08:00 New Revision: 6990eaf1fe00e9736fbfbcae160e18c5edbcd1d4 URL: https://github.com/llvm/llvm-project/commit/6990eaf1fe00e9736fbfbcae160e18c5edbcd1d4 DIFF:

[Lldb-commits] [PATCH] D74636: [lldb-vscode] Add inheritEnvironment option

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Very close, just need to check for the "host" platform and possibly add windows support, or return an error on windows, if LLVM doesn't have a OS abstracted wrapper that allows

[Lldb-commits] [PATCH] D74657: [lldb/Plugins] Add `platform process crash-info` command

mib updated this revision to Diff 245528. mib added a comment. Update documentation. Address Jonas' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74657/new/ https://reviews.llvm.org/D74657 Files: lldb/bindings/interface/SBPlatform.i

[Lldb-commits] [PATCH] D74798: [lldb-vscode] Use libOption with tablegen to parse command line options.

ivanhernandez13 updated this revision to Diff 245523. ivanhernandez13 added a comment. - Add missing newline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74798/new/ https://reviews.llvm.org/D74798 Files:

[Lldb-commits] [PATCH] D74798: [lldb-vscode] Use libOption with tablegen to parse command line options.

JDevlieghere accepted this revision. JDevlieghere added inline comments. Comment at: lldb/test/Shell/VSCode/TestOptions.test:8 +# CHECK: --wait-for-debugger \ No newline at end of file Missing newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D74798: [lldb-vscode] Use libOption with tablegen to parse command line options.

ivanhernandez13 updated this revision to Diff 245517. ivanhernandez13 added a comment. - Update ldb-vscode options test to simply look for the expected flags when passing the --help option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74798/new/

[Lldb-commits] [PATCH] D74727: Allow customized relative PYTHONHOME

hhb updated this revision to Diff 245499. hhb added a comment. Rename LLDB_RELOCATABLE_PYTHON to LLDB_EMBED_PYTHON_HOME. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74727/new/ https://reviews.llvm.org/D74727 Files:

[Lldb-commits] [PATCH] D74859: [lldb] Fix version string when using LLDB_REVISION but not LLDB_REPOSITORY

rupprecht created this revision. rupprecht added reviewers: labath, JDevlieghere, friss. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. lldb's format string (line one) is: `lldb version $clang_version ($lldb_repo revision $lldb_revision)` When only using $lldb_revision

[Lldb-commits] [PATCH] D73125: [lldb/Plugins] Move entry points out of plugin namespace

JDevlieghere abandoned this revision. JDevlieghere added a comment. This is no longer relevant Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73125/new/ https://reviews.llvm.org/D73125 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D73119: [lldb/Initializers] Rename plugins to match their entry points

JDevlieghere abandoned this revision. JDevlieghere added a comment. This is no longer relevant. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73119/new/ https://reviews.llvm.org/D73119 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D74657: [lldb/Plugins] Add `platform process crash-info` command

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Target/Platform.h:838 + /// \return + /// A Structured Data Dictionnary containing at each entry an array for + /// each different crash information type. Or a nullptr if the process has

[Lldb-commits] [PATCH] D74657: [lldb/Plugins] Add `platform process crash-info` command

mib marked an inline comment as done. mib added a comment. In D74657#1883019 , @JDevlieghere wrote: > This looks like a great feature, I see myself using this a lot in the future. > Thanks for working on this! Appreciated it! Repository: rG LLVM

[Lldb-commits] [PATCH] D74657: [lldb/Plugins] Add `platform process crash-info` command

mib marked 10 inline comments as done. mib added inline comments. Comment at: lldb/include/lldb/Target/Platform.h:838 + /// \return + /// A Structured Data Dictionnary containing at each entry an array for + /// each different crash information type. Or a nullptr if

[Lldb-commits] [PATCH] D74798: [lldb-vscode] Use libOption with tablegen to parse command line options.

clayborg added a comment. In D74798#1883015 , @JDevlieghere wrote: > In D74798#1882994 , @ivanhernandez13 > wrote: > > > I added the test file but atm the two existing arguments > > (--wait-for-debugger and

[Lldb-commits] [PATCH] D74816: [lldb/Core] Remove more duplicate code in PluginManager (NFCI)

JDevlieghere added a comment. In D74816#1883023 , @JDevlieghere wrote: > In D74816#1882389 , @labath wrote: > > > Very nice. > > > > I'm not really sure why we need that mutex in the first place. All the > >

[Lldb-commits] [lldb] df590f5 - [lldb/Core] Remove locking in the PluginManager

Author: Jonas Devlieghere Date: 2020-02-19T10:04:05-08:00 New Revision: df590f51b62d57c19f8cae8e87c1641dc0382f55 URL: https://github.com/llvm/llvm-project/commit/df590f51b62d57c19f8cae8e87c1641dc0382f55 DIFF:

[Lldb-commits] [PATCH] D74816: [lldb/Core] Remove more duplicate code in PluginManager (NFCI)

JDevlieghere added a comment. In D74816#1882389 , @labath wrote: > Very nice. > > I'm not really sure why we need that mutex in the first place. All the plugin > registration happens when we're still single-threaded. I'd be tempted to just > delete it.

[Lldb-commits] [PATCH] D74657: [lldb/Plugins] Add `platform process crash-info` command

JDevlieghere added a comment. This looks like a great feature, I see myself using this a lot in the future. Thanks for working on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74657/new/ https://reviews.llvm.org/D74657

[Lldb-commits] [PATCH] D74657: [lldb/Plugins] Add `platform process crash-info` command

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Target/Platform.h:838 + /// \return + /// A Structured Data Dictionnary containing at each entry an array for + /// each different crash information type. Or a nullptr if the process has

[Lldb-commits] [PATCH] D74798: [lldb-vscode] Use libOption with tablegen to parse command line options.

JDevlieghere added a comment. In D74798#1882994 , @ivanhernandez13 wrote: > I added the test file but atm the two existing arguments (--wait-for-debugger > and --port) will cause lldb-vscode to hang and await some sort of action from > an external

[Lldb-commits] [PATCH] D74798: [lldb-vscode] Use libOption with tablegen to parse command line options.

ivanhernandez13 added a comment. I added the test file but atm the two existing arguments (--wait-for-debugger and --port) will cause lldb-vscode to hang and await some sort of action from an external process causing the test runner to hang. I added a single test case for handling an invalid

[Lldb-commits] [PATCH] D74798: [lldb-vscode] Use libOption with tablegen to parse command line options.

ivanhernandez13 updated this revision to Diff 245442. ivanhernandez13 marked 2 inline comments as done. ivanhernandez13 added a comment. - Rename opts to options to be consistent with the lldb driver and add a test case around setting an invalid port. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D74839: [lldb] Remove license headers from all test source files

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Perfect, we already agreed upon this in the past, thanks for making things consistent! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74839/new/

[Lldb-commits] [PATCH] D74657: [lldb/Plugins] Add `platform process crash-info` command

mib updated this revision to Diff 245424. mib retitled this revision from "[lldb/Target] Add process crash-info command" to "[lldb/Plugins] Add `platform process crash-info` command". mib edited the summary of this revision. mib added a comment. Moved implementation from Process to Platform /

[Lldb-commits] [lldb] bb61021 - [lldb][NFC] Remove giant do{...}while(false); in ClangASTSource::FindExternalVisibleDecls

Author: Raphael Isemann Date: 2020-02-19T17:35:07+01:00 New Revision: bb61021a8fcc21676af65e4cbbf4d495831fad52 URL: https://github.com/llvm/llvm-project/commit/bb61021a8fcc21676af65e4cbbf4d495831fad52 DIFF:

[Lldb-commits] [PATCH] D74836: [lldb/test] Move `platform process list` tests to its own directory (NFC)

mib created this revision. mib added a reviewer: teemperor. mib added a project: LLDB. Herald added a subscriber: lldb-commits. mib edited the summary of this revision. Since the `platform process` commamnd has more tests now, this commits separates each of the `platform process` subcommand's

[Lldb-commits] [PATCH] D74217: Add target.xml support for qXfer request.

PatriosTheGreat added a comment. Hi Muhammad, Thank you for review. Could you or Pavel commit this to master, since I don't have commit access? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74217/new/ https://reviews.llvm.org/D74217 ___

[Lldb-commits] [lldb] 53eece0 - [lldb][NFC] Modernize test setup code in several lang/cpp tests

Author: Raphael Isemann Date: 2020-02-19T15:07:26+01:00 New Revision: 53eece04bd15d9235b104e545d01184347e5f703 URL: https://github.com/llvm/llvm-project/commit/53eece04bd15d9235b104e545d01184347e5f703 DIFF:

[Lldb-commits] [lldb] 1b2deb9 - [lldb] Remove Windows X-fail for TestCPPAuto and TestStepTarget

Author: Raphael Isemann Date: 2020-02-19T15:05:36+01:00 New Revision: 1b2deb9ae00f6fa1e47ec7059d777fb36a1df1d1 URL: https://github.com/llvm/llvm-project/commit/1b2deb9ae00f6fa1e47ec7059d777fb36a1df1d1 DIFF:

[Lldb-commits] [lldb] 3d7b591 - [lldb][NFC] Pointer to reference conversion for CompilerDeclContext params in ClangExpressionDeclMap.

Author: Raphael Isemann Date: 2020-02-19T14:45:23+01:00 New Revision: 3d7b591dca83595ebcca04f94260f1f4901b8956 URL: https://github.com/llvm/llvm-project/commit/3d7b591dca83595ebcca04f94260f1f4901b8956 DIFF:

[Lldb-commits] [PATCH] D74727: Allow customized relative PYTHONHOME

labath added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:298 +llvm::sys::path::append(path, lldb_python_home); +llvm::sys::path::remove_dots(path, /* remove_dot_dots = */ true); +

[Lldb-commits] [lldb] 8131cb6 - [lldb/DWARF] Add support for location lists in package files

Author: Pavel Labath Date: 2020-02-19T14:33:58+01:00 New Revision: 8131cb6e18931e4cb642a1dfaa7c219c38656442 URL: https://github.com/llvm/llvm-project/commit/8131cb6e18931e4cb642a1dfaa7c219c38656442 DIFF: https://github.com/llvm/llvm-project/commit/8131cb6e18931e4cb642a1dfaa7c219c38656442.diff

[Lldb-commits] [PATCH] D74217: Add target.xml support for qXfer request.

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. I have tested this not sure why it actually failed on the buildbot. The test seems to pass independently. Lets see if the new version fixes the issue. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D74727: Allow customized relative PYTHONHOME

labath added a comment. In D74727#1881962 , @JDevlieghere wrote: > In D74727#1881055 , @hhb wrote: > > > > Can we maybe rename it to something like that? > > > > LLDB_RELOCATABLE_PYTHON is misleading. I'd be happy

[Lldb-commits] [lldb] 10df88d - [lldb] Remove some unnecessary includes from test sources

Author: Raphael Isemann Date: 2020-02-19T14:12:45+01:00 New Revision: 10df88de21772ff40818bec7eef6b099ba4279fb URL: https://github.com/llvm/llvm-project/commit/10df88de21772ff40818bec7eef6b099ba4279fb DIFF:

[Lldb-commits] [PATCH] D74759: Treat RangeDataVector as an augmented BST

labath added a comment. In D74759#1880559 , @jarin wrote: > In D74759#1880499 , @labath wrote: > > > I like this idea a lot, in principle. It is much simpler than a full blown > > interval tree, and it should give

[Lldb-commits] [PATCH] D74816: [lldb/Core] Remove more duplicate code in PluginManager (NFCI)

labath added a comment. Very nice. I'm not really sure why we need that mutex in the first place. All the plugin registration happens when we're still single-threaded. I'd be tempted to just delete it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 4a9011d - [lldb] Skip failing parts of TestCppConstructors that use 'new' on Windows

Author: Raphael Isemann Date: 2020-02-19T13:21:51+01:00 New Revision: 4a9011dcdade7cd562e0488d387ccbbaf2eee6c8 URL: https://github.com/llvm/llvm-project/commit/4a9011dcdade7cd562e0488d387ccbbaf2eee6c8 DIFF:

[Lldb-commits] [lldb] b0060c3 - [lldb] Make comparing RegisterInfo::[alt_]name's pointer value less footy-shooty

Author: Raphael Isemann Date: 2020-02-19T13:19:41+01:00 New Revision: b0060c3a7868ef026d95d0cf8a076791ef74f474 URL: https://github.com/llvm/llvm-project/commit/b0060c3a7868ef026d95d0cf8a076791ef74f474 DIFF:

[Lldb-commits] [lldb] faff707 - Reland "[DebugInfo] Enable the debug entry values feature by default"

Author: Djordje Todorovic Date: 2020-02-19T11:12:26+01:00 New Revision: faff707db82d7db12fcd9f7826b8741261230e63 URL: https://github.com/llvm/llvm-project/commit/faff707db82d7db12fcd9f7826b8741261230e63 DIFF:

[Lldb-commits] [lldb] a3093bf - [lldb] Let TestCppConstructors pass without fix-it intervention

Author: Raphael Isemann Date: 2020-02-19T11:02:10+01:00 New Revision: a3093bfb3e7c4972e7ff7af1cc38452ec9984e13 URL: https://github.com/llvm/llvm-project/commit/a3093bfb3e7c4972e7ff7af1cc38452ec9984e13 DIFF:

[Lldb-commits] [lldb] 3ed0ce4 - [lldb] Put Host/common headers in a module

Author: Raphael Isemann Date: 2020-02-19T10:47:46+01:00 New Revision: 3ed0ce458c3a51b866625ec70e50b0f8556e0d20 URL: https://github.com/llvm/llvm-project/commit/3ed0ce458c3a51b866625ec70e50b0f8556e0d20 DIFF:

[Lldb-commits] [PATCH] D74759: Treat RangeDataVector as an augmented BST

teemperor added a comment. If we get away with this approach them I'm completely fine with it. But I would feel better if we first have some more unit tests for RangeDataVector first. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74759/new/

[Lldb-commits] [PATCH] D74478: [lldb] Let TypeSystemClang::GetDisplayTypeName remove anonymous and inline namespaces.

This revision was automatically updated to reflect the committed changes. Closed by commit rG785df616807f: [lldb] Let TypeSystemClang::GetDisplayTypeName remove anonymous and inline… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

dstenb added a comment. In D73534#1881353 , @nickdesaulniers wrote: > As a heads up, Linaro's ToolChain Working Group's Linux kernel CI lit up on > this change. I see it's been reverted (thank you). Please cc me on the > updated patch and I can help

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. In D73534#1882118 , @dstenb wrote: > In D73534#1881353 , @nickdesaulniers > wrote: > > > As a heads up, Linaro's ToolChain Working Group's Linux kernel CI lit up on > > this change. I

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

dstenb added a comment. In D73534#1882127 , @djtodoro wrote: > @dstenb No problem, we have already addressed the issue. Thanks to @vsk and > @nickdesaulniers! I'll update the patch. Great, thanks! CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro updated this revision to Diff 245345. djtodoro added a comment. - Address the issue with ARM `describeLoadedValue()` (thanks to @vsk, I've reduced the test `llvm/test/DebugInfo/MIR/ARM/dbgcallsite-noreg-is-imm-check.mir`) CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

nickdesaulniers added a comment. As a heads up, Linaro's ToolChain Working Group's Linux kernel CI lit up on this change. I see it's been reverted (thank you). Please cc me on the updated patch and I can help test it against the Linux kernel. Edit: Link:

[Lldb-commits] [lldb] 785df61 - [lldb] Let TypeSystemClang::GetDisplayTypeName remove anonymous and inline namespaces.

Author: Raphael Isemann Date: 2020-02-19T10:30:11+01:00 New Revision: 785df616807fde4f13738f2fafd978de8202fb12 URL: https://github.com/llvm/llvm-project/commit/785df616807fde4f13738f2fafd978de8202fb12 DIFF:

[Lldb-commits] [lldb] b4608ef - [lldb][NFC] Add a missing test case to TestCppConstructors.py

Author: Raphael Isemann Date: 2020-02-19T10:24:59+01:00 New Revision: b4608efc0b7d0317030ba13daf4833751c5cba64 URL: https://github.com/llvm/llvm-project/commit/b4608efc0b7d0317030ba13daf4833751c5cba64 DIFF:

[Lldb-commits] [lldb] 2bab173 - [lldb] Make TestFormatters.py not rely on working constructor calls

Author: Raphael Isemann Date: 2020-02-19T10:21:36+01:00 New Revision: 2bab1738f39606324f7bd4c71de1354288c63285 URL: https://github.com/llvm/llvm-project/commit/2bab1738f39606324f7bd4c71de1354288c63285 DIFF:

[Lldb-commits] [PATCH] D74816: [lldb/Core] Remove more duplicate code in PluginManager (NFCI)

This revision was automatically updated to reflect the committed changes. Closed by commit rG80b2e3cc5312: [lldb/Core] Remove more duplicate code in PluginManager (NFCI) (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION