[Lldb-commits] [PATCH] D75031: [lldb] Fix that a crashing test is marked as unsupported when it prints UNSUPPORTED before crashing

This revision was automatically updated to reflect the committed changes. Closed by commit rG55d4b0d7dd70: [lldb] Fix that a crashing test is marked as unsupported when it prints… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 55d4b0d - [lldb] Fix that a crashing test is marked as unsupported when it prints UNSUPPORTED before crashing

Author: Raphael Isemann Date: 2020-02-25T08:46:37+01:00 New Revision: 55d4b0d7dd70d5ecc9e641d93fbf234bb7104d1a URL: https://github.com/llvm/llvm-project/commit/55d4b0d7dd70d5ecc9e641d93fbf234bb7104d1a DIFF:

[Lldb-commits] [lldb] c08a1c7 - [lldb] Mark ObjectFileBreakpad test inputs as non-text

Author: Pavel Labath Date: 2020-02-25T08:29:41+01:00 New Revision: c08a1c7071c43b7bd0384e71c486ad5e5546b08f URL: https://github.com/llvm/llvm-project/commit/c08a1c7071c43b7bd0384e71c486ad5e5546b08f DIFF: https://github.com/llvm/llvm-project/commit/c08a1c7071c43b7bd0384e71c486ad5e5546b08f.diff

[Lldb-commits] [lldb] 35a0614 - [lldb/Utility] Fix unspecified behavior.

Author: Jonas Devlieghere Date: 2020-02-24T21:25:55-08:00 New Revision: 35a061453579f623aca1edc7f6f23dd969c21395 URL: https://github.com/llvm/llvm-project/commit/35a061453579f623aca1edc7f6f23dd969c21395 DIFF:

[Lldb-commits] [lldb] 4fdd2ed - Revert "Unwind past an interrupt handler correctly on arm or at pc==0"

Author: Jason Molenda Date: 2020-02-24T19:03:22-08:00 New Revision: 4fdd2edbdb4bfe6a95df0fac12e8beffcbe33b86 URL: https://github.com/llvm/llvm-project/commit/4fdd2edbdb4bfe6a95df0fac12e8beffcbe33b86 DIFF: https://github.com/llvm/llvm-project/commit/4fdd2edbdb4bfe6a95df0fac12e8beffcbe33b86.diff

[Lldb-commits] [lldb] d5a4fa0 - Revert "My prevous commit to RegisterContextLLDB is causing a test fail"

Author: Jason Molenda Date: 2020-02-24T19:03:22-08:00 New Revision: d5a4fa05146fe290735e2a38adb50d76052c4313 URL: https://github.com/llvm/llvm-project/commit/d5a4fa05146fe290735e2a38adb50d76052c4313 DIFF: https://github.com/llvm/llvm-project/commit/d5a4fa05146fe290735e2a38adb50d76052c4313.diff

[Lldb-commits] [PATCH] D74996: [arcconfig] Delete subproject arcconfigs

This revision was automatically updated to reflect the committed changes. Closed by commit rGe34ddc09f464: [arcconfig] Delete subproject arcconfigs (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74996/new/

[Lldb-commits] [lldb] 082f1a3 - My prevous commit to RegisterContextLLDB is causing a test fail

Author: Jason Molenda Date: 2020-02-24T17:19:06-08:00 New Revision: 082f1a3b15999c803265fabcb555ad253a00d477 URL: https://github.com/llvm/llvm-project/commit/082f1a3b15999c803265fabcb555ad253a00d477 DIFF: https://github.com/llvm/llvm-project/commit/082f1a3b15999c803265fabcb555ad253a00d477.diff

Re: [Lldb-commits] [lldb] de8793b - [lldb/DWARF] Add support for type units in dwp files

I don't think it's this particular change that caused it, but every so often this test fails for me locally. Command Output (stderr): -- /Users/jonas/llvm/llvm-project/lldb/test/Shell/SymbolFile/DWARF/dwp-debug-types.s:24:17: error: SYMBOLS-NEXT: is not on the line after the previous match #

[Lldb-commits] [PATCH] D75007: When unwinding out of a trap handler, fetch the saved pc even if there's a return address register defined

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGedc4f4c9c9d9: Unwind past an interrupt handler correctly on arm or at pc==0 (authored by jasonmolenda). Changed prior to

[Lldb-commits] [lldb] edc4f4c - Unwind past an interrupt handler correctly on arm or at pc==0

Author: Jason Molenda Date: 2020-02-24T16:11:15-08:00 New Revision: edc4f4c9c9d90b2a4f8831ba4c873f08eaa5395a URL: https://github.com/llvm/llvm-project/commit/edc4f4c9c9d90b2a4f8831ba4c873f08eaa5395a DIFF: https://github.com/llvm/llvm-project/commit/edc4f4c9c9d90b2a4f8831ba4c873f08eaa5395a.diff

[Lldb-commits] [PATCH] D75070: [lldb] Color the line marker

This revision was automatically updated to reflect the committed changes. Closed by commit rG841be9854c49: [lldb] Color the line marker (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D75070?vs=246308=246327#toc Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D75070: [lldb] Color the line marker

JDevlieghere added a comment. In D75070#1890334 , @clayborg wrote: > Ok, we can think about the PC marker later if it wouldn't just work in this > setting. Yeah, if we change either we should have them both behave the same way CHANGES SINCE LAST

[Lldb-commits] [lldb] 841be98 - [lldb] Color the line marker

Author: Jonas Devlieghere Date: 2020-02-24T15:40:31-08:00 New Revision: 841be9854c496adb1944fbf33af055814366ec86 URL: https://github.com/llvm/llvm-project/commit/841be9854c496adb1944fbf33af055814366ec86 DIFF:

[Lldb-commits] [PATCH] D75070: [lldb] Color the line marker

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Ok, we can think about the PC marker later if it wouldn't just work in this setting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75070/new/ https://reviews.llvm.org/D75070

[Lldb-commits] [PATCH] D75070: [lldb] Color the line marker

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/source/Core/Debugger.cpp:443 + const uint32_t idx = ePropertyStopShowLineMarkerAnsiPrefix; + return m_collection_sp->GetPropertyAtIndexAsString(nullptr, idx, ""); +}

[Lldb-commits] [PATCH] D75049: [lldb/Plugins] Move SBTarget::GetExtendedCrashInformation to SBProcess

This revision was automatically updated to reflect the committed changes. mib marked 2 inline comments as done. Closed by commit rGeefda18227a2: [lldb/Plugins] Move SBTarget::GetExtendedCrashInformation to SBProcess (authored by mib). Changed prior to commit:

[Lldb-commits] [PATCH] D75070: [lldb] Color the line marker

JDevlieghere updated this revision to Diff 246308. JDevlieghere added a comment. Explicitly check the suffix CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75070/new/ https://reviews.llvm.org/D75070 Files: lldb/include/lldb/Core/Debugger.h lldb/source/Core/CoreProperties.td

[Lldb-commits] [PATCH] D75073: [lldb] Color the current PC marker

clayborg added a comment. In D75070 I commented that we might want to allow users to change the ${current-pc-arrow} as a string. It is hard coded to "->", though with all the terminal codes, it might be nice to let this be a setting. Repository: rG LLVM

[Lldb-commits] [lldb] eefda18 - [lldb/Plugins] Move SBTarget::GetExtendedCrashInformation to SBProcess

Author: Med Ismail Bennani Date: 2020-02-24T23:37:04+01:00 New Revision: eefda18227a2faeacbd5420cb482fa8b5836283b URL: https://github.com/llvm/llvm-project/commit/eefda18227a2faeacbd5420cb482fa8b5836283b DIFF:

[Lldb-commits] [PATCH] D75070: [lldb] Color the line marker

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. If we are going to use this to to ansi stuff we should ensure the suffix works too. The current testing example will turn the line green along with all lines that follow if all

[Lldb-commits] [PATCH] D75070: [lldb] Color the line marker

clayborg added inline comments. Comment at: lldb/source/Core/Debugger.cpp:443 + const uint32_t idx = ePropertyStopShowLineMarkerAnsiPrefix; + return m_collection_sp->GetPropertyAtIndexAsString(nullptr, idx, ""); +} do we have a setting to control how the

[Lldb-commits] [lldb] 7f9f027 - [lldb/Test] Update TestDisassemblyFormat for new format

Author: Jonas Devlieghere Date: 2020-02-24T14:08:16-08:00 New Revision: 7f9f027c62623bff79730cd30d1a8a534e2ddb06 URL: https://github.com/llvm/llvm-project/commit/7f9f027c62623bff79730cd30d1a8a534e2ddb06 DIFF:

[Lldb-commits] [PATCH] D75073: [lldb] Color the current PC marker

This revision was automatically updated to reflect the committed changes. Closed by commit rGc4093db3dac4: [lldb] Color the current PC marker (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75073/new/

[Lldb-commits] [lldb] c4093db - [lldb] Color the current PC marker

Author: Jonas Devlieghere Date: 2020-02-24T12:51:01-08:00 New Revision: c4093db3dac4ef09fb175f4aa79c8a422da70771 URL: https://github.com/llvm/llvm-project/commit/c4093db3dac4ef09fb175f4aa79c8a422da70771 DIFF:

[Lldb-commits] [PATCH] D75073: [lldb] Color the current PC marker

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. This is the best patch I have seen since I started working on LLVM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75073/new/

[Lldb-commits] [PATCH] D75073: [lldb] Color the current PC marker

JDevlieghere created this revision. JDevlieghere added reviewers: teemperor, clayborg. Herald added a project: LLDB. teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. This is the best patch I have seen since I started working on LLVM

[Lldb-commits] [lldb] 77a2744 - [lldb/Debugger] Remove macros formerly used by property definitions

Author: Jonas Devlieghere Date: 2020-02-24T12:48:31-08:00 New Revision: 77a2744fa50b80c73d68356af010a002cc2a3d7f URL: https://github.com/llvm/llvm-project/commit/77a2744fa50b80c73d68356af010a002cc2a3d7f DIFF:

[Lldb-commits] [PATCH] D75070: [lldb] Color the line marker

JDevlieghere updated this revision to Diff 246271. JDevlieghere added a comment. Simplify `should_show_stop_line_with_ansi` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75070/new/ https://reviews.llvm.org/D75070 Files: lldb/include/lldb/Core/Debugger.h

[Lldb-commits] [PATCH] D75070: [lldb] Color the line marker

JDevlieghere created this revision. JDevlieghere added reviewers: teemperor, clayborg. Herald added a subscriber: abidh. Herald added a project: LLDB. JDevlieghere updated this revision to Diff 246271. JDevlieghere added a comment. Simplify `should_show_stop_line_with_ansi` Highlight the color

[Lldb-commits] [PATCH] D75004: Fix a race between lldb's packet timeout and killing the profile thread

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Jim Ingham said in email: > I don’t understand your suggestion. The point of this change was to get the > profile loop to exit without waiting the full sleep time. That time is >

[Lldb-commits] [PATCH] D74598: [lldb/gdb-remote] Add support for the qOffsets packet

clayborg added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h:429 + /// Use qOffsets to query the offset used when relocating the target + /// executable. Currently, we only support relocating all sections by the same +

[Lldb-commits] [PATCH] D75031: [lldb] Fix that a crashing test is marked as unsupported when it prints UNSUPPORTED before crashing

JDevlieghere added a comment. I don't remember why this was written this way, maybe there was a good reason for it but probably it was just a mistake. Let's see what happens when we land this :-) Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75031/new/

Re: [Lldb-commits] [PATCH] D75004: Fix a race between lldb's packet timeout and killing the profile thread

I don’t understand your suggestion. The point of this change was to get the profile loop to exit without waiting the full sleep time. That time is generally pretty long (1 second or thereabouts) and so if you have the main debugserver thread wait on the profile thread’s timeout before

[Lldb-commits] [PATCH] D74964: [lldb/DWARF] Don't index dwp file multiple times

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.h:66 /// Non-null value means we haven't built the index yet. + SymbolFileDWARF *m_dwarf; labath wrote: > JDevlieghere wrote: > > This seems inverted? >

[Lldb-commits] [PATCH] D75031: [lldb] Fix that a crashing test is marked as unsupported when it prints UNSUPPORTED before crashing

aprantl added a comment. Nice. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75031/new/ https://reviews.llvm.org/D75031 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] c9c09ef - [lldb/DWARF] Fix dwp search path in the separate-debug-file case

Author: Pavel Labath Date: 2020-02-24T17:01:15+01:00 New Revision: c9c09ef836b49dba0a6fc784f322a96a86a9b985 URL: https://github.com/llvm/llvm-project/commit/c9c09ef836b49dba0a6fc784f322a96a86a9b985 DIFF: https://github.com/llvm/llvm-project/commit/c9c09ef836b49dba0a6fc784f322a96a86a9b985.diff

[Lldb-commits] [PATCH] D75049: [lldb/Plugins] Move SBTarget::GetExtendedCrashInformation to SBProcess

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This is great now, thanks for bearing with me. Comment at: lldb/bindings/interface/SBProcess.i:350 +%feature("autodoc", " +Returns the platform's process extended

[Lldb-commits] [PATCH] D74657: [lldb/Plugins] Add ability to fetch crash information on crashed processes

mib marked 3 inline comments as done. mib added a comment. Addressed Pavel's request in D75049 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74657/new/ https://reviews.llvm.org/D74657

[Lldb-commits] [PATCH] D75049: [lldb/Plugins] Move SBTarget::GetExtendedCrashInformation to SBProcess

mib created this revision. mib added a reviewer: labath. mib added a project: LLDB. Herald added a subscriber: lldb-commits. This patch moves the SB API method GetExtendedCrashInformation from SBTarget to SBProcess since it only makes sense to call this method on a sane process which might not be

[Lldb-commits] [PATCH] D74598: [lldb/gdb-remote] Add support for the qOffsets packet

labath added a comment. Thanks for the quick response, and sorry it took me a while to get back to this. In D74598#1877316 , @clayborg wrote: > While Module::SetLoadAddress doesn't, the Target interfaces do in fact > support this fully. You specify the

[Lldb-commits] [PATCH] D74598: [lldb/gdb-remote] Add support for the qOffsets packet

labath updated this revision to Diff 246196. labath marked 4 inline comments as done. labath added a comment. Add some comments and documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74598/new/ https://reviews.llvm.org/D74598 Files:

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

labath added a comment. Yes, I believe this matches the behavior we were talking about. I could make a bunch of comments on the implementation and the test, but I'm not sure if we're at that stage yet... Comment at: lldb/source/Core/SearchFilter.cpp:712 + // the list of

[Lldb-commits] [PATCH] D74255: [LLDB] Add support for AVR breakpoints

dylanmckay added a comment. > However, if we look at this locally, if the AVR architecture has a trap > opcode (maybe to implement __builtin_debugbreak() -- I am assuming that's > what 0x98 0x95 is), then I don't see a problem with this function returning > it. Chiming in from an AVR

[Lldb-commits] [PATCH] D74650: [lldb] WIP: idea for keeping filenames in raw form when coming from DWARF

kwk abandoned this revision. kwk added a comment. I abandon this revision because @labath mentioned that in the past we must have had something similar: two file specs where one was normalized and one doesn't and then the behavior was not very predictable. I hope this recaptures our

[Lldb-commits] [PATCH] D74954: Add a basic tiling pass for parallel loops

bkramer updated this revision to Diff 246166. bkramer marked 4 inline comments as done. bkramer added a comment. Herald added subscribers: libc-commits, libcxx-commits, lldb-commits, Sanitizers, cfe-commits, bader, kerbowa, csigg, usaxena95, jdoerfert, ormris, jsji, kadircet, rupprecht, jfb,

[Lldb-commits] [PATCH] D73969: [LLDB] Let DataExtractor deal with two-byte addresses

dylanmckay added a comment. This looks good to me from an AVR point of view. I don't have very much experience with LLDB however. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73969/new/ https://reviews.llvm.org/D73969

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk added a comment. I figured it might be the easiest to re-use `SearchFilterByModuleListAndCU` but it needs to be renamed still. If you have a good suggestion, please let me know. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk added a comment. @labath @jingham Can you please have a look at the `lldb/test/Shell/Breakpoint/search-support-files.test` to see if the test reflects the desired behavior? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Optionally follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 246162. kwk added a comment. - Clear formatting - Make list private again - Remove open from CommandObjectBreakpoint.cpp - Remove change in unrelated file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Optionally follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 246160. kwk added a comment. Updated tests and code to remove the --search-source-files flag and make it the default behavior to also search source files. TODO: rename class SearchFilterByModuleListAndCU to something more meaningful when an agreement on the

[Lldb-commits] [PATCH] D74657: [lldb/Plugins] Add ability to fetch crash information on crashed processes

labath added a comment. A couple of more comments from me. The two on the test are minor, but I think it would be good to resolve the one about the SB method placement soon, before this thing starts having users. Comment at: lldb/bindings/interface/SBTarget.i:952-957 +

[Lldb-commits] [PATCH] D75031: [lldb] Fix that a crashing test is marked as unsupported when it prints UNSUPPORTED before crashing

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I think this is the right thing to do, but let's also see what Jonas says about it. Also, this has the potential to mark some tests as failures even though there were previously "passing",

[Lldb-commits] [PATCH] D75031: [lldb] Fix that a crashing test is marked as unsupported when it prints UNSUPPORTED before crashing

teemperor created this revision. teemperor added reviewers: labath, JDevlieghere. Herald added subscribers: lldb-commits, aprantl. Herald added a project: LLDB. teemperor retitled this revision from "[lldb] Fx that a crashing test is marked as passed as passing/unsupported when it prints

[Lldb-commits] [PATCH] D74957: [lldb] Disable auto fix-its when evaluating expressions in the test suite

This revision was automatically updated to reflect the committed changes. teemperor marked an inline comment as done. Closed by commit rGc131dfefe2b4: [lldb] Disable auto fix-its when evaluating expressions in the test suite (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [lldb] c131dfe - [lldb] Disable auto fix-its when evaluating expressions in the test suite

Author: Raphael Isemann Date: 2020-02-24T09:31:11+01:00 New Revision: c131dfefe2b404dc1dbb32a02ea484fd7edaffdc URL: https://github.com/llvm/llvm-project/commit/c131dfefe2b404dc1dbb32a02ea484fd7edaffdc DIFF:

[Lldb-commits] [PATCH] D74964: [lldb/DWARF] Don't index dwp file multiple times

labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.h:66 /// Non-null value means we haven't built the index yet. + SymbolFileDWARF *m_dwarf; JDevlieghere wrote: > This seems inverted? Actually, it is correct,

[Lldb-commits] [lldb] be3b448 - [lldb/test] simplify basic-elf.yaml

Author: Pavel Labath Date: 2020-02-24T09:02:18+01:00 New Revision: be3b448c2e39b9f1302601935955a9f5e5f013e8 URL: https://github.com/llvm/llvm-project/commit/be3b448c2e39b9f1302601935955a9f5e5f013e8 DIFF: https://github.com/llvm/llvm-project/commit/be3b448c2e39b9f1302601935955a9f5e5f013e8.diff