[Lldb-commits] [lldb] 4016c6b - [lldb/Reproducer] Prevent crash when GDB multi-loader can't be created.

Author: Jonas Devlieghere Date: 2020-03-10T23:16:55-07:00 New Revision: 4016c6b07f2ade01c65750d1297f72b43f9eb244 URL: https://github.com/llvm/llvm-project/commit/4016c6b07f2ade01c65750d1297f72b43f9eb244 DIFF: https://github.com/llvm/llvm-project/commit/4016c6b07f2ade01c65750d1297f72b43f9eb244.d

[Lldb-commits] [PATCH] D75626: Add support for owning module information to TypeSystemClang.

shafik added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp:996 m_clang_ast_context->GetUniqueNamespaceDeclaration( - g_lldb_local_vars_namespace_cstr, nullptr); + g_lldb_local_vars_namespace_cstr, null

[Lldb-commits] [PATCH] D75877: [lldb/Reproducers] Fix replay for process attach workflows

JDevlieghere updated this revision to Diff 249555. JDevlieghere added a comment. - Add ProcessInfo provider. - Rewrite test as an dotest-test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75877/new/ https://reviews.llvm.org/D75877 Files: lldb/include/lldb/Utility/FileSpec.h lldb/i

[Lldb-commits] [PATCH] D74636: [lldb-vscode] Add inheritEnvironment option

diazhector98 updated this revision to Diff 249536. diazhector98 added a comment. Adding remote process check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74636/new/ https://reviews.llvm.org/D74636 Files: lldb/packages/Python/lldbsuite/test/tool

[Lldb-commits] [PATCH] D74636: [lldb-vscode] Add inheritEnvironment option

wallace requested changes to this revision. wallace added inline comments. This revision now requires changes to proceed. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:1380 auto envs = GetStrings(arguments, "env"); + if (launchWithDebuggerEnvironment) { +std::vector

[Lldb-commits] [PATCH] D74636: [lldb-vscode] Add inheritEnvironment option

diazhector98 updated this revision to Diff 249527. diazhector98 added a comment. Adding support for windows systems Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74636/new/ https://reviews.llvm.org/D74636 Files: lldb/packages/Python/lldbsuite/te

[Lldb-commits] [PATCH] D75880: [NFC} Move ThreadPlans stacks into their own class, store it in Process by TID

jingham updated this revision to Diff 249525. jingham added a comment. Fix some clang-format nits. I didn't change: condition1 && condition2 && condition3 to condition1 && condition2 && condition3 as it suggests. We use that all over the place in lldb, and I much prefer it. It makes

[Lldb-commits] [PATCH] D75784: Avoid including Module.h from ExternalASTSource.h

rnk added a comment. In D75784#1910688 , @aprantl wrote: > This will no doubt also need some patches to the Swift compiler, but given > the NFC-ness this hopefully should be fine. True. I could leave behind a typedef for the ASTSourceDescriptor if it ma

[Lldb-commits] [PATCH] D75626: Add support for owning module information to TypeSystemClang.

shafik added inline comments. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.h:73 + unsigned GetOwningModuleID() { return Flags(m_payload).Clear(ObjCClassBit); } + void SetOwningModuleID(unsigned id) { +assert(id < ObjCClassBit); Why not u

[Lldb-commits] [PATCH] D75406: Avoid including FileManager.h from SourceManager.h

rnk added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75406/new/ https://reviews.llvm.org/D75406 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[Lldb-commits] [PATCH] D75880: [NFC} Move ThreadPlans stacks into their own class, store it in Process by TID

jingham updated this revision to Diff 249515. jingham marked 3 inline comments as done. jingham added a comment. Addressed Pavel's review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75880/new/ https://reviews.llvm.org/D75880 Files: l

[Lldb-commits] [PATCH] D75880: [NFC} Move ThreadPlans stacks into their own class, store it in Process by TID

jingham marked 9 inline comments as done. jingham added a comment. Addressed Pavel's review comments. Comment at: lldb/include/lldb/Target/ThreadPlanStack.h:113 + +class ThreadPlanStackMap { +public: labath wrote: > It's not clear to me what is the value of thi

[Lldb-commits] [PATCH] D75715: Switch TypeSystemClang over to CreateDeserialized() (NFC)

shafik added a comment. A bunch of small comments but a few more serious ones as well. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:1394 + func_tmpl_decl->setDeclName(func_decl->getDeclName()); + func_tmpl_decl->init(func_decl, template_param_list);

[Lldb-commits] [PATCH] D75715: Switch TypeSystemClang over to CreateDeserialized() (NFC)

shafik added inline comments. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:1265 + CXXRecordDecl *decl = CXXRecordDecl::CreateDeserialized(ast, 0); + decl->setTagKind((TagDecl::TagKind)kind); + decl->setDeclContext(decl_ctx); `static_cas

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

dblaikie added a comment. In D75929#1915009 , @labath wrote: > I haven't digested the patch yet, but I am wondering if you've seen the > recent discussion (`DWP mixed (DWARFv4/pre-standard + DWARFv5) content`) on > dwarf-discuss (link1 >

[Lldb-commits] [PATCH] D75925: [lldb] reject `.debug_arange` sections with nonzero segment size

clayborg added a comment. Change looks good, just needs a test. Should be easy to take a simple binary that has a .debug_aranges, and run obj2yaml on it, and tweak the segment size as needed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75925/new

[Lldb-commits] [PATCH] D75488: Preserve the owning module information from DWARF in the synthesized AST

teemperor added inline comments. Comment at: lldb/include/lldb/Symbol/Type.h:198 uint32_t GetEncodingMask(); - - bool IsCompleteObjCClass() { return m_is_complete_objc_class; } - - void SetIsCompleteObjCClass(bool is_complete_objc_class) { -m_is_complete_objc_class = is_

[Lldb-commits] [PATCH] D75626: Add support for owning module information to TypeSystemClang.

teemperor added a comment. I'm not a big fan of storing data in the `ClangExternalASTSourceCallbacks`. The main reason is that this external source only exists when the ASTContext in the TypeSystemClang is created by the TypeSystemClang. When the TypeSystem adopts an ASTContext there can be any

[Lldb-commits] [PATCH] D75711: [NFC] Have ThreadPlans hold onto the Process & TID, rather than the Thread

jingham added a comment. In D75711#1914001 , @labath wrote: > In D75711#1912902 , @jingham wrote: > > > In D75711#1912230 , @labath wrote: > > > > > So this is technically no

[Lldb-commits] [PATCH] D74023: [RISCV] ELF attribute section for RISC-V

HsiangKai updated this revision to Diff 249024. HsiangKai added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Move llvm-readobj changes and tests to D75833 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

mstorsjo added a comment. Herald added a subscriber: danielkiss. This broke compiling for mingw, repro.c: a(short); b() { a(1); } `clang -target x86_64-w64-mingw32 -c repro.c -g -O2`, which gives `Assertion `!MI.isMoveImmediate() && "Unexpected MoveImm instruction"' failed.` CHANGES SINCE

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

ikudrin created this revision. ikudrin added reviewers: dblaikie, probinson, jhenderson, aprantl, labath. ikudrin added projects: LLVM, debug-info. Herald added subscribers: lldb-commits, arphaman, hiraditya. Herald added a project: LLDB. DWARFv5 defines index sections in package files in a slight

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

labath added a comment. I haven't digested the patch yet, but I am wondering if you've seen the recent discussion (`DWP mixed (DWARFv4/pre-standard + DWARFv5) content`) on dwarf-discuss (link1 , link2

[Lldb-commits] [PATCH] D75761: Fix to get the AST we generate for function templates to be closer to what clang generates and expects

shafik updated this revision to Diff 249430. shafik added a comment. Move to using `expect_expr` in the test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75761/new/ https://reviews.llvm.org/D75761 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp lldb/test/API/l

[Lldb-commits] [PATCH] D75877: [lldb/Reproducers] Fix replay for process attach workflows

JDevlieghere added a comment. In D75877#1914900 , @labath wrote: > In D75877#1914755 , @JDevlieghere > wrote: > > > In D75877#1913959 , @labath wrote: > > > > > A more princ

[Lldb-commits] [PATCH] D75864: Add a decorator option to skip tests based on a default setting

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D75864#1914795 , @aprantl wrote: > In D75864#1913876 , @labath wrote: > > > If a test requires a specific va

[Lldb-commits] [PATCH] D75877: [lldb/Reproducers] Fix replay for process attach workflows

labath added a comment. In D75877#1914755 , @JDevlieghere wrote: > In D75877#1913959 , @labath wrote: > > > A more principled way to make this work would be to intercept (record) the > > Host::FindProcesses api. T

[Lldb-commits] [PATCH] D75864: Add a decorator option to skip tests based on a default setting

JDevlieghere added a comment. LGTM but let's give Pavel another chance to take a look. Comment at: lldb/test/API/sanity/TestSettingSkipping.py:28 + def testNotExisting(self): +self.assertTrue(True, "This test should run!") + aprantl wrote: > JDevlieghere w

[Lldb-commits] [PATCH] D75864: Add a decorator option to skip tests based on a default setting

aprantl marked an inline comment as done. aprantl added inline comments. Comment at: lldb/test/API/sanity/TestSettingSkipping.py:28 + def testNotExisting(self): +self.assertTrue(True, "This test should run!") + JDevlieghere wrote: > This won't trip if the te

[Lldb-commits] [PATCH] D75864: Add a decorator option to skip tests based on a default setting

aprantl added a comment. In D75864#1913876 , @labath wrote: > If a test requires a specific value of a setting, would it make more sense to > just (re)set its value at the start of a test? This is not meant for requiring a setting, but to run the testsu

[Lldb-commits] [PATCH] D75925: [lldb] reject `.debug_arange` sections with nonzero segment size

ldrumm created this revision. ldrumm added reviewers: clayborg, jasonmolenda. ldrumm added a project: LLDB. If a producer emits a nonzero segment size, `lldb` will silently read incorrect values and crash, or do something worse later, as the tuple size is expected to be 2, rather than 3.

[Lldb-commits] [PATCH] D75877: [lldb/Reproducers] Fix replay for process attach workflows

JDevlieghere planned changes to this revision. JDevlieghere marked 2 inline comments as done. JDevlieghere added a comment. In D75877#1913959 , @labath wrote: > A more principled way to make this work would be to intercept (record) the > Host::FindProcess

[Lldb-commits] [lldb] 6b37c47 - [lldb] Improve test failure messages in vscode tests

Author: Pavel Labath Date: 2020-03-10T14:32:45+01:00 New Revision: 6b37c476a2d4e63f6c02ca8996e0e92ae3db3282 URL: https://github.com/llvm/llvm-project/commit/6b37c476a2d4e63f6c02ca8996e0e92ae3db3282 DIFF: https://github.com/llvm/llvm-project/commit/6b37c476a2d4e63f6c02ca8996e0e92ae3db3282.diff

[Lldb-commits] [PATCH] D75848: [lldb] Make UnwindLLDB a non-plugin

This revision was automatically updated to reflect the committed changes. Closed by commit rGd00dff88b402: [lldb] Make UnwindLLDB a non-plugin (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75848/new/ https://reviews.llvm.org/D7

[Lldb-commits] [lldb] 1ca1e08 - [lldb] Break up CommandObjectDisassemble::DoExecute

Author: Pavel Labath Date: 2020-03-10T14:03:16+01:00 New Revision: 1ca1e08e7544aea88d5978284a1c18086458d6c0 URL: https://github.com/llvm/llvm-project/commit/1ca1e08e7544aea88d5978284a1c18086458d6c0 DIFF: https://github.com/llvm/llvm-project/commit/1ca1e08e7544aea88d5978284a1c18086458d6c0.diff

[Lldb-commits] [lldb] d00dff8 - [lldb] Make UnwindLLDB a non-plugin

Author: Pavel Labath Date: 2020-03-10T13:56:15+01:00 New Revision: d00dff88b402ea9074b87aa5d3faddfd50c4bc0f URL: https://github.com/llvm/llvm-project/commit/d00dff88b402ea9074b87aa5d3faddfd50c4bc0f DIFF: https://github.com/llvm/llvm-project/commit/d00dff88b402ea9074b87aa5d3faddfd50c4bc0f.diff

[Lldb-commits] [PATCH] D75761: Fix to get the AST we generate for function templates to be closer to what clang generates and expects

labath added a comment. (This looks fine to me.) In D75761#1913585 , @shafik wrote: > I was planning on looking into removing the template parameters from the > names altogether for lldb but we would still need to do this on the lldb side > to support o

[Lldb-commits] [PATCH] D75880: [NFC} Move ThreadPlans stacks into their own class, store it in Process by TID

labath added a comment. As we've seen, I don't know much about thread plans so I don't have much to say on the higher-level aspects of this patch. But I see a bunch of opportunities to make this more consistent with llvm code style. Comment at: lldb/include/lldb/Target/Threa

[Lldb-commits] [PATCH] D75711: [NFC] Have ThreadPlans hold onto the Process & TID, rather than the Thread

labath added a comment. In D75711#1912902 , @jingham wrote: > In D75711#1912230 , @labath wrote: > > > So this is technically not "our" fault. The plugin is doing something > > unsupported and gets weird behavior a

[Lldb-commits] [PATCH] D75877: [lldb/Reproducers] Fix replay for process attach workflows

labath added a comment. A more principled way to make this work would be to intercept (record) the Host::FindProcesses api. That way other functionality pertaining to running processes (e.g. the "platform process list" command) would also work. But if this is all you care about right now, then

[Lldb-commits] [lldb] 5aa5c94 - Reland "[DebugInfo] Enable the debug entry values feature by default"

Author: Djordje Todorovic Date: 2020-03-10T09:15:06+01:00 New Revision: 5aa5c943f7da155b95564058cd5d50a93eabfc89 URL: https://github.com/llvm/llvm-project/commit/5aa5c943f7da155b95564058cd5d50a93eabfc89 DIFF: https://github.com/llvm/llvm-project/commit/5aa5c943f7da155b95564058cd5d50a93eabfc89.d

[Lldb-commits] [PATCH] D75864: Add a decorator option to skip tests based on a default setting

labath added a comment. If a test requires a specific value of a setting, would it make more sense to just (re)set its value at the start of a test? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75864/new/ https://reviews.llvm.org/D75864 _