[Lldb-commits] [PATCH] D77107: [intel-pt] Implement a basic test case

labath added a comment. It's nice to see this code getting some use. I was starting to think we should delete it... Comment at: lldb/test/API/tools/intel-features/intel-pt/test/TestIntelPTSimpleBinary.py:30-36 +exe = self.getBuildArtifact("a.out") +self.runCmd

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

labath added a comment. In D76968#1951707 , @clayborg wrote: > Looks good as long as with we have "llvm::Optional > request_path = {}" in the arguments for a function, that "{}" will turn into > llvm::None and not an empty StringRef? Unclear to me. As lo

[Lldb-commits] [PATCH] D77108: [lldb/DWARF] Fix evaluator crash when accessing empty stack

labath added a comment. In D77108#1951610 , @aprantl wrote: > This is obviously good! Do you think that a similar error handling bug might > exist in other cases that depend top-of-stack? Most DW_OP cases check their stack, but it's quite possible that

[Lldb-commits] [PATCH] D74398: [lldb-server] jThreadsInfo returns stack memory

jarin added a comment. In D74398#1939372 , @jarin wrote: > In D74398#1935438 , @jasonmolenda > wrote: > > > (and if you're still seeing mystery reads, put a breakpoint on > > ProcessGDBRemote::DoReadMemory and see

[Lldb-commits] [PATCH] D77108: [lldb/DWARF] Fix evaluator crash when accessing empty stack

kwk added a comment. In D77108#1951879 , @labath wrote: > In D77108#1951610 , @aprantl wrote: > > > This is obviously good! Do you think that a similar error handling bug > > might exist in other cases that depend

[Lldb-commits] [lldb] d30e9ad - Correct the duplicate pragma marks in CommandObjectTarget.cpp

Author: Shivam Mittal Date: 2020-03-31T11:16:40+02:00 New Revision: d30e9ad34519cb0ec17d411bc103af7bb76da77e URL: https://github.com/llvm/llvm-project/commit/d30e9ad34519cb0ec17d411bc103af7bb76da77e DIFF: https://github.com/llvm/llvm-project/commit/d30e9ad34519cb0ec17d411bc103af7bb76da77e.diff

[Lldb-commits] [PATCH] D77123: [lldb] Inherit host environment when running shell commands

labath created this revision. labath added reviewers: jingham, friss. Herald added a project: LLDB. labath added a comment. This stems from D76835 -- when the inherit fallback on windows gets removed some tests fail bacause the can't find `ls`. This is used in `

[Lldb-commits] [PATCH] D77096: Correct the duplicate pragma marks in CommandObjectTarget.cpp

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77096/new/ https://reviews.llvm.org/D77096 __

[Lldb-commits] [PATCH] D77108: [lldb/DWARF] Fix evaluator crash when accessing empty stack

labath added a comment. In D77108#1951997 , @kwk wrote: > In D77108#1951879 , @labath wrote: > > > Most DW_OP cases check their stack, but it's quite possible that others > > were missed too. It might be a nice cle

[Lldb-commits] [PATCH] D77123: [lldb] Inherit host environment when running shell commands

labath added a comment. This stems from D76835 -- when the inherit fallback on windows gets removed some tests fail bacause the can't find `ls`. This is used in `lldbutil.wait_for_file_on_target`. The inheritance was not a problem because `ls` is normally in th

[Lldb-commits] [PATCH] D77096: Correct the duplicate pragma marks in CommandObjectTarget.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rGd30e9ad34519: Correct the duplicate pragma marks in CommandObjectTarget.cpp (authored by shivammittal99, committed by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

labath added a comment. Having this in the host layer sounds good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76471/new/ https://reviews.llvm.org/D76471 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.o

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

labath added a comment. Making a plugin out of this sounds like a good idea to me, and I could immediately find several downstream users for it. However, it seems to me there is a great deal of overlap between this SymbolServer thingy and the existing SymbolVendor plugin (I mean, "vend" and "se

[Lldb-commits] [PATCH] D77000: [LLDB] [PECOFF] Only use PECallFrameInfo on the one supported architecture

mstorsjo added a comment. @labath @aleksandr.urakov Does this version look good to you? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77000/new/ https://reviews.llvm.org/D77000 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https

[Lldb-commits] [PATCH] D77000: [LLDB] [PECOFF] Only use PECallFrameInfo on the one supported architecture

aleksandr.urakov accepted this revision. aleksandr.urakov added a comment. This revision is now accepted and ready to land. Sorry for the long delay, LGTM now, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77000/new/ https://reviews.llvm.org/D77000 ___

[Lldb-commits] [PATCH] D77123: [lldb] Inherit host environment when running shell commands

friss accepted this revision. friss added a comment. This revision is now accepted and ready to land. I agree host shell command should run with the host environment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77123/new/ https://reviews.llvm.org

[Lldb-commits] [lldb] e26eece - [lldb/DWARF] Fix evaluator crash when accessing empty stack.

Author: Med Ismail Bennani Date: 2020-03-31T17:28:15+02:00 New Revision: e26eece1e2e7d7e6fbadb1207afef9b6353b5330 URL: https://github.com/llvm/llvm-project/commit/e26eece1e2e7d7e6fbadb1207afef9b6353b5330 DIFF: https://github.com/llvm/llvm-project/commit/e26eece1e2e7d7e6fbadb1207afef9b6353b5330.

[Lldb-commits] [PATCH] D77141: [DebugInfo] Rename section identifiers which are deprecated in DWARFv5. NFC.

ikudrin created this revision. ikudrin added reviewers: dblaikie, jhenderson, probinson, aprantl. ikudrin added projects: LLVM, debug-info. Herald added subscribers: lldb-commits, arphaman, hiraditya. Herald added a project: LLDB. ikudrin added a parent revision: D76067: [llvm-dwp] Refactor handlin

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

ikudrin updated this revision to Diff 253879. ikudrin added a comment. - Removed `DWARFUnitIndex::getVersion()` as it is related to the other patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75929/new/ https://reviews.llvm.org/D75929 Files: llvm/include/llvm/BinaryFormat/Dwarf.de

[Lldb-commits] [PATCH] D74023: [RISCV] ELF attribute section for RISC-V

This revision was automatically updated to reflect the committed changes. Closed by commit rG581ba35291a6: [RISCV] ELF attribute section for RISC-V. (authored by HsiangKai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74023/new/ https://reviews.ll

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

ikudrin updated this revision to Diff 253874. ikudrin marked 4 inline comments as done. ikudrin added a comment. - Updated the comment for `DWARFSectionKind`. - Simplified the storing of raw section identifiers. - Moved independent changes into separate patches. CHANGES SINCE LAST ACTION https

[Lldb-commits] [lldb] f3a7d79 - [lldb/DWARF] Fix evaluator crash when accessing empty stack.

Author: Med Ismail Bennani Date: 2020-03-31T17:44:57+02:00 New Revision: f3a7d790df3357d52c10ec5ef48606944bcf5c6c URL: https://github.com/llvm/llvm-project/commit/f3a7d790df3357d52c10ec5ef48606944bcf5c6c DIFF: https://github.com/llvm/llvm-project/commit/f3a7d790df3357d52c10ec5ef48606944bcf5c6c.

[Lldb-commits] [lldb] e4a7780 - Revert "[lldb/DWARF] Fix evaluator crash when accessing empty stack."

Author: Med Ismail Bennani Date: 2020-03-31T17:44:17+02:00 New Revision: e4a778052e98c6d67f601342a7ca3b3c52ce7fbd URL: https://github.com/llvm/llvm-project/commit/e4a778052e98c6d67f601342a7ca3b3c52ce7fbd DIFF: https://github.com/llvm/llvm-project/commit/e4a778052e98c6d67f601342a7ca3b3c52ce7fbd.

[Lldb-commits] [PATCH] D77108: [lldb/DWARF] Fix evaluator crash when accessing empty stack

mib added a comment. In D77108#1951610 , @aprantl wrote: > This is obviously good! Do you think that a similar error handling bug might > exist in other cases that depend top-of-stack? I quickly ran through the function, and it seems this was the only l

[Lldb-commits] [PATCH] D77108: [lldb/DWARF] Fix evaluator crash when accessing empty stack

mib updated this revision to Diff 253895. mib marked an inline comment as done. mib added a comment. Addressed Pavel's request. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77108/new/ https://reviews.llvm.org/D77108 Files: lldb/source/Expressio

[Lldb-commits] [PATCH] D77108: [lldb/DWARF] Fix evaluator crash when accessing empty stack

This revision was automatically updated to reflect the committed changes. Closed by commit rGf3a7d790df33: [lldb/DWARF] Fix evaluator crash when accessing empty stack. (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77108/new/ https

[Lldb-commits] [PATCH] D77108: [lldb/DWARF] Fix evaluator crash when accessing empty stack

aprantl added a comment. For the future, a clean solution would be extending the macros in Dwarf.def to list the stack effects in the definitions of the DW_OP_*, for example // opcode, name, version, vendor, in, out HANDLE_DW_OP(0x12, dup, 2, DWARF, 1, 2) and then we could write a static ve

[Lldb-commits] [PATCH] D75488: Preserve the owning module information from DWARF in the synthesized AST

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Sorry for resetting this back from accepted :) Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:1260 + + module->Name = name.str(); + re

[Lldb-commits] [lldb] 5c2bf57 - [lldb/API] Add missing reproducer instrumentation to GetHostPlatform.

Author: Jonas Devlieghere Date: 2020-03-31T10:45:25-07:00 New Revision: 5c2bf577dcd34b0f4a20360d411e410d739b752f URL: https://github.com/llvm/llvm-project/commit/5c2bf577dcd34b0f4a20360d411e410d739b752f DIFF: https://github.com/llvm/llvm-project/commit/5c2bf577dcd34b0f4a20360d411e410d739b752f.d

[Lldb-commits] [PATCH] D75562: Add an opque payload field to lldb::Type (NFC).

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Could you make the `uint32_t` a typedef? I'm fine with this not being type-safe, but a typedef would at least allow me to search for where this information is used. Grepping/searching fo

[Lldb-commits] [PATCH] D77153: [lldb/DataFormatters] Display null C++ pointers as nullptr

friss added a comment. I haven't tested the libstdc++ part, would be great if someone could confirm this works. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77153/new/ https://reviews.llvm.org/D77153 ___

[Lldb-commits] [PATCH] D77153: [lldb/DataFormatters] Display null C++ pointers as nullptr

friss created this revision. friss added reviewers: jingham, labath. Herald added a project: LLDB. friss added a comment. I haven't tested the libstdc++ part, would be great if someone could confirm this works. The original motivation for this patch was to display a null std::string pointer as

[Lldb-commits] [lldb] 75cfd38 - Revert "[lldb/Reproducers] Always collect the whole dSYM in the reproducer"

Author: Davide Italiano Date: 2020-03-31T10:56:02-07:00 New Revision: 75cfd382201978615cca1c91c2d9f14f8b7af56d URL: https://github.com/llvm/llvm-project/commit/75cfd382201978615cca1c91c2d9f14f8b7af56d DIFF: https://github.com/llvm/llvm-project/commit/75cfd382201978615cca1c91c2d9f14f8b7af56d.dif

[Lldb-commits] [lldb] 7b06cb4 - Add an opque payload field to lldb::Type (NFC).

Author: Adrian Prantl Date: 2020-03-31T11:14:12-07:00 New Revision: 7b06cb4523083206ad79776c80a564cd26bd8326 URL: https://github.com/llvm/llvm-project/commit/7b06cb4523083206ad79776c80a564cd26bd8326 DIFF: https://github.com/llvm/llvm-project/commit/7b06cb4523083206ad79776c80a564cd26bd8326.diff

[Lldb-commits] [PATCH] D75562: Add an opque payload field to lldb::Type (NFC).

This revision was automatically updated to reflect the committed changes. Closed by commit rG7b06cb452308: Add an opque payload field to lldb::Type (NFC). (authored by aprantl). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D75562?vs=253226&id=253937#toc Repos

[Lldb-commits] [lldb] 128c0d0 - [intel-pt] Fix existing support in LLDB

Author: Walter Erquinigo Date: 2020-03-31T11:32:34-07:00 New Revision: 128c0d037d32c929c58d63fd7f324038430f73ba URL: https://github.com/llvm/llvm-project/commit/128c0d037d32c929c58d63fd7f324038430f73ba DIFF: https://github.com/llvm/llvm-project/commit/128c0d037d32c929c58d63fd7f324038430f73ba.di

[Lldb-commits] [PATCH] D76872: [intel-pt] Fix existing support in LLDB

This revision was automatically updated to reflect the committed changes. Closed by commit rG128c0d037d32: [intel-pt] Fix existing support in LLDB (authored by Walter Erquinigo ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76872/ne

[Lldb-commits] [lldb] e8f13f4 - Replace std::string::find == 0 with StringRef::startswith

Author: Benjamin Kramer Date: 2020-03-31T21:01:09+02:00 New Revision: e8f13f4f62f52067cadb55f3c746ccf9d26ee2ce URL: https://github.com/llvm/llvm-project/commit/e8f13f4f62f52067cadb55f3c746ccf9d26ee2ce DIFF: https://github.com/llvm/llvm-project/commit/e8f13f4f62f52067cadb55f3c746ccf9d26ee2ce.dif

[Lldb-commits] [PATCH] D77153: [lldb/DataFormatters] Display null C++ pointers as nullptr

shafik added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/libstdcpp/string/main.cpp:13 std::basic_string uchar(5, 'a'); +std::string *null = nullptr; S.assign(L"!"); // Set break point at this line. --

[Lldb-commits] [lldb] 015c6cd - Re-land "[lldb/Reproducers] Always collect the whole dSYM in the reproducer"

Author: Jonas Devlieghere Date: 2020-03-31T12:47:12-07:00 New Revision: 015c6cd47557272bb8b92fbf9f5bd2bcb8fa8989 URL: https://github.com/llvm/llvm-project/commit/015c6cd47557272bb8b92fbf9f5bd2bcb8fa8989 DIFF: https://github.com/llvm/llvm-project/commit/015c6cd47557272bb8b92fbf9f5bd2bcb8fa8989.d

[Lldb-commits] [PATCH] D77108: [lldb/DWARF] Fix evaluator crash when accessing empty stack

aprantl added a comment. CC'ing the DWARF cabal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77108/new/ https://reviews.llvm.org/D77108 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https

[Lldb-commits] [PATCH] D77108: [lldb/DWARF] Fix evaluator crash when accessing empty stack

labath added a comment. In D77108#1952818 , @aprantl wrote: > For the future, a clean solution would be extending the macros in Dwarf.def > to list the stack effects in the definitions of the DW_OP_*, for example > > // opcode, name, version, vendor, in

[Lldb-commits] [PATCH] D77173: [PATCH] [debugserver/ARM64] Make sure watchpoints hit are attributed correctly.

davide created this revision. davide added a reviewer: jasonmolenda. davide added a project: LLDB. Herald added subscribers: danielkiss, kristof.beyls. >From e330facaea0c3780734a6a061134551662fb9d74 Mon Sep 17 00:00:00 2001 From: Davide Italiano Date: Tue, 31 Mar 2020 13:55:36 -0700 Subject: [PAT

[Lldb-commits] [lldb] 00efcd6 - Add a Type::Payload typedef. (NFC)

Author: Adrian Prantl Date: 2020-03-31T14:32:53-07:00 New Revision: 00efcd6fffa533e5a4aa5646e678d57df0f9aca8 URL: https://github.com/llvm/llvm-project/commit/00efcd6fffa533e5a4aa5646e678d57df0f9aca8 DIFF: https://github.com/llvm/llvm-project/commit/00efcd6fffa533e5a4aa5646e678d57df0f9aca8.diff

[Lldb-commits] [lldb] ec11c56 - Replace uint32_t with typedef (NFC)

Author: Adrian Prantl Date: 2020-03-31T14:58:25-07:00 New Revision: ec11c5615a7c153a68d098903edebbb92719f5f9 URL: https://github.com/llvm/llvm-project/commit/ec11c5615a7c153a68d098903edebbb92719f5f9 DIFF: https://github.com/llvm/llvm-project/commit/ec11c5615a7c153a68d098903edebbb92719f5f9.diff

[Lldb-commits] [PATCH] D77173: [PATCH] [debugserver/ARM64] Make sure watchpoints hit are attributed correctly.

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. I was a little worried about the case where we have an 8-byte region being watched that is 4-byte aligned (so it's spanning two 8-byte watchpoints), but a quick test of that with t

[Lldb-commits] [lldb] 64799fb - [debugserver/ARM64] Make sure watchpoints hit are attributed correctly.

Author: Davide Italiano Date: 2020-03-31T15:56:20-07:00 New Revision: 64799fbebddc9877f78c7501b0b986b7afe84d6b URL: https://github.com/llvm/llvm-project/commit/64799fbebddc9877f78c7501b0b986b7afe84d6b DIFF: https://github.com/llvm/llvm-project/commit/64799fbebddc9877f78c7501b0b986b7afe84d6b.dif

[Lldb-commits] [PATCH] D75488: Preserve the owning module information from DWARF in the synthesized AST

aprantl marked an inline comment as done. aprantl added inline comments. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:1260 + + module->Name = name.str(); + return ast_source->RegisterModule(module); teemperor wrote: > Why is that done? T

[Lldb-commits] [PATCH] D75488: Preserve the owning module information from DWARF in the synthesized AST

aprantl updated this revision to Diff 254027. aprantl marked an inline comment as done. aprantl added a comment. (Made const_cast explicit to illustrate mismatch.) However, I still need to de-constify in order to create the module. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75488/new

Re: [Lldb-commits] [lldb] 64799fb - [debugserver/ARM64] Make sure watchpoints hit are attributed correctly.

Folks, I don’t have a Windows or a Linux machine to try this, but please let me know or skip this test in case it breaks something. I’ll try to keep an eye on the bots for notifications. > On Mar 31, 2020, at 3:56 PM, Davide Italiano via lldb-commits > wrote: > > > Author: Davide Italiano > D

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

wallace updated this revision to Diff 254039. wallace added a comment. Account for dynamically loaded libraries and update the logic for breakpoint events Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76968/new/ https://reviews.llvm.org/D76968 Fi

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

wallace added a comment. Some included changes: - Removed the "source" element if the "breakpoint" object returned in breakpoint events - CreateBreakpoint now accepts an optional line number, which is used as fallback if no location is valid - Added a test that asserts breakpoints in dynamicall

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

wallace updated this revision to Diff 254041. wallace added a comment. cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76968/new/ https://reviews.llvm.org/D76968 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testc

[Lldb-commits] [PATCH] D77107: [intel-pt] Implement a basic test case

wallace marked 2 inline comments as done. wallace added inline comments. Comment at: lldb/test/API/tools/intel-features/intel-pt/test/TestIntelPTSimpleBinary.py:50-54 +"rand", # We expect to see a reference to the rand function +# within t

[Lldb-commits] [PATCH] D77186: [source maps] Ensure all valid source maps are added instead of failing with the first invalid one

wallace created this revision. wallace added reviewers: clayborg, labath, kusmour, aadsm. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Several lldb-vscode users have noticed that when a source map rule is invalid (because a folder doesn't exist anymore), the rest of the

[Lldb-commits] [PATCH] D77107: [intel-pt] Implement a basic test case

wallace updated this revision to Diff 254068. wallace added a comment. Noise, for some reason I can't run clang-format as part of arc lint on this device. I'm running it manually anyway Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77107/new/ htt

[Lldb-commits] [PATCH] D77107: [intel-pt] Implement a basic test case

wallace updated this revision to Diff 254067. wallace added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77107/new/ https://reviews.llvm.org/D77107 Files: lldb/test/API/tools/intel-features/intel-pt/test/Makefile lldb/

[Lldb-commits] [PATCH] D77107: [intel-pt] Implement a basic test case

wallace updated this revision to Diff 254065. wallace added a comment. Addressed comments Also ran the test in parallel to a 'stress -c 100 -i 100' invocation, and it passed correctly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77107/new/ https:

[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

aprantl updated this revision to Diff 254071. aprantl added a comment. I just had an off-list conversation with @jingham were we discussed what should be Platform versus Host in detail. The resulting solution looks even more convoluted at first, but it actually solves a bunch of problems that I

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Just use "llvm::None" instead of "{}" and this is good to go. Comment at: lldb/tools/lldb-vscode/JSONUtils.h:237 +CreateBreakpoint(lldb::SBBreakpoint &bp, +

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

clayborg added a comment. The main issue is that the symbol vendors currently are ELF, macOS and WASM. Right now we have one SymbolVendor for a triple, but I can see a SymbolVendor wanting to use multiple symbol servers to get information: one for the OS binaries (debuginfod or DebugSymbols.fra

[Lldb-commits] [PATCH] D77186: [source maps] Ensure all valid source maps are added instead of failing with the first invalid one

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. This will do what the user intends more of the time. Good catch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77186/new/ https://reviews.llv

[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

JDevlieghere added a comment. I think the current separation makes a lot of sense, but I don't like that `XcodeSDK` class is part of Utility. I understand the need from a layering perspective and I don't really have a better idea, but maybe someone else does? CHANGES SINCE LAST ACTION https:

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

clayborg added a comment. Another idea for the SymbolServers: be able to specify a source repository (git, svn etc) and hash or revision ID. The symbol server can grab the source from the repo and cache is locally for display. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION