[Lldb-commits] [PATCH] D78648: [CMake] Bump CMake minimum version to 3.13.4

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. With the newer minimum CMake version, we can eliminate a bunch of the policy settings as well, but that can be a follow-up (especially given this isn't gonna ship for a few months). (Anothe

[Lldb-commits] [lldb] a0919ac - Invert an #ifdef in XcodeSDKModuleTests.cpp and actually make the test work.

Author: Adrian Prantl Date: 2020-04-24T18:39:40-07:00 New Revision: a0919ac080951dec5047f18319a2974b6c6258e5 URL: https://github.com/llvm/llvm-project/commit/a0919ac080951dec5047f18319a2974b6c6258e5 DIFF: https://github.com/llvm/llvm-project/commit/a0919ac080951dec5047f18319a2974b6c6258e5.diff

[Lldb-commits] [lldb] af015c1 - Revert "Add a getter to retrieve the XcodeSDK from Module and unit-test it. (NFC)"

Author: Adrian Prantl Date: 2020-04-24T16:59:48-07:00 New Revision: af015c1a33b772502be579eb5f62ae3847f27d97 URL: https://github.com/llvm/llvm-project/commit/af015c1a33b772502be579eb5f62ae3847f27d97 DIFF: https://github.com/llvm/llvm-project/commit/af015c1a33b772502be579eb5f62ae3847f27d97.diff

[Lldb-commits] [lldb] 06e4f69 - Add a getter to retrieve the XcodeSDK from Module and unit-test it. (NFC)

Author: Adrian Prantl Date: 2020-04-24T17:00:34-07:00 New Revision: 06e4f69b225753af396a28be69637f4fc2d8839d URL: https://github.com/llvm/llvm-project/commit/06e4f69b225753af396a28be69637f4fc2d8839d DIFF: https://github.com/llvm/llvm-project/commit/06e4f69b225753af396a28be69637f4fc2d8839d.diff

[Lldb-commits] [lldb] 345df86 - Add a getter to retrieve the XcodeSDK from Module and unit-test it. (NFC)

Author: Adrian Prantl Date: 2020-04-24T16:51:54-07:00 New Revision: 345df863ce649860bea9040fe5c2f10780d29080 URL: https://github.com/llvm/llvm-project/commit/345df863ce649860bea9040fe5c2f10780d29080 DIFF: https://github.com/llvm/llvm-project/commit/345df863ce649860bea9040fe5c2f10780d29080.diff

[Lldb-commits] [PATCH] D78839: [lldb-vscode] Add an option for loading core files

wallace created this revision. wallace added reviewers: labath, clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Currently loading core files on lldb-vscode is broken because there's a check in the attach workflow that asserts that the PID is valid, which of course

[Lldb-commits] [PATCH] D78396: [lldb/Dataformatter] Add support for CoreFoundation Dictionaries and Sets

mib updated this revision to Diff 260012. mib added a comment. After playing with `llvm::sys::swapByteOrder` and the `DataExtractor` getters (GetU8, GetU16, GetU32 ), it looks like neither of these supports bitfields. Since the `CFBasicHash` struct relies heavily on bitfields, it won't suppo

[Lldb-commits] [lldb] 6a9edce - Fix a dangling-gsl warning and avoid transitively including string.

Author: Eric Christopher Date: 2020-04-24T16:03:17-07:00 New Revision: 6a9edce25778e6c131914ab2e6c3f8528785a8df URL: https://github.com/llvm/llvm-project/commit/6a9edce25778e6c131914ab2e6c3f8528785a8df DIFF: https://github.com/llvm/llvm-project/commit/6a9edce25778e6c131914ab2e6c3f8528785a8df.di

[Lldb-commits] [lldb] d8fb631 - Relax testcase. The Clang module debug info may return additional

Author: Adrian Prantl Date: 2020-04-24T15:50:26-07:00 New Revision: d8fb631d13d7b23780063a9c6000ae8208f84f8c URL: https://github.com/llvm/llvm-project/commit/d8fb631d13d7b23780063a9c6000ae8208f84f8c DIFF: https://github.com/llvm/llvm-project/commit/d8fb631d13d7b23780063a9c6000ae8208f84f8c.diff

[Lldb-commits] [lldb] b9c7e27 - Disable path-sensitive test on Windows.

Author: Adrian Prantl Date: 2020-04-24T15:21:54-07:00 New Revision: b9c7e276bdc42c3f3f58e494ac87c3fcce0422a2 URL: https://github.com/llvm/llvm-project/commit/b9c7e276bdc42c3f3f58e494ac87c3fcce0422a2 DIFF: https://github.com/llvm/llvm-project/commit/b9c7e276bdc42c3f3f58e494ac87c3fcce0422a2.diff

[Lldb-commits] [PATCH] D78825: [lldb/Driver] Exit with a non-zero exit code in batch mode when stopping because of an error.

vsk added a comment. Can we delete an override of SBDebugger::RunCommandInterpreter, or are they all part of the stable API? If we can, it'd be nice to get rid of the one with 6 args. Otherwise this lgtm. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78825/ne

[Lldb-commits] [PATCH] D78675: Add an internal bit to the XcodeSDK class

This revision was automatically updated to reflect the committed changes. Closed by commit rG79feafa5147a: Add an internal bit to the XcodeSDK class. (authored by aprantl). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior to commit: https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D78825: [lldb/Driver] Exit with a non-zero exit code in batch mode when stopping because of an error.

JDevlieghere created this revision. JDevlieghere added reviewers: LLDB, labath, clayborg, jingham, teemperor. We have the option to stop running commands in batch mode when an error occurs. Currently we still exit with a zero exit code when that happens. This is counter intuitive and not very PO

[Lldb-commits] [lldb] 79feafa - Add an internal bit to the XcodeSDK class.

Author: Adrian Prantl Date: 2020-04-24T12:55:53-07:00 New Revision: 79feafa5147af3cfaa821a5488ac40ed8b79b072 URL: https://github.com/llvm/llvm-project/commit/79feafa5147af3cfaa821a5488ac40ed8b79b072 DIFF: https://github.com/llvm/llvm-project/commit/79feafa5147af3cfaa821a5488ac40ed8b79b072.diff

[Lldb-commits] [lldb] 0d671db - [lldb/Driver] Remove level of indentation (NFC)

Author: Jonas Devlieghere Date: 2020-04-24T12:50:53-07:00 New Revision: 0d671dbca949e70536da371a43dc55248301705f URL: https://github.com/llvm/llvm-project/commit/0d671dbca949e70536da371a43dc55248301705f DIFF: https://github.com/llvm/llvm-project/commit/0d671dbca949e70536da371a43dc55248301705f.d

Re: [Lldb-commits] [lldb] 304ba5d - Delete cargo-cult code that doesn't affect the testsuite.

> On Apr 24, 2020, at 11:55 AM, Adrian Prantl via lldb-commits > wrote: > > > Author: Adrian Prantl > Date: 2020-04-24T11:54:52-07:00 > New Revision: 304ba5d4c6bc48853832e4fc4666f8e37308d7a4 > > URL: > https://github.com/llvm/llvm-project/commit/304ba5d4c6bc48853832e4fc4666f8e37308d7a4 > DI

[Lldb-commits] [lldb] 304ba5d - Delete cargo-cult code that doesn't affect the testsuite.

Author: Adrian Prantl Date: 2020-04-24T11:54:52-07:00 New Revision: 304ba5d4c6bc48853832e4fc4666f8e37308d7a4 URL: https://github.com/llvm/llvm-project/commit/304ba5d4c6bc48853832e4fc4666f8e37308d7a4 DIFF: https://github.com/llvm/llvm-project/commit/304ba5d4c6bc48853832e4fc4666f8e37308d7a4.diff

[Lldb-commits] [PATCH] D78333: Add Objective-C property accessors loaded from Clang module DWARF to lookup

This revision was automatically updated to reflect the committed changes. Closed by commit rGef423a3ba570: Add Objective-C property accessors loaded from Clang module DWARF to lookup (authored by aprantl). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D78333?vs

[Lldb-commits] [lldb] ef423a3 - Add Objective-C property accessors loaded from Clang module DWARF to lookup

Author: Adrian Prantl Date: 2020-04-24T11:10:50-07:00 New Revision: ef423a3ba57045f80b0fcafce72121449a8b54d4 URL: https://github.com/llvm/llvm-project/commit/ef423a3ba57045f80b0fcafce72121449a8b54d4 DIFF: https://github.com/llvm/llvm-project/commit/ef423a3ba57045f80b0fcafce72121449a8b54d4.diff

[Lldb-commits] [PATCH] D78462: get rid of PythonInteger::GetInteger()

lawrence_danna added a comment. @omjavaid ok to re-land? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78462/new/ https://reviews.llvm.org/D78462 ___ lldb-commits mailing list lldb-commits@lists.llvm.o

[Lldb-commits] [PATCH] D78462: get rid of PythonInteger::GetInteger()

lawrence_danna updated this revision to Diff 259916. lawrence_danna added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78462/new/ https://reviews.llvm.org/D78462 Files: lldb/bindings/python/python-typemaps.swig lldb/binding

Re: [Lldb-commits] [PATCH] D78807: Fix gendered documentation

A lot of our comments and documentation was written a while ago when the “good” practice was to be careful to use “he” and “she” in equal measure when referring to our users. The consensus has shifted to using “they” instead, so there are probably a bunch of other places using he and she. Plea

[Lldb-commits] [PATCH] D78807: Fix gendered documentation

JDevlieghere accepted this revision. JDevlieghere added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78807/new/ https://reviews.llvm.org/D78807 ___ lldb-commits mailing list lldb

[Lldb-commits] [lldb] 1fcd234 - [lldb/Core] Don't crash in GetSoftwareBreakpointTrapOpcode for unknown triples

Author: Jonas Devlieghere Date: 2020-04-24T09:10:41-07:00 New Revision: 1fcd234ac54a0bb9dcb14338db5a336d80321662 URL: https://github.com/llvm/llvm-project/commit/1fcd234ac54a0bb9dcb14338db5a336d80321662 DIFF: https://github.com/llvm/llvm-project/commit/1fcd234ac54a0bb9dcb14338db5a336d80321662.d

[Lldb-commits] [PATCH] D78588: [lldb/Core] Don't crash in GetSoftwareBreakpointTrapOpcode for unknown triples

This revision was automatically updated to reflect the committed changes. Closed by commit rG1fcd234ac54a: [lldb/Core] Don't crash in GetSoftwareBreakpointTrapOpcode for unknown triples (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D78333: Add Objective-C property accessors loaded from Clang module DWARF to lookup

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. So it seems there aren't any alternative solutions that are less invasive, so I think this can go in. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.

[Lldb-commits] [PATCH] D78697: [lldb][TypeSystemClang] Desugar an elaborated type before checking if it's a typedef or getting a typedefed type

labath added a comment. In D78697#2001751 , @aleksandr.urakov wrote: > The problem here is that in the case of success `GetCString()` returns > `nullptr`, and we fail on concatenation with `None` even if the expression > was evaluated successfully. Yo

[Lldb-commits] [PATCH] D78697: [lldb][TypeSystemClang] Desugar an elaborated type before checking if it's a typedef or getting a typedefed type

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. In D78697#2001751 , @aleksandr.urakov wrote: > The problem here is that in the case of success `GetCString()` returns > `nullptr`, and we fail o

[Lldb-commits] [PATCH] D78807: Fix gendered documentation

sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78807/new/ https://reviews.llvm.org/D78807 __

[Lldb-commits] [PATCH] D78697: [lldb][TypeSystemClang] Desugar an elaborated type before checking if it's a typedef or getting a typedefed type

aleksandr.urakov added a comment. The problem here is that in the case of success `GetCString()` returns `nullptr`, and we fail on concatenation with `None` even if the expression was evaluated successfully. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D78801: [LLDB] Add class ProcessWasm for WebAssembly debugging

labath added a comment. Before we get into the details of this patch (with all the criss-cross friends and dependencies there's a lot to talk about there too), could you give an overview of how do you imagine this working as a whole, and why it is necessary to create these new classes. Having s

[Lldb-commits] [PATCH] D73206: Pass `CompileUnit *` along `DWARFDIE` for DWZ

jankratochvil added a comment. @labath now with existing callbacks llvm::function_ref callback I am going to add `DWARFCompileUnit *main_unit` somewhere. BTW it can be `nullptr`, for example for DIES from type units. In my WIP patches I was putting it in front (as `main_unit` sort of contain

[Lldb-commits] [PATCH] D78697: [lldb][TypeSystemClang] Desugar an elaborated type before checking if it's a typedef or getting a typedefed type

teemperor added a comment. In D78697#2001682 , @aleksandr.urakov wrote: > Thanks! Fixed. The only thing is that `GetCString()` can return `nullptr`, > which leads to `None` in Python, so I made a simple wrapper for that. I think GetCString should alway

[Lldb-commits] [PATCH] D78807: Fix gendered documentation

pedro.gonnet created this revision. pedro.gonnet added reviewers: JDevlieghere, hokein. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. Changed two references to developers as "he" or "him" to the more neutral "they". Repository: rG LLVM Github Monorep

[Lldb-commits] [PATCH] D78697: [lldb][TypeSystemClang] Desugar an elaborated type before checking if it's a typedef or getting a typedefed type

aleksandr.urakov updated this revision to Diff 259864. aleksandr.urakov added a comment. Thanks! Fixed. The only thing is that `GetCString()` can return `nullptr`, which leads to `None` in Python, so I made a simple wrapper for that. I'm not very deep into the testing infrastructure, so I'm not

[Lldb-commits] [PATCH] D78712: [lldb/Host] Improve error messages on unowned read files

labath added a comment. I'm not very fond of this reverse engineering of the checks that os performs when opening a file (this is not the only place doing it). Could we just make sure that the operation for opening a file returns a reasonable error message, and then do something like Status

[Lldb-commits] [PATCH] D78462: get rid of PythonInteger::GetInteger()

labath accepted this revision. labath added a comment. Still looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78462/new/ https://reviews.llvm.org/D78462 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D78588: [lldb/Core] Don't crash in GetSoftwareBreakpointTrapOpcode for unknown triples

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This makes sense to me. (If we are able to reach this deep into the code with an invalid archspec by just issuing (sb or cli) commands, it sounds like there should be some check (and a bail o

[Lldb-commits] [PATCH] D78697: [lldb][TypeSystemClang] Desugar an elaborated type before checking if it's a typedef or getting a typedefed type

labath added inline comments. Comment at: lldb/test/API/lang/cpp/typedef/TestCppTypedef.py:33 +expr_result = frame.EvaluateExpression("(SF)s") +self.assertTrue(expr_result.IsValid(), "Can't evaluate an expression with result type `SF`") + teemper

[Lldb-commits] [PATCH] D78801: [LLDB] Add class ProcessWasm for WebAssembly debugging

paolosev created this revision. paolosev added reviewers: clayborg, labath. paolosev added a project: LLDB. Herald added subscribers: lldb-commits, sunfish, aheejin, jgravelle-google, sbc100, aprantl, mgorny. paolosev marked 2 inline comments as done. paolosev added a comment. What is the best wa

[Lldb-commits] [PATCH] D78801: [LLDB] Add class ProcessWasm for WebAssembly debugging

paolosev marked 2 inline comments as done. paolosev added a comment. What is the best way to test classes WasmProcessGDBRemote and UnwindWasm? Comment at: lldb/source/Plugins/Process/wasm/ProcessWasm.cpp:92 +size_t buffer_size, size_t &si