[Lldb-commits] [PATCH] D79120: [lldb/API] Add RunCommandInterpreter overload that returns SBCommandInterpreterRunResults (NFC)

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Sorry, missed the fact that the new class had ivars. For ABI stability, we can't modify the number of ivars since we need the class size of SBCommandInterpreterRunResults to

[Lldb-commits] [PATCH] D79120: [lldb/API] Add RunCommandInterpreter overload that returns SBCommandInterpreterRunResults (NFC)

clayborg added inline comments. Comment at: lldb/include/lldb/API/SBCommandInterpreterRunOptions.h:93 + bool m_stopped_for_crash; +}; + like how SBCommandInterpreterRunOptions does it above with its ivar "m_opaque_up" that never changes size Repository:

[Lldb-commits] [PATCH] D79120: [lldb/API] Add RunCommandInterpreter overload that returns SBCommandInterpreterRunResults (NFC)

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Yeah, anytime you see API calls that have many arguments it is a good idea to switch to this kind of API as adding accessors doesn't require us to change the API. We did this with

[Lldb-commits] [PATCH] D79147: [WIP] Merge -debug-info-kind=constructor into -debug-info-kind=limited

akhuang created this revision. Herald added subscribers: lldb-commits, cfe-commits, aprantl. Herald added projects: clang, LLDB. There will be an RFC for this in cfe-dev. This reduces the amount of class debug info emitted in Limited debug info mode. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D78972: Treat hasWeakODRLinkage symbols as external in REPL computations

jingham added a comment. In D78972#2010033 , @labath wrote: > In D78972#2008129 , @jingham wrote: > > > In D78972#2007493 , @labath wrote: > > > > > > I don't have a way to

[Lldb-commits] [PATCH] D78801: [LLDB] Add class ProcessWasm for WebAssembly debugging

clayborg added a comment. Sounds like we have an approach to try! I would like to see solutions that are not WASM specific when possible. One other way of doing the memory read/write with segments: maybe the "m" and "M" packets can be overloaded include the memory segment identifier if the

[Lldb-commits] [PATCH] D78801: [LLDB] Add class ProcessWasm for WebAssembly debugging

clayborg added a comment. In D78801#2009917 , @labath wrote: > In D78801#2009048 , @clayborg wrote: > > > In D78801#2007795 , @labath wrote: > > > > > While that idea has

[Lldb-commits] [PATCH] D78825: [lldb/Driver] Exit with a non-zero exit code in batch mode when stopping because of an error.

JDevlieghere updated this revision to Diff 261006. JDevlieghere added a comment. Use `SBCommandInterpreterRunResults` Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78825/new/ https://reviews.llvm.org/D78825 Files:

[Lldb-commits] [PATCH] D79120: [lldb/API] Add RunCommandInterpreter overload that returns SBCommandInterpreterRunResults (NFC)

JDevlieghere created this revision. JDevlieghere added reviewers: clayborg, labath. JDevlieghere added a parent revision: D79115: [lldb/API] Move SBCommandInterpreterRunOption in its own header. (NFC). JDevlieghere added a child revision: D78825: [lldb/Driver] Exit with a non-zero exit code in

[Lldb-commits] [PATCH] D79115: [lldb/API] Move SBCommandInterpreterRunOption in its own header. (NFC)

JDevlieghere created this revision. JDevlieghere added reviewers: clayborg, labath. Herald added a subscriber: mgorny. JDevlieghere added a parent revision: D79108: [lldb/CommandInterpreter] Move AutoHandleEvents and SpawnThread into CommandInterpreterRunOptions (NFC). Currently,

[Lldb-commits] [PATCH] D79108: [lldb/CommandInterpreter] Move AutoHandleEvents and SpawnThread into CommandInterpreterRunOptions (NFC)

JDevlieghere updated this revision to Diff 260978. JDevlieghere added a comment. Add reproducer instrumentation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79108/new/ https://reviews.llvm.org/D79108 Files: lldb/include/lldb/API/SBCommandInterpreter.h

[Lldb-commits] [PATCH] D78801: [LLDB] Add class ProcessWasm for WebAssembly debugging

paolosev added a comment. Also, to eliminate `qWasmCallStack` we could maybe add the call stack (a list of PCs) to the stop packet. The format of a stop packet is: T AA n1:r1;n2:r2;… The program received signal number AA (a two-digit hexadecimal number). [...] Each ‘n:r’ pair is

[Lldb-commits] [PATCH] D79108: [lldb/CommandInterpreter] Move AutoHandleEvents and SpawnThread into CommandInterpreterRunOptions (NFC)

JDevlieghere created this revision. JDevlieghere added reviewers: clayborg, labath, vsk. This implements Greg's suggestion from D78825 to include AutoHandleEvents and SpawnThread in CommandInterpreterRunOptions. This is in preparation for adding a new overload

[Lldb-commits] [PATCH] D78801: [LLDB] Add class ProcessWasm for WebAssembly debugging

paolosev added a comment. In D78801#2010536 , @ted wrote: > Hi Paulo, > @clayborg asked me to look at this, because I've worked with systems that > have multiple address spaces. I was thinking, instead of a WebAssembly > specific memory read, we should

[Lldb-commits] [lldb] 613d866 - [lldb] Remove a redundant semicolon, fixing GCC warnings. NFC.

Author: Martin Storsjö Date: 2020-04-29T21:00:43+03:00 New Revision: 613d86637434182adb4f2a1f629a2ec94d02b569 URL: https://github.com/llvm/llvm-project/commit/613d86637434182adb4f2a1f629a2ec94d02b569 DIFF:

[Lldb-commits] [PATCH] D78801: [LLDB] Add class ProcessWasm for WebAssembly debugging

ted added a comment. Hi Paulo, @clayborg asked me to look at this, because I've worked with systems that have multiple address spaces. I was thinking, instead of a WebAssembly specific memory read, we should implement an optional generic memory read and write with memory space support. So

[Lldb-commits] [PATCH] D78801: [LLDB] Add class ProcessWasm for WebAssembly debugging

paolosev added a comment. In D78801#2009856 , @labath wrote: > What if the wasm engine actually made some effort to present a more > "conventional" view of the wasm "process"? I.e., in addition to the "implied" > PC, we could have an "implied" SP (and

[Lldb-commits] [lldb] 2cf6968 - [lldb/DWARF] Fix a split-dwarf crash while parsing compile units

Author: Pavel Labath Date: 2020-04-29T16:21:11+02:00 New Revision: 2cf69684fb3089a2cde46fc9eac22dd6b8475b5f URL: https://github.com/llvm/llvm-project/commit/2cf69684fb3089a2cde46fc9eac22dd6b8475b5f DIFF: https://github.com/llvm/llvm-project/commit/2cf69684fb3089a2cde46fc9eac22dd6b8475b5f.diff

[Lldb-commits] [PATCH] D78972: Treat hasWeakODRLinkage symbols as external in REPL computations

labath added a comment. In D78972#2008129 , @jingham wrote: > In D78972#2007493 , @labath wrote: > > > > I don't have a way to write a C-based test for this as I don't know how > > > to craft a user expression in

[Lldb-commits] [PATCH] D78825: [lldb/Driver] Exit with a non-zero exit code in batch mode when stopping because of an error.

labath added a comment. (I made this comment yesterday, but it seems I didn't click send) Comment at: lldb/source/API/SBDebugger.cpp:1205-1209 options.ref()); num_errors = interp.GetNumErrors(); quit_requested =

[Lldb-commits] [PATCH] D78801: [LLDB] Add class ProcessWasm for WebAssembly debugging

labath added a comment. In D78801#2009048 , @clayborg wrote: > In D78801#2007795 , @labath wrote: > > > While that idea has occurred to me too, I am not convinced it is a good one: > > > > - it replaces one odd

[Lldb-commits] [PATCH] D78801: [LLDB] Add class ProcessWasm for WebAssembly debugging

labath added a comment. What if the wasm engine actually made some effort to present a more "conventional" view of the wasm "process"? I.e., in addition to the "implied" PC, we could have an "implied" SP (and maybe an FP too). Then it could lay out the call stack and the function arguments in

[Lldb-commits] [PATCH] D78712: [lldb/Host] Improve error messages on unowned read files

labath added a comment. Yes, this is definitely better. Comment at: lldb/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp:187 if (error.Fail() || !exe_module_sp) { -if (FileSystem::Instance().Readable( -resolved_module_spec.GetFileSpec())) { +

[Lldb-commits] [lldb] bb7bde5 - Revert "[lldb/Platform] Return a std::string from GetSDKPath"

Author: Jonas Devlieghere Date: 2020-04-29T01:26:24-07:00 New Revision: bb7bde5bba579a0521ed5b9a7b8a69465928986e URL: https://github.com/llvm/llvm-project/commit/bb7bde5bba579a0521ed5b9a7b8a69465928986e DIFF: