[Lldb-commits] [PATCH] D79273: Add an explicit API to read the Xcode SDK DWARF attribute from compile units

aprantl updated this revision to Diff 261603. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79273/new/ https://reviews.llvm.org/D79273 Files: lldb/include/lldb/Core/Module.h lldb/include/lldb/Symbol/SymbolFile.h lldb/source/Core/Module.cpp lldb/source/Plugins/SymbolFile/DWARF/Sym

[Lldb-commits] [PATCH] D79120: [lldb/API] Add RunCommandInterpreter overload that returns SBCommandInterpreterRunResults (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c67b11918d5: [lldb/API] Add SBCommandInterpreterRunResult (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D79120?vs=261382&id=261587#toc Rep

[Lldb-commits] [PATCH] D79209: [lldb/CommandInterpreter] Add CommandInterpreterRunResult (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG1bff0928f52b: [lldb/CommandInterpreter] Add CommandInterpreterRunResult (NFC) (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D79209?vs=261361

[Lldb-commits] [PATCH] D79273: Add an explicit API to read the Xcode SDK DWARF attribute from compile units

aprantl updated this revision to Diff 261573. aprantl added a comment. Delete more code that is made obsolete by the new API. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79273/new/ https://reviews.llvm.org/D79273 Files: lldb/include/lldb/Symbol/SymbolFile.h lldb/source/Core/Modul

[Lldb-commits] [PATCH] D79273: Add an explicit API to read the Xcode SDK DWARF attribute from compile units

aprantl created this revision. aprantl added reviewers: friss, jingham, JDevlieghere, davide. Herald added a reviewer: jdoerfert. aprantl updated this revision to Diff 261573. aprantl added a comment. Delete more code that is made obsolete by the new API. When debugging from a SymbolMap the crea

[Lldb-commits] [PATCH] D77843: [lldb/DataFormatters] Delete GetStringPrinterEscapingHelper

vsk marked 4 inline comments as done. vsk added inline comments. Comment at: lldb/source/DataFormatters/StringPrinter.cpp:268 case GetPrintableElementType::UTF8: -return [](uint8_t *buffer, uint8_t *buffer_end, - uint8_t *&next) -> StringPrinter::StringPrinter

[Lldb-commits] [PATCH] D77843: [lldb/DataFormatters] Delete GetStringPrinterEscapingHelper

vsk updated this revision to Diff 261558. vsk marked an inline comment as done. vsk added a comment. Address review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77843/new/ https://reviews.llvm.org/D77843 Files: lldb/include/lldb/DataFo

[Lldb-commits] [PATCH] D77843: [lldb/DataFormatters] Delete GetStringPrinterEscapingHelper

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM with minor comments, this is a big set of changes, I would prefer if one of the other reviewers also gave it a second look. Comment at: lldb/source/DataFormatters/Strin

[Lldb-commits] [PATCH] D78825: [lldb/Driver] Exit with a non-zero exit code in batch mode when stopping because of an error.

JDevlieghere added a comment. Greg, you requested changes to this revision, I guess because of the dependencies. Anything here you'd like to see changed? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78825/new/ https://reviews.llvm.org/D78825 __

[Lldb-commits] [PATCH] D79251: Fix overloaded operator new cases in TestCppOperators.py which currently work by accident

shafik created this revision. shafik added reviewers: teemperor, aprantl, labath. The overloaded `new operator` in `TestCppOperators.py` are working by accident. Currently we have: void *operator new(std::size_t size) { C* r = ::new C; r->custom_new = true; return r; } void *operator new[](

[Lldb-commits] [PATCH] D78712: [lldb/Host] Improve error messages on unowned read files

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78712/new/ https://reviews.llvm.org/D78712 __

[Lldb-commits] [lldb] 30ddd4c - [ARM64] Remove more dead code. NFC.

Author: Davide Italiano Date: 2020-05-01T15:05:42-07:00 New Revision: 30ddd4ce19316fd2a8a50c5bc511433c87ecb95c URL: https://github.com/llvm/llvm-project/commit/30ddd4ce19316fd2a8a50c5bc511433c87ecb95c DIFF: https://github.com/llvm/llvm-project/commit/30ddd4ce19316fd2a8a50c5bc511433c87ecb95c.dif

[Lldb-commits] [lldb] 68f8e02 - [ARM64] Remove dead code.

Author: Davide Italiano Date: 2020-05-01T15:04:44-07:00 New Revision: 68f8e0264e297bf7abadb1ca3850949606bdb4f5 URL: https://github.com/llvm/llvm-project/commit/68f8e0264e297bf7abadb1ca3850949606bdb4f5 DIFF: https://github.com/llvm/llvm-project/commit/68f8e0264e297bf7abadb1ca3850949606bdb4f5.dif

[Lldb-commits] [lldb] 4c67b11 - [lldb/API] Add SBCommandInterpreterRunResult

Author: Jonas Devlieghere Date: 2020-05-01T13:55:38-07:00 New Revision: 4c67b11918d5cc819ebf965004abbdd7f281a652 URL: https://github.com/llvm/llvm-project/commit/4c67b11918d5cc819ebf965004abbdd7f281a652 DIFF: https://github.com/llvm/llvm-project/commit/4c67b11918d5cc819ebf965004abbdd7f281a652.d

[Lldb-commits] [lldb] 232ef38 - [lldb/CommandInterpreter] Fix typo in CommandInterpreterResult::IsResult

Author: Jonas Devlieghere Date: 2020-05-01T12:07:21-07:00 New Revision: 232ef38713b984cc84d2a009e83c1b044f0c06d3 URL: https://github.com/llvm/llvm-project/commit/232ef38713b984cc84d2a009e83c1b044f0c06d3 DIFF: https://github.com/llvm/llvm-project/commit/232ef38713b984cc84d2a009e83c1b044f0c06d3.d

[Lldb-commits] [lldb] 1bff092 - [lldb/CommandInterpreter] Add CommandInterpreterRunResult (NFC)

Author: Jonas Devlieghere Date: 2020-05-01T11:29:28-07:00 New Revision: 1bff0928f52b3d6602bae085c9590a1d807c2910 URL: https://github.com/llvm/llvm-project/commit/1bff0928f52b3d6602bae085c9590a1d807c2910 DIFF: https://github.com/llvm/llvm-project/commit/1bff0928f52b3d6602bae085c9590a1d807c2910.d

[Lldb-commits] [PATCH] D78801: [LLDB] Add class ProcessWasm for WebAssembly debugging

paolosev added a comment. > The thing I am resisting is to put all of this stuff in the the > ProcessGDBRemote class. Instead of trying to generalize it so that it can > handle everything (and generalize to the wrong thing), I very much like the > idea of introducing a `WasmProcess` plugin clas