[Lldb-commits] [PATCH] D79614: Fix error reporting for qLaunchSuccess, check for fix/enable it via qSupported

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG2b8b783b1ab4: Quote error string from qLaunchSuccess (authored by jasonmolenda). Changed prior to commit:

[Lldb-commits] [lldb] 2b8b783 - Quote error string from qLaunchSuccess

Author: Jason Molenda Date: 2020-05-11T20:05:57-07:00 New Revision: 2b8b783b1ab4a2388d5d80136221729871f65a32 URL: https://github.com/llvm/llvm-project/commit/2b8b783b1ab4a2388d5d80136221729871f65a32 DIFF: https://github.com/llvm/llvm-project/commit/2b8b783b1ab4a2388d5d80136221729871f65a32.diff

[Lldb-commits] [PATCH] D79654: [lldb/Driver] Support terminal resizing

friss added a comment. In D79654#2030635 , @friss wrote: > > If we wanted to avoid delaying the change to the next keystroke, we could > > reuse the same mechanism that ^C/SIGINT uses > > (`m_input_connection.InterruptRead()`). That would probably

[Lldb-commits] [PATCH] D79614: Fix error reporting for qLaunchSuccess, check for fix/enable it via qSupported

jasonmolenda added a comment. Thanks for the feedback. In D79614#2029157 , @labath wrote: > I think that "piggy-backing" on the `qSupported` packet for communicating > protocol fixes is a good idea. However, I agree with Greg, that it does not > seem

[Lldb-commits] [PATCH] D79654: [lldb/Driver] Support terminal resizing

friss updated this revision to Diff 263331. friss added a comment. Herald added a subscriber: jfb. Use sig_atomic_t as Pavel suggested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79654/new/ https://reviews.llvm.org/D79654 Files:

[Lldb-commits] [PATCH] D79654: [lldb/Driver] Support terminal resizing

friss added a comment. In D79654#2029131 , @labath wrote: > Yes, resizing the window (or doing any other nontrivial task) from within a > signal handler is a bad idea. Making a note of the signal and then bailing > out is the right approach. Though, to

[Lldb-commits] [PATCH] D79757: Try IPv4 before IPv6 when creating TCP connection

emrekultursay updated this revision to Diff 263327. emrekultursay added a comment. Update commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79757/new/ https://reviews.llvm.org/D79757 Files: lldb/source/Host/common/TCPSocket.cpp

[Lldb-commits] [PATCH] D79491: [lldb] Revive TestBasicEntryValuesX86_64

dblaikie added a comment. @vsk (assuming you're the original author of this test - couldn't quite figure out the revision history, sorry) - could you check if some of this could be simplified a bit to make it more clear what's being tested/what's "interesting" here? (I've provided some inline

[Lldb-commits] [PATCH] D79757: Try IPv4 before IPv6 when creating TCP connection

emrekultursay created this revision. Herald added subscribers: lldb-commits, mgrang. Herald added a project: LLDB. When connecting to Android, LLDB calls adb#Shell 5 times. At each call, a TCP connection to "localhost:port" needs to be established. On hosts that support IPv4 and IPv6, the

[Lldb-commits] [PATCH] D79752: [lldb] Move ClangModulesDeclVendor ownership to ClangPersistentVariables

xiaobai created this revision. xiaobai added reviewers: teemperor, labath, JDevlieghere. Herald added subscribers: yaxunl, mgorny. Herald added a project: LLDB. This is another step in moving plugin dependencies out of non-plugins. Target doesn't need to know about this, and

[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

aadsm updated this revision to Diff 263299. aadsm added a comment. Rebase and remove unwanted debug code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79726/new/ https://reviews.llvm.org/D79726 Files:

[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

aadsm marked 2 inline comments as done. aadsm added a comment. I chose the name terminate because this happens just before the `terminated` event is sent back to the client. Comment at: lldb/test/API/tools/lldb-vscode/attach/TestVSCode_attach.py:49-67 +@skipIfDarwin

[Lldb-commits] [lldb] 8d7796c - Fix a few clang-tidy warnings about auto * and const auto.

Author: Eric Christopher Date: 2020-05-11T15:33:17-07:00 New Revision: 8d7796cf9427a0c361a5831e4371ff030b98dfac URL: https://github.com/llvm/llvm-project/commit/8d7796cf9427a0c361a5831e4371ff030b98dfac DIFF:

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek updated this revision to Diff 263288. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D79219 Files: clang/CMakeLists.txt clang/test/CMakeLists.txt clang/test/lit.site.cfg.py.in compiler-rt/test/lit.common.configured.in

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek added a comment. In D79219#2029520 , @JDevlieghere wrote: > I'm in favor of this change. I'm not too happy with how this works in CMake, > I've expressed similar concerns when the FORCE_ON approach was suggested in > D71306

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

JDevlieghere added inline comments. Comment at: llvm/cmake/config-ix.cmake:514 + if(ZLIB_FOUND) +set(LLVM_ENABLE_ZLIB "YES" CACHE STRING + "Use zlib for compression/decompression if available. Can be ON, OFF, or FORCE_ON" phosek wrote: > JDevlieghere

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek updated this revision to Diff 263284. phosek marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D79219 Files: clang/CMakeLists.txt clang/test/CMakeLists.txt clang/test/lit.site.cfg.py.in

[Lldb-commits] [PATCH] D79646: [Reproducers] Serialize process arguments in ProcessInfo

JDevlieghere updated this revision to Diff 263287. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. - Serialize Args::ArgEntry - Add unit test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79646/new/ https://reviews.llvm.org/D79646 Files:

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

JDevlieghere added a comment. I'm in favor of this change. I'm not too happy with how this works in CMake, I've expressed similar concerns when the FORCE_ON approach was suggested in D71306 . I really like what we ended up with in LLDB. The TL;DR is that we

[Lldb-commits] [lldb] cd7cb1f - Update lldb for rG10658691951f to avoid Werror messages around

Author: Eric Christopher Date: 2020-05-11T13:45:21-07:00 New Revision: cd7cb1f4ce3ffc8be1146eeba28ae7dc50089459 URL: https://github.com/llvm/llvm-project/commit/cd7cb1f4ce3ffc8be1146eeba28ae7dc50089459 DIFF:

[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

wallace added a comment. I don't know if terminate is the best name, as it could seem related to the inferior. What about finalize? It reminds me of the try/catch/finalize words, and it's harder to associate it with the inferior's own exit event. Comment at:

[Lldb-commits] [PATCH] D79666: Complete breakpoint enable/disable/delete/modify with a list of breakpoint IDs

jingham added a comment. This is great, but you can also specify breakpoints by name. Should be possible to also complete on the list of breakpoint names. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79666/new/ https://reviews.llvm.org/D79666

[Lldb-commits] [PATCH] D79645: [lldb/test] Fix for flakiness in TestNSDictionarySynthetic

This revision was automatically updated to reflect the committed changes. vsk marked an inline comment as done. Closed by commit rGf807d0b4acdb: [lldb/test] Fix for flakiness in TestNSDictionarySynthetic (authored by vsk). Changed prior to commit:

[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

aadsm created this revision. aadsm added reviewers: clayborg, wallace. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. aadsm updated this revision to Diff 263206. aadsm added a comment. Remove debugging leftovers Adding this in line with "stopCommands" and "exitCommands"

[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

aadsm updated this revision to Diff 263206. aadsm added a comment. Remove debugging leftovers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79726/new/ https://reviews.llvm.org/D79726 Files:

[Lldb-commits] [lldb] f807d0b - [lldb/test] Fix for flakiness in TestNSDictionarySynthetic

Author: Vedant Kumar Date: 2020-05-11T09:53:48-07:00 New Revision: f807d0b4acdb70c5a15919f6e9b02d8b212d1088 URL: https://github.com/llvm/llvm-project/commit/f807d0b4acdb70c5a15919f6e9b02d8b212d1088 DIFF: https://github.com/llvm/llvm-project/commit/f807d0b4acdb70c5a15919f6e9b02d8b212d1088.diff

[Lldb-commits] [PATCH] D79659: [lldb/Commands] Add ability to run shell command on the host.

mib marked an inline comment as done. mib added inline comments. Comment at: lldb/source/Commands/CommandObjectPlatform.cpp:1625 +// When called from the `shell` alias with no argument, exit. +if (args.GetRawPart().empty()) JDevlieghere wrote: > Is

[Lldb-commits] [PATCH] D79563: [lldb/test] Make "inline" tests handle multiple statements at the same location

labath added a comment. In D79563#2024854 , @teemperor wrote: > Changing might actually be a better idea as this way we at least know this > isn't crashing. Ok, I'll change the expectation then. Comment at:

[Lldb-commits] [lldb] caa2408 - [lldb] Speculative fix for the entry values test on arm64

Author: Pavel Labath Date: 2020-05-11T17:54:34+02:00 New Revision: caa2408cbe0a21e175cb287795d283ec4196cdee URL: https://github.com/llvm/llvm-project/commit/caa2408cbe0a21e175cb287795d283ec4196cdee DIFF: https://github.com/llvm/llvm-project/commit/caa2408cbe0a21e175cb287795d283ec4196cdee.diff

[Lldb-commits] [PATCH] D79563: [lldb/test] Make "inline" tests handle multiple statements at the same location

This revision was automatically updated to reflect the committed changes. labath marked an inline comment as done. Closed by commit rGba898282bc20: [lldb/test] Make inline tests handle multiple statements at the same location (authored by labath). Changed prior to commit:

[Lldb-commits] [PATCH] D79491: [lldb] Revive TestBasicEntryValuesX86_64

This revision was automatically updated to reflect the committed changes. Closed by commit rGa5c23179826a: [lldb] Revive TestBasicEntryValuesX86_64 (authored by labath). Changed prior to commit: https://reviews.llvm.org/D79491?vs=262595=263176#toc Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] ba89828 - [lldb/test] Make "inline" tests handle multiple statements at the same location

Author: Pavel Labath Date: 2020-05-11T16:37:34+02:00 New Revision: ba898282bc204f78016c2e7779dc5cde37e10fd1 URL: https://github.com/llvm/llvm-project/commit/ba898282bc204f78016c2e7779dc5cde37e10fd1 DIFF: https://github.com/llvm/llvm-project/commit/ba898282bc204f78016c2e7779dc5cde37e10fd1.diff

[Lldb-commits] [lldb] a5c2317 - [lldb] Revive TestBasicEntryValuesX86_64

Author: Pavel Labath Date: 2020-05-11T16:31:02+02:00 New Revision: a5c23179826a6dc4f26a4f3fcda66290bc04a201 URL: https://github.com/llvm/llvm-project/commit/a5c23179826a6dc4f26a4f3fcda66290bc04a201 DIFF: https://github.com/llvm/llvm-project/commit/a5c23179826a6dc4f26a4f3fcda66290bc04a201.diff

[Lldb-commits] [PATCH] D78798: [lldb] Add missing nullptr checks to AppleObjCRuntime::GetBacktraceThreadFromException

This revision was automatically updated to reflect the committed changes. Closed by commit rGf8af9f5fca7d: [lldb] Add missing nullptr checks to AppleObjCRuntime… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D79491: [lldb] Revive TestBasicEntryValuesX86_64

labath marked an inline comment as done. labath added a comment. In D79491#2024849 , @djtodoro wrote: > I see.. Enabling it only for specific OSes could be a temp solution, but we > can discuss about that. > > > A different way to address this would be

[Lldb-commits] [PATCH] D79559: [lldb] Also recognize DWARF UTF base types using their size

labath added a comment. The running aspect is somewhat unfortunate, as it forces the input to be compatible with the host system. I wouldn't be surprised if the test broke somewhere (in fact, I would be surprised if it didn't), because ir already hardcodes a lot of assumptions about the host

[Lldb-commits] [lldb] f8af9f5 - [lldb] Add missing nullptr checks to AppleObjCRuntime::GetBacktraceThreadFromException

Author: Raphael Isemann Date: 2020-05-11T16:02:51+02:00 New Revision: f8af9f5fca7dac5479a43837daa3e2bd897b00b7 URL: https://github.com/llvm/llvm-project/commit/f8af9f5fca7dac5479a43837daa3e2bd897b00b7 DIFF:

[Lldb-commits] [PATCH] D79686: Tab completion for breakpoint write and breakpoint name add/delete

This revision was automatically updated to reflect the committed changes. Closed by commit rGe87362e6894e: Tab completion for breakpoint write and breakpoint name add/delete (authored by MrHate, committed by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github

[Lldb-commits] [lldb] e87362e - Tab completion for breakpoint write and breakpoint name add/delete

Author: Gongyu Deng Date: 2020-05-11T15:55:11+02:00 New Revision: e87362e6894e052456c645129ac570f6bc23e8d1 URL: https://github.com/llvm/llvm-project/commit/e87362e6894e052456c645129ac570f6bc23e8d1 DIFF: https://github.com/llvm/llvm-project/commit/e87362e6894e052456c645129ac570f6bc23e8d1.diff

[Lldb-commits] [PATCH] D79554: [lldb/Dataformatter] Add support to CF{Dictionary, Set}Ref types

labath added a comment. In D79554#2026999 , @teemperor wrote: > I don't see a huge problem with things like `__lldb_autogen_nspair` as it's a > single obviously generated type hardcoded into LLDB. But this really generic > approach here can generate all

[Lldb-commits] [PATCH] D79666: Complete breakpoint enable/disable/delete/modify with a list of breakpoint IDs

This revision was automatically updated to reflect the committed changes. Closed by commit rG0e50b9a43bf6: Complete breakpoint enable/disable/delete/modify with a list of breakpoint IDs (authored by MrHate, committed by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM

[Lldb-commits] [lldb] 0e50b9a - Complete breakpoint enable/disable/delete/modify with a list of breakpoint IDs

Author: Gongyu Deng Date: 2020-05-11T15:21:51+02:00 New Revision: 0e50b9a43bf65714cc6669203aeb1c175878a7da URL: https://github.com/llvm/llvm-project/commit/0e50b9a43bf65714cc6669203aeb1c175878a7da DIFF: https://github.com/llvm/llvm-project/commit/0e50b9a43bf65714cc6669203aeb1c175878a7da.diff

[Lldb-commits] [PATCH] D79614: Fix error reporting for qLaunchSuccess, check for fix/enable it via qSupported

labath added a comment. I think that "piggy-backing" on the `qSupported` packet for communicating protocol fixes is a good idea. However, I agree with Greg, that it does not seem like it's needed for this case. Fixing the problem purely on the debugserver side seems preferable, as it avoids

[Lldb-commits] [PATCH] D79654: [lldb/Driver] Support terminal resizing

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Yes, resizing the window (or doing any other nontrivial task) from within a signal handler is a bad idea. Making a note of the signal and then bailing out is the right approach. Though, to be

[Lldb-commits] [PATCH] D79646: [Reproducers] Serialize process arguments in ProcessInfo

labath added inline comments. Comment at: lldb/source/Utility/Args.cpp:691 + std::string str; + Val.GetCommandString(str); + Out << str; The `GetCommandString` -> `SetCommandString` roundtrip is very lossy (mainly because of the `Get` part). That may be

[Lldb-commits] [PATCH] D79586: Do not list adb devices when a device id is given

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79586/new/ https://reviews.llvm.org/D79586

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and ptrace support

omjavaid updated this revision to Diff 263106. omjavaid added a comment. This patch now contains AArch64 SVE register infos description and support for core dump SVE register access. Linux ptrace support will be submitted in a follow up patch while linux ptrace headers are being submitted by

[Lldb-commits] [PATCH] D77045: Minor fixups to LLDB AArch64 register infos macros for SVE register infos

omjavaid updated this revision to Diff 263105. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77045/new/ https://reviews.llvm.org/D77045 Files: lldb/source/Plugins/Process/Utility/RegisterInfos_arm64.h Index: lldb/source/Plugins/Process/Utility/RegisterInfos_arm64.h

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

omjavaid created this revision. omjavaid added reviewers: labath, jasonmolenda, clayborg. Herald added subscribers: danielkiss, kristof.beyls, tschuett. Herald added a reviewer: rengolin. This patch adds NativeRegisterContext_arm64 ptrace routines to access AArch64 SVE registers. This patch also

[Lldb-commits] [PATCH] D77045: Minor fixups to LLDB AArch64 register infos macros for SVE register infos

omjavaid added a comment. In D77045#1966540 , @omjavaid wrote: > In D77045#1963896 , @labath wrote: > > > In D77045#1956879 , @omjavaid > > wrote: > > > > > Adding a

[Lldb-commits] [PATCH] D77043: Fix process gdb-remote usage of value_regs/invalidate_regs

omjavaid updated this revision to Diff 263107. omjavaid added a comment. @labath as per your suggestion I have implemented a solution where we fixup register index before sending them to the host in xml or registerinfos packet. Also two new helper functions are added which can be overriden by