[Lldb-commits] [PATCH] D79752: [lldb] Move ClangModulesDeclVendor ownership to ClangPersistentVariables

xiaobai updated this revision to Diff 266389. xiaobai added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79752/new/ https://reviews.llvm.org/D79752 Files: lldb/include/lldb/Target/Target.h

[Lldb-commits] [lldb] 40c4eca - [lldb/Docs] Add the application speicfic lldbinit to the man page

Author: Jonas Devlieghere Date: 2020-05-26T17:34:09-07:00 New Revision: 40c4ecabc238cfdd639bc1e927800337457e69e3 URL: https://github.com/llvm/llvm-project/commit/40c4ecabc238cfdd639bc1e927800337457e69e3 DIFF:

[Lldb-commits] [PATCH] D79823: [lldb][Core] Remove dead codepath in Mangled

jingham added a comment. Note that there is no guarantee that ObjC names won't be mangled. They aren't on macOS because the macOS linker grew up along with objC so all the weird characters it introduces into the symbol namespace ([,],-,+, ,etc...) are allowed. Way back in the day when

[Lldb-commits] [PATCH] D79823: [lldb][Core] Remove dead codepath in Mangled

This revision was automatically updated to reflect the committed changes. Closed by commit rG1079978b3c50: [lldb][Core] Remove dead codepath in Mangled (authored by xiaobai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79823/new/

[Lldb-commits] [lldb] 1079978 - [lldb][Core] Remove dead codepath in Mangled

Author: Alex Langford Date: 2020-05-26T17:12:20-07:00 New Revision: 1079978b3c506abca2b4dd9a5b131c024330206b URL: https://github.com/llvm/llvm-project/commit/1079978b3c506abca2b4dd9a5b131c024330206b DIFF: https://github.com/llvm/llvm-project/commit/1079978b3c506abca2b4dd9a5b131c024330206b.diff

[Lldb-commits] [lldb] e724db0 - [lldb/Test] Modify TestSymbolTable.py for reproducers

Author: Jonas Devlieghere Date: 2020-05-26T17:07:41-07:00 New Revision: e724db03752a0cd06a86153fea0d95e377f999c0 URL: https://github.com/llvm/llvm-project/commit/e724db03752a0cd06a86153fea0d95e377f999c0 DIFF:

[Lldb-commits] [PATCH] D80595: Also cache negative results in GetXcodeSDKPath (NFC)

aprantl created this revision. aprantl added reviewers: JDevlieghere, friss. This fixes a performance issue in the failure case. rdar://63547920 https://reviews.llvm.org/D80595 Files: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm Index:

[Lldb-commits] [lldb] 6e39379 - [DwarfExpression] Support entry values for indirect parameters

Author: Vedant Kumar Date: 2020-05-26T14:22:28-07:00 New Revision: 6e39379bbbe1d8aba658f638dfc42f0ba0cbb926 URL: https://github.com/llvm/llvm-project/commit/6e39379bbbe1d8aba658f638dfc42f0ba0cbb926 DIFF: https://github.com/llvm/llvm-project/commit/6e39379bbbe1d8aba658f638dfc42f0ba0cbb926.diff

[Lldb-commits] [lldb] 09de6e0 - Let @skipUnlessAddressSanitizer imply @skipIfAsan

Author: Adrian Prantl Date: 2020-05-26T13:51:08-07:00 New Revision: 09de6e0fbd0b6ca7fa8760ac3513be6a5a81 URL: https://github.com/llvm/llvm-project/commit/09de6e0fbd0b6ca7fa8760ac3513be6a5a81 DIFF: https://github.com/llvm/llvm-project/commit/09de6e0fbd0b6ca7fa8760ac3513be6a5a81.diff

[Lldb-commits] [PATCH] D80519: [lldb/DWARF] Add support for pre-standard GNU call site attributes

vsk added a comment. Also, I think it'd be good to enable most/all of the tests under test/API/functionalities/tail_call_frames under -ggdb along with this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80519/new/

[Lldb-commits] [lldb] e1d2cec - [lldb/Test] Cleanup TestSymbolTable.py (NFC)

Author: Jonas Devlieghere Date: 2020-05-26T13:17:43-07:00 New Revision: e1d2cecec5197af7104e4c50e6aed4313d512cda URL: https://github.com/llvm/llvm-project/commit/e1d2cecec5197af7104e4c50e6aed4313d512cda DIFF:

[Lldb-commits] [PATCH] D80345: [DwarfExpression] Support entry values for indirect parameters

djtodoro accepted this revision. djtodoro added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: llvm/test/DebugInfo/MIR/AArch64/dbgcall-site-indirect-param.mir:18 +# CHECK-NEXT: [0x, 0x0010): DW_OP_breg0 W0+0 +#

[Lldb-commits] [PATCH] D80519: [lldb/DWARF] Add support for pre-standard GNU call site attributes

vsk added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3740 + if (tail_call) +call_inst_pc = low_pc; + else I think this needs to be `call_inst_pc = low_pc - 1`, see

[Lldb-commits] [PATCH] D80518: [lldb] Make "inline" tests more configurable

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks, lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80518/new/ https://reviews.llvm.org/D80518

[Lldb-commits] [lldb] ae903f0 - [lldb/Test] Reinstate FoundationSymtabTestCase

Author: Jonas Devlieghere Date: 2020-05-26T12:14:42-07:00 New Revision: ae903f0313e481520eff8a13044070aca4d0b75d URL: https://github.com/llvm/llvm-project/commit/ae903f0313e481520eff8a13044070aca4d0b75d DIFF:

[Lldb-commits] [lldb] 713538b - Be more specific about auto * vs auto for po alias.

Author: Eric Christopher Date: 2020-05-26T11:59:09-07:00 New Revision: 713538b629e45e6236b5d60fd6b64d7b8669cd00 URL: https://github.com/llvm/llvm-project/commit/713538b629e45e6236b5d60fd6b64d7b8669cd00 DIFF:

[Lldb-commits] [PATCH] D80543: [lldb] Manual remove of DISALLOW_COPY_AND_ASSIGN def and one expansion

aprantl accepted this revision. aprantl added a comment. > I am all for this, because makes lldb code more consistent with llvm (llvm > used to have a LLVM_DELETED_FUNCTION macro, but it was removed as soon as > c++11 came into being). That argument makes sense to me. Repository: rG LLVM

[Lldb-commits] [PATCH] D80543: [lldb] Manual remove of DISALLOW_COPY_AND_ASSIGN def and one expansion

teemperor added a comment. In D80543#2054405 , @labath wrote: > I am all for this, because makes lldb code more consistent with llvm (llvm > used to have a LLVM_DELETED_FUNCTION macro, but it was removed as soon as > c++11 came into being). > > But

[Lldb-commits] [lldb] 8d31dd2 - [lldb/Reproducers] Skip remaining failing test in python_api subdir

Author: Jonas Devlieghere Date: 2020-05-26T11:23:52-07:00 New Revision: 8d31dd23ec2368d00b0668c3d01b1fd2ce4d621b URL: https://github.com/llvm/llvm-project/commit/8d31dd23ec2368d00b0668c3d01b1fd2ce4d621b DIFF:

[Lldb-commits] [lldb] d1f0a76 - [YAMLTraits] Remove char trait and serialize as uint8_t in lldb.

Author: Jonas Devlieghere Date: 2020-05-26T11:07:27-07:00 New Revision: d1f0a76b21975ba66ec2427c2d3ddb7ed1e63949 URL: https://github.com/llvm/llvm-project/commit/d1f0a76b21975ba66ec2427c2d3ddb7ed1e63949 DIFF:

[Lldb-commits] [PATCH] D78421: Fix out of sync source code/executable when debugging

n1tram1 added a comment. Passing a simple `Module &` sounds like an easy but I would also have to make `SourceManager::GetFile` take a `Module &`. There is one corner case, let's say file.c is being used by //Module A// and //Module B// (which are both shared libraries). If //file.c// is

[Lldb-commits] [PATCH] D80543: [lldb] Manual remove of DISALLOW_COPY_AND_ASSIGN def and one expansion

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I am all for this, because makes lldb code more consistent with llvm (llvm used to have a LLVM_DELETED_FUNCTION macro, but it was removed as soon as c++11 came into being). But please don't

[Lldb-commits] [PATCH] D80543: [lldb] Manual remove of DISALLOW_COPY_AND_ASSIGN def and one expansion

kwk abandoned this revision. kwk added a comment. Sorry, wrong revisions uploaded Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80543/new/ https://reviews.llvm.org/D80543 ___ lldb-commits mailing list

[Lldb-commits] [lldb] c34936d - [lldb] s/dyn_cast/isa

Author: Pavel Labath Date: 2020-05-26T09:21:54+02:00 New Revision: c34936dae734085c4bc01703da0f5b7456e1bf51 URL: https://github.com/llvm/llvm-project/commit/c34936dae734085c4bc01703da0f5b7456e1bf51 DIFF: https://github.com/llvm/llvm-project/commit/c34936dae734085c4bc01703da0f5b7456e1bf51.diff