[Lldb-commits] [PATCH] D81200: [vscode] set default values for terminateDebuggee for the disconnect request

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. I'm ok with this then if the error being returned for disconnect doesn't affect the IDE. Anyone else should chime in quickly if you have any objections. Repository: rG LLVM Github Monor

[Lldb-commits] [PATCH] D81696: [lldb/Test] Fix ASan/TSan workaround for Xcode Python 3

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/test/API/lldbtest.py:51 # build with. executable = test.config.python_executable vsk wrote: > .. so by the time this is reached, executable sho

[Lldb-commits] [PATCH] D81696: [lldb/Test] Fix ASan/TSan workaround for Xcode Python 3

This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rG526e0c8d1521: [lldb/Test] Fix ASan/TSan workaround for Xcode Python 3 (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github

[Lldb-commits] [lldb] 526e0c8 - [lldb/Test] Fix ASan/TSan workaround for Xcode Python 3

Author: Jonas Devlieghere Date: 2020-06-11T19:36:42-07:00 New Revision: 526e0c8d15216e6c49b1769c63f5433df6841c64 URL: https://github.com/llvm/llvm-project/commit/526e0c8d15216e6c49b1769c63f5433df6841c64 DIFF: https://github.com/llvm/llvm-project/commit/526e0c8d15216e6c49b1769c63f5433df6841c64.d

[Lldb-commits] [PATCH] D81696: [lldb/Test] Fix ASan/TSan workaround for Xcode Python 3

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Lgtm, thanks. Comment at: lldb/test/API/lit.cfg.py:102 +if 'DYLD_INSERT_LIBRARIES' in config.environment and platform.system() == 'Darwin': + config.python_executable = find_pyth

[Lldb-commits] [PATCH] D81696: [lldb/Test] Fix ASan/TSan workaround for Xcode Python 3

JDevlieghere marked 6 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/test/API/lit.cfg.py:56 +# copy of the "real" python to work with. +def find_python_interpreter(): + # Avoid doing any work if we already copied the binary. This serves as

[Lldb-commits] [PATCH] D81696: [lldb/Test] Fix ASan/TSan workaround for Xcode Python 3

JDevlieghere updated this revision to Diff 270275. JDevlieghere marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81696/new/ https://reviews.llvm.org/D81696 Files: lldb/test/API/lit.cfg.py lldb/test/API/lit.site.cfg.py.in lldb/test/API/lldbtest.py Ind

[Lldb-commits] [PATCH] D81696: [lldb/Test] Fix ASan/TSan workaround for Xcode Python 3

vsk added inline comments. Comment at: lldb/test/API/lit.cfg.py:56 +# copy of the "real" python to work with. +def find_python_interpreter(): + # Avoid doing any work if we already copied the binary. This serves as This isn't relevant for the unit or shell tests

[Lldb-commits] [PATCH] D81696: [lldb/Test] Fix ASan/TSan workaround for Xcode Python 3

JDevlieghere updated this revision to Diff 270262. JDevlieghere added a comment. Move work out of `LLDBTest` so we only have to compute it once. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81696/new/ https://reviews.llvm.org/D81696 Files: lldb/test/API/lit.cfg.py lldb/test/API/li

[Lldb-commits] [PATCH] D81697: Add support for batch-testing to the LLDB testsuite.

bbli created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. [LLDB] Hi, this is a patch for the proposed GSoC project "Add support for batch-testing to the LLDB testsuite". The project aimed to add continuation functionality when multiple assertions are call

[Lldb-commits] [PATCH] D81696: [lldb/Test] Fix ASan/TSan workaround for Xcode Python 3

JDevlieghere created this revision. JDevlieghere added reviewers: vsk, aprantl. JDevlieghere updated this revision to Diff 270256. JDevlieghere added a comment. JDevlieghere updated this revision to Diff 270258. Avoid a race that would result in another test finding the copied python before it ha

[Lldb-commits] [PATCH] D81696: [lldb/Test] Fix ASan/TSan workaround for Xcode Python 3

JDevlieghere updated this revision to Diff 270258. JDevlieghere added a comment. Fix typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81696/new/ https://reviews.llvm.org/D81696 Files: lldb/test/API/lldbtest.py Index: lldb/test/API/lldbtest.py =

[Lldb-commits] [PATCH] D81696: [lldb/Test] Fix ASan/TSan workaround for Xcode Python 3

JDevlieghere updated this revision to Diff 270256. JDevlieghere added a comment. Avoid a race that would result in another test finding the copied python before it has been tested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81696/new/ https://reviews.llvm.org/D81696 Files: lldb/t

[Lldb-commits] [lldb] 8d8ec55 - [lldb/Test] Unify DYLD_INSERT_LIBRARIES solution for ASan and TSan

Author: Jonas Devlieghere Date: 2020-06-11T16:04:46-07:00 New Revision: 8d8ec55035bda2cff5ef446cfacec93c67665c52 URL: https://github.com/llvm/llvm-project/commit/8d8ec55035bda2cff5ef446cfacec93c67665c52 DIFF: https://github.com/llvm/llvm-project/commit/8d8ec55035bda2cff5ef446cfacec93c67665c52.d

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3b43f0062949: [lldb] Check if thread was suspended during previous stop added. (authored by fallkrum, committed by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D80112?vs=270176&id=27

[Lldb-commits] [PATCH] D81200: [vscode] set default values for terminateDebuggee for the disconnect request

wallace marked an inline comment as done. wallace added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:796 +if (!error.Success()) + response.try_emplace("error", error.GetCString()); g_vsc.debugger.SetAsync(true); clayborg wrote

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

JDevlieghere added a comment. In D80112#2088585 , @fallkrum wrote: > It says to provide the name and e-mail: > Ilya Bukonkin fallk...@yahoo.com Thanks, committed! I took the liberty of running clang-format over the changes and fixing some trailing whit

[Lldb-commits] [lldb] 3b43f00 - [lldb] Check if thread was suspended during previous stop added.

Author: Ilya Bukonkin Date: 2020-06-11T15:02:46-07:00 New Revision: 3b43f006294971b8049d4807110032169780e5b8 URL: https://github.com/llvm/llvm-project/commit/3b43f006294971b8049d4807110032169780e5b8 DIFF: https://github.com/llvm/llvm-project/commit/3b43f006294971b8049d4807110032169780e5b8.diff

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

fallkrum added a comment. @JDevlieghere thanks for help. No, I have no commit access, please do it for me. Should I request the access now or you will grant it in the future? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80112/new/ https://review

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

fallkrum added a comment. It says to provide the name and e-mail: Ilya Bukonkin fallk...@yahoo.com Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80112/new/ https://reviews.llvm.org/D80112 ___ lldb-comm

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

JDevlieghere added a comment. In D80112#2088504 , @fallkrum wrote: > It says "This revision is now accepted and ready to land." If I understand > correctly I should be able to merge it somehow to the repository. Do not see > how to do it though... Could

[Lldb-commits] [lldb] 1c03389 - Re-land "Migrate the rest of COFFObjectFile to Error"

Author: Reid Kleckner Date: 2020-06-11T14:46:16-07:00 New Revision: 1c03389c29f32cce81a642365c484c71aba1a1cb URL: https://github.com/llvm/llvm-project/commit/1c03389c29f32cce81a642365c484c71aba1a1cb DIFF: https://github.com/llvm/llvm-project/commit/1c03389c29f32cce81a642365c484c71aba1a1cb.diff

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

fallkrum added a comment. It says "This revision is now accepted and ready to land." If I understand correctly I should be able to merge it somehow to the repository. Do not see how to do it though... Could you help to figure it out? Also very unclear why Harbormaster always fails with errors li

[Lldb-commits] [PATCH] D81200: [vscode] set default values for terminateDebuggee for the disconnect request

clayborg added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:796 +if (!error.Success()) + response.try_emplace("error", error.GetCString()); g_vsc.debugger.SetAsync(true); I am not sure what returning an error to disconnect wil

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

jankratochvil added a comment. I would separate/remove all [nfc] changes from this patch as they complicate it a bit. Such cleaned up patch I have prepared for myself: https://people.redhat.com/jkratoch/D74136-cleanup.patch Then also did you notice there is a regression for (I do not know why):

[Lldb-commits] [PATCH] D81589: [lldb/SymbolFile] Don't parse the whole line table for the support files

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Nice! Our DWARFUnit::GetLineTableOffset() isn't adding some extra offset to the line table offset that the LLVM parser is adding, but we can do this in a separate patch. CHANGES SINCE LA

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80112/new/ https://reviews.llvm.org/D80112 _

[Lldb-commits] [PATCH] D81589: [lldb/SymbolFile] Don't parse the whole line table for the support files

JDevlieghere updated this revision to Diff 270184. JDevlieghere retitled this revision from "[lldb/SymbolFile] Don't parse the whole line table for the support files (WIP)" to "[lldb/SymbolFile] Don't parse the whole line table for the support files". JDevlieghere edited the summary of this revis

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

fallkrum marked 9 inline comments as done. fallkrum added inline comments. Comment at: lldb/source/Target/Process.cpp:3977 +} else { + /* + For the sake of logical consistency. For example we have only jingham wrote: > I'm not entirely sure about t

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

fallkrum updated this revision to Diff 270176. fallkrum added a comment. Removed _ptr from found_valid_stopinfo_ptr. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80112/new/ https://reviews.llvm.org/D80112 Files: lldb/include/lldb/Target/Process

[Lldb-commits] [PATCH] D81516: [lldb/Test] Ensure inline tests have a unique build directory

This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rG5a33ba52b66c: [lldb/Test] Ensure inline tests have a unique build directory (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM G

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

jingham added a comment. In D74136#2087863 , @jingham wrote: > I need to read this in more detail at this point but I'm caught up in > something else. > > One of the not so great design decisions I made was to try to have "break > set" be a single comman

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

teemperor added a reviewer: LLDB. teemperor added a subscriber: lldb-commits. teemperor added a comment. I think this is ready to get a review from the rest. I'll add the other LLDB folks to the review. Comment at: lldb/include/lldb/Host/Editline.h:377 void *m_completion_ca

[Lldb-commits] [PATCH] D81612: [lldb/Test] Assert that no targets or global modules remain after a test completes.

JDevlieghere added a comment. In D81612#2086939 , @labath wrote: > I'm pretty indifferent about this functionality -- I don't think it hurts, > but it also doesn't seem like a pressing problem that needs addressing. Yeah. I agree it's not a problem we f

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

jingham added a comment. I need to read this in more detail at this point but I'm caught up in something else. One of the not so great design decisions I made was to try to have "break set" be a single command governed by flags. The way the command turned out, there are some flags that tell y

[Lldb-commits] [PATCH] D81516: [lldb/Test] Ensure inline tests have a unique build directory

JDevlieghere marked 3 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbinline.py:209 test_class = type(name, (InlineTest,), dict(test=test_func, -name=name, _build_dict=build_dict)) +name=name, _

[Lldb-commits] [lldb] 5a33ba5 - [lldb/Test] Ensure inline tests have a unique build directory

Author: Jonas Devlieghere Date: 2020-06-11T09:36:54-07:00 New Revision: 5a33ba52b66ceb336b2dd941c9e3f5313a388e63 URL: https://github.com/llvm/llvm-project/commit/5a33ba52b66ceb336b2dd941c9e3f5313a388e63 DIFF: https://github.com/llvm/llvm-project/commit/5a33ba52b66ceb336b2dd941c9e3f5313a388e63.d

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

fallkrum updated this revision to Diff 270148. fallkrum added a comment. Code review fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80112/new/ https://reviews.llvm.org/D80112 Files: lldb/include/lldb/Target/Process.h lldb/source/Target/P

[Lldb-commits] [PATCH] D81561: [lldb] Add basic -flimit-debug-info support to expression evaluator

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. I think the approach here makes sense. The only issue I see is how we get the complete replacement type (see the inline comment). There is the issue if having an artificial emp

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

labath marked an inline comment as done. labath added a comment. In D74136#2085076 , @kwk wrote: > IMPORTANT: The behavior of `target.inline-breakpoint-strategy` when set to > `headers` is still subject to change! > > I think the setting is not respected

[Lldb-commits] [PATCH] D81516: [lldb/Test] Ensure inline tests have a unique build directory

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/packages/Python/lldbsuite/test/lldbinline.py:209 test_class = type(name, (InlineTest,), dict(test=test_func, -name=name, _build_dict=build_d

[Lldb-commits] [lldb] e966a5d - [lldb] Remove Scalar operator= overloads

Author: Pavel Labath Date: 2020-06-11T13:55:02+02:00 New Revision: e966a5deaa50f1ddca3810e945acd14b899824c7 URL: https://github.com/llvm/llvm-project/commit/e966a5deaa50f1ddca3810e945acd14b899824c7 DIFF: https://github.com/llvm/llvm-project/commit/e966a5deaa50f1ddca3810e945acd14b899824c7.diff

[Lldb-commits] [PATCH] D81561: [lldb] Add basic -flimit-debug-info support to expression evaluator

labath added a comment. In D81561#2086435 , @clayborg wrote: > If we run into a class in the AST importer that was forcefully completed and > we can't find a better definition, what do we do? Error out? Do what we did. > I would like there to be a nice l

[Lldb-commits] [PATCH] D81561: [lldb] Add basic -flimit-debug-info support to expression evaluator

labath updated this revision to Diff 270097. labath added a comment. add more comments and logging Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81561/new/ https://reviews.llvm.org/D81561 Files: lldb/source/Plugins/ExpressionParser/Clang/ClangAS

[Lldb-commits] [PATCH] D80997: [lldb] Fix a crash in PlatformAppleSimulator::GetCoreSimulatorPath when Xcode developer directory can't be found

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc0f09804886: [lldb] Fix a crash in PlatformAppleSimulator::GetCoreSimulatorPath when Xcode… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository:

[Lldb-commits] [PATCH] D81612: [lldb/Test] Assert that no targets or global modules remain after a test completes.

labath added a comment. I'm pretty indifferent about this functionality -- I don't think it hurts, but it also doesn't seem like a pressing problem that needs addressing. Regarding the implementation, be aware that assertion failures during test teardown are reproted pretty weirdly -- IIRC at t

[Lldb-commits] [lldb] dc0f098 - [lldb] Fix a crash in PlatformAppleSimulator::GetCoreSimulatorPath when Xcode developer directory can't be found

Author: Raphael Isemann Date: 2020-06-11T09:48:39+02:00 New Revision: dc0f09804886bdf26870162423c7432d6e6a4114 URL: https://github.com/llvm/llvm-project/commit/dc0f09804886bdf26870162423c7432d6e6a4114 DIFF: https://github.com/llvm/llvm-project/commit/dc0f09804886bdf26870162423c7432d6e6a4114.dif