[Lldb-commits] [PATCH] D82273: [lldb/Lua] Use the debugger's output and error file for Lua's I/O library.

2020-06-21 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere updated this revision to Diff 272313. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82273/new/ https://reviews.llvm.org/D82273 Files: lldb/source/Plugins/ScriptInterpreter/Lua/Lua.cpp lldb/source/Plugins/ScriptInterpreter/Lua/Lua.h

[Lldb-commits] [PATCH] D82160: [lldb][PDB] Constexpr static member values as AST literals

2020-06-21 Thread Jack Andersen via Phabricator via lldb-commits
jackoalan updated this revision to Diff 272297. jackoalan added a comment. Apply formatting fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82160/new/ https://reviews.llvm.org/D82160 Files:

[Lldb-commits] [PATCH] D82273: [lldb/Lua] Use the debugger's output and error file for Lua's I/O library.

2020-06-21 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added reviewers: labath, LLDB. Add support for changing the stdout and stderr file in Lua's I/O library and hook it up with the debugger's output and error file respectively for the interactive Lua interpreter. Repository: rLLDB LLDB

[Lldb-commits] [PATCH] D82272: [lldb/Lua] Recognize "quit" as a way to exit the interactive script interpreter.

2020-06-21 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added reviewers: labath, LLDB. Add a way to quit the interactive script interpreter from a shell tests. Currently, the only way (that I know) to exit the interactive Lua interpreter is to send a EOF with CTRL-D. I noticed that the embedded Python

Re: [Lldb-commits] [lldb] 90c1af1 - [lldb][NFC] Add more test for builtin formats

2020-06-21 Thread Eric Christopher via lldb-commits
No problem at all, happens to all of us :) -eric On Sun, Jun 21, 2020 at 12:56 AM Raphael “Teemperor” Isemann < teempe...@gmail.com> wrote: > Sorry for that, it seems I overlooked those failure mails. Thanks! > > On 20 Jun 2020, at 23:22, Eric Christopher wrote: > > This is failing on some of

Re: [Lldb-commits] [lldb] 90c1af1 - [lldb][NFC] Add more test for builtin formats

2020-06-21 Thread Raphael “Teemperor” Isemann via lldb-commits
Sorry for that, it seems I overlooked those failure mails. Thanks! > On 20 Jun 2020, at 23:22, Eric Christopher wrote: > > This is failing on some of the debian buildbots so I've temporarily reverted > it here: > > commit 10b43541360efb35a1d33e9cf1e93023ebd69b15 (HEAD -> master, >

[Lldb-commits] [PATCH] D82160: [lldb][PDB] Constexpr static member values as AST literals

2020-06-21 Thread Jack Andersen via Phabricator via lldb-commits
jackoalan updated this revision to Diff 272288. jackoalan marked an inline comment as done. jackoalan added a comment. Fix ternary to use corresponding float/double overloaded constructors of APFloat Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D82160: [lldb][PDB] Constexpr static member values as AST literals

2020-06-21 Thread Jack Andersen via Phabricator via lldb-commits
jackoalan marked 4 inline comments as done. jackoalan added a comment. Thank you @teemperor, your comments and changes in D81471 are very informative. I didn't realise DWARF had similar issues with static const members. Curiously, I am able to resolve direct

[Lldb-commits] [PATCH] D82160: [lldb][PDB] Constexpr static member values as AST literals

2020-06-21 Thread Jack Andersen via Phabricator via lldb-commits
jackoalan updated this revision to Diff 272287. jackoalan added a comment. Review changes from @teemperor. Base on `TypeSystemClang::SetIntegerInitializerForVariable` from D81471 , and add associated `TypeSystemClang::SetFloatingInitializerForVariable`.

[Lldb-commits] [lldb] 6e3faae - [lldb/Lua] Remove redundant variable (NFC)

2020-06-21 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-06-20T23:28:22-07:00 New Revision: 6e3faaeb44bdcb42f059fa68eec1687c0f903a58 URL: https://github.com/llvm/llvm-project/commit/6e3faaeb44bdcb42f059fa68eec1687c0f903a58 DIFF: