[Lldb-commits] [PATCH] D82622: [DWARFYAML][debug_info] Replace 'InitialLength' with 'Format' and 'Length'.

Higuoxing updated this revision to Diff 273584. Higuoxing added a comment. Prettify test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82622/new/ https://reviews.llvm.org/D82622 Files: lldb/test/API/functionalities/source-map/a.yaml lld

[Lldb-commits] [PATCH] D82622: [DWARFYAML][debug_info] Replace 'InitialLength' with 'Format' and 'Length'.

Higuoxing created this revision. Higuoxing added reviewers: jhenderson, grimar, MaskRay. Herald added subscribers: llvm-commits, lldb-commits, cmtice, hiraditya, aprantl, emaste. Herald added a reviewer: espindola. Herald added a reviewer: alexshap. Herald added a reviewer: rupprecht. Herald added

[Lldb-commits] [PATCH] D82616: Improve the detection of iOS/tvOS/watchOS simulator binaries in debugserver and lldb

aprantl created this revision. aprantl added reviewers: jasonmolenda, friss, davide. This patch improves the heuristics for correctly identifying simulator binaries on Darwin and adds support for simulators running on Apple Silicon. rdar://problem/64046344 https://reviews.llvm.org/D82616 File

[Lldb-commits] [PATCH] D82559: [LLDB][Clang Integration][NFC] Remove redundant condition

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82559/new/ https://reviews.llvm.org/D82559 __

[Lldb-commits] [lldb] f441313 - [lldb/ScriptInterpreter] Fix Windows error C2371: 'pid_t': redefinition

Author: Jonas Devlieghere Date: 2020-06-25T17:15:29-07:00 New Revision: f441313464b2eef94a41c60bfde31a2bf9c602d7 URL: https://github.com/llvm/llvm-project/commit/f441313464b2eef94a41c60bfde31a2bf9c602d7 DIFF: https://github.com/llvm/llvm-project/commit/f441313464b2eef94a41c60bfde31a2bf9c602d7.d

[Lldb-commits] [lldb] c7eb06a - [test] XFail TestStepNoDebug based on arch rather than OS

Author: Davide Italiano Date: 2020-06-25T16:23:59-07:00 New Revision: c7eb06a880522867e7df3f025056f6c5b10d0eca URL: https://github.com/llvm/llvm-project/commit/c7eb06a880522867e7df3f025056f6c5b10d0eca DIFF: https://github.com/llvm/llvm-project/commit/c7eb06a880522867e7df3f025056f6c5b10d0eca.dif

[Lldb-commits] [lldb] 38135b2 - [test] XFail TestSigtrampUnwind based on arch rather than OS

Author: Davide Italiano Date: 2020-06-25T16:22:52-07:00 New Revision: 38135b2a7fff008093c0ca020855373f33ec9b12 URL: https://github.com/llvm/llvm-project/commit/38135b2a7fff008093c0ca020855373f33ec9b12 DIFF: https://github.com/llvm/llvm-project/commit/38135b2a7fff008093c0ca020855373f33ec9b12.dif

[Lldb-commits] [lldb] d358ec4 - [lldb/test] Skip TestBreakpointThumbCodesection on arm64.

Author: Davide Italiano Date: 2020-06-25T16:20:27-07:00 New Revision: d358ec463943878936080064d1c43afd8798aaf0 URL: https://github.com/llvm/llvm-project/commit/d358ec463943878936080064d1c43afd8798aaf0 DIFF: https://github.com/llvm/llvm-project/commit/d358ec463943878936080064d1c43afd8798aaf0.dif

[Lldb-commits] [lldb] 0df7be2 - [lldb/test] XFAIL TestHWBreakMultiThread on arch rather platform.

Author: Davide Italiano Date: 2020-06-25T16:21:23-07:00 New Revision: 0df7be234412e60fbbaaf8c181fe2dfb3a2c1cc3 URL: https://github.com/llvm/llvm-project/commit/0df7be234412e60fbbaaf8c181fe2dfb3a2c1cc3 DIFF: https://github.com/llvm/llvm-project/commit/0df7be234412e60fbbaaf8c181fe2dfb3a2c1cc3.dif

[Lldb-commits] [lldb] 11f2ef4 - [lldb/ScriptInterpreter] Fix missing include on Windows

Author: Jonas Devlieghere Date: 2020-06-25T12:19:04-07:00 New Revision: 11f2ef4d9e78fd51cc9813d4ff0d8913c4ae70e1 URL: https://github.com/llvm/llvm-project/commit/11f2ef4d9e78fd51cc9813d4ff0d8913c4ae70e1 DIFF: https://github.com/llvm/llvm-project/commit/11f2ef4d9e78fd51cc9813d4ff0d8913c4ae70e1.d

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

gedatsu217 marked an inline comment as done. gedatsu217 added inline comments. Comment at: lldb/source/Host/common/Editline.cpp:1017 + el_insertstr(m_editline, to_add.c_str()); + return CC_REFRESH; +} teemperor wrote: > If I understand t

[Lldb-commits] [PATCH] D82477: [lldb-vscode] Add Support for Module Event

clayborg added a comment. Here is a makefile that does stripping: llvm-project/lldb/test/API/lang/objc/objc-ivar-stripped/Makefile Then when creating the target, use a.out.stripped: exe = self.getBuildArtifact("a.out.stripped") symbols = exe = self.getBuildArtifact("a.out") target = self.

Re: [Lldb-commits] [PATCH] D82155: [WIP][lldb/interpreter] Add ability to save lldb session to a file

I’m not sure > On Jun 25, 2020, at 5:08 AM, Pavel Labath wrote: > > On 24/06/2020 18:55, Jim Ingham wrote: >> >>> On Jun 22, 2020, at 5:52 AM, Pavel Labath via Phabricator via lldb-commits >>> wrote: >>> >>> labath added a comment. >>> >>> This seems like it could be useful in some circums

[Lldb-commits] [PATCH] D82477: [lldb-vscode] Add Support for Module Event

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. We need to add a test for the symbols added target notification. See my previous comment on stripping a.out to a.out.stripped and then using "a.out.stripped" as the main executab

[Lldb-commits] [PATCH] D82507: [lldb/Docs] Add more details to the issues with custom Python installs on macOS

This revision was automatically updated to reflect the committed changes. Closed by commit rG2bdd41b8c0b4: [lldb/Docs] Add more details to the issues with custom Python installs on macOS (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/

[Lldb-commits] [PATCH] D82522: [lldb/IOHandlerCursesGUI] Make the menu bar clickable

clayborg added a comment. I wrote all this, so feel free to contact me directly with questions! It would be nice to pass the events along to the window or object for the mouse coordinates. See inlined comment and let me know what you think. Comment at: lldb/source/Core/IOHand

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

teemperor added a comment. Just a quick comment while I look into how we can test this code. Comment at: lldb/source/Host/common/Editline.cpp:1017 + el_insertstr(m_editline, to_add.c_str()); + return CC_REFRESH; +} If I understand the

[Lldb-commits] [lldb] 2bdd41b - [lldb/Docs] Add more details to the issues with custom Python installs on macOS

Author: Jonas Devlieghere Date: 2020-06-25T10:53:30-07:00 New Revision: 2bdd41b8c0b4cc8d13ca6c3d255a642a8a9c0969 URL: https://github.com/llvm/llvm-project/commit/2bdd41b8c0b4cc8d13ca6c3d255a642a8a9c0969 DIFF: https://github.com/llvm/llvm-project/commit/2bdd41b8c0b4cc8d13ca6c3d255a642a8a9c0969.d

[Lldb-commits] [PATCH] D82396: [lldb/ScriptInterpreter] Extract IO redirection logic and move it out of ScriptInterpreterPython (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rGd79273c941d5: [lldb/ScriptInterpreter] Extract IO redirection logic (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D82396?vs=273068&id=273429

[Lldb-commits] [PATCH] D82412: [lldb/Lua] Redirect Lua stdout/stderr to the CommandReturnObject

This revision was automatically updated to reflect the committed changes. Closed by commit rGed8184b7814d: [lldb/Lua] Redirect Lua stdout/stderr to the CommandReturnObject (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D82412?vs=27307

[Lldb-commits] [PATCH] D82507: [lldb/Docs] Add more details to the issues with custom Python installs on macOS

friss accepted this revision. friss added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82507/new/ https://reviews.llvm.org/D82507 ___ lldb-commits m

[Lldb-commits] [lldb] 4df7d85 - [lldb][NFC] Use expect_expr in TestDollarInVariable

Author: Raphael Isemann Date: 2020-06-25T19:07:55+02:00 New Revision: 4df7d852afc04844184f0a02d3a3ca4449bbbc5f URL: https://github.com/llvm/llvm-project/commit/4df7d852afc04844184f0a02d3a3ca4449bbbc5f DIFF: https://github.com/llvm/llvm-project/commit/4df7d852afc04844184f0a02d3a3ca4449bbbc5f.dif

[Lldb-commits] [lldb] 8422836 - [lldb/ScriptInterpreter] Let the IORedirect factory handle IO being disabled.

Author: Jonas Devlieghere Date: 2020-06-25T09:55:46-07:00 New Revision: 842283652eb89e7c207ecfdac5e546472332f02b URL: https://github.com/llvm/llvm-project/commit/842283652eb89e7c207ecfdac5e546472332f02b DIFF: https://github.com/llvm/llvm-project/commit/842283652eb89e7c207ecfdac5e546472332f02b.d

[Lldb-commits] [lldb] ed8184b - [lldb/Lua] Redirect Lua stdout/stderr to the CommandReturnObject

Author: Jonas Devlieghere Date: 2020-06-25T09:55:46-07:00 New Revision: ed8184b7814df4310dbad065a9a1c3bb8f3bfa86 URL: https://github.com/llvm/llvm-project/commit/ed8184b7814df4310dbad065a9a1c3bb8f3bfa86 DIFF: https://github.com/llvm/llvm-project/commit/ed8184b7814df4310dbad065a9a1c3bb8f3bfa86.d

[Lldb-commits] [lldb] d79273c - [lldb/ScriptInterpreter] Extract IO redirection logic

Author: Jonas Devlieghere Date: 2020-06-25T09:43:28-07:00 New Revision: d79273c941d58486d09c020eb7767a5246a9c24d URL: https://github.com/llvm/llvm-project/commit/d79273c941d58486d09c020eb7767a5246a9c24d DIFF: https://github.com/llvm/llvm-project/commit/d79273c941d58486d09c020eb7767a5246a9c24d.d

[Lldb-commits] [PATCH] D82505: [lldb-vscode] Add Support for Module Event

aelitashen abandoned this revision. aelitashen added a comment. Mistakenly created two diffs on same commit, See D82477 for the original diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82505/new/ https://revie

[Lldb-commits] [PATCH] D82477: [lldb-vscode] Add Support for Module Event

aelitashen updated this revision to Diff 273378. aelitashen added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Formatting the codes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82477/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D82559: [LLDB][Clang Integration][NFC] Remove redundant condition

baloghadamsoftware created this revision. baloghadamsoftware added a reviewer: jingham. baloghadamsoftware added a project: LLDB. Herald added subscribers: martong, gamesh411, Szelethus, dkrupp, rnkovacs. Condition `omit_empty_base_classes` is checked both in an outer and in an inner `if` stateme

[Lldb-commits] [PATCH] D82558: [LLDB][NFC] Remove redundant condition

baloghadamsoftware created this revision. baloghadamsoftware added a reviewer: clayborg. baloghadamsoftware added a project: LLDB. Herald added subscribers: martong, gamesh411, Szelethus, dkrupp, rnkovacs, kbarton, kristof.beyls, nemanjai. Condition `auto_advance_pc` is checked both in an outer a

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

gedatsu217 updated this revision to Diff 273349. gedatsu217 added a comment. I revised the code according to your advice. In addition, llvm::Optional was originally returned in CommandInterpreter::GetAutoSuggestionForCommand, but it seems to useless that converting llvm::Optional to std::string

[Lldb-commits] [lldb] d0fa52c - [lldb] Rewrite Scalar::GetBytes

Author: Pavel Labath Date: 2020-06-25T15:31:48+02:00 New Revision: d0fa52cc3797fd8805d24a04e6b8198154cd7b53 URL: https://github.com/llvm/llvm-project/commit/d0fa52cc3797fd8805d24a04e6b8198154cd7b53 DIFF: https://github.com/llvm/llvm-project/commit/d0fa52cc3797fd8805d24a04e6b8198154cd7b53.diff

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

gedatsu217 added a comment. I understood what you said. Sorry, I misunderstood it. Indeed, m_current_autosuggestion is not good for the future. I will get the current user input every time calling ApplyCompleteCommand instead of using m_current_autosuggestion. By the way, when I use llvm::Opti

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 273307. kwk added a comment. - bring back logic to keep a symbol context when a function passes and add a comment as Jan suggested - remove test from scripted resolver that calls SearchFilterByModulesAndSupportFiles::AddressPasses - before the test checked tha

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 273309. kwk added a comment. - Add newlines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.org/D74136 Files: lldb/include/lldb/Core/SearchFilter.h lldb/include/lldb/Target/Target

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk marked an inline comment as done. kwk added inline comments. Comment at: lldb/test/API/functionalities/breakpoint/scripted_bkpt/TestScriptedResolver.py:124 -file_list.Append(lldb.SBFileSpec("noFileOfThisName.xxx")) -wrong.append(target.BreakpointCreateFromScr

Re: [Lldb-commits] [lldb] d4ef569 - Disable a flaky lldb-vscode test on aarch64

These tests are also flaky on GreenDragon: (http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/21850/testReport/, http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/21848/testReport/, http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/21847/testReport/). So, it sounds like this is a

Re: [Lldb-commits] [PATCH] D82155: [WIP][lldb/interpreter] Add ability to save lldb session to a file

On 24/06/2020 18:55, Jim Ingham wrote: > >> On Jun 22, 2020, at 5:52 AM, Pavel Labath via Phabricator via lldb-commits >> wrote: >> >> labath added a comment. >> >> This seems like it could be useful in some circumstances, though for the use >> cases I am imagining (bug reporting) it would be e

[Lldb-commits] [PATCH] D82064: [ARM64] Add QEMU testing environment setup guide for SVE testing

rovka added a comment. Hi Omair, If this is intended to be more generally useful, I wonder if we should rename it to something else (e.g. lldb-qemu-howto.txt) and only use AArch64 SVE as a case study. In any case, thanks for writing this up! Comment at: lldb/docs/lldb-qemu-

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

labath added inline comments. Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:1875-1878 +if (entry.startswith(line)) { + llvm::StringRef res = entry.substr(line.size()); + result = res.str(); + return result; teemperor wrote: > gedat

[Lldb-commits] [PATCH] D82378: [lldb/Unwind] Use eh_frame plan directly when it doesn't need to be augmented

labath added a comment. Thanks for replying Jason. I think having the augmentation string specify its validity would be great, though I am somewhat sceptical of being able to push that idea through -- given that eh_frame needs to be understood by a lot of consumers and is actually critical for

[Lldb-commits] [PATCH] D82537: [lldb] Deduplicate copy-pasted TypeSystemMap::GetTypeSystemForLanguage

teemperor created this revision. teemperor added a reviewer: LLDB. Herald added a subscriber: JDevlieghere. There are two implementations for `TypeSystemMap::GetTypeSystemForLanguage` which are both identical beside one taking a `Module` and one taking a `Target` (and then passing that argument

[Lldb-commits] [PATCH] D82522: [lldb/IOHandlerCursesGUI] Make the menu bar clickable

labath added a comment. Being curious is nice, but it would be even nicer if we figured out a way to test all of this stuff. Currently we have some very basic pexpect tests for this, but it's not clear how that will scale to more complex interactions (such as mouse clicking). My idea for a tes

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

teemperor added a comment. In D81001#2107102 , @gedatsu217 wrote: > Change the name and return of the function( bool UseAutosuggestion() -> void > SetShowAutosuggestion (bool) ) (ll. 1447 in Editline.cpp and ll.194 in > Editline.h). > int -> size_t (ll.

[Lldb-commits] [PATCH] D82155: [WIP][lldb/interpreter] Add ability to save lldb session to a file

labath added a comment. The code looks fine to me, though it sounds like there are still issues to be sorted out w.r.t commands run from inside data formatters, through sb apis, etc. And it needs tests, of course. Comment at: lldb/source/Commands/CommandObjectSession.h:22-26

[Lldb-commits] [PATCH] D82477: [lldb-vscode] Add Support for Module Event

labath added inline comments. Comment at: lldb/test/API/tools/lldb-vscode/module/TestVSCode_module.py:27-29 +self.assertTrue('a.out' in self.vscode.get_active_modules(), +'Module: a.out is loaded') +self.assertTrue('symbolFilePath' in sel

[Lldb-commits] [PATCH] D82160: [lldb][PDB] Constexpr static member values as AST literals

This revision was automatically updated to reflect the committed changes. Closed by commit rG895529cfd875: [lldb][PDB] Constexpr static member values as AST literals (authored by aleksandr.urakov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82160/

[Lldb-commits] [PATCH] D82396: [lldb/ScriptInterpreter] Extract IO redirection logic and move it out of ScriptInterpreterPython (NFC)

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I think this looks good, though it looks like you have uploaded an partial patch... Comment at: lldb/include/lldb/Interpreter/ScriptInterpreter.h:57-58 private: + friend s

[Lldb-commits] [PATCH] D82412: [lldb/Lua] Redirect Lua stdout/stderr to the CommandReturnObject

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/ScriptInterpreter/Lua/ScriptInterpreterLua.cpp:77 + io_redirect_or_error = + options.GetEnableIO() + ? ScriptI

[Lldb-commits] [lldb] 895529c - [lldb][PDB] Constexpr static member values as AST literals

Author: Aleksandr Urakov Date: 2020-06-25T11:27:16+03:00 New Revision: 895529cfd8756e2b4dc609f5af92e0d8ae280ed8 URL: https://github.com/llvm/llvm-project/commit/895529cfd8756e2b4dc609f5af92e0d8ae280ed8 DIFF: https://github.com/llvm/llvm-project/commit/895529cfd8756e2b4dc609f5af92e0d8ae280ed8.di

[Lldb-commits] [PATCH] D82378: [lldb/Unwind] Use eh_frame plan directly when it doesn't need to be augmented

jasonmolenda added a comment. Hi Pavel, sorry I've been doing a bunch of random things today and haven't really had a chance to look at this yet. eh_frame is so problematic for lldb, we never know what we're getting. I keep thinking we should take over a few augmentation string characters so t

[Lldb-commits] [PATCH] D82522: [lldb/IOHandlerCursesGUI] Make the menu bar clickable

JDevlieghere created this revision. JDevlieghere added reviewers: clayborg, teemperor, labath. JDevlieghere added a project: LLDB. Add mouse support to the `IOHandlerCursesGUI` and make it possible to select items in the top menu bar by clicking on them. This patch only makes the top level items

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

jankratochvil added inline comments. Comment at: lldb/source/Core/SearchFilter.cpp:722 + return false; + } + jankratochvil wrote: > This `IsSourceImplementationFile()` should be checking the filename requested > by user, not filename found in DWARF. It sho