jasonmolenda accepted this revision.
jasonmolenda added a comment.
Sorry yes this patch is fine. To be honest, on x86_64 at least, as you've
pointed out, maybe we should just live on eh_frame completely without going
through any of these augmentation checks at all. AFAIK gdb is living off of
jhenderson added a comment.
LGTM. Well done on catching the lldb failures - I don't even build lldb by
default personally.
Comment at: llvm/test/ObjectYAML/MachO/DWARF-debug_info.yaml:515
-#CHECK: DWARF:
-#CHECK: debug_info:
-#CHECK: - Length:
Higuoxing marked an inline comment as done.
Higuoxing added a comment.
Thanks for reviewing!
Comment at: llvm/test/ObjectYAML/MachO/DWARF-debug_info.yaml:515
-#CHECK: DWARF:
-#CHECK: debug_info:
-#CHECK: - Length:
-#CHECK: TotalLength:
labath added inline comments.
Comment at: lldb/include/lldb/Interpreter/ScriptInterpreter.h:57-58
private:
+ friend std::unique_ptr
+ std::make_unique();
+
labath wrote:
> If that works, I suppose it's fine. But I wouldn't be surprised if this trick
> backfir
Higuoxing updated this revision to Diff 273632.
Higuoxing marked 2 inline comments as done.
Higuoxing added a comment.
Address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82622/new/
https://reviews.llvm.org/D82622
Files:
lldb/test/AP
Author: Pavel Labath
Date: 2020-06-26T11:46:47+02:00
New Revision: 5ed8765e2f007e56a34e3aa0ab01f65c5aaa7e27
URL:
https://github.com/llvm/llvm-project/commit/5ed8765e2f007e56a34e3aa0ab01f65c5aaa7e27
DIFF:
https://github.com/llvm/llvm-project/commit/5ed8765e2f007e56a34e3aa0ab01f65c5aaa7e27.diff
Author: Pavel Labath
Date: 2020-06-26T11:46:47+02:00
New Revision: ce275d3030a9dfcf9c55c81b88ae1b2c88f1828f
URL:
https://github.com/llvm/llvm-project/commit/ce275d3030a9dfcf9c55c81b88ae1b2c88f1828f
DIFF:
https://github.com/llvm/llvm-project/commit/ce275d3030a9dfcf9c55c81b88ae1b2c88f1828f.diff
jankratochvil added inline comments.
Comment at: lldb/source/Breakpoint/BreakpointResolverName.cpp:323
+ // passing.
+ remove_it = false;
+ }
Now `if (filter_by_function) {}` always overrides any result from `if
(filter_by_cu)`. So it woul
kwk marked 2 inline comments as done.
kwk added inline comments.
Comment at: lldb/source/Breakpoint/BreakpointResolverName.cpp:323
+ // passing.
+ remove_it = false;
+ }
jankratochvil wrote:
> Now `if (filter_by_function) {}` always overrid
jankratochvil added inline comments.
Comment at: lldb/source/Core/SearchFilter.cpp:829
+ m_target_sp->GetInlineStrategy() == eInlineBreakpointsHeaders)
+return flags | eSymbolContextCompUnit;
+ return flags;
`filter_by_function` now fully overrides `fil
kwk updated this revision to Diff 273637.
kwk added a comment.
- Simplify logic
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74136/new/
https://reviews.llvm.org/D74136
Files:
lldb/include/lldb/Core/SearchFilter.h
lldb/include/lldb/Target/Targ
This revision was automatically updated to reflect the committed changes.
Closed by commit rG5ed8765e2f00: [lldb/Unwind] Use eh_frame plan directly when
it doesn't need to be augmented (authored by labath).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.or
Author: Raphael Isemann
Date: 2020-06-26T12:56:22+02:00
New Revision: 048d11de43be087fd2fa0c5e35f20486f6094c29
URL:
https://github.com/llvm/llvm-project/commit/048d11de43be087fd2fa0c5e35f20486f6094c29
DIFF:
https://github.com/llvm/llvm-project/commit/048d11de43be087fd2fa0c5e35f20486f6094c29.dif
jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.
Forgot to mark as accepted before, but one more comment to add.
Comment at: llvm/test/ObjectYAML/MachO/DWARF-debug_info.yaml:515
-#CHECK: DWARF:
-#CHECK:
Author: Simon Pilgrim
Date: 2020-06-26T13:24:32+01:00
New Revision: 754f3c4af4b8526d7576c8e92959ad10d40b6e2e
URL:
https://github.com/llvm/llvm-project/commit/754f3c4af4b8526d7576c8e92959ad10d40b6e2e
DIFF:
https://github.com/llvm/llvm-project/commit/754f3c4af4b8526d7576c8e92959ad10d40b6e2e.diff
Author: Raphael Isemann
Date: 2020-06-26T15:24:15+02:00
New Revision: bb91520e4fe89ad35bc89578601bf1c35bd9d2fc
URL:
https://github.com/llvm/llvm-project/commit/bb91520e4fe89ad35bc89578601bf1c35bd9d2fc
DIFF:
https://github.com/llvm/llvm-project/commit/bb91520e4fe89ad35bc89578601bf1c35bd9d2fc.dif
davezarzycki abandoned this revision.
davezarzycki added a comment.
Now that my core concern is addressed (moving clang's default module cache out
of /tmp), I don't have the time to push for this deprecation. Sorry.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://revi
Author: Jonas Devlieghere
Date: 2020-06-26T15:59:59-07:00
New Revision: b4180fe477bfe302778aaceee65faf69c5e7be76
URL:
https://github.com/llvm/llvm-project/commit/b4180fe477bfe302778aaceee65faf69c5e7be76
DIFF:
https://github.com/llvm/llvm-project/commit/b4180fe477bfe302778aaceee65faf69c5e7be76.d
JDevlieghere added inline comments.
Comment at: lldb/test/Shell/Unwind/eh-frame-augment-noop.test:18
+target modules show-unwind -n foo
+# CHECK: Asynchronous (not restricted to call-sites) UnwindPlan is 'eh_frame
CFI'
+# CHECK: eh_frame augmented UnwindPlan:
On
19 matches
Mail list logo
