Re: [Lldb-commits] [PATCH] D81978: Redo of Add terminateCommands to lldb-vscode protocol

> On Jun 24, 2020, at 15:48, Walter wrote: > > I'll revert this patch. This seems to be the reason Great thanks! What’s puzzling is that on some runs, it seems to find , but on others it does not. Cheers, Florian ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D82835: [lldb] Fix missing characters when autocompleting LLDB commands in REPL

poya added a comment. Don't believe I have the necessary permissions to land this myself, so would need some help to get this committed to the repo. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82835/new/ https://reviews.llvm.org/D82835

[Lldb-commits] [PATCH] D81697: Add support for batch-testing to the LLDB testsuite.

bbli added a comment. > For example, the thing that's annoying me now is that whenever a test fails > in the "make" phase (e.g. a compile error), we only get an error message with > the return status, and the original make invocation. Sure thing, how should I get started(in particular where in

[Lldb-commits] [PATCH] D82477: [lldb-vscode] Add Support for Module Event

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. See inline comments. Changes needed are: - test for eBroadcastBitSymbolsLoaded - add "version" to module info - test all data we expect in module info ('name', 'symbolFilePath',

[Lldb-commits] [PATCH] D83072: [lldb-vscode] Add Compile Unit List to Modules View

aelitashen created this revision. aelitashen added reviewers: wallace, clayborg. Herald added subscribers: lldb-commits, aprantl. Herald added a project: LLDB. aelitashen retitled this revision from "Add Compile Unit List to Modules View" to "[lldb-vscode] Add Compile Unit List to Modules View".

[Lldb-commits] [PATCH] D83072: [lldb-vscode] Add Compile Unit List to Modules View

aelitashen updated this revision to Diff 275192. aelitashen added a comment. Remove comment line in request_getCompileUnits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83072/new/ https://reviews.llvm.org/D83072 Files:

[Lldb-commits] [PATCH] D83023: [lldb/ObjectFileMachO] Fetch shared cache images from our own shared cache

friss marked 4 inline comments as done. friss added a comment. In D83023#2128298 , @labath wrote: > I think this is a very interesting feature (lldb being able to load modules > from memory; the mac shared cache thingy is interesting too, but in a >

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

JDevlieghere accepted this revision. JDevlieghere added a comment. Thanks Petr, LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D79219 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek marked an inline comment as done. phosek added inline comments. Comment at: llvm/cmake/config-ix.cmake:514 + if(ZLIB_FOUND) +set(LLVM_ENABLE_ZLIB "YES" CACHE STRING + "Use zlib for compression/decompression if available. Can be ON, OFF, or FORCE_ON"

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek updated this revision to Diff 274256. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D79219 Files: clang/CMakeLists.txt clang/test/CMakeLists.txt clang/test/lit.site.cfg.py.in compiler-rt/test/lit.common.configured.in

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek updated this revision to Diff 274255. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D79219 Files: clang/CMakeLists.txt clang/test/CMakeLists.txt clang/test/lit.site.cfg.py.in compiler-rt/test/lit.common.configured.in

[Lldb-commits] [PATCH] D82772: [lldb] Fix type conversion in the Scalar getters

This revision was automatically updated to reflect the committed changes. Closed by commit rGb725142c8db8: [lldb] Fix type conversion in the Scalar getters (authored by labath). Changed prior to commit: https://reviews.llvm.org/D82772?vs=274127=275143#toc Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D82772: [lldb] Fix type conversion in the Scalar getters

labath marked 3 inline comments as done. labath added inline comments. Comment at: lldb/source/Utility/Scalar.cpp:864 case e_uint512: -return static_cast( -llvm::APIntOps::RoundAPIntToDouble(m_integer)); teemperor wrote: > Seems unrelated to the

[Lldb-commits] [lldb] b725142 - [lldb] Fix type conversion in the Scalar getters

Author: Pavel Labath Date: 2020-07-02T18:02:57+02:00 New Revision: b725142c8db8584007cb1cd9149e8bcecaa88547 URL: https://github.com/llvm/llvm-project/commit/b725142c8db8584007cb1cd9149e8bcecaa88547 DIFF: https://github.com/llvm/llvm-project/commit/b725142c8db8584007cb1cd9149e8bcecaa88547.diff

[Lldb-commits] [PATCH] D81697: Add support for batch-testing to the LLDB testsuite.

labath added a comment. In D81697#2127061 , @bbli wrote: > Hi, bumping my post from two weeks ago. The main question I had was: would it > be ok if I just brought over the Outcome object for the time being? Umm... I don't know... Maybe? I suppose it

[Lldb-commits] [PATCH] D83023: [lldb/ObjectFileMachO] Fetch shared cache images from our own shared cache

labath added a comment. I think this is a very interesting feature (lldb being able to load modules from memory; the mac shared cache thingy is interesting too, but in a different way). We have a feature request from people who are downloading modules from a network (from a proprietary symbol

[Lldb-commits] [lldb] c1f1db8 - [lldb] Add a host-independent test for handling -flimit-debug-info

Author: Pavel Labath Date: 2020-07-02T15:51:20+02:00 New Revision: c1f1db8502f1fc788eefeafd3dc225bd287ee4b9 URL: https://github.com/llvm/llvm-project/commit/c1f1db8502f1fc788eefeafd3dc225bd287ee4b9 DIFF: https://github.com/llvm/llvm-project/commit/c1f1db8502f1fc788eefeafd3dc225bd287ee4b9.diff

[Lldb-commits] [lldb] d6343e6 - [lldb] Skip TestLimitDebugInfo on windows

Author: Pavel Labath Date: 2020-07-02T14:34:33+02:00 New Revision: d6343e607ac8fa71fa6d99f9c86369ae9e66e671 URL: https://github.com/llvm/llvm-project/commit/d6343e607ac8fa71fa6d99f9c86369ae9e66e671 DIFF: https://github.com/llvm/llvm-project/commit/d6343e607ac8fa71fa6d99f9c86369ae9e66e671.diff

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

omjavaid updated this revision to Diff 275037. omjavaid added a comment. @labath I have updated diff after resolving issues highlighted. Also I have removed dependence on generic interfaces. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77047/new/ https://reviews.llvm.org/D77047

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

omjavaid updated this revision to Diff 275038. omjavaid added a comment. This update remove dependence over generic interfaces by calling ConfigureRegisterContext on every call to ReadRegister/WriteRegister. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79699/new/

[Lldb-commits] [lldb] 83aa58d - [lldb][NFC] Don't pass around passthrough from ClangDiagnosticManagerAdapter

Author: Raphael Isemann Date: 2020-07-02T10:42:14+02:00 New Revision: 83aa58d795b92cd864c6c09d9a65817a14e63acc URL: https://github.com/llvm/llvm-project/commit/83aa58d795b92cd864c6c09d9a65817a14e63acc DIFF:

[Lldb-commits] [lldb] 11b1eee - [lldb][NFC] Fix a variable name in ClangDiagnosticManagerAdapter

Author: Raphael Isemann Date: 2020-07-02T09:10:07+02:00 New Revision: 11b1eeeaec642052e7299181c6a087f68807ae8b URL: https://github.com/llvm/llvm-project/commit/11b1eeeaec642052e7299181c6a087f68807ae8b DIFF: