[Lldb-commits] [PATCH] D83180: Set generic error in SBError SetErrorToGenericError

2020-07-05 Thread Shivam Mittal via Phabricator via lldb-commits
shivammittal99 created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Signed-off-by: Shivam Mittal Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83180 Files: lldb/source/API/SBError.cpp Index: lldb/source/API/SBError.cpp ===

[Lldb-commits] [PATCH] D83008: Fix ItaniumRecordLayoutBuilder so that is grabs the correct bases class offsets from the external source

2020-07-05 Thread Thorsten via Phabricator via lldb-commits
tschuett added a comment. You could try: clangxx_host -Xclang -fdump-record-layouts %p/Inputs/layout.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83008/new/ https://reviews.llvm.org/D83008 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D83008: Fix ItaniumRecordLayoutBuilder so that is grabs the correct bases class offsets from the external source

2020-07-05 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Thanks for tracking this down, this is a really nasty bug... The fix itself is obviously fine, but I think I'm out of the loop regarding the testing strategy. We talked about a

[Lldb-commits] [lldb] 7794326 - [lldb][NFC] Clarify that spaces can't be in breakpoint names

2020-07-05 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2020-07-05T10:55:02+02:00 New Revision: 779432690fba5184464f10ac56eb5ce510d15ea1 URL: https://github.com/llvm/llvm-project/commit/779432690fba5184464f10ac56eb5ce510d15ea1 DIFF: https://github.com/llvm/llvm-project/commit/779432690fba5184464f10ac56eb5ce510d15ea1.dif

[Lldb-commits] [lldb] fc1d95e - [lldb][NFC] Remove an unnecessary cast in SBCommandInterpreter

2020-07-05 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2020-07-05T10:54:18+02:00 New Revision: fc1d95eb7b35be418b326a18b1779ac18fb31c57 URL: https://github.com/llvm/llvm-project/commit/fc1d95eb7b35be418b326a18b1779ac18fb31c57 DIFF: https://github.com/llvm/llvm-project/commit/fc1d95eb7b35be418b326a18b1779ac18fb31c57.dif