[Lldb-commits] [PATCH] D83847: [lldb][NFC] Add 'override' where missing in source/ and tools/

logan-5 created this revision. logan-5 added a reviewer: clayborg. logan-5 added a project: LLDB. Herald added a subscriber: lldb-commits. These were found by Clang's new `-Wsuggest-override`. This patch doesn't touch any code in unittests/, since much of it intentionally doesn't use `override`

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

omjavaid marked an inline comment as done. omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/elf-core/RegisterContextPOSIXCore_arm64.cpp:82-106 +uint32_t +RegisterContextCorePOSIX_arm64::CalculateSVEOffset(uint32_t reg_num) const { + uint32_t sve_offset =

[Lldb-commits] [lldb] 61cf9f4 - [ObjectFilePECOFF] Try to avoid unaligned access.

Author: Davide Italiano Date: 2020-07-14T18:53:23-07:00 New Revision: 61cf9f4e723bd9522757931706b208a1357c30ba URL: https://github.com/llvm/llvm-project/commit/61cf9f4e723bd9522757931706b208a1357c30ba DIFF:

[Lldb-commits] [PATCH] D83840: [lldb][test] Prevent infinite loop while looking for use_lldb_suite_root.py.

rupprecht created this revision. rupprecht added reviewers: labath, JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. use_lldb_suite.py looks for use_lldb_suite_root.py by checking parent directories. If for some reason it doesn't exist, it keeps checking

[Lldb-commits] [lldb] 74c8d01 - Fix the skipIfRosetta decorator

Author: Adrian Prantl Date: 2020-07-14T18:16:17-07:00 New Revision: 74c8d01aff80a7371ea2ff16fbe84858a266711a URL: https://github.com/llvm/llvm-project/commit/74c8d01aff80a7371ea2ff16fbe84858a266711a DIFF: https://github.com/llvm/llvm-project/commit/74c8d01aff80a7371ea2ff16fbe84858a266711a.diff

[Lldb-commits] [PATCH] D83433: Fix how we handle bit-fields for Objective-C when creating an AST

shafik updated this revision to Diff 278026. shafik marked 6 inline comments as done. shafik added a comment. Added clarifying comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83433/new/ https://reviews.llvm.org/D83433 Files:

[Lldb-commits] [lldb] 984e12a - [lldb/Test] Create reproducer dir if necessary

Author: Jonas Devlieghere Date: 2020-07-14T16:17:53-07:00 New Revision: 984e12ab48cdb5d81d0e994e1e0baca9cc3037a1 URL: https://github.com/llvm/llvm-project/commit/984e12ab48cdb5d81d0e994e1e0baca9cc3037a1 DIFF:

[Lldb-commits] [PATCH] D83815: [lldb/Test] Use a process group for subprocesses

JDevlieghere updated this revision to Diff 277989. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83815/new/ https://reviews.llvm.org/D83815 Files: lldb/packages/Python/lldbsuite/test/lldbtest.py Index: lldb/packages/Python/lldbsuite/test/lldbtest.py

[Lldb-commits] [PATCH] D83815: [lldb/Test] Use a process group for subprocesses

JDevlieghere added a comment. We're still seeing a lot of zombies from the test suite on the bots. I'm hoping this might get rid of one possible source. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83815/new/ https://reviews.llvm.org/D83815

[Lldb-commits] [PATCH] D83815: [lldb/Test] Use a process group for subprocesses

JDevlieghere created this revision. JDevlieghere added reviewers: labath, teemperor. Herald added a subscriber: abidh. Use a process group for processes spawned by the test suite so we can send a signal to the whole group. This ensures any child processes are terminated as well. Repository:

[Lldb-commits] [PATCH] D83796: [ObjC] Wrap namespace-global structure in an anonymous namespace to avoid ODR violations

shafik added a comment. It does indeed solve the immediate problem but if those namespaces aren't really meant to be shared across translation units they should have different names but that is for another PR. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] c6e8bf7 - [lldb/Test] Skip TestProcessConnect.py on Windows

Author: Jonas Devlieghere Date: 2020-07-14T14:07:06-07:00 New Revision: c6e8bf7287edddf74e1fe4005d6284667bae4542 URL: https://github.com/llvm/llvm-project/commit/c6e8bf7287edddf74e1fe4005d6284667bae4542 DIFF:

[Lldb-commits] [PATCH] D83787: [lldb/Test] Always set the cleanupSubprocesses tear down hook

This revision was automatically updated to reflect the committed changes. Closed by commit rG4aafc479f28c: [lldb/Test] Always set the cleanupSubprocesses tear down hook (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] 4aafc47 - [lldb/Test] Always set the cleanupSubprocesses tear down hook

Author: Jonas Devlieghere Date: 2020-07-14T14:05:56-07:00 New Revision: 4aafc479f28ce1ad952f66ac3758f69060c77a08 URL: https://github.com/llvm/llvm-project/commit/4aafc479f28ce1ad952f66ac3758f69060c77a08 DIFF:

[Lldb-commits] [lldb] 368eb77 - Fix a -Wunused-variable warning.

Author: Eric Christopher Date: 2020-07-14T12:40:56-07:00 New Revision: 368eb7712f9f19f93f3e318d8b16e732436fb9c4 URL: https://github.com/llvm/llvm-project/commit/368eb7712f9f19f93f3e318d8b16e732436fb9c4 DIFF:

[Lldb-commits] [PATCH] D83433: Fix how we handle bit-fields for Objective-C when creating an AST

aprantl added a comment. > @aprantl I think this Objective-C Runtime Programming Guide: Bye Encodings > entry and this sample program answer the rest of your questions: Thank you! So it really looks like the ObjC runtime is unaware of bitfields, and we do need the bit offsets in DWARF to know

[Lldb-commits] [lldb] 3f2d880 - [ObjC] Wrap namespace-global structs in an anonymous namespace to avoid ODR violations

Author: Davide Italiano Date: 2020-07-14T11:26:20-07:00 New Revision: 3f2d880a932970d19bfed88c6900d50c9c3bc203 URL: https://github.com/llvm/llvm-project/commit/3f2d880a932970d19bfed88c6900d50c9c3bc203 DIFF:

[Lldb-commits] [PATCH] D83796: [ObjC] Wrap namespace-global structure in an anonymous namespace to avoid ODR violations

This revision was automatically updated to reflect the committed changes. Closed by commit rG3f2d880a9329: [ObjC] Wrap namespace-global structs in an anonymous namespace to avoid ODR… (authored by davide). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D83796: [ObjC] Wrap namespace-global structure in an anonymous namespace to avoid ODR violations

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. This seems to resolve the -Wodr build issues from what I can see, so LGTM. I guess the next step is drawing straws to see who has to refactor this code into something readable...

[Lldb-commits] [PATCH] D83796: [ObjC] Wrap namespace-global structure in an anonymous namespace to avoid ODR violations

davide created this revision. davide added a reviewer: teemperor. rdar://problem/65537147 https://reviews.llvm.org/D83796 Files: lldb/source/Plugins/Language/ObjC/NSArray.cpp lldb/source/Plugins/Language/ObjC/NSDictionary.cpp Index: lldb/source/Plugins/Language/ObjC/NSDictionary.cpp

[Lldb-commits] [PATCH] D83425: [lldb] add printing of stdout compile errors to lldbsuite

bbli added a comment. Yeah so in this pic, F12338615: original.png , you can see in the code that both stdout and stderr point to PIPE, and what gets printed out is the concatenation of the two. However, in F12338626: stderr_as_stdout.png

[Lldb-commits] [lldb] 5a62008 - [lldb] Use runBuildCommands from buildGModules

Author: Jonas Devlieghere Date: 2020-07-14T10:41:45-07:00 New Revision: 5a62008f352b38ca80cb4156fb5d234404db75f2 URL: https://github.com/llvm/llvm-project/commit/5a62008f352b38ca80cb4156fb5d234404db75f2 DIFF:

[Lldb-commits] [lldb] 9ecbad5 - [lldb] lldbinline and lldbtest gardening (NFC)

Author: Jonas Devlieghere Date: 2020-07-14T10:41:45-07:00 New Revision: 9ecbad54c2f02e3ef44077d1f542eaa8b3dd6d44 URL: https://github.com/llvm/llvm-project/commit/9ecbad54c2f02e3ef44077d1f542eaa8b3dd6d44 DIFF:

[Lldb-commits] [PATCH] D83787: [lldb/Test] Always set the cleanupSubprocesses tear down hook

JDevlieghere added a comment. In D83787#2150926 , @labath wrote: > I suppose this might have been because someone wanted to ensure > cleanupSubprocesses is not called twice (if multiple subprocesses are > spawned). It looks like it should be safe to do

[Lldb-commits] [PATCH] D83787: [lldb/Test] Always set the cleanupSubprocesses tear down hook

shafik added a comment. Curious, why didn't we do it this way before? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83787/new/ https://reviews.llvm.org/D83787 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D83787: [lldb/Test] Always set the cleanupSubprocesses tear down hook

labath added a comment. I suppose this might have been because someone wanted to ensure cleanupSubprocesses is not called twice (if multiple subprocesses are spawned). It looks like it should be safe to do so, though it's not completely ideal. TBH, I'm not sure why this needs to be a tear down

[Lldb-commits] [PATCH] D83787: [lldb/Test] Always set the cleanupSubprocesses tear down hook

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83787/new/ https://reviews.llvm.org/D83787 ___

[Lldb-commits] [lldb] f5f15ac - [lldb/Test] Skip TestProcessConnect.py on Windows

Author: Jonas Devlieghere Date: 2020-07-14T10:12:40-07:00 New Revision: f5f15acebbbab9c56c1a50c7f01834e067c8c3b2 URL: https://github.com/llvm/llvm-project/commit/f5f15acebbbab9c56c1a50c7f01834e067c8c3b2 DIFF:

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

gedatsu217 marked an inline comment as done. gedatsu217 added inline comments. Comment at: lldb/source/Host/common/Editline.cpp:1017 + el_insertstr(m_editline, to_add.c_str()); + return CC_REFRESH; +} teemperor wrote: > gedatsu217

[Lldb-commits] [PATCH] D83787: [lldb/Test] Always set the cleanupSubprocesses tear down hook

JDevlieghere created this revision. JDevlieghere added reviewers: labath, teemperor. Always set the cleanupSubprocesses tear down hook when using spawnSubprocess or forkSubprocess instead of relying on the caller to do so. This is not only less error prone but also means the tests can be more

[Lldb-commits] [PATCH] D83512: [lldb/Module] Allow for the creation of memory-only modules

friss marked an inline comment as done. friss added inline comments. Comment at: lldb/unittests/TestingSupport/TestUtilities.h:39-41 + TestFile(TestFile &) : Buffer(std::move(RHS.Buffer)) { +RHS.Buffer = llvm::None; } labath wrote: > Since we don't need

[Lldb-commits] [PATCH] D83512: [lldb/Module] Allow for the creation of memory-only modules

This revision was automatically updated to reflect the committed changes. Closed by commit rGa4a00ced0cf8: [lldb/Module] Allow for the creation of memory-only modules (authored by friss). Changed prior to commit: https://reviews.llvm.org/D83512?vs=277657=277850#toc Repository: rG LLVM

[Lldb-commits] [lldb] a4a00ce - [lldb/Module] Allow for the creation of memory-only modules

Author: Fred Riss Date: 2020-07-14T08:45:44-07:00 New Revision: a4a00ced0cf8cc5663ff0ced801d6139153f3f76 URL: https://github.com/llvm/llvm-project/commit/a4a00ced0cf8cc5663ff0ced801d6139153f3f76 DIFF: https://github.com/llvm/llvm-project/commit/a4a00ced0cf8cc5663ff0ced801d6139153f3f76.diff

[Lldb-commits] [lldb] 706cccb - [lldb] Make `process connect` blocking in synchronous mode.

Author: Jonas Devlieghere Date: 2020-07-14T08:45:34-07:00 New Revision: 706cccb889c8d14791c029a7bb69d8eddb6b1728 URL: https://github.com/llvm/llvm-project/commit/706cccb889c8d14791c029a7bb69d8eddb6b1728 DIFF:

[Lldb-commits] [PATCH] D83728: [lldb] Make `process connect` blocking in synchronous mode.

This revision was automatically updated to reflect the committed changes. JDevlieghere marked 2 inline comments as done. Closed by commit rG706cccb889c8: [lldb] Make `process connect` blocking in synchronous mode. (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D83728: [lldb] Make `process connect` blocking in synchronous mode.

JDevlieghere marked 7 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Target/Platform.cpp:1834 if (error.Fail()) return nullptr; labath wrote: > JDevlieghere wrote: > > jingham wrote: > > > If you fail here you

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

labath added inline comments. Comment at: lldb/source/Plugins/Process/elf-core/RegisterContextPOSIXCore_arm64.cpp:82-106 +uint32_t +RegisterContextCorePOSIX_arm64::CalculateSVEOffset(uint32_t reg_num) const { + uint32_t sve_offset = 0; + if (m_sve_state ==

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

omjavaid marked an inline comment as done. omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/elf-core/RegisterContextPOSIXCore_arm64.cpp:82-106 +uint32_t +RegisterContextCorePOSIX_arm64::CalculateSVEOffset(uint32_t reg_num) const { + uint32_t sve_offset =

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

labath added inline comments. Comment at: lldb/source/Plugins/Process/elf-core/RegisterContextPOSIXCore_arm64.cpp:82-106 +uint32_t +RegisterContextCorePOSIX_arm64::CalculateSVEOffset(uint32_t reg_num) const { + uint32_t sve_offset = 0; + if (m_sve_state ==

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

omjavaid marked an inline comment as done. omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/elf-core/RegisterContextPOSIXCore_arm64.cpp:82-106 +uint32_t +RegisterContextCorePOSIX_arm64::CalculateSVEOffset(uint32_t reg_num) const { + uint32_t sve_offset =

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

labath added inline comments. Comment at: lldb/source/Plugins/Process/elf-core/RegisterContextPOSIXCore_arm64.cpp:82-106 +uint32_t +RegisterContextCorePOSIX_arm64::CalculateSVEOffset(uint32_t reg_num) const { + uint32_t sve_offset = 0; + if (m_sve_state ==

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

omjavaid marked 6 inline comments as done. omjavaid added a comment. In D77047#2125220 , @labath wrote: > There's always a chance for ODR violations, particularly with header files > defining static objects. This looks better though what I really wanted

[Lldb-commits] [PATCH] D83662: [lldb] Refactor character printing in DumpDataExtractor

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f51ceea1f98: [lldb] Refactor character printing in DumpDataExtractor (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] 6f51cee - [lldb] Refactor character printing in DumpDataExtractor

Author: Raphael Isemann Date: 2020-07-14T14:22:03+02:00 New Revision: 6f51ceea1f9858f18133b6101235d26133e11d10 URL: https://github.com/llvm/llvm-project/commit/6f51ceea1f9858f18133b6101235d26133e11d10 DIFF:

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

labath added a comment. Some more comments (and questions) from me. Sorry about the back-and-forth. It's taking me a while to wrap my head around this, and as I start to understand things, new questions arise... Comment at:

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

teemperor added inline comments. Comment at: lldb/source/Host/common/Editline.cpp:1017 + el_insertstr(m_editline, to_add.c_str()); + return CC_REFRESH; +} gedatsu217 wrote: > teemperor wrote: > > gedatsu217 wrote: > > > teemperor wrote:

[Lldb-commits] [lldb] 3cdbacc - [lldb/test] Avoid globbing in log file handling code

Author: Pavel Labath Date: 2020-07-14T13:10:59+02:00 New Revision: 3cdbacc46422b8ed6dc6fb8aaec3dfb58451460f URL: https://github.com/llvm/llvm-project/commit/3cdbacc46422b8ed6dc6fb8aaec3dfb58451460f DIFF: https://github.com/llvm/llvm-project/commit/3cdbacc46422b8ed6dc6fb8aaec3dfb58451460f.diff

[Lldb-commits] [PATCH] D83512: [lldb/Module] Allow for the creation of memory-only modules

labath accepted this revision. labath marked an inline comment as done. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:543-544 + if (m_data.ValidOffsetForDataOfSize(offset,

[Lldb-commits] [PATCH] D83753: Remove use of multiple reg index enums by RegisterContextPOSIX_arm64

omjavaid created this revision. omjavaid added a reviewer: labath. Herald added subscribers: danielkiss, arphaman, kristof.beyls, emaste. This patch removes dependence of RegisterContextPOSIX_arm64 on register number enums defined in lldb-arm64-register-enums.h. RegisterContextPOSIX_arm64 makes

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

omjavaid updated this revision to Diff 277703. omjavaid added a comment. This update makes changes to avoid dependence on lldb-arm64-register-enums.h. Also provides rebased version after update of parent patches. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79699/new/

[Lldb-commits] [PATCH] D83541: Remove Linux sysroot dependencies of SVE PT macros

omjavaid updated this revision to Diff 277702. omjavaid added a comment. This update addresses concerns raised in last iteration. LGTM? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83541/new/ https://reviews.llvm.org/D83541 Files:

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

omjavaid updated this revision to Diff 277701. omjavaid added a comment. This update addresses issues raised in last iteration. Also have removed dependence on lldb-arm64-register-enums.h. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77047/new/ https://reviews.llvm.org/D77047 Files:

[Lldb-commits] [PATCH] D83425: [lldb] add printing of stdout compile errors to lldbsuite

labath added a comment. Using two headers is ok, though I'd like to know what you meant by the "mixed up" comment. Are you saying that the contents comes out nondeterministically? Can you provide an example of that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D83728: [lldb] Make `process connect` blocking in synchronous mode.

labath accepted this revision. labath added a comment. The code looks fine. The test could be cleaned up a bit... Comment at: lldb/source/Target/Platform.cpp:1834 if (error.Fail()) return nullptr; JDevlieghere wrote: > jingham wrote: > > If you fail

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

clayborg requested changes to this revision. clayborg added a comment. See inlined comments. You will also need to fix the test for this since it will now fail as the "symbolStatus" now contains the size. Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:342-349 +uint64_t