[Lldb-commits] [PATCH] D83772: [Windows] Fix limit on command line size

2020-07-21 Thread Serge Pavlov via Phabricator via lldb-commits
sepavloff added reviewers: k8stone, max-kudr. sepavloff added subscribers: max-kudr, k8stone. sepavloff added a comment. @k8stone @max-kudr Could you please review the changes for LLDB? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83772/new/ https

[Lldb-commits] [PATCH] D84257: [lldb] Don't use hardware index to determine whether a breakpoint site is hardware

2020-07-21 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added inline comments. Comment at: lldb/source/Breakpoint/BreakpointLocation.cpp:73 + if (m_bp_site_sp) +return m_bp_site_sp->IsHardware(); + Should we sanity check that this is true when `m_hardware_index != LLDB_INVALID_INDEX32`? ```lldbass

[Lldb-commits] [PATCH] D83772: [Windows] Fix limit on command line size

2020-07-21 Thread Serge Pavlov via Phabricator via lldb-commits
sepavloff updated this revision to Diff 279709. sepavloff added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Added changes for LLDB Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83772/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D82155: [lldb/interpreter] Add ability to save lldb session to a file

2020-07-21 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:2941 + + GetDebugger().GetOutputStreamSP()->Printf( + "Session's transcripts saved to %s\n",

[Lldb-commits] [lldb] e9f5ca0 - [lldb] Adjust for getIntegerConstantExpression refactor

2020-07-21 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-07-21T23:04:22-07:00 New Revision: e9f5ca0b7977bb3886feae0d35617a0ea9349a2a URL: https://github.com/llvm/llvm-project/commit/e9f5ca0b7977bb3886feae0d35617a0ea9349a2a DIFF: https://github.com/llvm/llvm-project/commit/e9f5ca0b7977bb3886feae0d35617a0ea9349a2a.d

[Lldb-commits] [lldb] 8632931 - [DWARFYAML] Make the length field of compilation units optional. NFC.

2020-07-21 Thread Xing GUO via lldb-commits
Author: Xing GUO Date: 2020-07-22T12:16:19+08:00 New Revision: 86329317873e46f8bc094b05437a44a1f65c55d6 URL: https://github.com/llvm/llvm-project/commit/86329317873e46f8bc094b05437a44a1f65c55d6 DIFF: https://github.com/llvm/llvm-project/commit/86329317873e46f8bc094b05437a44a1f65c55d6.diff LOG:

[Lldb-commits] [PATCH] D84267: Thread ExecutionContextScope through GetByteSize where possible (NFC-ish)

2020-07-21 Thread Jim Ingham via Phabricator via lldb-commits
jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. I think you missed two more places to pass a target, then this looks good to me. How tedious, thanks for doing it... Comment at: lldb/source/Commands/CommandObjectTarget.

[Lldb-commits] [PATCH] D84285: Unify the return value of GetByteSize to an llvm::Optional (NFC-ish)

2020-07-21 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl marked an inline comment as done. aprantl added inline comments. Comment at: lldb/source/Target/StackFrame.cpp:1445 +int64_t index = offset / pointee->GetByteSize().getValueOr(1); +offset = offset % pointee->GetByteSize().getValueOr(1); const bool can_create

[Lldb-commits] [PATCH] D84285: Unify the return value of GetByteSize to an llvm::Optional (NFC-ish)

2020-07-21 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl created this revision. aprantl added reviewers: jingham, shafik, teemperor. Herald added a project: LLDB. This cleanup patch unifies all methods called GetByteSize in the ValueObject hierarchy to return an optional, like the methods in CompilerType do. This means fewer magic `0` values,

[Lldb-commits] [PATCH] D84267: Thread ExecutionContextScope through GetByteSize where possible (NFC-ish)

2020-07-21 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl updated this revision to Diff 279675. aprantl marked 6 inline comments as done. aprantl added a comment. Added missed opportunities pointed out by Jim! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84267/new/ https://reviews.llvm.org/D84267 Files: lldb/include/lldb/Symbol/Com

[Lldb-commits] [PATCH] D84267: Thread ExecutionContextScope through GetByteSize where possible (NFC-ish)

2020-07-21 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl updated this revision to Diff 279670. aprantl added a comment. Add another PPC syntax failure. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84267/new/ https://reviews.llvm.org/D84267 Files: lldb/include/lldb/Symbol/CompilerType.h lldb/include/lldb/Symbol/Type.h lldb/incl

[Lldb-commits] [PATCH] D84267: Thread ExecutionContextScope through GetByteSize where possible (NFC-ish)

2020-07-21 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. I pointed out a couple of places where you have either at hand or near at hand a useful exe_ctx that you could pass instead of nullptr. Other than that, this seems good to me. Thanks for pushing this through. Comment at: lldb/source/API/SBType.cpp:21

[Lldb-commits] [PATCH] D84267: Thread ExecutionContextScope through GetByteSize where possible (NFC-ish)

2020-07-21 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl updated this revision to Diff 279660. aprantl marked an inline comment as done. aprantl added a comment. Upload the *entire* patch m( CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84267/new/ https://reviews.llvm.org/D84267 Files: lldb/include/lldb/Symbol/CompilerType.h lldb

[Lldb-commits] [PATCH] D84272: Add checks for ValueObjectSP in Cocoa summary providers

2020-07-21 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. The `!text` test is correct, since you intend to pass `*text` in as a `ValueObject &`. But I wouldn't add the GetValueAsUnsigned check, that seems confusing. The NSStringSummaryProvider is returning a bool to tell you whether it succeeded or not, so it seems odd to pr

[Lldb-commits] [PATCH] D84267: Thread ExecutionContextScope through GetByteSize where possible (NFC-ish)

2020-07-21 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. The patch lost seems to have lost everything but the PPC, SystemZ and MIPS code... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84267/new/ https://reviews.llvm.org/D84267 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D84272: Add checks for ValueObjectSP in Cocoa summary providers

2020-07-21 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik created this revision. shafik added a reviewer: jingham. We saw a crash recently that looks related to we had good `ValueObjectSP` for some Cocoa summary providers. This adds checks before we use them when calling `NSStringSummaryProvider`. https://reviews.llvm.org/D84272 Files: lldb

[Lldb-commits] [PATCH] D82155: [lldb/interpreter] Add ability to save lldb session to a file

2020-07-21 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib updated this revision to Diff 279639. mib added a comment. Reformat patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82155/new/ https://reviews.llvm.org/D82155 Files: lldb/include/lldb/Interpreter/CommandInterpreter.h lldb/source/Comma

[Lldb-commits] [PATCH] D82155: [lldb/interpreter] Add ability to save lldb session to a file

2020-07-21 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib updated this revision to Diff 279638. mib marked 6 inline comments as done. mib added a comment. Address @JDevlieghere comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82155/new/ https://reviews.llvm.org/D82155 Files: lldb/include/lld

[Lldb-commits] [PATCH] D84267: Thread ExecutionContextScope through GetByteSize where possible (NFC-ish)

2020-07-21 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl marked 3 inline comments as done. aprantl added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp:308 lldb::TargetSP target_sp(m_execution_unit.GetTarget()); - lldb_private::ExecutionContext exe_ctx(target_sp, true); - llvm::Opti

[Lldb-commits] [PATCH] D84267: Thread ExecutionContextScope through GetByteSize where possible (NFC-ish)

2020-07-21 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl updated this revision to Diff 279634. aprantl added a comment. Fix `&Thread` copy&paste errors. Good catch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84267/new/ https://reviews.llvm.org/D84267 Files: lldb/source/Plugins/ABI/ARC/ABISysV_arc.cpp lldb/source/Plugins/ABI/Mi

[Lldb-commits] [PATCH] D84267: Thread ExecutionContextScope through GetByteSize where possible (NFC-ish)

2020-07-21 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added inline comments. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:4092 TypeSystemClang::GetArrayElementType(lldb::opaque_compiler_type_t type, - uint64_t *stride) { if (type) { So we alre

[Lldb-commits] [PATCH] D84263: [debugserver/Apple Silicon] Handoff connections when attaching to translated processes

2020-07-21 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda added a comment. With this patch, debugging a translated app will only work when we invoke debugserver with --fd for its communication back to lldb. e.g. running 'debugserver localhost:2000 --attach=translated-app' will pass -fd=-1 as a command line argument to /Library/Apple/usr/

[Lldb-commits] [PATCH] D84267: Thread ExecutionContextScope through GetByteSize where possible (NFC-ish)

2020-07-21 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added inline comments. Comment at: lldb/source/Plugins/ABI/ARC/ABISysV_arc.cpp:461 if (type_flags & eTypeIsInteger) { -const size_t byte_size = compiler_type.GetByteSize(nullptr).getValueOr(0); +const size_t byte_size = compiler_type.GetByteSize(thread).getVa

[Lldb-commits] [PATCH] D84267: Thread ExecutionContextScope through GetByteSize where possible (NFC-ish)

2020-07-21 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp:308 lldb::TargetSP target_sp(m_execution_unit.GetTarget()); - lldb_private::ExecutionContext exe_ctx(target_sp, true); - llvm::Optional bit_size = - m_result_type.GetBit

[Lldb-commits] [PATCH] D84267: Thread ExecutionContextScope through GetByteSize where possible (NFC-ish)

2020-07-21 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik added inline comments. Comment at: lldb/source/Plugins/ABI/ARC/ABISysV_arc.cpp:461 if (type_flags & eTypeIsInteger) { -const size_t byte_size = compiler_type.GetByteSize(nullptr).getValueOr(0); +const size_t byte_size = compiler_type.GetByteSize(thread).getValue

[Lldb-commits] [PATCH] D84269: [lldb] Add some example type anotations to python.swig

2020-07-21 Thread Nathan Lanza via Phabricator via lldb-commits
lanza created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Python3.5 (3.4?) added type annotations to the python language. This lets tools such as LSPs provide useful IDE-like completion when writing python. Add type annotations throughout the python swig

[Lldb-commits] [PATCH] D84267: Thread ExecutionContextScope through GetByteSize where possible (NFC-ish)

2020-07-21 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl created this revision. aprantl added reviewers: jingham, shafik. Herald added subscribers: atanasyan, jrtc27, kbarton, nemanjai, sdardis. Herald added a project: LLDB. This patch has no effect for C and C++. In more dynamic languages, such as Objective-C and Swift GetByteSize() needs to c

[Lldb-commits] [PATCH] D84263: [debugserver/Apple Silicon] Handoff connections when attaching to translated processes

2020-07-21 Thread Davide Italiano via Phabricator via lldb-commits
davide created this revision. davide added a reviewer: jasonmolenda. When we detect a process that the native debugserver cannot handle, handoff the connection fd to the translated debugserver. https://reviews.llvm.org/D84263 Files: lldb/tools/debugserver/source/DNB.cpp lldb/tools/debugser

[Lldb-commits] [PATCH] D84257: [lldb] Don't use hardware index to determine whether a breakpoint site is hardware

2020-07-21 Thread Tatyana Krasnukha via Phabricator via lldb-commits
tatyana-krasnukha added a comment. Probably fixes llvm.org/PR44659, though I cannot check on arm/aarch64. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84257/new/ https://reviews.llvm.org/D84257 ___ ll

Re: [Lldb-commits] [lldb] cd05406 - [testsuite] Adapt lldb-server base test helper to run on arm64

2020-07-21 Thread Davidino Italiano via lldb-commits
> On Jul 21, 2020, at 5:17 AM, Pavel Labath wrote: > > On 20/07/2020 23:38, Davide Italiano via lldb-commits wrote: >> @@ -1601,8 +1601,18 @@ def single_step_only_steps_one_instruction( >> # variable value >> if re.match("s390x", arch): >> expected_step_count = 2 >>

Re: [Lldb-commits] [lldb] 62ccfb6 - [LLDB] Fix Arm/AArch64 Linux broken build

2020-07-21 Thread Davidino Italiano via lldb-commits
> On Jul 21, 2020, at 1:47 AM, Muhammad Omair Javaid via lldb-commits > wrote: > > > Author: Muhammad Omair Javaid > Date: 2020-07-21T13:46:39+05:00 > New Revision: 62ccfb6ed0bed899f22abc00bec96a372420c5d0 > > URL: > https://github.com/llvm/llvm-project/commit/62ccfb6ed0bed899f22abc00bec96a

[Lldb-commits] [PATCH] D84253: OptionValue::Clear should return void not bool

2020-07-21 Thread Jim Ingham via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8d6aa688eeff: Remove the "bool" return from OptionValue::Clear and its subclasses. (authored by jingham). Changed prior to commit: https://reviews.llvm.org/D84253?vs=279580&id=279594#toc Repository:

[Lldb-commits] [lldb] 8d6aa68 - Remove the "bool" return from OptionValue::Clear and its subclasses.

2020-07-21 Thread Jim Ingham via lldb-commits
Author: Jim Ingham Date: 2020-07-21T11:32:55-07:00 New Revision: 8d6aa688eeffea4b9151d1a208ed619ca50c823a URL: https://github.com/llvm/llvm-project/commit/8d6aa688eeffea4b9151d1a208ed619ca50c823a DIFF: https://github.com/llvm/llvm-project/commit/8d6aa688eeffea4b9151d1a208ed619ca50c823a.diff LO

[Lldb-commits] [lldb] 46334df - [lldb/test] Skip test in TestBitfieldIvars.py instead of xfailing it

2020-07-21 Thread Vedant Kumar via lldb-commits
Author: Vedant Kumar Date: 2020-07-21T11:29:09-07:00 New Revision: 46334dfc3ba99ee5300675f8300b9044e350f2ff URL: https://github.com/llvm/llvm-project/commit/46334dfc3ba99ee5300675f8300b9044e350f2ff DIFF: https://github.com/llvm/llvm-project/commit/46334dfc3ba99ee5300675f8300b9044e350f2ff.diff

[Lldb-commits] [PATCH] D84257: [lldb] Don't use hardware index to determine whether a breakpoint site is hardware

2020-07-21 Thread Tatyana Krasnukha via Phabricator via lldb-commits
tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: clayborg, labath, JDevlieghere. tatyana-krasnukha added a project: LLDB. Herald added subscribers: lldb-commits, arphaman. Most process plugins (if not all) don't set hardware index for breakpoints. They even are not able

[Lldb-commits] [PATCH] D84255: [lldb] Make process plugins check whether a hardware breakpoint is required

2020-07-21 Thread Tatyana Krasnukha via Phabricator via lldb-commits
tatyana-krasnukha created this revision. tatyana-krasnukha added a reviewer: clayborg. tatyana-krasnukha added a project: LLDB. Herald added subscribers: lldb-commits, emaste. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84255 Files: lldb/source/Plugins/Process/FreeBSD/Proce

[Lldb-commits] [PATCH] D84254: [lldb] Skip overlapping hardware and external breakpoints when writing memory

2020-07-21 Thread Tatyana Krasnukha via Phabricator via lldb-commits
tatyana-krasnukha created this revision. tatyana-krasnukha added a reviewer: clayborg. tatyana-krasnukha added a project: LLDB. Herald added a subscriber: lldb-commits. This fixes the assertion `assert(intersects);` in the Process::WriteMemory function. Repository: rG LLVM Github Monorepo ht

[Lldb-commits] [PATCH] D84253: OptionValue::Clear should return void not bool

2020-07-21 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84253/new/ https://reviews.llvm.org/D84253 __

[Lldb-commits] [PATCH] D84253: OptionValue::Clear should return void not bool

2020-07-21 Thread Jim Ingham via Phabricator via lldb-commits
jingham created this revision. jingham added a reviewer: JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I forgot to add a "return true" to the new OptionValueFileColonLine::Clear method which the Windows compiler caught (thanks Jonas for fixing that!) But th

[Lldb-commits] [lldb] dd064af - [lldb] Add missing member initialziation list

2020-07-21 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-07-21T10:15:38-07:00 New Revision: dd064afe84b3fd01ef3407dec0aeb22720450048 URL: https://github.com/llvm/llvm-project/commit/dd064afe84b3fd01ef3407dec0aeb22720450048 DIFF: https://github.com/llvm/llvm-project/commit/dd064afe84b3fd01ef3407dec0aeb22720450048.d

[Lldb-commits] [lldb] e031eda - Revert "[lldb] Unify type name matching in FormattersContainer"

2020-07-21 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2020-07-21T19:03:33+02:00 New Revision: e031eda08df471c67f9a37289072d338517457a9 URL: https://github.com/llvm/llvm-project/commit/e031eda08df471c67f9a37289072d338517457a9 DIFF: https://github.com/llvm/llvm-project/commit/e031eda08df471c67f9a37289072d338517457a9.dif

[Lldb-commits] [lldb] 98efa3d - [lldb] Change the CommandArgumentData ctor (NFC)

2020-07-21 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-07-21T09:50:30-07:00 New Revision: 98efa3d57f0a38c9cd5433640a9abe6e7d9b7513 URL: https://github.com/llvm/llvm-project/commit/98efa3d57f0a38c9cd5433640a9abe6e7d9b7513 DIFF: https://github.com/llvm/llvm-project/commit/98efa3d57f0a38c9cd5433640a9abe6e7d9b7513.d

[Lldb-commits] [PATCH] D84151: [lldb] Unify type name matching in FormattersContainer

2020-07-21 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG5b0de5756ccc: [lldb] Unify type name matching in FormattersContainer (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D83541: Remove Linux sysroot dependencies of SVE PT macros

2020-07-21 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. This broke the Windows build: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/17701 Can you take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83541/new/ https://reviews.llvm.org/D83541 ___

[Lldb-commits] [lldb] 5b0de57 - [lldb] Unify type name matching in FormattersContainer

2020-07-21 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2020-07-21T18:44:50+02:00 New Revision: 5b0de5756ccc7a540926e4eeaa3b398539d88cd8 URL: https://github.com/llvm/llvm-project/commit/5b0de5756ccc7a540926e4eeaa3b398539d88cd8 DIFF: https://github.com/llvm/llvm-project/commit/5b0de5756ccc7a540926e4eeaa3b398539d88cd8.dif

[Lldb-commits] [PATCH] D82155: [lldb/interpreter] Add ability to save lldb session to a file

2020-07-21 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added inline comments. Comment at: lldb/include/lldb/Interpreter/CommandInterpreter.h:532 + bool SaveTranscripts(std::string file_path); + - Is there more than one transcript? - Maybe make the string optional as you have logic to deal with that

[Lldb-commits] [lldb] 1c9cc09 - [lldb] Fix typo that went unnoticed on my case insensitive FS

2020-07-21 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-07-21T09:13:26-07:00 New Revision: 1c9cc094d033d3e8dcc1a5e410ddcc973449b5e1 URL: https://github.com/llvm/llvm-project/commit/1c9cc094d033d3e8dcc1a5e410ddcc973449b5e1 DIFF: https://github.com/llvm/llvm-project/commit/1c9cc094d033d3e8dcc1a5e410ddcc973449b5e1.d

Re: [Lldb-commits] [lldb] f8df2e1 - [lldb/Reproducers] Always record the current working directory

2020-07-21 Thread Jonas Devlieghere via lldb-commits
On Tue, Jul 21, 2020 at 5:06 AM Pavel Labath wrote: > On 20/07/2020 20:54, Jonas Devlieghere via lldb-commits wrote: > > > > Author: Jonas Devlieghere > > Date: 2020-07-20T11:54:11-07:00 > > New Revision: f8df2e1a19913e997d8d6dbe573de977406e736e > > > > URL: > https://github.com/llvm/llvm-project

[Lldb-commits] [lldb] 9f8d481 - [lldb/Reproducers] Don't recursively record everything in the CWD

2020-07-21 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-07-21T09:02:38-07:00 New Revision: 9f8d481d6816d620fc0a1f1c510f662c01fdacec URL: https://github.com/llvm/llvm-project/commit/9f8d481d6816d620fc0a1f1c510f662c01fdacec DIFF: https://github.com/llvm/llvm-project/commit/9f8d481d6816d620fc0a1f1c510f662c01fdacec.d

[Lldb-commits] [PATCH] D83552: [lldb/test] Do a better job at setting (DY)LD_LIBRARY_PATH

2020-07-21 Thread Frederic Riss via Phabricator via lldb-commits
friss accepted this revision. friss added a comment. This revision is now accepted and ready to land. In D83552#2162782 , @labath wrote: > In D83552#2162555 , @friss wrote: > > > The `lldbtest.py` part LGTM, but I'm

[Lldb-commits] [PATCH] D82155: [lldb/interpreter] Add ability to save lldb session to a file

2020-07-21 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib updated this revision to Diff 279519. mib added a comment. Reformat. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82155/new/ https://reviews.llvm.org/D82155 Files: lldb/include/lldb/Interpreter/CommandInterpreter.h lldb/source/Commands/CM

[Lldb-commits] [PATCH] D84070: [LLDB] [COFF] Fix handling of symbols with more than one aux symbol

2020-07-21 Thread Hans Wennborg via Phabricator via lldb-commits
hans added a comment. In D84070#2162932 , @mstorsjo wrote: > @hans - I think this one could be a fairly safe backport to the release > branch. (Apparently phab lags behind regarding updating the reviews when they > are committed at the moment; this was c

[Lldb-commits] [PATCH] D82155: [lldb/interpreter] Add ability to save lldb session to a file

2020-07-21 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib updated this revision to Diff 279505. mib retitled this revision from "[WIP][lldb/interpreter] Add ability to save lldb session to a file" to "[lldb/interpreter] Add ability to save lldb session to a file". mib added a comment. - Address previous comments - Add test Repository: rG LLVM G

Re: [Lldb-commits] [lldb] cd05406 - [testsuite] Adapt lldb-server base test helper to run on arm64

2020-07-21 Thread Pavel Labath via lldb-commits
On 20/07/2020 23:38, Davide Italiano via lldb-commits wrote: > @@ -1601,8 +1601,18 @@ def single_step_only_steps_one_instruction( > # variable value > if re.match("s390x", arch): > expected_step_count = 2 > +# ARM64 requires "4" instructions: 2 to compute the

Re: [Lldb-commits] [lldb] f8df2e1 - [lldb/Reproducers] Always record the current working directory

2020-07-21 Thread Pavel Labath via lldb-commits
On 20/07/2020 20:54, Jonas Devlieghere via lldb-commits wrote: > > Author: Jonas Devlieghere > Date: 2020-07-20T11:54:11-07:00 > New Revision: f8df2e1a19913e997d8d6dbe573de977406e736e > > URL: > https://github.com/llvm/llvm-project/commit/f8df2e1a19913e997d8d6dbe573de977406e736e > DIFF: > https

[Lldb-commits] [PATCH] D84154: [lldb] Remove FormattersContainer's name member

2020-07-21 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG5c15426d7c62: [lldb] Remove FormattersContainer's name member (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [lldb] 5c15426 - [lldb] Remove FormattersContainer's name member

2020-07-21 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2020-07-21T13:54:38+02:00 New Revision: 5c15426d7c62aa8c38547144f28c5a1c6e50549a URL: https://github.com/llvm/llvm-project/commit/5c15426d7c62aa8c38547144f28c5a1c6e50549a DIFF: https://github.com/llvm/llvm-project/commit/5c15426d7c62aa8c38547144f28c5a1c6e50549a.dif

[Lldb-commits] [lldb] b621e8c - [LLDB] Fix build on windows caused by LinuxPTraceDefines_arm64sve.h

2020-07-21 Thread Muhammad Omair Javaid via lldb-commits
Author: Muhammad Omair Javaid Date: 2020-07-21T16:47:25+05:00 New Revision: b621e8c787b3e20aa9e9dc940bfd4a792cd2a06c URL: https://github.com/llvm/llvm-project/commit/b621e8c787b3e20aa9e9dc940bfd4a792cd2a06c DIFF: https://github.com/llvm/llvm-project/commit/b621e8c787b3e20aa9e9dc940bfd4a792cd2a0

[Lldb-commits] [lldb] 6960e39 - [LLDB] Fix LinuxPTraceDefines_arm64sve.h for AArch64 Linux host

2020-07-21 Thread Muhammad Omair Javaid via lldb-commits
Author: Muhammad Omair Javaid Date: 2020-07-21T14:31:47+05:00 New Revision: 6960e39eff0a3363ca7dc6b7cf8134180b7d101f URL: https://github.com/llvm/llvm-project/commit/6960e39eff0a3363ca7dc6b7cf8134180b7d101f DIFF: https://github.com/llvm/llvm-project/commit/6960e39eff0a3363ca7dc6b7cf8134180b7d10

[Lldb-commits] [lldb] 510e37c - Revert "Revert "AArch64 SVE register infos and core file support""

2020-07-21 Thread Muhammad Omair Javaid via lldb-commits
Author: Muhammad Omair Javaid Date: 2020-07-21T14:31:47+05:00 New Revision: 510e37c88c1203de341c23e0878c994478d2594f URL: https://github.com/llvm/llvm-project/commit/510e37c88c1203de341c23e0878c994478d2594f DIFF: https://github.com/llvm/llvm-project/commit/510e37c88c1203de341c23e0878c994478d259

[Lldb-commits] [lldb] 62ccfb6 - [LLDB] Fix Arm/AArch64 Linux broken build

2020-07-21 Thread Muhammad Omair Javaid via lldb-commits
Author: Muhammad Omair Javaid Date: 2020-07-21T13:46:39+05:00 New Revision: 62ccfb6ed0bed899f22abc00bec96a372420c5d0 URL: https://github.com/llvm/llvm-project/commit/62ccfb6ed0bed899f22abc00bec96a372420c5d0 DIFF: https://github.com/llvm/llvm-project/commit/62ccfb6ed0bed899f22abc00bec96a372420c5