[Lldb-commits] [lldb] 10b1b4a - [CMake] Simplify CMake handling for zlib

Author: Petr Hosek Date: 2020-07-23T23:05:36-07:00 New Revision: 10b1b4a231a485f1711d576e6131f6755e008abe URL: https://github.com/llvm/llvm-project/commit/10b1b4a231a485f1711d576e6131f6755e008abe DIFF: https://github.com/llvm/llvm-project/commit/10b1b4a231a485f1711d576e6131f6755e008abe.diff LO

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

omjavaid marked 3 inline comments as done. omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:240 + // Update SVE registers in case there is change in configuration. + ConfigureRegisterContext(); + ---

[Lldb-commits] [PATCH] D84480: debugserver: Support ios simulator load command disambiguation in qProcessInfo

friss accepted this revision. friss added a comment. This revision is now accepted and ready to land. LGTM! Comment at: lldb/tools/debugserver/source/DNB.cpp:1396 if (GetProcessSP(pid, procSP)) { -// FIXME: This doesn't correct for older ios simulator and macCatalyst. +

[Lldb-commits] [PATCH] D84480: debugserver: Support ios simulator load command disambiguation in qProcessInfo

aprantl updated this revision to Diff 280307. aprantl added a comment. Update comment. I wonder if it is feasible to give the macCatalyst code the same treatment. It's more tricky because supporting zippered objects would force some additional state into the function. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D84480: debugserver: Support ios simulator load command disambiguation in qProcessInfo

aprantl created this revision. aprantl added reviewers: friss, davide, jasonmolenda. This patch basically moves the disambiguation code from a place where it was complicated to implement straight to where the load command is parsed, which has the neat side affect of actually supporting all call

[Lldb-commits] [PATCH] D83972: Modify ImportDefiniton for ObjCInterfaceDecl so that we always the ImportDeclContext one we start the definition

shafik updated this revision to Diff 280291. shafik added a comment. Updating diff since the parent landed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83972/new/ https://reviews.llvm.org/D83972 Files: clang/lib/AST/ASTImporter.cpp lldb/test/API/lang/objc/bitfield_ivars/TestBitfi

[Lldb-commits] [PATCH] D84475: [lldb] Inform every language runtime of the modified modules

JDevlieghere created this revision. JDevlieghere added reviewers: jingham, labath, clayborg. Herald added a subscriber: abidh. When a process is notified that modules got loaded, currently only existing language runtimes are given a chance to deal with that. This means that if the runtime for a

[Lldb-commits] [PATCH] D84402: [lldb/DWARF] Add more line table validation

clayborg added a comment. If we do make a set of text ranges in SymbolFileDWARF, we should avoid producing function's whose address ranges are not within these bounds as well, so there are other uses for this text ranges list in SymbolFileDWARF. Repository: rG LLVM Github Monorepo CHANGES S

[Lldb-commits] [PATCH] D84402: [lldb/DWARF] Add more line table validation

clayborg added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1044 for (const llvm::DWARFDebugLine::Sequence &seq : line_table->Sequences) { +if (!list.ContainsFileAddressRange(seq.LowPC, seq.HighPC - seq.LowPC)) + continue;

[Lldb-commits] [lldb] 38c71b7 - Revert "[CMake] Simplify CMake handling for zlib"

Author: Petr Hosek Date: 2020-07-23T15:12:42-07:00 New Revision: 38c71b7c85cac4c8de39329ff3ed682e63f61525 URL: https://github.com/llvm/llvm-project/commit/38c71b7c85cac4c8de39329ff3ed682e63f61525 DIFF: https://github.com/llvm/llvm-project/commit/38c71b7c85cac4c8de39329ff3ed682e63f61525.diff LO

[Lldb-commits] [PATCH] D84402: [lldb/DWARF] Add more line table validation

dblaikie added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1044 for (const llvm::DWARFDebugLine::Sequence &seq : line_table->Sequences) { +if (!list.ContainsFileAddressRange(seq.LowPC, seq.HighPC - seq.LowPC)) + continue;

[Lldb-commits] [lldb] 1d09ecf - [CMake] Simplify CMake handling for zlib

Author: Petr Hosek Date: 2020-07-23T14:47:25-07:00 New Revision: 1d09ecf36175f7910ffedd6d497c07b5c74c22fb URL: https://github.com/llvm/llvm-project/commit/1d09ecf36175f7910ffedd6d497c07b5c74c22fb DIFF: https://github.com/llvm/llvm-project/commit/1d09ecf36175f7910ffedd6d497c07b5c74c22fb.diff LO

[Lldb-commits] [PATCH] D84401: [lldb] Add SectionList::ContainsFileAddressRange

clayborg added inline comments. Comment at: lldb/include/lldb/Core/Section.h:75 + /// sections in this list. + bool ContainsFileAddressRange(lldb::addr_t addr, lldb::addr_t size) const; + JDevlieghere wrote: > `addr_t` looks a bit weird for the size, but then `

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 280261. aelitashen added a comment. Fix run_test to cover every system case and attributes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83731/new/ https://reviews.llvm.org/D83731 Files: clang/tools/clang

[Lldb-commits] [Differential] D78648: [CMake] Bump CMake minimum version to 3.13.4

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGafa1afd4108d: [CMake] Bump CMake minimum version to 3.13.4 (authored by ldionne). Herald added subscribers: llvm-commits, msifontes, sstefan1, jurahu

[Lldb-commits] [PATCH] D84126: Enable -Wsuggest-override in the LLVM build

nemanjai added a comment. Herald added a subscriber: wuzish. There is a lot of instances where this warning fires in the unit tests since gtest does not appear to use the `override` keyword. This in turn causes failures on bootstrap builds that use `-Werror`. An example: http://lab.llvm.org:801

[Lldb-commits] [PATCH] D84126: Enable -Wsuggest-override in the LLVM build

logan-5 added a comment. In D84126#2165585 , @nemanjai wrote: > There is a lot of instances where this warning fires in the unit tests since > gtest does not appear to use the `override` keyword. This in turn causes > failures on bootstrap builds that us

[Lldb-commits] [PATCH] D84126: Enable -Wsuggest-override in the LLVM build

logan-5 added a comment. In D84126#2166952 , @erichkeane wrote: > I'd suggest disabling this unless the GCC version is >9.1. I've got a patch addressing exactly this issue here, hoping to get it landed soon: https://reviews.llvm.org/D84292 Thanks again

[Lldb-commits] [PATCH] D84126: Enable -Wsuggest-override in the LLVM build

erichkeane added a comment. Ive got a bit a of a problem here: This flag (suggest-override) on GCC 8.3 (and others) warns on missing-override EVEN WHEN the function is marked 'final'. This was not fixed until GCC 9.2: https://godbolt.org/z/55KeM3 The result is my build gave a few thousand diag

[Lldb-commits] [PATCH] D78648: [CMake] Bump CMake minimum version to 3.13.4

ldionne added a comment. Herald added subscribers: llvm-commits, msifontes, sstefan1, jurahul, stephenneuendorffer, aartbik. Herald added projects: MLIR, LLVM. Okay, the previous patch has landed and no issues have come up, so I'm going to move forward with this patch now. Repository: rG LLV

[Lldb-commits] [PATCH] D78648: [CMake] Bump CMake minimum version to 3.13.4

This revision was automatically updated to reflect the committed changes. Closed by commit rGafa1afd4108d: [CMake] Bump CMake minimum version to 3.13.4 (authored by ldionne). Changed prior to commit: https://reviews.llvm.org/D78648?vs=259300&id=279895#toc Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D84126: Enable -Wsuggest-override in the LLVM build

logan-5 created this revision. logan-5 added reviewers: dblaikie, rnk, aaron.ballman, ldionne. Herald added subscribers: llvm-commits, libcxx-commits, lldb-commits, lebedev.ri, dexonsmith, mgorny. Herald added a reviewer: lebedev.ri. Herald added projects: LLDB, libc++, libc++abi, LLVM. Herald add

[Lldb-commits] [PATCH] D84126: Enable -Wsuggest-override in the LLVM build

logan-5 added a comment. All the failures related to this patch are now resolved as far as I can tell. I'm very sorry for the trouble. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84126/new/ https://reviews.llvm.org/D84126

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

gedatsu217 added a comment. I checked what's the sequence that actually gets output, and it was like below. h\x1b[2melp frame\x1b[0m\x1b[1Ghe\x1b[2mlp frame\x1b[0m\x1b[1Gel\x1b[2mp frame\x1b[0m\x1b[1Gl Is it not good to check these characters in `expect_exact`? CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D84440: [llb] Remove the user-defined copy-ctor in ConstString

This revision was automatically updated to reflect the committed changes. Closed by commit rGcee60bbf417d: [lldb] Remove the user-defined copy-ctor in ConstString (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D84440?vs=280174&id=2802

[Lldb-commits] [lldb] cee60bb - [lldb] Remove the user-defined copy-ctor in ConstString

Author: Jonas Devlieghere Date: 2020-07-23T13:09:08-07:00 New Revision: cee60bbf417dbec1cb3df6fc465ac06295a0cd9d URL: https://github.com/llvm/llvm-project/commit/cee60bbf417dbec1cb3df6fc465ac06295a0cd9d DIFF: https://github.com/llvm/llvm-project/commit/cee60bbf417dbec1cb3df6fc465ac06295a0cd9d.d

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

clayborg added inline comments. Comment at: lldb/test/API/tools/lldb-vscode/module/TestVSCode_module.py:55-61 +active_modules = self.vscode.get_active_modules() +program_module = active_modules[program_basename] +self.assertEqual(program_basena

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen marked an inline comment as done. aelitashen added inline comments. Comment at: lldb/test/API/tools/lldb-vscode/module/TestVSCode_module.py:55-61 +active_modules = self.vscode.get_active_modules() +program_module = active_modules[program_basenam

[Lldb-commits] [PATCH] D84440: [llb] Remove the user-defined copy-ctor in ConstString

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Btw, this might spawn a bunch of warnings about unused ConstString variables (I remember I did a similar change locally to find unused ConstStrings some time ago) as the compiler maybe n

[Lldb-commits] [PATCH] D84440: [llb] Remove the user-defined copy-ctor in ConstString

shafik added inline comments. Comment at: lldb/include/lldb/Utility/ConstString.h:45 /// Initializes the string to an empty string. ConstString() : m_string(nullptr) {} Since your touching this type, why not modernize it and use an in class member initia

[Lldb-commits] [PATCH] D84285: Unify the return value of GetByteSize to an llvm::Optional (NFC-ish)

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Expression/Materializer.cpp:283 (uint64_t)mem, - (unsigned long long)m_persistent_variable_sp->GetByteSize())

[Lldb-commits] [PATCH] D84272: Add checks for ValueObjectSP in Cocoa summary providers

shafik added a comment. I updated to include the radar number. So we have a crash in `NSStringSummaryProvider(...)` when calling `valobj.GetProcessSP()` and we have what looks like a `nullptr` e.g. `0x0068` In this specific case we are coming from `NSBundleSummaryProvider(...)` and

[Lldb-commits] [PATCH] D84440: [llb] Remove the user-defined copy-ctor in ConstString

JDevlieghere created this revision. JDevlieghere added reviewers: labath, aprantl. ConstString is essentially trivially copyable yet it has a user defined copy constructor that copies its one member pointer. Remove it so it qualifies as trivial in the eyes of the compiler. Repository: rLLDB

[Lldb-commits] [PATCH] D84017: [lldb] Make socket_packet_pump.py work in Python3

This revision was automatically updated to reflect the committed changes. Closed by commit rG4a3a821c68a1: [lldb] Make socket_packet_pump.py work in Python3 (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANG

[Lldb-commits] [lldb] 4a3a821 - [lldb] Make socket_packet_pump.py work in Python3

Author: Raphael Isemann Date: 2020-07-23T18:36:50+02:00 New Revision: 4a3a821c68a1ca4a44de86c5fe88b026134b39c9 URL: https://github.com/llvm/llvm-project/commit/4a3a821c68a1ca4a44de86c5fe88b026134b39c9 DIFF: https://github.com/llvm/llvm-project/commit/4a3a821c68a1ca4a44de86c5fe88b026134b39c9.dif

[Lldb-commits] [PATCH] D84296: [lldb][NFC] Remove FormatMap

This revision was automatically updated to reflect the committed changes. Closed by commit rG77ae06b8c6c7: [lldb][NFC] Remove FormatMap (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior to commit: https://reviews.llvm.org/D84296?vs=279

[Lldb-commits] [lldb] 77ae06b - [lldb][NFC] Remove FormatMap

Author: Raphael Isemann Date: 2020-07-23T18:34:59+02:00 New Revision: 77ae06b8c6c7425c0376dbd526390ba1f48b3db5 URL: https://github.com/llvm/llvm-project/commit/77ae06b8c6c7425c0376dbd526390ba1f48b3db5 DIFF: https://github.com/llvm/llvm-project/commit/77ae06b8c6c7425c0376dbd526390ba1f48b3db5.dif

Re: [Lldb-commits] [lldb] 074b121 - Reland [lldb] Unify type name matching in FormattersContainer

That's actually a better idea. Relanded it with the member removed and constructor deleted. Thanks! - Raphael > On 23 Jul 2020, at 09:49, Eric Christopher wrote: > > Hi Raphael, > > I've temporarily reverted this again with hopefully a better explanation here: > > echristo@athyra ~/s/llvm-pr

Re: [Lldb-commits] [lldb] 0d5fc82 - [lldb] Eliminate unneeded value parameters in Utility (NFC)

Is there some clever C++ way to prohibit taking an object's address (similar to how you can delete a copy constructor)? -- adrian > On Jul 23, 2020, at 12:20 AM, Pavel Labath wrote: > > On 22/07/2020 22:56, Jonas Devlieghere via lldb-commits wrote: >> - ConstString operator=(ConstString rhs)

[Lldb-commits] [PATCH] D84401: [lldb] Add SectionList::ContainsFileAddressRange

JDevlieghere accepted this revision. JDevlieghere added inline comments. This revision is now accepted and ready to land. Comment at: lldb/include/lldb/Core/Section.h:75 + /// sections in this list. + bool ContainsFileAddressRange(lldb::addr_t addr, lldb::addr_t size) const; +

[Lldb-commits] [lldb] 4d489e9 - Reland [lldb] Unify type name matching in FormattersContainer II

Author: Raphael Isemann Date: 2020-07-23T18:17:42+02:00 New Revision: 4d489e9f91db7e2d04b25e07805030b2cdcfa709 URL: https://github.com/llvm/llvm-project/commit/4d489e9f91db7e2d04b25e07805030b2cdcfa709 DIFF: https://github.com/llvm/llvm-project/commit/4d489e9f91db7e2d04b25e07805030b2cdcfa709.dif

[Lldb-commits] [lldb] ccdb5b4 - [lldb] Pass ConstString by value (again) (NFC)

Author: Jonas Devlieghere Date: 2020-07-23T09:08:32-07:00 New Revision: ccdb5b4bbe8470d1c558ecfd0658240d4c8f8df2 URL: https://github.com/llvm/llvm-project/commit/ccdb5b4bbe8470d1c558ecfd0658240d4c8f8df2 DIFF: https://github.com/llvm/llvm-project/commit/ccdb5b4bbe8470d1c558ecfd0658240d4c8f8df2.d

[Lldb-commits] [PATCH] D84404: [lldb] Make deleting frame recognizers actually work

This revision was automatically updated to reflect the committed changes. Closed by commit rG5477fbc29446: [lldb] Make deleting frame recognizers actually work (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CH

[Lldb-commits] [lldb] 5477fbc - [lldb] Make deleting frame recognizers actually work

Author: Raphael Isemann Date: 2020-07-23T17:43:37+02:00 New Revision: 5477fbc294469a1cc543d6d816c0b1519e632735 URL: https://github.com/llvm/llvm-project/commit/5477fbc294469a1cc543d6d816c0b1519e632735 DIFF: https://github.com/llvm/llvm-project/commit/5477fbc294469a1cc543d6d816c0b1519e632735.dif

[Lldb-commits] [PATCH] D84008: [DWARFYAML] Refactor emitDebugInfo() to make the length be inferred.

This revision was automatically updated to reflect the committed changes. Closed by commit rG92874d286695: [DWARFYAML] Refactor emitDebugInfo() to make the length be inferred. (authored by Higuoxing). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D840

[Lldb-commits] [lldb] 92874d2 - [DWARFYAML] Refactor emitDebugInfo() to make the length be inferred.

Author: Xing GUO Date: 2020-07-23T23:00:19+08:00 New Revision: 92874d286695d2233a3fc526b07896c3676ec1d3 URL: https://github.com/llvm/llvm-project/commit/92874d286695d2233a3fc526b07896c3676ec1d3 DIFF: https://github.com/llvm/llvm-project/commit/92874d286695d2233a3fc526b07896c3676ec1d3.diff LOG:

[Lldb-commits] [PATCH] D84008: [DWARFYAML] Refactor emitDebugInfo() to make the length be inferred.

Higuoxing marked an inline comment as done. Higuoxing added inline comments. Comment at: llvm/lib/ObjectYAML/DWARFEmitter.cpp:380-382 + cantFail(writeVariableSizedInteger(Unit.AbbrOffset, + Unit.Format == dwarf::DWARF64 ? 8 : 4, +

[Lldb-commits] [PATCH] D84008: [DWARFYAML] Refactor emitDebugInfo() to make the length be inferred.

jhenderson added inline comments. Comment at: llvm/lib/ObjectYAML/DWARFEmitter.cpp:380-382 + cantFail(writeVariableSizedInteger(Unit.AbbrOffset, + Unit.Format == dwarf::DWARF64 ? 8 : 4, + OS, DI.

[Lldb-commits] [PATCH] D84008: [DWARFYAML] Refactor emitDebugInfo() to make the length be inferred.

Higuoxing added inline comments. Comment at: llvm/lib/ObjectYAML/DWARFEmitter.cpp:207-215 +static unsigned getOffsetSize(const DWARFYAML::Unit &Unit) { + return Unit.Format == dwarf::DWARF64 ? 8 : 4; +} - void onValue(const uint16_t U) override { -writeInteger(U, OS, Debu

[Lldb-commits] [PATCH] D84008: [DWARFYAML] Refactor emitDebugInfo() to make the length be inferred.

Higuoxing updated this revision to Diff 280116. Higuoxing marked 3 inline comments as done. Higuoxing added a comment. Address comments. Thanks for reviewing! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84008/new/ https://reviews.llvm.org/D84008

[Lldb-commits] [PATCH] D84402: [lldb/DWARF] Add more line table validation

labath marked an inline comment as done. labath added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/debug_line-tombstone.s:35-36 # CHECK-NEXT: Line table for main.cpp -# CHECK-NEXT: 0x1000: main.cpp:1 -# CHECK-NEXT: 0x1001: main.cpp:1 +# C

[Lldb-commits] [PATCH] D84402: [lldb/DWARF] Add more line table validation

labath created this revision. labath added reviewers: JDevlieghere, MaskRay, clayborg. Herald added a subscriber: aprantl. Herald added a project: LLDB. The intention here is to prune out line sequences addresses referring outside any known sections. Such line sequences are typically produced by d

[Lldb-commits] [PATCH] D84401: [lldb] Add SectionList::ContainsFileAddressRange

labath created this revision. labath added reviewers: JDevlieghere, clayborg. Herald added a subscriber: mgorny. Herald added a project: LLDB. This is similar to FindSectionContainingFileAddress, except it doesn't return a section (because that would be ambiguous), and it checks for an address ran

[Lldb-commits] [lldb] 9cdd68e - Recommit "[lldb/API] Overwrite variables with SBLaunchInfo::SetEnvironment(append=true)"

Author: Pavel Labath Date: 2020-07-23T14:17:57+02:00 New Revision: 9cdd68e7c1331efd3c0aec84ef925a1679a73771 URL: https://github.com/llvm/llvm-project/commit/9cdd68e7c1331efd3c0aec84ef925a1679a73771 DIFF: https://github.com/llvm/llvm-project/commit/9cdd68e7c1331efd3c0aec84ef925a1679a73771.diff

[Lldb-commits] [PATCH] D84254: [lldb] Skip overlapping hardware and external breakpoints when writing memory

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D84254#2166562 , @tatyana-krasnukha wrote: > `BreakpointSite::IntersectsRange` returns `false` for hardware breakpoints, > that's why the assertion

[Lldb-commits] [lldb] e605994 - [lldb/test] Fix TestHistoryRecall failure (NFC)

Author: Med Ismail Bennani Date: 2020-07-23T13:27:12+02:00 New Revision: e605994bb30610107607f4267046e70a43852b97 URL: https://github.com/llvm/llvm-project/commit/e605994bb30610107607f4267046e70a43852b97 DIFF: https://github.com/llvm/llvm-project/commit/e605994bb30610107607f4267046e70a43852b97.

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

labath added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:240 + // Update SVE registers in case there is change in configuration. + ConfigureRegisterContext(); + omjavaid wrote: > labath wrote: > > What's

[Lldb-commits] [PATCH] D84307: [lldb/interpreter] Move the history subcommand to session (NFCI)

This revision was automatically updated to reflect the committed changes. Closed by commit rG85fbb08fa2ac: [lldb/interpreter] Move the history subcommand to session (NFCI) (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84307/new/ h

[Lldb-commits] [lldb] 85fbb08 - [lldb/interpreter] Move the history subcommand to session (NFCI)

Author: Med Ismail Bennani Date: 2020-07-23T13:05:45+02:00 New Revision: 85fbb08fa2ac5195dc7a2f13eea7de1471da2a21 URL: https://github.com/llvm/llvm-project/commit/85fbb08fa2ac5195dc7a2f13eea7de1471da2a21 DIFF: https://github.com/llvm/llvm-project/commit/85fbb08fa2ac5195dc7a2f13eea7de1471da2a21.

[Lldb-commits] [PATCH] D84307: [lldb/interpreter] Move the history subcommand to session (NFCI)

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. The patch itself is fine, so let's ship it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84307/new/ https://reviews.llvm.org/D84307 __

[Lldb-commits] [PATCH] D84257: [lldb] Don't use hardware index to determine whether a breakpoint site is hardware

omjavaid added a comment. In D84257#2166215 , @labath wrote: > In D84257#2164967 , > @tatyana-krasnukha wrote: > > > Probably fixes llvm.org/PR44659, though I cannot check on arm/aarch64. > > > @omjavaid might be i

[Lldb-commits] [PATCH] D84272: Add checks for ValueObjectSP in Cocoa summary providers

teemperor added a comment. I think Davide's point is that it's not clear what motivated this change and why this doesn't have a regression test. I'm also a bit confused by the description ("We saw a crash recently that looks related to we had good ValueObjectSP for some Cocoa summary providers.

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

labath added a comment. Some quibbles about the test. Otherwise, this looks good to me. Comment at: lldb/test/API/iohandler/autosuggestion/TestAutosuggestion.py:33 +self.child.send("hel") +self.child.expect_exact(faint_color + "p frame" + reset + "\x1b[1G") +

[Lldb-commits] [PATCH] D84008: [DWARFYAML] Refactor emitDebugInfo() to make the length be inferred.

labath accepted this revision. labath added a comment. Yeah, looks good. Some small suggestions inline, though some of them may be better off as separate patches... Comment at: llvm/lib/ObjectYAML/DWARFEmitter.cpp:207-215 +static unsigned getOffsetSize(const DWARFYAML::Unit &U

[Lldb-commits] [PATCH] D84008: [DWARFYAML] Refactor emitDebugInfo() to make the length be inferred.

jhenderson accepted this revision. jhenderson added a comment. This revision is now accepted and ready to land. LGTM, thanks, but might be best to get a second opinion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84008/new/ https://reviews.llvm.o

Re: [Lldb-commits] [lldb] 074b121 - Reland [lldb] Unify type name matching in FormattersContainer

Hi Raphael, I've temporarily reverted this again with hopefully a better explanation here: echristo@athyra ~/s/llvm-project> git push To github.com:llvm/llvm-project.git 55c0f12a869..3a75466f41b master -> master One review thought: If you don't want people using the default constructor for T

[Lldb-commits] [lldb] 3a75466 - Temporarily Revert "Reland [lldb] Unify type name matching in FormattersContainer"

Author: Eric Christopher Date: 2020-07-23T00:47:05-07:00 New Revision: 3a75466f41be12a8cdcff7ff786d55a319e6c2df URL: https://github.com/llvm/llvm-project/commit/3a75466f41be12a8cdcff7ff786d55a319e6c2df DIFF: https://github.com/llvm/llvm-project/commit/3a75466f41be12a8cdcff7ff786d55a319e6c2df.di

Re: [Lldb-commits] [lldb] 0d5fc82 - [lldb] Eliminate unneeded value parameters in Utility (NFC)

On Thu, Jul 23, 2020 at 00:20 Pavel Labath wrote: > On 22/07/2020 22:56, Jonas Devlieghere via lldb-commits wrote: > > - ConstString operator=(ConstString rhs) { > > + ConstString operator=(const ConstString &rhs) { > > ConstString is trivially copyable (well, it has a user defined copy > const

Re: [Lldb-commits] [lldb] 0d5fc82 - [lldb] Eliminate unneeded value parameters in Utility (NFC)

On 22/07/2020 22:56, Jonas Devlieghere via lldb-commits wrote: > - ConstString operator=(ConstString rhs) { > + ConstString operator=(const ConstString &rhs) { ConstString is trivially copyable (well, it has a user defined copy constructor but it is trivial...). Plus, not so long ago (D59030) w

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

omjavaid updated this revision to Diff 280037. omjavaid added a comment. This update fixes issues highlighted in last review iteration. @labath any further action on this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79699/new/ https://reviews.llvm.org/D79699 Files: lldb/source/Plu