[Lldb-commits] [PATCH] D84815: [LLDB] Improve PDB discovery

amccarth updated this revision to Diff 281445. amccarth added a comment. Fixed typos in comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84815/new/ https://reviews.llvm.org/D84815 Files: lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp Index:

[Lldb-commits] [PATCH] D84815: [LLDB] Improve PDB discovery

amccarth created this revision. amccarth added reviewers: labath, stella.stamenova. amccarth requested review of this revision. When loading a PE/COFF target, the associated PDB file often wasn't found. The executable module contains a path for the associated PDB file, but people often debug

[Lldb-commits] [PATCH] D84809: [lldb] Fix invalid error message in TargetList::CreateTargetInternal

JDevlieghere added inline comments. Comment at: lldb/source/Target/TargetList.cpp:245 } + error_strm.Printf("), specify an architecture to disambiguate"); + error.SetErrorString(error_strm.GetString()); jingham wrote: > jingham

[Lldb-commits] [PATCH] D84809: [lldb] Fix invalid error message in TargetList::CreateTargetInternal

jingham added inline comments. Comment at: lldb/source/Target/TargetList.cpp:245 } + error_strm.Printf("), specify an architecture to disambiguate"); + error.SetErrorString(error_strm.GetString()); jingham wrote: > I'm not sure why

[Lldb-commits] [PATCH] D84809: [lldb] Fix invalid error message in TargetList::CreateTargetInternal

jingham added a comment. This LGTM with a couple of quibbles but I haven't been working on the platform support recently so we should wait till people who have done so weight in. Comment at: lldb/source/Target/TargetList.cpp:175-176 + if

[Lldb-commits] [PATCH] D84809: [lldb] Fix invalid error message in TargetList::CreateTargetInternal

JDevlieghere updated this revision to Diff 281421. JDevlieghere added a comment. Reduce yaml CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84809/new/ https://reviews.llvm.org/D84809 Files: lldb/source/Commands/CommandObjectTarget.cpp lldb/source/Target/TargetList.cpp

[Lldb-commits] [PATCH] D84810: [intel-pt] Simplify Python API configuration

wallace created this revision. wallace added reviewers: clayborg, labath, kusmour. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. wallace requested review of this revision. Depends on D84791 . The existing way to configure Intel PT tracing

[Lldb-commits] [PATCH] D84800: [lldb] Remove unused option '--platform-path' for 'target create'

This revision was automatically updated to reflect the committed changes. Closed by commit rG2fa3da7dcdd0: [lldb] Remove unused option --platform-path for target create (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 2fa3da7 - [lldb] Remove unused option '--platform-path' for 'target create'

Author: Jonas Devlieghere Date: 2020-07-28T16:16:30-07:00 New Revision: 2fa3da7dcdd021e05899770c02e08a20c19a98b3 URL: https://github.com/llvm/llvm-project/commit/2fa3da7dcdd021e05899770c02e08a20c19a98b3 DIFF:

[Lldb-commits] [PATCH] D84809: [lldb] Various related target create improvements

JDevlieghere created this revision. JDevlieghere added a reviewer: jingham. Herald added subscribers: teemperor, abidh. JDevlieghere requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. - General cleanup in TargetList::CreateTargetInternal. -

[Lldb-commits] [lldb] 80bd6ae - On Windows build, making the /bigobj flag global , instead of passing it per file.

Author: Zahira Ammarguellat Date: 2020-07-28T18:04:36-05:00 New Revision: 80bd6ae13ea23d453a1f45d6ccdbfc7d0c877bb0 URL: https://github.com/llvm/llvm-project/commit/80bd6ae13ea23d453a1f45d6ccdbfc7d0c877bb0 DIFF:

[Lldb-commits] [PATCH] D84800: [lldb] Remove unused option '--platform-path' for 'target create'

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. I'm a little curious how you would specify the path to your binary on a remote platform using the command line. But this way certainly wasn't it... Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D84800: [lldb] Remove unused option '--platform-path' for 'target create'

JDevlieghere created this revision. JDevlieghere added a reviewer: jingham. JDevlieghere requested review of this revision. Repository: rLLDB LLDB https://reviews.llvm.org/D84800 Files: lldb/source/Commands/CommandObjectTarget.cpp Index: lldb/source/Commands/CommandObjectTarget.cpp

[Lldb-commits] [PATCH] D84791: [intel-pt] Fix python support and add a full python test

wallace updated this revision to Diff 281334. wallace added a comment. fix incorrect comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84791/new/ https://reviews.llvm.org/D84791 Files: lldb/source/API/SBDebugger.cpp

[Lldb-commits] [PATCH] D84791: [intel-pt] Fix python support and add a full python test

wallace added inline comments. Comment at: lldb/source/API/SBDebugger.cpp:66-69 + std::string error_message; llvm::sys::DynamicLibrary dynlib = - llvm::sys::DynamicLibrary::getPermanentLibrary(spec.GetPath().c_str()); +

[Lldb-commits] [PATCH] D84791: [intel-pt] Fix python support and add a full python test

wallace created this revision. wallace added reviewers: clayborg, labath. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. wallace requested review of this revision. The initial implementation of the Intel PT support for LLDB came with some Python support. However,

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

gedatsu217 added a comment. For example, I execute "help frame variable" and save it as command history. Then, when I type "hel", "helhelp [me variable]" (gray characters are in []) is displayed, probably because of cursor position or CC_NORM. I am trying to solve this problem, but I have not

[Lldb-commits] [lldb] 394db22 - Revert "Switch to using -debug-info-kind=constructor as default (from =limited)"

Author: Amy Huang Date: 2020-07-28T11:23:59-07:00 New Revision: 394db2259575ef3cac8d3d37836b11eb2373c435 URL: https://github.com/llvm/llvm-project/commit/394db2259575ef3cac8d3d37836b11eb2373c435 DIFF: https://github.com/llvm/llvm-project/commit/394db2259575ef3cac8d3d37836b11eb2373c435.diff

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

gedatsu217 added a comment. Sorry, I found the bug. Please do not check this yet. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81001/new/ https://reviews.llvm.org/D81001 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

gedatsu217 updated this revision to Diff 281247. gedatsu217 added a comment. Editline::TypedCharacter is called when delete is pressed. (This probably fix the above bug.) Revise the test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81001/new/ https://reviews.llvm.org/D81001 Files:

[Lldb-commits] [PATCH] D84748: [cmake] Make gtest macro definitions a part the library interface

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. Can you confirm that all the targets that need to "link" (in the CMake sense) against gtest use the gtest CMake target? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D84748: [cmake] Make gtest macro definitions a part the library interface

labath created this revision. labath added reviewers: ldionne, logan-5, beanz. Herald added subscribers: lldb-commits, dexonsmith, hiraditya, mgorny. Herald added projects: LLDB, LLVM. labath requested review of this revision. These definitions are needed by any file which uses gtest. Previously

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

labath added a comment. Thanks. When trying this out I did notice one subtle bug related to backspacing. When backspacing over the first character, the command line does not get redrawn, which means the autosuggested text remains on screen. The "deleted" character also remains, and is printed

[Lldb-commits] [PATCH] D79147: Switch to using -debug-info-kind=constructor as default (from =limited)

russell.gallop added a comment. Hi, It looks like is causing one of the debuginfo-tests: llgdb-tests/nrvo-string.cpp to fail, run on Linux. Failure as below. I don't think the debuginfo-tests are run on any bot (but probably should be!). I bisected the failure back to this change. Please