[Lldb-commits] [lldb] a22301e - [lldb] Remove redundant add_definitions() in CMake (NFC)

Author: Jonas Devlieghere Date: 2020-08-10T22:45:33-07:00 New Revision: a22301ef9899b77d02cc8ad6bea68009baa60413 URL: https://github.com/llvm/llvm-project/commit/a22301ef9899b77d02cc8ad6bea68009baa60413 DIFF:

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek added a comment. I have finally managed to reproduce the issue on my Windows machine, the latest version of the patch should address the issue. The previous logic would fail to find zlib altogether on Windows, which is why this issue haven't manifested before. `find_package` locates the

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek added a comment. In D79219#2201994 , @kuhnel wrote: > This patch broke the Windows compilation on buildbot > and pre-merge > testing

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek added a comment. In D79219#2201109 , @lxfind wrote: > @phosek, Under this change, now when I build LLVM (with a basic config `cmake > -G Ninja --LLVM_ENABLE_PROJECTS=clang ../llvm`), in file > `build_dir/lib/cmake/llvm/LLVMExports.cmake`, I see

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

This revision was automatically updated to reflect the committed changes. Closed by commit rG1adc494bce44: [CMake] Simplify CMake handling for zlib (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D79219?vs=283398=283434#toc Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

kuhnel added a comment. > Looking at the error, it seems like you have a 32-bit version of zlib > installed and in your search path on a 64-bit version of Windows. I'm not > quite sure how to handle that in CMake. For mlir-windows buildbot: I have no clue on what is installed there. For

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek updated this revision to Diff 284106. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D79219 Files: clang/test/CMakeLists.txt clang/test/lit.site.cfg.py.in compiler-rt/test/lit.common.configured.in lld/test/CMakeLists.txt

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

kuhnel added a comment. This patch broke the Windows compilation on buildbot and pre-merge testing . So I'll revert it to get pre-merge testing back online. Otherwise

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

kuhnel added a comment. In D79219#2202048 , @phosek wrote: > How can I test this change on pre-merge bots? I haven't seen any builds > posted on this change before. You can just look at the mlir-windows buildbot, this also showed the failing build:

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek updated this revision to Diff 284161. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D79219 Files: clang/test/CMakeLists.txt clang/test/lit.site.cfg.py.in compiler-rt/test/lit.common.configured.in lld/test/CMakeLists.txt

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek updated this revision to Diff 283398. phosek marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D79219 Files: clang/test/CMakeLists.txt clang/test/lit.site.cfg.py.in compiler-rt/test/lit.common.configured.in

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek added a comment. @kuhnel do you want to take a look or is it okay if I just submit the change? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D79219 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

lxfind added a comment. @phosek, Under this change, now when I build LLVM (with a basic config `cmake -G Ninja --LLVM_ENABLE_PROJECTS="clang" ../llvm`), in file `build_dir/lib/cmake/llvm/LLVMExports.cmake`, I see this: set_target_properties(LLVMSupport PROPERTIES INTERFACE_LINK_LIBRARIES

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek added a comment. How can I test this change on pre-merge bots? I haven't seen any builds posted on this change before. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D79219

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

hans added inline comments. Comment at: llvm/cmake/config-ix.cmake:178 -if (LLVM_ENABLE_ZLIB STREQUAL "FORCE_ON" AND NOT HAVE_LIBZ) - message(FATAL_ERROR "Failed to configure zlib") Could this check be put back? E.g. for now it seems building with

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGccbc1485b55f: [CMake] Simplify CMake handling for zlib (authored by phosek). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

lxfind added a comment. In D79219#2201415 , @phosek wrote: > In D79219#2201109 , @lxfind wrote: > >> @phosek, Under this change, now when I build LLVM (with a basic config >> `cmake -G Ninja

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek reopened this revision. phosek added a comment. This revision is now accepted and ready to land. Sorry about the breakage, that was an unintentional change. I have updated the patch and restored the original behavior on Windows. CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] bca4366 - [lldb] Use modern CMake to avoid repetition (NFC)

Author: Jonas Devlieghere Date: 2020-08-10T22:29:40-07:00 New Revision: bca43666e7dc41207b91fe28d7c6442b60d0e787 URL: https://github.com/llvm/llvm-project/commit/bca43666e7dc41207b91fe28d7c6442b60d0e787 DIFF:

[Lldb-commits] [PATCH] D85705: First patch that adds processor trace.

clayborg added a comment. Unresolved issues in this patch: - For "trace load", I get the plugin for the JSON file by matching it up with the "name" field in the JSON, but I don't store the "trace_sp" anywhere. We will need to store it with the target that we create, or for later commands add

[Lldb-commits] [PATCH] D85705: First patch that adds processor trace.

clayborg created this revision. clayborg added reviewers: labath, aprantl, JDevlieghere, wallace, jingham. Herald added subscribers: dang, mgorny. Herald added a project: LLDB. clayborg requested review of this revision. This is the first in a series of patches that will adds a new processor

[Lldb-commits] [lldb] c4701c9 - [lldb] Add missings moves where appropiate (NFC)

Author: Jonas Devlieghere Date: 2020-08-10T21:02:11-07:00 New Revision: c4701c9c620fecfd6975e2885dae02d6e1b96698 URL: https://github.com/llvm/llvm-project/commit/c4701c9c620fecfd6975e2885dae02d6e1b96698 DIFF:

[Lldb-commits] [lldb] b448eda - [lldb] Fix typo in AppleDWARFIndex

Author: Jonas Devlieghere Date: 2020-08-10T19:22:52-07:00 New Revision: b448eda4066ff5dee2517018e386893ab629f9e8 URL: https://github.com/llvm/llvm-project/commit/b448eda4066ff5dee2517018e386893ab629f9e8 DIFF:

[Lldb-commits] [PATCH] D85376: Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue()

shafik updated this revision to Diff 284507. shafik added a comment. Updated to use llvm.org clang, remove header files from the main.c and add the commit hash for the clang so that it is easier to replicate the main.s in the future. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Also signing this off as I think this is in a good enough state to land. The remaining issues can all be follow-up patches. Also you might want to change your editor to remove trailing

[Lldb-commits] [PATCH] D84179: [lldb] tab completion for `platform target-install`

This revision was automatically updated to reflect the committed changes. Closed by commit rGe3820570d406: [lldb] tab completion for `platform target-install` (authored by MrHate, committed by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [lldb] e382057 - [lldb] tab completion for `platform target-install`

Author: Gongyu Deng Date: 2020-08-10T20:14:46+02:00 New Revision: e3820570d406f56a25eee681df03a394882febb0 URL: https://github.com/llvm/llvm-project/commit/e3820570d406f56a25eee681df03a394882febb0 DIFF: https://github.com/llvm/llvm-project/commit/e3820570d406f56a25eee681df03a394882febb0.diff

[Lldb-commits] [PATCH] D85376: Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue()

teemperor added a comment. I just have a small comment about the test. If you build the test with an llvm.org version of clang (best if it contains the git hash it was build from) and you don't include headers (they don't seem to be required for the test), then the file would be much easier to

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

JDevlieghere accepted this revision as: JDevlieghere. JDevlieghere added a comment. I applied the patch locally and gave this another shot. I'm still missing all the common ways I accept auto-suggestions in fish: - C-e - Right arrow - End but I'm fine with fixing that in another patch assuming

[Lldb-commits] [lldb] 3162c6a - [lldb] Skip TestSimulatorPlatform with out-of-tree debugserver

Author: Jonas Devlieghere Date: 2020-08-10T10:00:45-07:00 New Revision: 3162c6aa4587d5161008d2b9729b5f2873b0fff9 URL: https://github.com/llvm/llvm-project/commit/3162c6aa4587d5161008d2b9729b5f2873b0fff9 DIFF:

[Lldb-commits] [lldb] b8ff0da - [lldb] Fix NSArray0 data formatter and add test

Author: Jonas Devlieghere Date: 2020-08-10T09:38:37-07:00 New Revision: b8ff0daeac0752689ffca9345686845d1b7cfed8 URL: https://github.com/llvm/llvm-project/commit/b8ff0daeac0752689ffca9345686845d1b7cfed8 DIFF:

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

omjavaid updated this revision to Diff 284328. omjavaid added a comment. This patch fixes review items from last review cycles. Now we do not use LinuxPTraceDefines_arm64sve.h for NativeProcessLinux_arm64 as these defs are already back ported into libc ptrace.h available on most distros. LLDB

[Lldb-commits] [PATCH] D85641: [LLDB] Convert SVE macros into c++ constants and inlines

omjavaid created this revision. omjavaid added a reviewer: labath. Herald added a subscriber: tschuett. Herald added a reviewer: rengolin. omjavaid requested review of this revision. This patch updates LLDB's in house version of SVE ptrace/sig macros by converting them into constants and

[Lldb-commits] [lldb] 8119d6c - [lldb][NFC] Remove dead code in BreakpointResolverAddress

Author: Raphael Isemann Date: 2020-08-10T11:29:40+02:00 New Revision: 8119d6c14695b436adb66f0d891863eeea9e62ad URL: https://github.com/llvm/llvm-project/commit/8119d6c14695b436adb66f0d891863eeea9e62ad DIFF: