[Lldb-commits] [PATCH] D84974: [WIP] Enable Launching the Debugee in VSCode Terminal

2020-08-14 Thread Greg Clayton via Phabricator via lldb-commits
clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. So there is a lot of noise in this patch that is just reformatting on code that hasn't changed. It would be nice to get rid of any changes that are

[Lldb-commits] [lldb] 0cceb54 - [TestPtrRefsObjC] Prefer `command script import`.

2020-08-14 Thread Davide Italiano via lldb-commits
Author: Davide Italiano Date: 2020-08-14T15:31:02-07:00 New Revision: 0cceb54366b406649fdfe7bb11b133ab96f3cd70 URL: https://github.com/llvm/llvm-project/commit/0cceb54366b406649fdfe7bb11b133ab96f3cd70 DIFF:

[Lldb-commits] [lldb] 8fcfe28 - [TestPtrRefs] Prefer `command script import`.

2020-08-14 Thread Davide Italiano via lldb-commits
Author: Davide Italiano Date: 2020-08-14T15:30:31-07:00 New Revision: 8fcfe2862fd4fde4793e232cfeebe6c5540c80a5 URL: https://github.com/llvm/llvm-project/commit/8fcfe2862fd4fde4793e232cfeebe6c5540c80a5 DIFF:

[Lldb-commits] [PATCH] D85993: [lldb] Set the access property on member function decls

2020-08-14 Thread Alexandre Ganea via Phabricator via lldb-commits
aganea added a comment. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85993/new/ https://reviews.llvm.org/D85993 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D85993: [lldb] Set the access property on member function decls

2020-08-14 Thread Adrian McCarthy via Phabricator via lldb-commits
amccarth created this revision. amccarth added reviewers: clayborg, aganea. amccarth requested review of this revision. This fixes two failures in the PDB tests. LLVM has a "sanity" check on function decls. One of the requirements of member functions is that they have the access property

[Lldb-commits] [PATCH] D85988: Fix the ability to list iOS simulator processes.

2020-08-14 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. We should have a few tests that launch a simulator. @aprantl revived them recently: - TestAppleSimulatorOSType.py - TestSimulatorPlatform.py - TestIOSSimulator.py Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D84974: [WIP] Enable Launching the Debugee in VSCode Terminal

2020-08-14 Thread Yifan Shen via Phabricator via lldb-commits
aelitashen updated this revision to Diff 285727. aelitashen added a comment. Remove uncomplete tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84974/new/ https://reviews.llvm.org/D84974 Files: lldb/tools/lldb-vscode/VSCode.cpp

[Lldb-commits] [PATCH] D84974: [WIP] Enable Launching the Debugee in VSCode Terminal

2020-08-14 Thread Yifan Shen via Phabricator via lldb-commits
aelitashen updated this revision to Diff 285725. aelitashen added a comment. Add a attacher thread to avoid race condition Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84974/new/ https://reviews.llvm.org/D84974 Files:

[Lldb-commits] [PATCH] D85988: Fix the ability to list iOS simulator processes.

2020-08-14 Thread Greg Clayton via Phabricator via lldb-commits
clayborg created this revision. clayborg added reviewers: labath, aprantl, JDevlieghere, jingham, jasonmolenda. Herald added a project: LLDB. clayborg requested review of this revision. This can be done by doing: (lldb) platform select ios-simulator (lldb) platform process list There was code

[Lldb-commits] [lldb] b6db0a5 - Add python enumerators for SBTypeEnumMemberList, and some tests for this API.

2020-08-14 Thread Jim Ingham via lldb-commits
Author: Jim Ingham Date: 2020-08-14T09:57:46-07:00 New Revision: b6db0a544df1f28e7fa53b74e19839e55e63c8c9 URL: https://github.com/llvm/llvm-project/commit/b6db0a544df1f28e7fa53b74e19839e55e63c8c9 DIFF: https://github.com/llvm/llvm-project/commit/b6db0a544df1f28e7fa53b74e19839e55e63c8c9.diff

[Lldb-commits] [PATCH] D85951: Add Python iterator & getitem for SBTypeEnumMemberList

2020-08-14 Thread Jim Ingham via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGb6db0a544df1: Add python enumerators for SBTypeEnumMemberList, and some tests for this API. (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D85976: [lldb] Get rid of helper CMake variables for Python

2020-08-14 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added reviewers: mgorny, labath, LLDB. JDevlieghere requested review of this revision. Herald added a subscriber: aheejin. This patch is basically just a big sed to update the variables: s/PYTHON_LIBRARIES/Python3_LIBRARIES/g

[Lldb-commits] [PATCH] D85942: [lldb] Remove Python 2 fallback and make Python 3 the only supported configuration.

2020-08-14 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGce439cb1c962: [lldb] Remove Python 2 fallback and only support Python 3 (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] ce439cb - [lldb] Remove Python 2 fallback and only support Python 3

2020-08-14 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-08-14T08:50:11-07:00 New Revision: ce439cb1c962360267fb7a94d44ad57053787607 URL: https://github.com/llvm/llvm-project/commit/ce439cb1c962360267fb7a94d44ad57053787607 DIFF:

[Lldb-commits] [PATCH] D85915: [lldb] Use file to synchronize TestDeepBundle and TestBundleWithDotInFilename

2020-08-14 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG37ec83fcfc6c: [lldb] Use file to synchronize TestDeepBundle and TestBundleWithDotInFilename (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [lldb] 37ec83f - [lldb] Use file to synchronize TestDeepBundle and TestBundleWithDotInFilename

2020-08-14 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-08-14T08:32:21-07:00 New Revision: 37ec83fcfc6c7915c51268f578b8e0dadb54c1cf URL: https://github.com/llvm/llvm-project/commit/37ec83fcfc6c7915c51268f578b8e0dadb54c1cf DIFF:

[Lldb-commits] [lldb] 46ed27f - [lldb] Make packetlog_get_dylib_info returns the last full response

2020-08-14 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2020-08-14T14:51:13+02:00 New Revision: 46ed27ff1b1cd74742511d73a4a43afa97455fe2 URL: https://github.com/llvm/llvm-project/commit/46ed27ff1b1cd74742511d73a4a43afa97455fe2 DIFF:

[Lldb-commits] [PATCH] D85968: [lldb] Forcefully complete a type when adding nested classes

2020-08-14 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. labath added reviewers: teemperor, shafik. Herald added a project: LLDB. labath requested review of this revision. Herald added a subscriber: JDevlieghere. With -flimit-debug-info, we can run into cases when we only have a class as a declaration, but we do have a

[Lldb-commits] [lldb] bb4efab - [lldb] Use SBProcess::Continue instead of 'run' command in TestTargetAPI.py

2020-08-14 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2020-08-14T13:12:52+02:00 New Revision: bb4efab9a4d9431dbedb27f04249effd0a73812e URL: https://github.com/llvm/llvm-project/commit/bb4efab9a4d9431dbedb27f04249effd0a73812e DIFF:

[Lldb-commits] [PATCH] D85904: [lldb] Check Decl kind when completing -flimit-debug-info types

2020-08-14 Thread Pavel Labath via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfdc6aea3fd82: [lldb] Check Decl kind when completing -flimit-debug-info types (authored by labath). Changed prior to commit:

[Lldb-commits] [lldb] fdc6aea - [lldb] Check Decl kind when completing -flimit-debug-info types

2020-08-14 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2020-08-14T12:31:37+02:00 New Revision: fdc6aea3fd822b639baaa5b666fdf7598d08c8de URL: https://github.com/llvm/llvm-project/commit/fdc6aea3fd822b639baaa5b666fdf7598d08c8de DIFF: https://github.com/llvm/llvm-project/commit/fdc6aea3fd822b639baaa5b666fdf7598d08c8de.diff

[Lldb-commits] [PATCH] D85904: [lldb] Check Decl kind when completing -flimit-debug-info types

2020-08-14 Thread Pavel Labath via Phabricator via lldb-commits
labath marked 2 inline comments as done. labath added a comment. In D85904#2215700 , @teemperor wrote: > Is it too late to claim that I did this on purpose to see if anyone noticed > the bug? It probably is :/ :P Comment at:

[Lldb-commits] [lldb] e6b1b61 - [lldb] Fix py3 incompatibility in gdbremote_testcase.py

2020-08-14 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2020-08-14T12:15:25+02:00 New Revision: e6b1b61054c285efad7bf4ee0a4da53e56944d87 URL: https://github.com/llvm/llvm-project/commit/e6b1b61054c285efad7bf4ee0a4da53e56944d87 DIFF: https://github.com/llvm/llvm-project/commit/e6b1b61054c285efad7bf4ee0a4da53e56944d87.diff

[Lldb-commits] [PATCH] D82537: [lldb] Deduplicate copy-pasted TypeSystemMap::GetTypeSystemForLanguage

2020-08-14 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf974d64b372c: [lldb] Deduplicate copy-pasted TypeSystemMap::GetTypeSystemForLanguage (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM

[Lldb-commits] [lldb] f974d64 - [lldb] Deduplicate copy-pasted TypeSystemMap::GetTypeSystemForLanguage

2020-08-14 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2020-08-14T11:58:54+02:00 New Revision: f974d64b372c5554783369bab901de8f4dee5e02 URL: https://github.com/llvm/llvm-project/commit/f974d64b372c5554783369bab901de8f4dee5e02 DIFF:

[Lldb-commits] [lldb] de9e850 - [lldb] Display autosuggestion part in gray if there is one possible suggestion

2020-08-14 Thread Raphael Isemann via lldb-commits
Author: Shu Anzai Date: 2020-08-14T11:37:49+02:00 New Revision: de9e85026fcb7c3e992f12a86594fd50bb101ad3 URL: https://github.com/llvm/llvm-project/commit/de9e85026fcb7c3e992f12a86594fd50bb101ad3 DIFF: https://github.com/llvm/llvm-project/commit/de9e85026fcb7c3e992f12a86594fd50bb101ad3.diff

[Lldb-commits] [lldb] 40d7742 - [lldb/Utility] Simplify Scalar::PromoteToMaxType

2020-08-14 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2020-08-14T11:09:16+02:00 New Revision: 40d774265b08fbfd0f3e2ffa79ce7feddbd060bc URL: https://github.com/llvm/llvm-project/commit/40d774265b08fbfd0f3e2ffa79ce7feddbd060bc DIFF: https://github.com/llvm/llvm-project/commit/40d774265b08fbfd0f3e2ffa79ce7feddbd060bc.diff

[Lldb-commits] [PATCH] D85906: [lldb/Utility] Simplify Scalar::PromoteToMaxType

2020-08-14 Thread Pavel Labath via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG40d774265b08: [lldb/Utility] Simplify Scalar::PromoteToMaxType (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

2020-08-14 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D79699#2215216 , @omjavaid wrote: > @labath Any further action needed on this change? I have updated test main.c > for doing asm write to SVE regs and then reading them back during testing. > Also i have removed

[Lldb-commits] [PATCH] D85539: [lldb] Extend builder to pass the TRIPLE spec to Make

2020-08-14 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D85539#2216197 , @JDevlieghere wrote: > Even though this file is called "base", there's no inheritance going on here, > it's just methods and `lldbtest.py` will import the appropriate module. I > considered this too, but

[Lldb-commits] [lldb] bbe3c47 - [lldb] Fix a crash when tab-completion an empty line in a function with only one local variable

2020-08-14 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2020-08-14T09:06:52+02:00 New Revision: bbe3c479a6adf0abfe5d111e9ba206daa5a1eb2b URL: https://github.com/llvm/llvm-project/commit/bbe3c479a6adf0abfe5d111e9ba206daa5a1eb2b DIFF:

[Lldb-commits] [PATCH] D85903: [lldb] Fix a crash when tab-completion an empty line in a function with only one local variable

2020-08-14 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGbbe3c479a6ad: [lldb] Fix a crash when tab-completion an empty line in a function with only… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository:

[Lldb-commits] [PATCH] D84623: Remove HAVE_VCS_VERSION_INC, not needed

2020-08-14 Thread Marcel Hlopko via Phabricator via lldb-commits
hlopko added a comment. Herald added a subscriber: JDevlieghere. Friendly ping, this change will remove HAVE_VCS_VERSION_INC define. If you disagree, please complain :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84623/new/

[Lldb-commits] [PATCH] D85915: [lldb] Use file to synchronize TestDeepBundle and TestBundleWithDotInFilename

2020-08-14 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. This fills my heart with joy. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85915/new/ https://reviews.llvm.org/D85915

[Lldb-commits] [PATCH] D85942: [lldb] Remove Python 2 fallback and make Python 3 the only supported configuration.

2020-08-14 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. In D85942#2217494 , @mgorny wrote: > I wonder if we can remove the helper variables such as `PYTHON_LIBRARIES` now. Yep, that was going to be the next patch :-) Repository: rLLDB LLDB CHANGES SINCE LAST ACTION