[Lldb-commits] [PATCH] D86381: Move Py_buffer_RAII to .h file so SWIG 2 doesnt have to parse it

aadsm updated this revision to Diff 287160. aadsm added a comment. After reading a bit more how clang-tidy works this isn't fixable because it actually needs to compile it. I also didn't find a way to exclude a file from it. My plan is to just land this and then make a PR to add this file to

[Lldb-commits] [lldb] 86fc193 - [lldb] Don't pass --rerun-all-issues on Windows.

Author: Jonas Devlieghere Date: 2020-08-21T19:58:24-07:00 New Revision: 86fc1933099d8818c7d7559ae41e5903a1daf9bd URL: https://github.com/llvm/llvm-project/commit/86fc1933099d8818c7d7559ae41e5903a1daf9bd DIFF:

[Lldb-commits] [PATCH] D86381: Move Py_buffer_RAII to .h file so SWIG 2 doesnt have to parse it

aadsm updated this revision to Diff 287149. aadsm added a comment. Moved the header file to be in Plugins/ScriptInterpreter/Python so clang-tidy doesn't get confused solving include paths. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86381/new/

[Lldb-commits] [PATCH] D86381: Move Py_buffer_RAII to .h file so SWIG 2 doesnt have to parse it

aadsm updated this revision to Diff 287144. aadsm added a comment. Added include guards, clang-format and python include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86381/new/ https://reviews.llvm.org/D86381 Files:

[Lldb-commits] [PATCH] D86389: [lldb] Add a SymbolFileProvider to record and replay calls to dsymForUUID

JDevlieghere added a comment. I wasn't sure how to test this but Jason told me I can set `LLDB_APPLE_DSYMFORUUID_EXECUTABLE`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86389/new/ https://reviews.llvm.org/D86389 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D86389: [lldb] Add a SymbolFileProvider to record and replay calls to dsymForUUID

JDevlieghere created this revision. JDevlieghere added a reviewer: jasonmolenda. Herald added a subscriber: mgrang. JDevlieghere requested review of this revision. When replaying a reproducer captured from a core file, we always use dsymForUUID for the kernel binary. When enabled, we also use it

[Lldb-commits] [PATCH] D86388: Fix use-after-free in ThreadPlan, and add test.Background:ThreadPlan objects store a cached pointer to the associated Thread. To quotethe code:// We don't cache the thr

comex created this revision. comex added reviewers: jingham, clayborg. Herald added a subscriber: aaron.ballman. Herald added a project: LLDB. comex requested review of this revision. Herald added a subscriber: JDevlieghere. ...Thread represent // the same underlying object on a later stop. This

[Lldb-commits] [PATCH] D86381: Move Py_buffer_RAII to .h file so SWIG 2 doesnt have to parse it

lawrence_danna accepted this revision. lawrence_danna added a comment. This revision is now accepted and ready to land. Looks fine to me, assuming that the tests pass. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86381/new/

[Lldb-commits] [PATCH] D86381: Move Py_buffer_RAII to .h file so SWIG 2 doesnt have to parse it

aadsm created this revision. aadsm added reviewers: clayborg, wallace, lawrence_danna. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. aadsm requested review of this revision. Herald added a subscriber: JDevlieghere. `struct Py_buffer_RAII` definition uses explicit deleted

[Lldb-commits] [PATCH] D86355: Instantiate Error in Target::GetEntryPointAddress() only when necessary

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Target/Target.cpp:2408-2446 llvm::Expected Target::GetEntryPointAddress() { Module *exe_module = GetExecutableModulePointer();

[Lldb-commits] [lldb] 02bf563 - Fix swig scripts install target name

Author: António Afonso Date: 2020-08-21T14:41:52-07:00 New Revision: 02bf5632a94da6c3570df002804f8d3f79c11bfc URL: https://github.com/llvm/llvm-project/commit/02bf5632a94da6c3570df002804f8d3f79c11bfc DIFF:

[Lldb-commits] [PATCH] D86235: Fix swig scripts install target name

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG02bf5632a94d: Fix swig scripts install target name (authored by aadsm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D86375: Load correct module for linux and android when duplicates exist in minidump.

clayborg created this revision. clayborg added reviewers: labath, aadsm, wallace. Herald added a subscriber: mgrang. Herald added a project: LLDB. clayborg requested review of this revision. Herald added a subscriber: JDevlieghere. Breakpad creates minidump files that can a module loaded multiple

[Lldb-commits] [lldb] d3a49b0 - [lldb] Remove --rerun-all-issues as its functionality no longer exists

Author: Jonas Devlieghere Date: 2020-08-21T14:28:08-07:00 New Revision: d3a49b03a57bb7448620c31f493932018e752c0d URL: https://github.com/llvm/llvm-project/commit/d3a49b03a57bb7448620c31f493932018e752c0d DIFF:

[Lldb-commits] [PATCH] D86235: Fix swig scripts install target name

aadsm updated this revision to Diff 287106. aadsm edited the summary of this revision. aadsm added a comment. Updated to use more friendly component name `lldb-python-scripts` name instead of `finish_swig_python_scripts` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

aadsm added inline comments. Comment at: lldb/bindings/python/python-typemaps.swig:500 + } +}; + lawrence_danna wrote: > lawrence_danna wrote: > > aadsm wrote: > > > labath wrote: > > > > Could you also `= delete` the copy operations to make sure nothing > > >

[Lldb-commits] [lldb] 52e758f - [lldb] Fix build error in TestSimulatorPlatform.py

Author: Jonas Devlieghere Date: 2020-08-21T13:35:26-07:00 New Revision: 52e758f352e6fc7c2458e92cc0b6351bf9469628 URL: https://github.com/llvm/llvm-project/commit/52e758f352e6fc7c2458e92cc0b6351bf9469628 DIFF:

[Lldb-commits] [PATCH] D86311: Fix how ValueObjectVariable handles DW_AT_const_value when the DWARFExpression holds the data that represents a constant value

aprantl added a comment. @shafik would you mind preparing a separate commit that add the REQUIRES everywhere it is needed, or if there are many, create an x86 subdir with an implicit requirement (like we do in the llvm/test/debuginfo tests)? If it weren't for Rosetta, these would break on Apple

[Lldb-commits] [PATCH] D86348: [lldb/DWARF] More DW_AT_const_value fixes

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. LGTM with that caveat Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86348/new/ https://reviews.llvm.org/D86348

[Lldb-commits] [PATCH] D86348: [lldb/DWARF] More DW_AT_const_value fixes

aprantl added a comment. This looks nice! I'm somewhat suspicious that the new test doesn't specifically test the union case of the old test, but I'm assuming that would still work and your simpler tests covers the same code? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D85705: Add a "Trace" plug-in to LLDB to add process trace support in stages.

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Lots of little things regarding the encoding and format of the JSON. Comment at: lldb/source/Target/Trace.cpp:37 + std::errc::invalid_argument, + "no

[Lldb-commits] [PATCH] D85705: Add a "Trace" plug-in to LLDB to add process trace support in stages.

wallace updated this revision to Diff 287079. wallace added a comment. - Added libipt as a dependency to build the new intel pt plugin. It's merely a copy paste of what the old intel pt plugin does. - Added a test with a sample trace.json definition file. It includes a simple a.out object

[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

lawrence_danna added inline comments. Comment at: lldb/bindings/python/python-typemaps.swig:500 + } +}; + lawrence_danna wrote: > aadsm wrote: > > labath wrote: > > > Could you also `= delete` the copy operations to make sure nothing funny > > > happens with

[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

lawrence_danna added inline comments. Comment at: lldb/bindings/python/python-typemaps.swig:500 + } +}; + aadsm wrote: > labath wrote: > > Could you also `= delete` the copy operations to make sure nothing funny > > happens with those. > The `= delete` is

[Lldb-commits] [PATCH] D86261: Add hashing of the .text section to ProcessMinidump.

clayborg updated this revision to Diff 287078. clayborg added a comment. Added a test case with a 1 byte .text section that will overflow into the 15 bytes of the .data section that follows. This will test the overflow case that was requested. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D86355: Consume error for valid return from Target::GetEntryPointAddress()

dim updated this revision to Diff 287077. dim added a comment. As @JDevlieghere suggests, only instantiate `Error` objects when necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86355/new/ https://reviews.llvm.org/D86355 Files:

[Lldb-commits] [PATCH] D86355: Consume error for valid return from Target::GetEntryPointAddress()

dim added inline comments. Comment at: lldb/source/Target/Target.cpp:2408-2446 llvm::Expected Target::GetEntryPointAddress() { Module *exe_module = GetExecutableModulePointer(); llvm::Error error = llvm::Error::success(); assert(!error); // Check the success value when

[Lldb-commits] [lldb] 57e0ef1 - [lldb] Make it a fatal error when %lldb cannot be substituted

Author: Jonas Devlieghere Date: 2020-08-21T11:18:21-07:00 New Revision: 57e0ef131b621dc88ad2db53a52bf86b498e49c3 URL: https://github.com/llvm/llvm-project/commit/57e0ef131b621dc88ad2db53a52bf86b498e49c3 DIFF:

[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

aadsm added inline comments. Comment at: lldb/bindings/python/python-typemaps.swig:500 + } +}; + labath wrote: > Could you also `= delete` the copy operations to make sure nothing funny > happens with those. The `= delete` is unsupported in SWIG 2, only in 3:

[Lldb-commits] [lldb] 08249d7 - [lldb] Fix TestAPILog.py for reproducer replay

Author: Jonas Devlieghere Date: 2020-08-21T10:35:35-07:00 New Revision: 08249d7f72ff8f8648c5264e090813c9c2cad466 URL: https://github.com/llvm/llvm-project/commit/08249d7f72ff8f8648c5264e090813c9c2cad466 DIFF:

[Lldb-commits] [PATCH] D86311: Fix how ValueObjectVariable handles DW_AT_const_value when the DWARFExpression holds the data that represents a constant value

labath added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/DW_AT_const_value.s:2 +# RUN: llvm-mc -filetype=obj -o %t -triple x86_64-apple-macosx10.15.0 %s +# RUN: %lldb %t -o "target variable constant" -b | FileCheck %s + shafik wrote: > aprantl

[Lldb-commits] [PATCH] D86355: Consume error for valid return from Target::GetEntryPointAddress()

JDevlieghere added inline comments. Comment at: lldb/source/Target/Target.cpp:2408-2446 llvm::Expected Target::GetEntryPointAddress() { Module *exe_module = GetExecutableModulePointer(); llvm::Error error = llvm::Error::success(); assert(!error); // Check the success

[Lldb-commits] [lldb] 2799031 - [lldb] Skip PDB and NativePDB tests with reproducers

Author: Jonas Devlieghere Date: 2020-08-21T09:09:45-07:00 New Revision: 2799031a14323eee48694a3aa4f56a171a687d00 URL: https://github.com/llvm/llvm-project/commit/2799031a14323eee48694a3aa4f56a171a687d00 DIFF:

[Lldb-commits] [PATCH] D86355: Consume error for valid return from Target::GetEntryPointAddress()

dim created this revision. dim added reviewers: aprantl, emaste, JDevlieghere, jingham. Herald added subscribers: krytarowski, arichardson. Herald added a project: LLDB. dim requested review of this revision. When `Target::GetEntryPointAddress()` calls

[Lldb-commits] [PATCH] D86311: Fix how ValueObjectVariable handles DW_AT_const_value when the DWARFExpression holds the data that represents a constant value

shafik marked an inline comment as done. shafik added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/DW_AT_const_value.s:2 +# RUN: llvm-mc -filetype=obj -o %t -triple x86_64-apple-macosx10.15.0 %s +# RUN: %lldb %t -o "target variable constant" -b | FileCheck %s +

[Lldb-commits] [PATCH] D86348: [lldb/DWARF] More DW_AT_const_value fixes

shafik added a comment. Thank you finding these additional fixed, it looks good but I don't know some of the details as well as Adrian so I would prefer he gives the LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86348/new/

[Lldb-commits] [PATCH] D86348: [lldb/DWARF] More DW_AT_const_value fixes

labath updated this revision to Diff 287023. labath added a comment. Actually, keep the old const_value test, but give it a bitfield-specific name. Testing bitfields+const_values is still interesting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D86348: [lldb/DWARF] More DW_AT_const_value fixes

labath created this revision. labath added reviewers: shafik, aprantl. Herald added a project: LLDB. labath requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: sstefan1, JDevlieghere. This fixes several issues in handling of DW_AT_const_value

[Lldb-commits] [PATCH] D83116: [DWARFYAML] Add support for referencing different abbrev tables.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf5643dc3dce2: Recommit: [DWARFYAML] Add support for referencing different abbrev tables. (authored by Higuoxing). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D83116: [DWARFYAML] Add support for referencing different abbrev tables.

jhenderson accepted this revision. jhenderson added a comment. This revision is now accepted and ready to land. Looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83116/new/ https://reviews.llvm.org/D83116

[Lldb-commits] [PATCH] D83116: [DWARFYAML] Add support for referencing different abbrev tables.

Higuoxing requested review of this revision. Higuoxing added a comment. Hi @jhenderson This change is causing build failure on armv7 platform and I've fixed it. See: http://lab.llvm.org:8011/builders/clang-cmake-armv7-global-isel/builds/10400 and

[Lldb-commits] [PATCH] D83116: [DWARFYAML] Add support for referencing different abbrev tables.

Higuoxing updated this revision to Diff 286987. Higuoxing added a comment. Add missing test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83116/new/ https://reviews.llvm.org/D83116 Files: llvm/include/llvm/ObjectYAML/DWARFYAML.h

[Lldb-commits] [PATCH] D83116: [DWARFYAML] Add support for referencing different abbrev tables.

Higuoxing updated this revision to Diff 286985. Higuoxing added a comment. Fix incorrect format string. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83116/new/ https://reviews.llvm.org/D83116 Files: llvm/include/llvm/ObjectYAML/DWARFYAML.h

[Lldb-commits] [PATCH] D86261: Add hashing of the .text section to ProcessMinidump.

labath accepted this revision. labath added a comment. In D86261#2229341 , @clayborg wrote: > Hopefully this should be good to go, let me know if anyone has any issues. Looks good, just please also add a test case which runs off the end of the text

[Lldb-commits] [lldb] e1cd7ca - [lldb] Tab completion for process load/unload

Author: Gongyu Deng Date: 2020-08-21T10:36:39+02:00 New Revision: e1cd7cac8a36608616d515b64d12f2e86643970d URL: https://github.com/llvm/llvm-project/commit/e1cd7cac8a36608616d515b64d12f2e86643970d DIFF: https://github.com/llvm/llvm-project/commit/e1cd7cac8a36608616d515b64d12f2e86643970d.diff

[Lldb-commits] [PATCH] D79887: [lldb] Tab completion for process load/unload

This revision was automatically updated to reflect the committed changes. Closed by commit rGe1cd7cac8a36: [lldb] Tab completion for process load/unload (authored by MrHate, committed by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D86311: Fix how ValueObjectVariable handles DW_AT_const_value when the DWARFExpression holds the data that represents a constant value

labath added a comment. LGTM, modulo the defensive check. Incidentally, I was just looking at a DW_AT_const_value bug, but I think it's a different issue than this one. Comment at: lldb/source/Core/ValueObjectVariable.cpp:136 +if (expr.GetExpressionData(m_data)) { +