[Lldb-commits] [PATCH] D87675: [lldb/DWARF] Refactor to prefer emplace_back() vs. push_back()

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Ok, this is something we can talk about. dwarf parsing is a big bottle neck, so spending some time to optimize that (and even sacrifice some readability/mantainability/etc. if needed) is worth

[Lldb-commits] [PATCH] D87694: [lldb] Don't send invalid region addresses to lldb server

labath added inline comments. Comment at: lldb/source/Commands/CommandObjectMemory.cpp:1710 result.SetStatus(eReturnStatusFailed); } } How about adding `return false` here to avoid indenting the code below? Comm

[Lldb-commits] [PATCH] D87694: [lldb] Don't send invalid region addresses to lldb server

DavidSpickett updated this revision to Diff 292142. DavidSpickett added a comment. - Return early - Only check for expected error in TestMemoryRegion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87694/new/ https://reviews.llvm.org/D87694 Files:

[Lldb-commits] [PATCH] D87694: [lldb] Don't send invalid region addresses to lldb server

DavidSpickett marked an inline comment as done. DavidSpickett added inline comments. Comment at: lldb/source/Commands/CommandObjectMemory.cpp:1710 result.SetStatus(eReturnStatusFailed); } } labath wrote: > How about adding `return

[Lldb-commits] [PATCH] D87694: [lldb] Don't send invalid region addresses to lldb server

labath added inline comments. Comment at: lldb/source/Commands/CommandObjectMemory.cpp:1710 result.SetStatus(eReturnStatusFailed); } } DavidSpickett wrote: > labath wrote: > > How about adding `return false` here to avoid indentin

[Lldb-commits] [PATCH] D87694: [lldb] Don't send invalid region addresses to lldb server

DavidSpickett updated this revision to Diff 292175. DavidSpickett marked an inline comment as done. DavidSpickett added a comment. - Check complete error message instead of using regex Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87694/new/ https:

[Lldb-commits] [PATCH] D87694: [lldb] Don't send invalid region addresses to lldb server

DavidSpickett added inline comments. Comment at: lldb/test/API/functionalities/memory-region/TestMemoryRegion.py:44-52 +# Test that when the address fails to parse, we do not carry on +# and ask lldb-server for an invalid address +interp.HandleCommand("me

[Lldb-commits] [PATCH] D87694: [lldb] Don't send invalid region addresses to lldb server

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/test/API/functionalities/memory-region/TestMemoryRegion.py:44-52 +# Test that when the address fails to parse, we do not carry on +# and

[Lldb-commits] [PATCH] D87765: [llvm][lldb] Add optimal ThreadPool concurrency

dmantipov created this revision. dmantipov added a reviewer: labath. Herald added subscribers: llvm-commits, lldb-commits, arphaman. Herald added projects: LLDB, LLVM. dmantipov requested review of this revision. Herald added a subscriber: JDevlieghere. Add an optimal thread strategy to execute sp

[Lldb-commits] [PATCH] D87765: [llvm][lldb] Add optimal ThreadPool concurrency

dmantipov added a comment. Running on 48-core system, I was pretty surprised to see 48-threads pool when attempting to debug a toy C++ program. So here is a fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87765/new/ https://reviews.llvm.org/D87

[Lldb-commits] [PATCH] D87590: Backport D79219, D85820, D86134 to 10.0 branch

haampie added a comment. D86134 should not be added, it was reverted afterwards. What eventually landed was D85820 , which adds a better fix for what D86134 was supposed to solve. Repository:

[Lldb-commits] [PATCH] D87590: Backport D79219, D85820, D86134 to 10.0 branch

labath added a comment. In D87590#2273721 , @haampie wrote: > Also note that the changes are not likely to be backported to 11 even: > https://reviews.llvm.org/rG31e5f7120bdd2f76337686d9d169b1c00e6ee69c#942622. 11.0.0, probably. There's should be enough

[Lldb-commits] [PATCH] D87590: Backport D79219, D85820, D86134 to 10.0 branch

haampie added a comment. Also note that the changes are not likely to be backported to 11 even: https://reviews.llvm.org/rG31e5f7120bdd2f76337686d9d169b1c00e6ee69c#942622 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87590/new/ https://reviews.llv

[Lldb-commits] [PATCH] D87590: Backport D79219, D85820, D86134 to 10.0 branch

labath added subscribers: tstellar, labath. labath added a reviewer: tstellar. labath added a comment. @tstellar, who is (was) the release manager for 10.0, can make a definitive call, but our usual modus operandi is to have one point release for each major version. I don't know if this is a suf

[Lldb-commits] [lldb] f723d19 - Add '<' meta command to read in code from external file

Author: Patrick Beard Date: 2020-09-16T11:36:54-07:00 New Revision: f723d193e2c92ea6903e3debfee32b13354808bc URL: https://github.com/llvm/llvm-project/commit/f723d193e2c92ea6903e3debfee32b13354808bc DIFF: https://github.com/llvm/llvm-project/commit/f723d193e2c92ea6903e3debfee32b13354808bc.diff

[Lldb-commits] [PATCH] D87640: Add '<' meta command to read in code from external file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf723d193e2c9: Add '<' meta command to read in code from external file (authored by pcbeard, committed by jingham). Repository: rG LLVM Github Mono

[Lldb-commits] [PATCH] D87637: [lldb/test] Enable faulthandler in dotest

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. I think this will be very useful. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87637/new/ https://reviews.llvm.org/D87637 __

[Lldb-commits] [lldb] dd67581 - [lldb/test] Enable faulthandler in dotest

Author: Jordan Rupprecht Date: 2020-09-16T14:26:40-07:00 New Revision: dd67581407c1693e43ac8a90b3a20c597614bda8 URL: https://github.com/llvm/llvm-project/commit/dd67581407c1693e43ac8a90b3a20c597614bda8 DIFF: https://github.com/llvm/llvm-project/commit/dd67581407c1693e43ac8a90b3a20c597614bda8.di

[Lldb-commits] [PATCH] D87637: [lldb/test] Enable faulthandler in dotest

This revision was automatically updated to reflect the committed changes. Closed by commit rGdd67581407c1: [lldb/test] Enable faulthandler in dotest (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87637/new/ https://reviews.ll

[Lldb-commits] [PATCH] D86660: Modifying ImportDeclContext(...) to ensure that we also handle the case when the FieldDecl is an ArrayType whose ElementType is a RecordDecl

shafik added a comment. Herald added a reviewer: JDevlieghere. We are going to move forward with this approach (after dealing with the multi-dimensional array case) temporarily. We are seeing crash bugs from this from users and we want to fix it while we explore the solution space more. This PR

[Lldb-commits] [PATCH] D87640: Add '<' meta command to read in code from external file

shafik added inline comments. Comment at: lldb/source/Expression/REPL.cpp:199 +error_sp->Printf("file at path '%s' too large: " + "file_size = %llu, max_size = %llu\n", + path.c_str(), file_size, max_size); `%llu` is no

[Lldb-commits] [PATCH] D87807: [lldb/Commands] Fix outdated `breakpoint command add` help string

kastiglione created this revision. kastiglione added reviewers: jingham, teemperor. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kastiglione requested review of this revision. Herald added a subscriber: JDevlieghere. Update the some examples in the help string for `breakp

[Lldb-commits] [PATCH] D87807: [lldb/Commands] Fix outdated `breakpoint command add` help string

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectBreakpointCommand.cpp:174-181 -(lldb) breakpoint command add -s python 1 -Enter your Python command(s). Type 'DONE' to end. -> def breakpoint_output (bp_no): -> out_string = "Hit breakpoint numbe

[Lldb-commits] [PATCH] D87807: [lldb/Commands] Fix outdated `breakpoint command add` help string

jingham added a comment. LGTM, if you want to remove the last example, I say go ahead. If you want to dig in more, then we should go through another review for the useful example. Comment at: lldb/source/Commands/CommandObjectBreakpointCommand.cpp:174-181 -(lldb) breakpoint c

[Lldb-commits] [lldb] c140322 - Use zu rather than llu format specifier for size_t (-Wformat warning fix).

Author: Eric Christopher Date: 2020-09-16T19:28:05-07:00 New Revision: c140322819806cb292e079d62f2e9dbab697c08c URL: https://github.com/llvm/llvm-project/commit/c140322819806cb292e079d62f2e9dbab697c08c DIFF: https://github.com/llvm/llvm-project/commit/c140322819806cb292e079d62f2e9dbab697c08c.di

[Lldb-commits] [PATCH] D87807: [lldb/Commands] Fix outdated `breakpoint command add` help string

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectBreakpointCommand.cpp:174-181 -(lldb) breakpoint command add -s python 1 -Enter your Python command(s). Type 'DONE' to end. -> def breakpoint_output (bp_no): -> out_string = "Hit breakpoint numbe

[Lldb-commits] [lldb] 57dd927 - [lldb] Return FileSP and StreamFileSP by value in IOHandler (NFC)

Author: Jonas Devlieghere Date: 2020-09-16T21:15:05-07:00 New Revision: 57dd92746a53526bd7a86c1cfc7c0dce57a2e170 URL: https://github.com/llvm/llvm-project/commit/57dd92746a53526bd7a86c1cfc7c0dce57a2e170 DIFF: https://github.com/llvm/llvm-project/commit/57dd92746a53526bd7a86c1cfc7c0dce57a2e170.d