[Lldb-commits] [PATCH] D87878: [DWARFYAML] Make the include_directories, file_names and opcodes fields of the line table optional.

jhenderson added a comment. I might be missing it, but do you have direct testing showing that the default for `IncludeDirs`\`Files`\`Opcodes` is an empty output, when the output is written? I think it's important that this is tested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[Lldb-commits] [PATCH] D87878: [DWARFYAML] Make the include_directories, file_names and opcodes fields of the line table optional.

Higuoxing updated this revision to Diff 292719. Higuoxing added a comment. In D87878#2281189 , @jhenderson wrote: > I might be missing it, but do you have direct testing showing that the > default for `IncludeDirs`\`Files`\`Opcodes` is an empty output, wh

[Lldb-commits] [PATCH] D87878: [DWARFYAML] Make the include_directories, file_names and opcodes fields of the line table optional.

jhenderson accepted this revision. jhenderson added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87878/new/ https://reviews.llvm.org/D87878

[Lldb-commits] [PATCH] D87878: [DWARFYAML] Make the include_directories, file_names and opcodes fields of the line table optional.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2d35092cd258: [DWARFYAML] Make the include_directories, file_names and opcodes fields of the… (authored by Higuoxing). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [lldb] 2d35092 - [DWARFYAML] Make the include_directories, file_names and opcodes fields of the line table optional.

Author: Xing GUO Date: 2020-09-18T20:21:11+08:00 New Revision: 2d35092cd2589dffbca1e34a3dc68f6df75818a9 URL: https://github.com/llvm/llvm-project/commit/2d35092cd2589dffbca1e34a3dc68f6df75818a9 DIFF: https://github.com/llvm/llvm-project/commit/2d35092cd2589dffbca1e34a3dc68f6df75818a9.diff LOG:

[Lldb-commits] [PATCH] D85705: Add a "Trace" plug-in to LLDB to add process trace support in stages.

wallace updated this revision to Diff 292922. wallace added a comment. Based on the discussion from D87335 , I'm moving all the JSON utilities as non-member functions to the settings parser file. Eventually this can be refactored if that patch moves forward. The