jasonmolenda created this revision.
jasonmolenda added reviewers: jingham, clayborg.
jasonmolenda added a project: LLDB.
Herald added subscribers: lldb-commits, JDevlieghere.
Herald added a reviewer: JDevlieghere.
jasonmolenda requested review of this revision.
I implemented something that's been
teemperor added a comment.
This also doesn't work on my macOS system:
FAIL: LLDB (/Users/teemperor/1llvm/rel/bin/clang-x86_64) ::
test_stop_hooks_scripted_return_false (TestStopHookScripted.TestStopHooks)
==
FAIL:
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGe779427757f2: Fix MIPS and MIPS64 ABI to use ConstString in
their register info arrays. (authored by tatsuo, committed by teemperor).
Repository:
teemperor added a comment.
Done. Thanks for the patch!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88375/new/
https://reviews.llvm.org/D88375
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
Author: Tatsuo Nomura
Date: 2020-09-27T12:36:09+02:00
New Revision: e779427757f233ef7bbb381289c63f2399ecca92
URL:
https://github.com/llvm/llvm-project/commit/e779427757f233ef7bbb381289c63f2399ecca92
DIFF:
https://github.com/llvm/llvm-project/commit/e779427757f233ef7bbb381289c63f2399ecca92.diff
tatsuo added a comment.
@teemperor Thanks for the quick review and context!
I don't have commit access, that'd be great if you could merge it in.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88375/new/
https://reviews.llvm.org/D88375
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
To clarify the description a bit: `RegInfoBasedABI::GetRegisterInfoByName` is
comparing the name/alt_name by doing a `const char *` pointer value comparison.
That only works if both
tatsuo created this revision.
tatsuo added reviewers: LLDB, jasonmolenda.
Herald added subscribers: lldb-commits, atanasyan, jrtc27, arichardson, sdardis.
Herald added a project: LLDB.
tatsuo requested review of this revision.
Herald added a subscriber: JDevlieghere.
davezarzycki added a comment.
Hi Jim, this change broke my Fedora 33 Linux (x86) box. Do you think we can get
a quick fix or revert this?
FAIL: lldb-shell :: Commands/command-stop-hook-output.test (69796 of 70913)
TEST 'lldb-shell ::
