[Lldb-commits] [PATCH] D88583: [lldb] [test/Register] Add read/write tests for x87 regs

mgorny added a comment. Well, it's not full input but sure, it's good enough. So I suppose the problem is that the register is named stmm instead of st. I suppose we can use a regex to fix read test, and maybe teach lldb stX alias for write test. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D88583: [lldb] [test/Register] Add read/write tests for x87 regs

JDevlieghere added a comment. In D88583#2310556 , @mgorny wrote: > In D88583#2310538 , @JDevlieghere > wrote: > >> This is failing on GreenDragon so I've XFAILed the tests (temporarily). Can >> you take a look and

[Lldb-commits] [PATCH] D88583: [lldb] [test/Register] Add read/write tests for x87 regs

mgorny added a comment. In D88583#2310538 , @JDevlieghere wrote: > This is failing on GreenDragon so I've XFAILed the tests (temporarily). Can > you take a look and see if they can be fixed and re-enabled? I'm afraid I don't have enough context. Would y

[Lldb-commits] [PATCH] D88792: [lldb/test] Catch invalid calls to expect()

kastiglione created this revision. kastiglione added reviewers: aprantl, JDevlieghere, teemperor. Herald added subscribers: lldb-commits, kbarton, nemanjai. Herald added a project: LLDB. kastiglione requested review of this revision. Add preconditions to `TestBase.expect()` that catch semantically

[Lldb-commits] [PATCH] D86670: [intel-pt] Add a basic implementation of the dump command

wallace abandoned this revision. wallace added a comment. I'm redoing this in https://reviews.llvm.org/D88769 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86670/new/ https://reviews.llvm.org/D86670 ___

[Lldb-commits] [PATCH] D88583: [lldb] [test/Register] Add read/write tests for x87 regs

JDevlieghere added a comment. This is failing on GreenDragon so I've XFAILed the tests (temporarily). Can you take a look and see if they can be fixed and re-enabled? commit 0f08a1a5b162dcd2caf1b76827b917ca69e3e48d (HEAD -> master, origin/master, origin/HEAD) Author: Jonas Devlieghere Da

[Lldb-commits] [lldb] 0f08a1a - [lldb] [test/Register] Mark new FP reg tests XFAIL on Darwin

Author: Jonas Devlieghere Date: 2020-10-03T22:36:28-07:00 New Revision: 0f08a1a5b162dcd2caf1b76827b917ca69e3e48d URL: https://github.com/llvm/llvm-project/commit/0f08a1a5b162dcd2caf1b76827b917ca69e3e48d DIFF: https://github.com/llvm/llvm-project/commit/0f08a1a5b162dcd2caf1b76827b917ca69e3e48d.d

[Lldb-commits] [PATCH] D88199: Introduce and use a new section type for the bb_addr_map section.

rahmanl updated this revision to Diff 295666. rahmanl added a comment. Herald added subscribers: libcxx-commits, openmp-commits, lldb-commits, Sanitizers, cfe-commits, tatianashp, wenlei, ThomasRaoux, AlexeySotkin, msifontes, sstefan1, jurahul, Kayjukh, grosul1, Joonsoo, stephenneuendorffer, ker

[Lldb-commits] [PATCH] D88199: Introduce and use a new section type for the bb_addr_map section.

rahmanl updated this revision to Diff 295668. rahmanl added a comment. Diff reupload. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88199/new/ https://reviews.llvm.org/D88199 Files: llvm/include/llvm/BinaryFormat/ELF.h llvm/lib/CodeGen/AsmPrin

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

labath added a comment. ABI plugins are one of the hardest things to test in lldb, particularly without actual hardware. That's why we've let them be added in the past without any accompanying tests. The situation is not ideal though, because we've accumulated various ABI plugins which are hard

[Lldb-commits] [PATCH] D88613: [flang] Semantic analysis for FINAL subroutines

klausler updated this revision to Diff 295423. klausler added a comment. Previous update to this review had inadvertent changes to other files because I neglected to rebase after updating master; now fixed. Sorry for the scare! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

Re: [Lldb-commits] [lldb] 92e1ebe - [trace] Fix destructor declaration

But what about the case Vedant mentioned? >Otherwise, when a std::shared_ptr is destroyed, the destructor for > the derived TraceIntelPT instance won't run. Or is C++ smart enough to pick the destructor from TraceIntelPT class in this case? On 9/30/20, 5:56 AM, "Pavel Labath" wrote:

[Lldb-commits] [lldb] 508ac0e - [lldb] [test/Register] Mark new FP reg tests XFAIL on Windows

Author: Michał Górny Date: 2020-10-03T22:16:29+02:00 New Revision: 508ac0ec13c1c56029fd2390a2e14c1b2ea84b73 URL: https://github.com/llvm/llvm-project/commit/508ac0ec13c1c56029fd2390a2e14c1b2ea84b73 DIFF: https://github.com/llvm/llvm-project/commit/508ac0ec13c1c56029fd2390a2e14c1b2ea84b73.diff

[Lldb-commits] [PATCH] D88682: [lldb] [Process/NetBSD] Fix crash on unsupported i386 regs

This revision was automatically updated to reflect the committed changes. Closed by commit rG9821632056dc: [lldb] [Process/NetBSD] Fix crash on unsupported i386 regs (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D88583: [lldb] [test/Register] Add read/write tests for x87 regs

This revision was automatically updated to reflect the committed changes. Closed by commit rG381bdc75ee2c: [lldb] [test/Register] Add read/write tests for x87 regs (authored by mgorny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88583/new/ https:

[Lldb-commits] [PATCH] D88681: [lldb] [Process/NetBSD] Fix reading FIP/FDP registers

This revision was automatically updated to reflect the committed changes. Closed by commit rG80b108f404fc: [lldb] [Process/NetBSD] Fix reading FIP/FDP registers (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [lldb] 80b108f - [lldb] [Process/NetBSD] Fix reading FIP/FDP registers

Author: Michał Górny Date: 2020-10-03T19:54:38+02:00 New Revision: 80b108f404fc9e9df7247f6ae9697083cbda URL: https://github.com/llvm/llvm-project/commit/80b108f404fc9e9df7247f6ae9697083cbda DIFF: https://github.com/llvm/llvm-project/commit/80b108f404fc9e9df7247f6ae9697083cbda.diff

[Lldb-commits] [lldb] 381bdc7 - [lldb] [test/Register] Add read/write tests for x87 regs

Author: Michał Górny Date: 2020-10-03T19:54:38+02:00 New Revision: 381bdc75ee2ca2fb9784ffb2f6b90accd8eab3b6 URL: https://github.com/llvm/llvm-project/commit/381bdc75ee2ca2fb9784ffb2f6b90accd8eab3b6 DIFF: https://github.com/llvm/llvm-project/commit/381bdc75ee2ca2fb9784ffb2f6b90accd8eab3b6.diff

[Lldb-commits] [lldb] 9821632 - [lldb] [Process/NetBSD] Fix crash on unsupported i386 regs

Author: Michał Górny Date: 2020-10-03T19:54:38+02:00 New Revision: 9821632056dce9e2150bab9c0fbd9b2c7da64258 URL: https://github.com/llvm/llvm-project/commit/9821632056dce9e2150bab9c0fbd9b2c7da64258 DIFF: https://github.com/llvm/llvm-project/commit/9821632056dce9e2150bab9c0fbd9b2c7da64258.diff

[Lldb-commits] [PATCH] D88583: [lldb] [test/Register] Add read/write tests for x87 regs

mgorny updated this revision to Diff 295980. mgorny added a comment. Added missing `-g` to x86-fp-read.cpp build, as necessary to get address of `zero`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88583/new/ https://reviews.llvm.org/D88583 Files: lldb/test/Shell/Register/Inputs/x8

[Lldb-commits] [PATCH] D88769: [trace] Scaffold "thread trace dump instructions"

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. See inline comments about "thread trace dump instructions" as I am not quite sure what --offset means. After we load a trace file, what is the default "offset" value? Is there a