[Lldb-commits] [PATCH] D90276: [lldb/utils] Add the lldb-env tool

JDevlieghere added a comment. In D90276#2358016 , @vsk wrote: > In D90276#2357978 , @JDevlieghere > wrote: > >> Can you explain the added value of the tool a bit more. I can see how it's >> nice to be able to run

[Lldb-commits] [PATCH] D90276: [lldb/utils] Add the lldb-env tool

vsk added a comment. In D90276#2357978 , @JDevlieghere wrote: > Can you explain the added value of the tool a bit more. I can see how it's > nice to be able to run `export $(lldb-env); path/to/lldb` but I wonder how > often you'd end up doing that. When

[Lldb-commits] [PATCH] D90276: [lldb/utils] Add the lldb-env tool

JDevlieghere added a comment. Can you explain the added value of the tool a bit more. I can see how it's nice to be able to run `export $(lldb-env); path/to/lldb` but I wonder how often you'd end up doing that. When I invoke lldb directly, it's mostly to debug a test case, in which case I'd nee

[Lldb-commits] [PATCH] D90276: [lldb/utils] Add the lldb-env tool

vsk created this revision. vsk added reviewers: JDevlieghere, teemperor, mgorny. Herald added a project: LLDB. vsk requested review of this revision. Introduce lldb-env, a tool that prints out the environment variables needed to launch lldb. Usually, no environment variables need to be set to lau

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

Hello Vitaly, This should be fixed. Please let me know if you still see the issue. Thanks Galina On Tue, Oct 27, 2020 at 4:45 PM Vitaly Buka wrote: > It looks fixed. I haven't seen them in recent reports. > > On Tue, 27 Oct 2020 at 16:32, Vitaly Buka wrote: > >> Any news regarding false-n

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

wallace updated this revision to Diff 301130. wallace added a comment. nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89283/new/ https://reviews.llvm.org/D89283 Files: lldb/include/lldb/Core/Disassembler.h lldb/include/lldb/Symbol/SymbolCo

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

wallace updated this revision to Diff 301128. wallace added a comment. Followed @vsk's suggestion. I didn't do exactly what he said, but I ended up creating my own IntelPTError to represent better the different kinds of errors and make sure we can create a correct llvm::Error when traversing the

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

It looks fixed. I haven't seen them in recent reports. On Tue, 27 Oct 2020 at 16:32, Vitaly Buka wrote: > Any news regarding false-negatives? > > +Mitch Phillips > > On Mon, 19 Oct 2020 at 22:07, Galina Kistanova > wrote: > >> Thanks, Vitaly. >> Somebody is looking at this. >> >> >> On Mon, Oc

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

Any news regarding false-negatives? +Mitch Phillips On Mon, 19 Oct 2020 at 22:07, Galina Kistanova wrote: > Thanks, Vitaly. > Somebody is looking at this. > > > On Mon, Oct 19, 2020 at 9:56 PM Vitaly Buka wrote: > >> it's not just staging, this build must be marked as failed >> http://lab.llv

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM with the few nits addressed. Comment at: lldb/include/lldb/Symbol/Type.h:269 + lldb::ModuleSP GetModule(); + Comment

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum added a comment. @JDevlieghere ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88483/new/ https://reviews.llvm.org/D88483 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lis

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

vsk added a comment. @wallace thanks for winnowing the test objects. I left an inline suggestion about simplifying the error-handling in IntelPTInstruction. Other than that, mechanically this is looking good. Thanks! Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThrea

[Lldb-commits] [lldb] 00bb397 - [lldb] Support Python imports relative the to the current file being sourced

Author: Jonas Devlieghere Date: 2020-10-27T09:20:45-07:00 New Revision: 00bb397b0dc79fcad27bfe63456a2100039706f2 URL: https://github.com/llvm/llvm-project/commit/00bb397b0dc79fcad27bfe63456a2100039706f2 DIFF: https://github.com/llvm/llvm-project/commit/00bb397b0dc79fcad27bfe63456a2100039706f2.d

[Lldb-commits] [PATCH] D89334: [lldb] Support Python imports relative the to the current file being sourced

This revision was automatically updated to reflect the committed changes. Closed by commit rG00bb397b0dc7: [lldb] Support Python imports relative the to the current file being sourced (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D89

[Lldb-commits] [PATCH] D89334: [lldb] Support Python imports relative the to the current file being sourced

JDevlieghere added a comment. In D89334#2355870 , @labath wrote: > Let's see how this goes. Thanks for bearing with me :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89334/new/ https://reviews.llvm.org/D89334 ___

[Lldb-commits] [lldb] 45c3fc9 - [lldb][NFC] Make GetResumeCountForLaunchInfo return an unsigned.

Author: Raphael Isemann Date: 2020-10-27T16:25:01+01:00 New Revision: 45c3fc97a2a5af760a55e72eb081aa5f977e9609 URL: https://github.com/llvm/llvm-project/commit/45c3fc97a2a5af760a55e72eb081aa5f977e9609 DIFF: https://github.com/llvm/llvm-project/commit/45c3fc97a2a5af760a55e72eb081aa5f977e9609.dif

[Lldb-commits] [lldb] d43c70a - [lldb] Add llvm-pdbutil to lldb test dependencies

Author: Raphael Isemann Date: 2020-10-27T15:46:25+01:00 New Revision: d43c70a2025972c60dc1a30b4661273dc584d0b8 URL: https://github.com/llvm/llvm-project/commit/d43c70a2025972c60dc1a30b4661273dc584d0b8 DIFF: https://github.com/llvm/llvm-project/commit/d43c70a2025972c60dc1a30b4661273dc584d0b8.dif

[Lldb-commits] [PATCH] D90102: [lldb] [Process/FreeBSDRemote] Enable watchpoint support

This revision was automatically updated to reflect the committed changes. Closed by commit rG8e7ea99c3823: [lldb] [Process/FreeBSDRemote] Enable watchpoint support (authored by mgorny). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D90102?vs=300806&id=300984#to

[Lldb-commits] [lldb] 8e7ea99 - [lldb] [Process/FreeBSDRemote] Enable watchpoint support

Author: Michał Górny Date: 2020-10-27T15:38:00+01:00 New Revision: 8e7ea99c382300439486e562ba507d4a1bd6cc89 URL: https://github.com/llvm/llvm-project/commit/8e7ea99c382300439486e562ba507d4a1bd6cc89 DIFF: https://github.com/llvm/llvm-project/commit/8e7ea99c382300439486e562ba507d4a1bd6cc89.diff

[Lldb-commits] [lldb] 4ba8ea4 - [lldb] [Process/FreeBSD] Fix missing namespace qualifier

Author: Michał Górny Date: 2020-10-27T15:38:00+01:00 New Revision: 4ba8ea4cb06758cb80dfa3d0409f7aab3d3f8e93 URL: https://github.com/llvm/llvm-project/commit/4ba8ea4cb06758cb80dfa3d0409f7aab3d3f8e93 DIFF: https://github.com/llvm/llvm-project/commit/4ba8ea4cb06758cb80dfa3d0409f7aab3d3f8e93.diff

[Lldb-commits] [PATCH] D90225: [lldb] Correct --help output for qemu rootfs script

DavidSpickett created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. DavidSpickett requested review of this revision. Herald added a subscriber: JDevlieghere. It was printing "Usage:" twice. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D9

[Lldb-commits] [PATCH] D89383: [lldb] Correct vFile:pread/pwrite packet docs

DavidSpickett added a comment. Landed as already agreed on in https://reviews.llvm.org/D89227. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89383/new/ https://reviews.llvm.org/D89383 ___ lldb-commits ma

[Lldb-commits] [PATCH] D89383: [lldb] Correct vFile:pread/pwrite packet docs

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGf8a3b9b06c4a: [lldb] Correct vFile:pread/pwrite packet docs (authored by DavidSpickett). Repository: rG LLVM Github Mon

[Lldb-commits] [lldb] f8a3b9b - [lldb] Correct vFile:pread/pwrite packet docs

Author: David Spickett Date: 2020-10-27T11:47:35Z New Revision: f8a3b9b06c4a46fe2a83ec52f8e396d335b44fdd URL: https://github.com/llvm/llvm-project/commit/f8a3b9b06c4a46fe2a83ec52f8e396d335b44fdd DIFF: https://github.com/llvm/llvm-project/commit/f8a3b9b06c4a46fe2a83ec52f8e396d335b44fdd.diff LOG

[Lldb-commits] [PATCH] D90102: [lldb] [Process/FreeBSDRemote] Enable watchpoint support

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeThreadFreeBSD.cpp:192-193 +return Status("not implemented"); + if (m_state == eStateLaunching) +return Status(); + Status error = RemoveWatchpoint(addr); labath w

[Lldb-commits] [PATCH] D89334: [lldb] Support Python imports relative the to the current file being sourced

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Let's see how this goes. Comment at: lldb/source/Commands/Options.td:709 +Group<1>, Desc<"Resolve relative paths relative to the location of the " +"current command f

[Lldb-commits] [lldb] 1f933ff - [lldb][NFC] Rewrite TestQuoting

Author: Raphael Isemann Date: 2020-10-27T11:12:17+01:00 New Revision: 1f933ff999f2c0373c79ddf23539873cbfa923e5 URL: https://github.com/llvm/llvm-project/commit/1f933ff999f2c0373c79ddf23539873cbfa923e5 DIFF: https://github.com/llvm/llvm-project/commit/1f933ff999f2c0373c79ddf23539873cbfa923e5.dif

[Lldb-commits] [PATCH] D90102: [lldb] [Process/FreeBSDRemote] Enable watchpoint support

labath added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeThreadFreeBSD.cpp:192-193 +return Status("not implemented"); + if (m_state == eStateLaunching) +return Status(); + Status error = RemoveWatchpoint(addr); mgorny w

[Lldb-commits] [PATCH] D87172: Check if debug line sequences are starting after the first code segment

labath accepted this revision. labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:503-505 + if (section_list) { +InitializeFirstCodeAddress(*section_list); + } clayborg wrote: > remove braces or even fold the

[Lldb-commits] [PATCH] D90102: [lldb] [Process/FreeBSDRemote] Enable watchpoint support

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeThreadFreeBSD.cpp:192-193 +return Status("not implemented"); + if (m_state == eStateLaunching) +return Status(); + Status error = RemoveWatchpoint(addr); labath w

[Lldb-commits] [PATCH] D90102: [lldb] [Process/FreeBSDRemote] Enable watchpoint support

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeThreadFreeBSD.cpp:192-193 +return Status("not implemented"); + if (m_state == eStateLaunching) +retu