[Lldb-commits] [lldb] 92b036d - debugserver should advance pc past builtin_debugtrap insn

Author: Jason Molenda Date: 2020-11-12T23:31:14-08:00 New Revision: 92b036dea24b6e7ebfd950facdbf5543135eda05 URL: https://github.com/llvm/llvm-project/commit/92b036dea24b6e7ebfd950facdbf5543135eda05 DIFF: https://github.com/llvm/llvm-project/commit/92b036dea24b6e7ebfd950facdbf5543135eda05.diff

[Lldb-commits] [PATCH] D91238: Recognize __builtin_debugtrap on arm64, advance pc past it so users can continue easily

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG92b036dea24b: debugserver should advance pc past builtin_debugtrap

[Lldb-commits] [PATCH] D91238: Recognize __builtin_debugtrap on arm64, advance pc past it so users can continue easily

jasonmolenda updated this revision to Diff 305040. jasonmolenda added a comment. Minor update to the patch to move the test case under API/macosx for now, because it depends on debugserver behavior. Add comments to note that we're all in agreement this should really be handled up in lldb - but

[Lldb-commits] [PATCH] D91293: [lldb] [Process/FreeBSDRemote] Modernize and simplify YMM logic

mgorny updated this revision to Diff 304990. mgorny added a comment. Use a `struct`-based return type. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91293/new/ https://reviews.llvm.org/D91293 Files: lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.cpp

[Lldb-commits] [PATCH] D77153: [lldb/DataFormatters] Display null C++ pointers as nullptr

This revision was automatically updated to reflect the committed changes. Closed by commit rG406ad187486b: [lldb/DataFormatters] Display null C++ pointers as nullptr (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D77153?vs=304614&id=304983#toc Repository: rG LL

[Lldb-commits] [lldb] 406ad18 - [lldb/DataFormatters] Display null C++ pointers as nullptr

Author: Jonas Devlieghere Date: 2020-11-12T15:24:06-08:00 New Revision: 406ad187486b4277fc82a2c0714ae53396e47928 URL: https://github.com/llvm/llvm-project/commit/406ad187486b4277fc82a2c0714ae53396e47928 DIFF: https://github.com/llvm/llvm-project/commit/406ad187486b4277fc82a2c0714ae53396e47928.d

[Lldb-commits] [PATCH] D91130: [crashlog] Implement parser for JSON encoded crashlogs

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Thanks for adding the extra tests! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91130/new/ https://reviews.llvm.org/D91130 ___ lldb-c

[Lldb-commits] [lldb] bae9aed - [LLDB] Fix handling of bit-fields in a union

Author: shafik Date: 2020-11-12T14:09:27-08:00 New Revision: bae9aedb341c5f4eceafba2ee1fec7c05d842c97 URL: https://github.com/llvm/llvm-project/commit/bae9aedb341c5f4eceafba2ee1fec7c05d842c97 DIFF: https://github.com/llvm/llvm-project/commit/bae9aedb341c5f4eceafba2ee1fec7c05d842c97.diff LOG: [

[Lldb-commits] [PATCH] D91118: Fix handling of bit-fields in a union

This revision was automatically updated to reflect the committed changes. Closed by commit rGbae9aedb341c: [LLDB] Fix handling of bit-fields in a union (authored by shafik). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D90729: [trace][intel-pt] Scaffold the 'thread trace start | stop' commands

wallace updated this revision to Diff 304867. wallace added a comment. improve error messages The diff is ready for review again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90729/new/ https://reviews.llvm.org/D90729 Files: lldb/include/lldb/C

[Lldb-commits] [PATCH] D91293: [lldb] [Process/FreeBSDRemote] Modernize and simplify YMM logic

mgorny updated this revision to Diff 304865. mgorny added a comment. Changed prototype to use pointer referenec. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91293/new/ https://reviews.llvm.org/D91293 Files: lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86

[Lldb-commits] [PATCH] D91268: [lldb] [Process/FreeBSDRemote] Access debug registers via offsets

mgorny updated this revision to Diff 304863. mgorny added a comment. Update following the changes in GPR patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91268/new/ https://reviews.llvm.org/D91268 Files: lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_

[Lldb-commits] [PATCH] D91248: [lldb] [Process/FreeBSDRemote] Access FPR via RegisterInfo offsets

mgorny updated this revision to Diff 304861. mgorny added a comment. Update to match changes in GPR patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91248/new/ https://reviews.llvm.org/D91248 Files: lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.cp

[Lldb-commits] [PATCH] D91216: [lldb] [Process/FreeBSDRemote] Access GPR via reginfo offsets

mgorny updated this revision to Diff 304859. mgorny added a comment. clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91216/new/ https://reviews.llvm.org/D91216 Files: lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.cpp lldb/source/Plugins/

[Lldb-commits] [PATCH] D89305: [lldb] Replace TestAbortExitCode with a debugserver specific test

This revision was automatically updated to reflect the committed changes. Closed by commit rGd4b08ccb8794: [lldb] Replace TestAbortExitCode with a debugserver specific test (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github

[Lldb-commits] [lldb] d4b08cc - [lldb] Replace TestAbortExitCode with a debugserver specific test

Author: Raphael Isemann Date: 2020-11-12T17:33:21+01:00 New Revision: d4b08ccb87944ec6c647f02b536a40922ec2dd73 URL: https://github.com/llvm/llvm-project/commit/d4b08ccb87944ec6c647f02b536a40922ec2dd73 DIFF: https://github.com/llvm/llvm-project/commit/d4b08ccb87944ec6c647f02b536a40922ec2dd73.dif

[Lldb-commits] [PATCH] D91118: Fix handling of bit-fields in a union

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91118/new/ https://reviews.llvm.org/D91118 ___ lldb-commits mailing list

[Lldb-commits] [lldb] d85cc03 - [lldb] Add expect_var_path to test variable path results

Author: Raphael Isemann Date: 2020-11-12T16:14:48+01:00 New Revision: d85cc03c9c4cc44c0281320558abc440575ae1d4 URL: https://github.com/llvm/llvm-project/commit/d85cc03c9c4cc44c0281320558abc440575ae1d4 DIFF: https://github.com/llvm/llvm-project/commit/d85cc03c9c4cc44c0281320558abc440575ae1d4.dif

[Lldb-commits] [PATCH] D90450: [lldb] Add expect_var_path to test variable path results

This revision was automatically updated to reflect the committed changes. Closed by commit rGd85cc03c9c4c: [lldb] Add expect_var_path to test variable path results (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] b4b8365 - [lldb][NFC] Move OptionDefinition from lldb-private-types.h to its own Utility header

Author: Raphael Isemann Date: 2020-11-12T15:30:26+01:00 New Revision: b4b836563ae3603b601b57d8992f2d5fe60f02f8 URL: https://github.com/llvm/llvm-project/commit/b4b836563ae3603b601b57d8992f2d5fe60f02f8 DIFF: https://github.com/llvm/llvm-project/commit/b4b836563ae3603b601b57d8992f2d5fe60f02f8.dif

[Lldb-commits] [PATCH] D91241: [LLDB] Make offset field optional in RegisterInfo packet for Arm64

labath added a comment. In D91241#2391156 , @omjavaid wrote: > I guess GDB standard does enforce ascending order, here is what it says about > regnum: > > "The register’s number. If omitted, a register’s number is one greater than > that of the previous

[Lldb-commits] [PATCH] D87442: [lldb] Show flags for memory regions

DavidSpickett added inline comments. Comment at: lldb/test/API/linux/aarch64/mte_memory_region/main.c:9-14 + if (!(getauxval(AT_HWCAP2) & HWCAP2_MTE)) +return 1; + + int got = prctl(PR_SET_TAGGED_ADDR_CTRL, PR_TAGGED_ADDR_ENABLE, 0, 0, 0); + if (got) +return 1; ---

[Lldb-commits] [PATCH] D91216: [lldb] [Process/FreeBSDRemote] Access GPR via reginfo offsets

mgorny updated this revision to Diff 304813. mgorny added a comment. Implemented all the requested changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91216/new/ https://reviews.llvm.org/D91216 Files: lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.c

[Lldb-commits] [PATCH] D91216: [lldb] [Process/FreeBSDRemote] Access GPR via reginfo offsets

mgorny added inline comments. Comment at: lldb/unittests/Process/FreeBSD/RegisterContextFreeBSDTests.cpp:26-31 +#define ASSERT_REG(regname, offset, size) \ + { \ +

[Lldb-commits] [PATCH] D91241: [LLDB] Make offset field optional in RegisterInfo packet for Arm64

omjavaid added a comment. In D91241#2391126 , @labath wrote: > That's a good point. Maybe this does need to be a two-pass algorithm (first > compute the offsets of primary registers, then fill out subregs). But that > doesn't mean the two passes should b

[Lldb-commits] [PATCH] D91241: [LLDB] Make offset field optional in RegisterInfo packet for Arm64

labath added a comment. That's a good point. Maybe this does need to be a two-pass algorithm (first compute the offsets of primary registers, then fill out subregs). But that doesn't mean the two passes should be in two completely separate files. It would still be better if that was done in a s

[Lldb-commits] [PATCH] D91241: [LLDB] Make offset field optional in RegisterInfo packet for Arm64

omjavaid added a comment. In D91241#2391072 , @labath wrote: > This looks pretty straightforward, modulo the inline comment about the > centralization of the offset computations So the current approach of finalizing offsets of pseudo registers after

[Lldb-commits] [PATCH] D87442: [lldb] Show flags for memory regions

labath added inline comments. Comment at: lldb/test/API/linux/aarch64/mte_memory_region/main.c:9-14 + if (!(getauxval(AT_HWCAP2) & HWCAP2_MTE)) +return 1; + + int got = prctl(PR_SET_TAGGED_ADDR_CTRL, PR_TAGGED_ADDR_ENABLE, 0, 0, 0); + if (got) +return 1; --

[Lldb-commits] [PATCH] D91241: [LLDB] Make offset field optional in RegisterInfo packet for Arm64

labath added a comment. This looks pretty straightforward, modulo the inline comment about the centralization of the offset computations Comment at: lldb/source/Plugins/Process/Utility/DynamicRegisterInfo.cpp:534 + // On AArch64 architecture we set offsets on client sid

[Lldb-commits] [PATCH] D91254: [lldb] [Process/Utility] Fix DR offsets for FreeBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rGa8bfee2a356a: [lldb] [Process/Utility] Fix DR offsets for FreeBSD (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D91264: [lldb] [test] Add a minimal test for x86 dbreg reading

This revision was automatically updated to reflect the committed changes. Closed by commit rGf37834c7dcbe: [lldb] [test] Add a minimal test for x86 dbreg reading (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [lldb] f37834c - [lldb] [test] Add a minimal test for x86 dbreg reading

Author: Michał Górny Date: 2020-11-12T14:09:03+01:00 New Revision: f37834c7dcbe69405bf3e182d2b3e3227cc4a569 URL: https://github.com/llvm/llvm-project/commit/f37834c7dcbe69405bf3e182d2b3e3227cc4a569 DIFF: https://github.com/llvm/llvm-project/commit/f37834c7dcbe69405bf3e182d2b3e3227cc4a569.diff

[Lldb-commits] [lldb] a8bfee2 - [lldb] [Process/Utility] Fix DR offsets for FreeBSD

Author: Michał Górny Date: 2020-11-12T14:09:03+01:00 New Revision: a8bfee2a356a2e70f854bf6d0b364798f4183795 URL: https://github.com/llvm/llvm-project/commit/a8bfee2a356a2e70f854bf6d0b364798f4183795 DIFF: https://github.com/llvm/llvm-project/commit/a8bfee2a356a2e70f854bf6d0b364798f4183795.diff

[Lldb-commits] [lldb] 1115d1d - Revert "Generalize regex matching std::string variants to compensate for recent"

Author: Raphael Isemann Date: 2020-11-12T14:01:22+01:00 New Revision: 1115d1d08302e246789b3c3915e65f3147888e47 URL: https://github.com/llvm/llvm-project/commit/1115d1d08302e246789b3c3915e65f3147888e47 DIFF: https://github.com/llvm/llvm-project/commit/1115d1d08302e246789b3c3915e65f3147888e47.dif

[Lldb-commits] [lldb] da121ff - [lldb] Introduce a LLDB printing policy for Clang type names that suppressed inline namespaces

Author: Raphael Isemann Date: 2020-11-12T14:00:33+01:00 New Revision: da121fff1184267a405f81a87f7314df2d474e1c URL: https://github.com/llvm/llvm-project/commit/da121fff1184267a405f81a87f7314df2d474e1c DIFF: https://github.com/llvm/llvm-project/commit/da121fff1184267a405f81a87f7314df2d474e1c.dif

[Lldb-commits] [PATCH] D91264: [lldb] [test] Add a minimal test for x86 dbreg reading

mgorny updated this revision to Diff 304772. mgorny added a comment. Restrict the test to FreeBSD only. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91264/new/ https://reviews.llvm.org/D91264 Files: lldb/test/Shell/Register/Inputs/x86-db-read.cpp lldb/test/Shell/Register/x86-db-re

[Lldb-commits] [PATCH] D91264: [lldb] [test] Add a minimal test for x86 dbreg reading

mgorny added inline comments. Comment at: lldb/test/Shell/Register/x86-db-read.test:2 +# XFAIL: system-windows +# REQUIRES: native && (target-x86 || target-x86_64) && can-set-dbregs +# RUN: %clangxx_host -g %p/Inputs/x86-db-read.cpp -o %t labath wrote: > mgorny w

[Lldb-commits] [PATCH] D91293: [lldb] [Process/FreeBSDRemote] Modernize and simplify YMM logic

labath added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.h:83 size_t GetDBROffset() const; + bool GetYMMSplitReg(uint32_t reg, void **xmm, void **ymm_hi); }; mgorny wrote: > labath wrote: > > `v

[Lldb-commits] [PATCH] D91264: [lldb] [test] Add a minimal test for x86 dbreg reading

mgorny updated this revision to Diff 304751. mgorny added a comment. Corrected `REQUIRES`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91264/new/ https://reviews.llvm.org/D91264 Files: lldb/test/Shell/Register/Inputs/x86-db-read.cpp lldb/test/Shell/Register/x86-db-read.test Ind

[Lldb-commits] [PATCH] D91293: [lldb] [Process/FreeBSDRemote] Modernize and simplify YMM logic

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.cpp:615 + if (offset == LLDB_INVALID_XSAVE_OFFSET) +return false; + labath wrote: > When does this return false? When the ymm regs are no

[Lldb-commits] [PATCH] D91264: [lldb] [test] Add a minimal test for x86 dbreg reading

labath added a comment. Comment at: lldb/test/Shell/Register/x86-db-read.test:2 +# XFAIL: system-windows +# REQUIRES: native && (target-x86 || target-x86_64) && can-set-dbregs +# RUN: %clangxx_host -g %p/Inputs/x86-db-read.cpp -o %t mgorny wrote: > labath wrot

[Lldb-commits] [PATCH] D91264: [lldb] [test] Add a minimal test for x86 dbreg reading

mgorny added a comment. In D91264#2390699 , @labath wrote: > I have a feeling we discussed this already, but I don't remember what was the > conclusion. > > Was exposing debug registers to the user a conscious choice? Other OSes don't > actually do that.

[Lldb-commits] [PATCH] D91293: [lldb] [Process/FreeBSDRemote] Modernize and simplify YMM logic

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.cpp:615 + if (offset == LLDB_INVALID_XSAVE_OFFSET) +return false; + --

[Lldb-commits] [PATCH] D91264: [lldb] [test] Add a minimal test for x86 dbreg reading

labath added a comment. I have a feeling we discussed this already, but I don't remember what was the conclusion. Was exposing debug registers to the user a conscious choice? Other OSes don't actually do that. Neither does gdb, afaict... In think that allowing the user to see dr contents is a

[Lldb-commits] [PATCH] D91216: [lldb] [Process/FreeBSDRemote] Access GPR via reginfo offsets

labath added a comment. I like this. Some comments in the tests -- trying to reduce the amount of preprocessor magic.. Comment at: lldb/unittests/Process/FreeBSD/CMakeLists.txt:1 +add_lldb_unittest(RegisterContextFreeBSDTests + RegisterContextFreeBSDTests.cpp