[Lldb-commits] [lldb] 2fa38fa - [lldb] Python3 byte<->string issue in patch-crashlog.py

Author: Raphael Isemann Date: 2020-11-18T09:58:02+01:00 New Revision: 2fa38fa9a651553080620f4c9883d075df2a706e URL: https://github.com/llvm/llvm-project/commit/2fa38fa9a651553080620f4c9883d075df2a706e DIFF: https://github.com/llvm/llvm-project/commit/2fa38fa9a651553080620f4c9883d075df2a706e.dif

[Lldb-commits] [PATCH] D91645: [lldb] [test] Un-XFAIL tests on freebsd/i386

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. These seems to pass on linux as well (and possibly others too), but I guess nobody runs i386 tests these days... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91645/new/ https://revi

[Lldb-commits] [PATCH] D91508: [LLDB/Lua] add support for one-liner breakpoint callback

labath added inline comments. Comment at: lldb/bindings/lua/lua-wrapper.swig:26-27 + + SBTypeToSWIGWrapper(L, &sb_frame); + SBTypeToSWIGWrapper(L, &sb_bp_loc); + This name made sense for python, as the functions actually returned the wrappers. But here, the

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values [WIP]

labath added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp:534 + // TODO + if (reg_info->kinds[lldb::eRegisterKindLLDB] == lldb_ftag_x86_64) { +uint8_t abridged_tw = *(uint8_t *)src; mgorny wrote: > la

[Lldb-commits] [PATCH] D89315: [debugserver] Add option to propagate SIGSEGV to target process

aarzilli added a comment. In D89315#2400244 , @JDevlieghere wrote: > In D89315#2399805 , @aarzilli wrote: > >> I don't want to be overbearing but should I be doing something else? Is this >> going to be merged and

[Lldb-commits] [PATCH] D91645: [lldb] [test] Un-XFAIL tests on freebsd/i386

mgorny added inline comments. Comment at: lldb/test/API/functionalities/exec/TestExec.py:19 -@expectedFailureAll(archs=['i386'], bugnumber="rdar://28656532") +@expectedFailureAll(archs=['i386'], +oslist=no_match(["freebsd"]), ema

[Lldb-commits] [PATCH] D91497: [lldb] Add explicit 64-bit fip/fdp registers on x86_64

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/unittests/Process/Utility/RegisterContextFreeBSDTest.cpp:82-83 EXPECT_OFF(fop_x86_64, 0x06, 2); // NB: Technically fiseg/foseg are 16-bit long and the higher 16 bits // are reserved.

[Lldb-commits] [lldb] 3e1f1b4 - [lldb] [test] Pass -mmmx to x86-gp-write test explicitly

Author: Michał Górny Date: 2020-11-18T12:08:24+01:00 New Revision: 3e1f1b406e92115f2a36294c2084a8b3a5d6a651 URL: https://github.com/llvm/llvm-project/commit/3e1f1b406e92115f2a36294c2084a8b3a5d6a651 DIFF: https://github.com/llvm/llvm-project/commit/3e1f1b406e92115f2a36294c2084a8b3a5d6a651.diff

[Lldb-commits] [lldb] b48ace0 - [lldb] [test] Un-XFAIL TestMultipleDebuggers.py

Author: Michał Górny Date: 2020-11-18T12:09:04+01:00 New Revision: b48ace051c4bd0a51152ace717bb3f7104f70433 URL: https://github.com/llvm/llvm-project/commit/b48ace051c4bd0a51152ace717bb3f7104f70433 DIFF: https://github.com/llvm/llvm-project/commit/b48ace051c4bd0a51152ace717bb3f7104f70433.diff

[Lldb-commits] [lldb] 5a75512 - [lldb] [test] Mark command-process-connect.test XFAIL

Author: Michał Górny Date: 2020-11-18T12:08:59+01:00 New Revision: 5a75512eba7ef351dab6f699b45c8bef37cb60b7 URL: https://github.com/llvm/llvm-project/commit/5a75512eba7ef351dab6f699b45c8bef37cb60b7 DIFF: https://github.com/llvm/llvm-project/commit/5a75512eba7ef351dab6f699b45c8bef37cb60b7.diff

[Lldb-commits] [lldb] 97a2eac - [lldb] [test] Un-XFAIL tests on freebsd/i386

Author: Michał Górny Date: 2020-11-18T12:09:11+01:00 New Revision: 97a2eac3a924f3081bf80ee69ce59bc89257b857 URL: https://github.com/llvm/llvm-project/commit/97a2eac3a924f3081bf80ee69ce59bc89257b857 DIFF: https://github.com/llvm/llvm-project/commit/97a2eac3a924f3081bf80ee69ce59bc89257b857.diff

[Lldb-commits] [PATCH] D91578: [lldb] [test] Pass -mmmx to x86-gp-write test explicitly

This revision was automatically updated to reflect the committed changes. Closed by commit rG3e1f1b406e92: [lldb] [test] Pass -mmmx to x86-gp-write test explicitly (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [PATCH] D91645: [lldb] [test] Un-XFAIL tests on freebsd/i386

This revision was automatically updated to reflect the committed changes. Closed by commit rG97a2eac3a924: [lldb] [test] Un-XFAIL tests on freebsd/i386 (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D91497: [lldb] Add explicit 64-bit fip/fdp registers on x86_64

mgorny updated this revision to Diff 306031. mgorny marked an inline comment as done. mgorny added a comment. Updated the test comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91497/new/ https://reviews.llvm.org/D91497 Files: lldb/source/Plugins/Process/FreeBSDRemote/NativeReg

[Lldb-commits] [lldb] 50f12ad - [lldb] Fix a couple of remote llgs tests

Author: David Spickett Date: 2020-11-18T11:36:45Z New Revision: 50f12ade2de1b30e989c13f410461cb27c126f13 URL: https://github.com/llvm/llvm-project/commit/50f12ade2de1b30e989c13f410461cb27c126f13 DIFF: https://github.com/llvm/llvm-project/commit/50f12ade2de1b30e989c13f410461cb27c126f13.diff LOG

[Lldb-commits] [PATCH] D91612: [lldb] Fix a couple of remote llgs tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG50f12ade2de1: [lldb] Fix a couple of remote llgs tests (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91612/new/ https://reviews

[Lldb-commits] [PATCH] D91634: [lldb] Error when there are no ports to launch a gdbserver on

labath added a comment. Yeah, I don't think it's possible to write a reliable end-to-end test for this feature. A unit test might be an option -- I don't know how hard it would be to mock the parts needed (starting a debug server). One could also consider refactoring this code to avoid the usag

[Lldb-commits] [PATCH] D91645: [lldb] [test] Un-XFAIL tests on freebsd/i386

labath added inline comments. Herald added a subscriber: JDevlieghere. Comment at: lldb/test/API/functionalities/exec/TestExec.py:19 -@expectedFailureAll(archs=['i386'], bugnumber="rdar://28656532") +@expectedFailureAll(archs=['i386'], +oslist=no

[Lldb-commits] [PATCH] D91645: [lldb] [test] Un-XFAIL tests on freebsd/i386

labath added inline comments. Comment at: lldb/test/API/functionalities/exec/TestExec.py:19 -@expectedFailureAll(archs=['i386'], bugnumber="rdar://28656532") +@expectedFailureAll(archs=['i386'], +oslist=no_match(["freebsd"]), lab

[Lldb-commits] [PATCH] D91241: [LLDB] Make offset field optional in RegisterInfo packet for Arm64

labath added a comment. Yes, this is pretty much what I hoped for. Thanks. Besides relaxing existing tests, it would be nice to have a positive test that checks for the behavior that we want. Maybe a gdb-client test which checks that the register values are extracted from the appropriate place

[Lldb-commits] [PATCH] D91634: [lldb] Error when there are no ports to launch a gdbserver on

DavidSpickett added a comment. I hadn't considered using a unit test instead, I'll give that a go. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91634/new/ https://reviews.llvm.org/D91634 ___ lldb-commit

[Lldb-commits] [lldb] ccd9091 - [lldb][NFC] Don't let Process inherit from UserID

Author: Raphael Isemann Date: 2020-11-18T14:33:48+01:00 New Revision: ccd9091d4a2fd55cb455e61fa77530e1a5de6e69 URL: https://github.com/llvm/llvm-project/commit/ccd9091d4a2fd55cb455e61fa77530e1a5de6e69 DIFF: https://github.com/llvm/llvm-project/commit/ccd9091d4a2fd55cb455e61fa77530e1a5de6e69.dif

[Lldb-commits] [PATCH] D91699: [lldb][NFC] Don't let Process inherit from UserID

This revision was automatically updated to reflect the committed changes. Closed by commit rGccd9091d4a2f: [lldb][NFC] Don't let Process inherit from UserID (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior to commit: https://reviews.l

[Lldb-commits] [PATCH] D90729: [trace][intel-pt] Scaffold the 'thread trace start | stop' commands

labath added a comment. I am can't keep up with all the reviews, so don't wait on my account. I checking these out from time to time though, and I will speak up if I see something very out of place. I like the idea of a common base class for different kinds of "core" processes. The name Record

[Lldb-commits] [PATCH] D87442: [lldb] Show flags for memory regions

DavidSpickett updated this revision to Diff 306091. DavidSpickett added a comment. Updated the way the test works. - If you build without MTE in the toolchain the binary just returns the magic failure number. - If you do have an MTE toolchain but your target doesn't have MTE then it will also f

[Lldb-commits] [PATCH] D91645: [lldb] [test] Un-XFAIL tests on freebsd/i386

emaste added inline comments. Comment at: lldb/test/API/functionalities/exec/TestExec.py:19 -@expectedFailureAll(archs=['i386'], bugnumber="rdar://28656532") +@expectedFailureAll(archs=['i386'], +oslist=no_match(["freebsd"]), lab

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values

mgorny updated this revision to Diff 306159. mgorny retitled this revision from "[lldb] Use translated full ftag values [WIP]" to "[lldb] Use translated full ftag values". mgorny added a comment. Updated Linux to use pointer comparison and FreeBSD. It's ready for review now, though I'd use a bet

[Lldb-commits] [PATCH] D91497: [lldb] Add explicit 64-bit fip/fdp registers on x86_64

mgorny updated this revision to Diff 306160. mgorny added a comment. Added contained/invalidate entries for FIP/FDP. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91497/new/ https://reviews.llvm.org/D91497 Files: lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD

[Lldb-commits] [PATCH] D91728: [lldb] [Process/Utility] Declare register overlaps between ST and MM

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste. mgorny requested review of this revision. Explicitly declare register overlaps/invalidation between ST(i) and MMi registers. https://reviews.llvm.org/D91728 Files: lldb/source/Plugins/Process/Utility/RegisterCo

[Lldb-commits] [PATCH] D91728: [lldb] [Process/Utility] Declare register overlaps between ST and MM [WIP]

mgorny added a comment. @labath, what do you think about this approach? What really sucks is that we have to repeat the whole voodoo for i386 and amd64 separately. Comment at: lldb/source/Plugins/Process/Utility/RegisterInfos_x86_64.h:93 {

[Lldb-commits] [PATCH] D90729: [trace][intel-pt] Scaffold the 'thread trace start | stop' commands

wallace updated this revision to Diff 306177. wallace marked 5 inline comments as done. wallace added a comment. Renamed to SavedProcess Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90729/new/ https://reviews.llvm.org/D90729 Files: lldb/include

[Lldb-commits] [PATCH] D91508: [LLDB/Lua] add support for one-liner breakpoint callback

tammela added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Lua/Lua.cpp:60-78 +static int runCallback(lua_State *L) { + LuaCallback *callback = static_cast(lua_touserdata(L, -1)); + return (*callback)(L); +} + +llvm::Error Lua::Run(LuaCallback &callback) {

[Lldb-commits] [PATCH] D90729: [trace][intel-pt] Scaffold the 'thread trace start | stop' commands

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Thanks for chiming in Pavel. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90729/new/ https://reviews.llvm.org/D90729 ___

[Lldb-commits] [PATCH] D91742: [lldb] Add examples and reword source-map help string

kastiglione created this revision. kastiglione added reviewers: aprantl, keith. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kastiglione requested review of this revision. Herald added a subscriber: JDevlieghere. Update the help string for `target.source-map` to remove th

[Lldb-commits] [lldb] f3aa9e3 - [MachO] Update embedded part of ObjectFileMachO for Mangled API change

Author: Jonas Devlieghere Date: 2020-11-18T14:47:31-08:00 New Revision: f3aa9e36d91b7b0f4f24f7a3b13cf80c11356e5e URL: https://github.com/llvm/llvm-project/commit/f3aa9e36d91b7b0f4f24f7a3b13cf80c11356e5e DIFF: https://github.com/llvm/llvm-project/commit/f3aa9e36d91b7b0f4f24f7a3b13cf80c11356e5e.d

[Lldb-commits] [lldb] fb19f11 - [trace][intel-pt] Scaffold the 'thread trace start | stop' commands

Author: Walter Erquinigo Date: 2020-11-18T18:24:36-08:00 New Revision: fb19f11ef47bc479d42c11450817c5e855a9830b URL: https://github.com/llvm/llvm-project/commit/fb19f11ef47bc479d42c11450817c5e855a9830b DIFF: https://github.com/llvm/llvm-project/commit/fb19f11ef47bc479d42c11450817c5e855a9830b.di

[Lldb-commits] [PATCH] D90729: [trace][intel-pt] Scaffold the 'thread trace start | stop' commands

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfb19f11ef47b: [trace][intel-pt] Scaffold the 'thread trace start | stop' commands (authored by wallace). Changed prior to commit: https://reviews.