[Lldb-commits] [lldb] 2bd4540 - [LLDB] Fix typo in RegisterContextPOSIXProcessMonitor_arm64

Author: Muhammad Omair Javaid Date: 2020-11-24T07:09:00+05:00 New Revision: 2bd4540f3816bb7acda31cba5351d02192d63f81 URL: https://github.com/llvm/llvm-project/commit/2bd4540f3816bb7acda31cba5351d02192d63f81 DIFF:

[Lldb-commits] [lldb] b20f3cc - [lldb] Add platform select to TestProcessConnect.py

Author: Jonas Devlieghere Date: 2020-11-23T18:02:00-08:00 New Revision: b20f3cc5b560ae15a8f9018eb96d65e6f5e125d1 URL: https://github.com/llvm/llvm-project/commit/b20f3cc5b560ae15a8f9018eb96d65e6f5e125d1 DIFF:

[Lldb-commits] [PATCH] D91508: [LLDB/Lua] add support for one-liner breakpoint callback

tammela added a comment. > I'm not sure what you mean by that. Can you elaborate? Sure, it's was just a nod to your previous comment about that running callbacks (C++ lambdas) inside a `pcall` is a dangerous API. Although possible, it requires that the developer be very cautious about implicit

[Lldb-commits] [PATCH] D91508: [LLDB/Lua] add support for one-liner breakpoint callback

tammela updated this revision to Diff 307202. tammela added a comment. Redesign of the API Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91508/new/ https://reviews.llvm.org/D91508 Files: lldb/bindings/lua/lua-swigsafecast.swig

Re: [Lldb-commits] [lldb] 6c0cd56 - [lldb] Make `process connect` behave the same in sync and async mode.

I didn't see the test deleted upstream (perhaps you forgot to run `git push`?) so I removed it in 5b8e4a11029ff169fdac7caa3c7aa211f318adf6. On Mon, Nov 23, 2020 at 10:51 AM Jonas Devlieghere wrote: > I'm OOO this week but I've deleted the test until I can write a better one > next week. > > On

[Lldb-commits] [lldb] 5b8e4a1 - [lldb/test] Remove flaky `process connect` test.

Author: Jordan Rupprecht Date: 2020-11-23T12:49:50-08:00 New Revision: 5b8e4a11029ff169fdac7caa3c7aa211f318adf6 URL: https://github.com/llvm/llvm-project/commit/5b8e4a11029ff169fdac7caa3c7aa211f318adf6 DIFF:

Re: [Lldb-commits] [lldb] 6c0cd56 - [lldb] Make `process connect` behave the same in sync and async mode.

I'm OOO this week but I've deleted the test until I can write a better one next week. On Mon, Nov 23, 2020 at 5:21 AM Pavel Labath wrote: > On 14/11/2020 02:39, Jonas Devlieghere via lldb-commits wrote: > > +# RUN: echo -e 'platform select remote-gdb-server\nprocess connect >

[Lldb-commits] [PATCH] D91963: [lldb] [test/Register] Initial tests for regsets in core dumps [WIP]

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste. Herald added a subscriber: arichardson. mgorny requested review of this revision. Add initial tests for reading register sets from core dumps. This includes a C++ program to write registers and dump core,

[Lldb-commits] [lldb] a8f6f4e - [lldb] [test] Restore Windows-skip on 'process connect' tests

Author: Michał Górny Date: 2020-11-23T14:27:32+01:00 New Revision: a8f6f4e8733cd601246ddc3e391cd82236231846 URL: https://github.com/llvm/llvm-project/commit/a8f6f4e8733cd601246ddc3e391cd82236231846 DIFF: https://github.com/llvm/llvm-project/commit/a8f6f4e8733cd601246ddc3e391cd82236231846.diff

Re: [Lldb-commits] [lldb] 6c0cd56 - [lldb] Make `process connect` behave the same in sync and async mode.

On 14/11/2020 02:39, Jonas Devlieghere via lldb-commits wrote: +# RUN: echo -e 'platform select remote-gdb-server\nprocess connect connect://localhost:4321' | %lldb 2>&1 | FileCheck %s + +# CHECK: Platform: remote-gdb-server +# CHECK: Connected: no +# CHECK: error: Failed to connect port This

[Lldb-commits] [PATCH] D91847: [lldb] [debugserver] Add stN aliases for stmmN for compatibility

mgorny updated this revision to Diff 307021. mgorny added a comment. Added `system-debugserver` feature to skip tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91847/new/ https://reviews.llvm.org/D91847 Files:

[Lldb-commits] [PATCH] D91847: [lldb] [debugserver] Add stN aliases for stmmN for compatibility

krytarowski added a comment. I would mark stmmX as an alias to stX and keep stX as the default for all platforms. stmmX could be an alias for everybody for legacy reasons. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91847/new/ https://reviews.llvm.org/D91847

[Lldb-commits] [PATCH] D91847: [lldb] [debugserver] Add stN aliases for stmmN for compatibility

mgorny added a comment. In D91847#2410564 , @labath wrote: > Still looks good to me. :) Jason, do you have any concerns? > > Unfortunately, we still need a `@skipIfOutOfTreeDebugserver` equivalent Long term, probably yes. Short term, the tests are

[Lldb-commits] [PATCH] D91847: [lldb] [debugserver] Add stN aliases for stmmN for compatibility

mgorny updated this revision to Diff 306986. mgorny added a comment. Rebase and fix TestRegisters. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91847/new/ https://reviews.llvm.org/D91847 Files: lldb/test/API/commands/register/register/register_command/TestRegisters.py

[Lldb-commits] [PATCH] D91810: [lldb] Prevent 'process connect' from using local-only plugins

This revision was automatically updated to reflect the committed changes. mgorny marked an inline comment as done. Closed by commit rG18e4272a4fe4: [lldb] Prevent process connect from using local-only plugins (authored by mgorny). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] 18e4272 - [lldb] Prevent 'process connect' from using local-only plugins

Author: Michał Górny Date: 2020-11-23T09:48:55+01:00 New Revision: 18e4272a4fe4667a44f4d323140645a83ddfd864 URL: https://github.com/llvm/llvm-project/commit/18e4272a4fe4667a44f4d323140645a83ddfd864 DIFF: https://github.com/llvm/llvm-project/commit/18e4272a4fe4667a44f4d323140645a83ddfd864.diff

[Lldb-commits] [PATCH] D91847: [lldb] [debugserver] Add stN aliases for stmmN for compatibility

labath added a comment. Still looks good to me. :) Jason, do you have any concerns? Unfortunately, we still need a `@skipIfOutOfTreeDebugserver` equivalent CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91847/new/ https://reviews.llvm.org/D91847

[Lldb-commits] [PATCH] D91810: [lldb] Prevent 'process connect' from using local-only plugins

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/test/Shell/Commands/command-process-connect.test:1 # UNSUPPORTED: system-windows labath wrote: > I'm pretty sure windows suffered from the same problem. Ok, I will remove

[Lldb-commits] [PATCH] D91810: [lldb] Prevent 'process connect' from using local-only plugins

labath accepted this revision. labath added a comment. Seems ok. The code could really use a refactor though... Comment at: lldb/test/Shell/Commands/command-process-connect.test:1 # UNSUPPORTED: system-windows I'm pretty sure windows suffered from the same

[Lldb-commits] [PATCH] D91923: [lldb] [Process/FreeBSDRemote] Fix regset names and related tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG8018e7b447da: [lldb] [Process/FreeBSDRemote] Fix regset names and related tests (authored by mgorny). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D91922: [lldb] [test] Fix qRegisterInfo lldb-server test to handle missing registers

This revision was automatically updated to reflect the committed changes. Closed by commit rG9367b57dadb7: [lldb] [test] Fix qRegisterInfo lldb-server tests to handle missing registers (authored by mgorny). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] 8018e7b - [lldb] [Process/FreeBSDRemote] Fix regset names and related tests

Author: Michał Górny Date: 2020-11-23T09:28:20+01:00 New Revision: 8018e7b447dacb37a520fe989ab42c0586730961 URL: https://github.com/llvm/llvm-project/commit/8018e7b447dacb37a520fe989ab42c0586730961 DIFF: https://github.com/llvm/llvm-project/commit/8018e7b447dacb37a520fe989ab42c0586730961.diff

[Lldb-commits] [lldb] 9367b57 - [lldb] [test] Fix qRegisterInfo lldb-server tests to handle missing registers

Author: Michał Górny Date: 2020-11-23T09:26:23+01:00 New Revision: 9367b57dadb7a8515fa454cb4bb8e4cc45bf57d2 URL: https://github.com/llvm/llvm-project/commit/9367b57dadb7a8515fa454cb4bb8e4cc45bf57d2 DIFF: https://github.com/llvm/llvm-project/commit/9367b57dadb7a8515fa454cb4bb8e4cc45bf57d2.diff

[Lldb-commits] [PATCH] D91923: [lldb] [Process/FreeBSDRemote] Fix regset names and related tests

mgorny added a comment. I'll also add a TODO here wrt unsupported registers. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91923/new/ https://reviews.llvm.org/D91923 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D91922: [lldb] [test] Fix qRegisterInfo lldb-server test to handle missing registers

mgorny marked an inline comment as done. mgorny added a comment. Ok, will add the comment and push. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91922/new/ https://reviews.llvm.org/D91922 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D91728: [lldb] [Process/Utility] Declare register overlaps between ST and MM

This revision was automatically updated to reflect the committed changes. Closed by commit rG8f2f9a82e2cc: [lldb] [Process/Utility] Declare register overlaps between ST and MM (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D91934: [lldb] [Process/FreeBSD] Add missing 'override' kws to POSIXStopInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rG7b7c372e3fca: [lldb] [Process/FreeBSD] Add missing override kws to POSIXStopInfo (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 8f2f9a8 - [lldb] [Process/Utility] Declare register overlaps between ST and MM

Author: Michał Górny Date: 2020-11-23T09:23:14+01:00 New Revision: 8f2f9a82e2cc333d36ddd1b6bb0523623e065cdc URL: https://github.com/llvm/llvm-project/commit/8f2f9a82e2cc333d36ddd1b6bb0523623e065cdc DIFF: https://github.com/llvm/llvm-project/commit/8f2f9a82e2cc333d36ddd1b6bb0523623e065cdc.diff

[Lldb-commits] [lldb] 7b7c372 - [lldb] [Process/FreeBSD] Add missing 'override' kws to POSIXStopInfo

Author: Michał Górny Date: 2020-11-23T09:22:41+01:00 New Revision: 7b7c372e3fcadfd5ee6ab3fb68d9f0f1c25e0247 URL: https://github.com/llvm/llvm-project/commit/7b7c372e3fcadfd5ee6ab3fb68d9f0f1c25e0247 DIFF: https://github.com/llvm/llvm-project/commit/7b7c372e3fcadfd5ee6ab3fb68d9f0f1c25e0247.diff

[Lldb-commits] [PATCH] D91923: [lldb] [Process/FreeBSDRemote] Fix regset names and related tests

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Consistency is nice. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91923/new/ https://reviews.llvm.org/D91923 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D91922: [lldb] Fix qRegisterInfo to handle missing registers

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good. I'd rephrase the commit title to make it clearer this only changes the single test, and does not change behavior otherwise... Comment at:

[Lldb-commits] [PATCH] D91934: [lldb] [Process/FreeBSD] Add missing 'override' kws to POSIXStopInfo

labath accepted this revision. labath added a comment. I don't think you need to spin up reviews for trivial fixes such as this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91934/new/ https://reviews.llvm.org/D91934 ___ lldb-commits

[Lldb-commits] [PATCH] D90857: [lldb] add a missing dependency on intrinsics_gen

labath added a comment. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90857/new/ https://reviews.llvm.org/D90857 ___ lldb-commits mailing list lldb-commits@lists.llvm.org