[Lldb-commits] [PATCH] D92187: [lldb] [FreeBSD] Fix establishing DT_NEEDED libraries from dyld

krytarowski added a comment. In D92187#2424109 , @emaste wrote: >> One thing that FreeBSD should do, is to upgrade to the protocol version 1 >> (stored in r_version), like Linux, NetBSD and OpenBSD. > > It looks like Linux has always used r_version=1 (sin

[Lldb-commits] [PATCH] D92249: [LLDB/Python] Fix segfault on Python scripted breakpoints

tammela updated this revision to Diff 308608. tammela added a comment. Addressing comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92249/new/ https://reviews.llvm.org/D92249 Files: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpr

[Lldb-commits] [PATCH] D92187: [lldb] [FreeBSD] Fix establishing DT_NEEDED libraries from dyld

mgorny added a comment. I've added some more debug as requested, and it confirmed that Linux and FreeBSD dyld are behaving differently here. Linux triggers the breakpoint twice: first time in `add` state, including only `/lib64/ld-linux-x86-64.so.2` and `linux-vdso.so.1` in module list, and the

[Lldb-commits] [PATCH] D92187: [lldb] [FreeBSD] Fix establishing DT_NEEDED libraries from dyld

mgorny added a comment. Full logs below. Linux: (lldb) log enable lldb dyld (lldb) run lldb DynamicLoaderDarwin::UseDYLDSPI: Use old DynamicLoader plugin lldb DynamicLoaderDarwin::UseDYLDSPI: Use old DynamicLoader plugin lldb DYLDRendezvous::DYLDRend

[Lldb-commits] [PATCH] D92187: [lldb] [FreeBSD] Fix establishing DT_NEEDED libraries from dyld

labath added a comment. In D92187#2425301 , @mgorny wrote: > I've added some more debug as requested, and it confirmed that Linux and > FreeBSD dyld are behaving differently here. > > Linux triggers the breakpoint twice: first time in `add` state, includi

[Lldb-commits] [PATCH] D92314: [lldb] [Process/FreeBSDRemote] Implement GetLoadedModuleFileSpec() and GetFileLoadAddress()

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. These are basically workarounds for dynamic linker bugs, when we're not able to get complete information via r_debug. If your dynamic linker (loader) behaves, then it's not surprising that the

[Lldb-commits] [PATCH] D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote

labath added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp:34 ThreadGDBRemote &thread, uint32_t concrete_frame_idx, -GDBRemoteDynamicRegisterInfo ®_info, bool read_all_at_once, +GDBRemoteDynamicRegisterInfoSP reg_in

[Lldb-commits] [PATCH] D92187: [lldb] [FreeBSD] Fix establishing DT_NEEDED libraries from dyld

krytarowski added a comment. Ideally we should iterate over the startup process and investigate the state of the `r_debug` structure. Once it gets initialized, set the software brakpoint to `r_brk` and keep track of the dynamic loading and unloading of libraries. The tricky part is to detect th

[Lldb-commits] [lldb] 64f0462 - [lldb][NFC] Modernize and cleanup TestClassTemplateParameterPack

Author: Raphael Isemann Date: 2020-12-01T15:53:40+01:00 New Revision: 64f04629aa7a4cf9d2deb725683959faa4a857fe URL: https://github.com/llvm/llvm-project/commit/64f04629aa7a4cf9d2deb725683959faa4a857fe DIFF: https://github.com/llvm/llvm-project/commit/64f04629aa7a4cf9d2deb725683959faa4a857fe.dif

[Lldb-commits] [PATCH] D92103: [ASTImporter] Import the default argument of TemplateTypeParmDecl

teemperor added a comment. @gamesh411 I recreated the setup you listed (thanks for that btw) but for me this works just fine. I assume the crash happens in a class template from one of the external libraries. It probably works for me because I don't have the same library version as you have, bu

[Lldb-commits] [PATCH] D92187: [lldb] [FreeBSD] Fix establishing DT_NEEDED libraries from dyld

mgorny added a comment. In D92187#2425378 , @labath wrote: > In D92187#2425301 , @mgorny wrote: > >> I've added some more debug as requested, and it confirmed that Linux and >> FreeBSD dyld are behaving differently

[Lldb-commits] [lldb] 26b8ea2 - RegisterInfoPOSIX_arm64 remove unused bytes from g/G packet

Author: Muhammad Omair Javaid Date: 2020-12-02T03:19:39+05:00 New Revision: 26b8ea2e3782890be96612701866d8ccec616bdc URL: https://github.com/llvm/llvm-project/commit/26b8ea2e3782890be96612701866d8ccec616bdc DIFF: https://github.com/llvm/llvm-project/commit/26b8ea2e3782890be96612701866d8ccec616b

[Lldb-commits] [lldb] 78cb456 - Make offset field optional in RegisterInfo packet for Arm64

Author: Muhammad Omair Javaid Date: 2020-12-02T03:19:43+05:00 New Revision: 78cb4562faa7315fff030593bc6bca4dc033f803 URL: https://github.com/llvm/llvm-project/commit/78cb4562faa7315fff030593bc6bca4dc033f803 DIFF: https://github.com/llvm/llvm-project/commit/78cb4562faa7315fff030593bc6bca4dc033f8

[Lldb-commits] [PATCH] D92063: [LLDB] RegisterInfoPOSIX_arm64 remove unused bytes from g/G packet

This revision was automatically updated to reflect the committed changes. Closed by commit rG26b8ea2e3782: RegisterInfoPOSIX_arm64 remove unused bytes from g/G packet (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[Lldb-commits] [PATCH] D91241: [LLDB] Make offset field optional in RegisterInfo packet for Arm64

This revision was automatically updated to reflect the committed changes. Closed by commit rG78cb4562faa7: Make offset field optional in RegisterInfo packet for Arm64 (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[Lldb-commits] [lldb] e1f613c - [lldb] [test] Reenable two passing tests on FreeBSD

Author: Michał Górny Date: 2020-12-01T23:25:45+01:00 New Revision: e1f613ce3c61d0664fd3cff663f290cf1c2b9696 URL: https://github.com/llvm/llvm-project/commit/e1f613ce3c61d0664fd3cff663f290cf1c2b9696 DIFF: https://github.com/llvm/llvm-project/commit/e1f613ce3c61d0664fd3cff663f290cf1c2b9696.diff

[Lldb-commits] [lldb] fa7fabb - [LLDB] Rename duplicate TestAlignAsBaseClass.py

Author: Muhammad Omair Javaid Date: 2020-12-02T07:31:29+05:00 New Revision: fa7fabb644f8645442cbe42c78420240b6657160 URL: https://github.com/llvm/llvm-project/commit/fa7fabb644f8645442cbe42c78420240b6657160 DIFF: https://github.com/llvm/llvm-project/commit/fa7fabb644f8645442cbe42c78420240b66571

[Lldb-commits] [lldb] ce5e218 - [lldb] Fix build after found_decls was removed by 1f40d60a3b7f310ff3f77bb8643a27d979a703cb

Author: Fangrui Song Date: 2020-12-01T19:14:35-08:00 New Revision: ce5e21868c22479df62ebd8884adc1bd7c964433 URL: https://github.com/llvm/llvm-project/commit/ce5e21868c22479df62ebd8884adc1bd7c964433 DIFF: https://github.com/llvm/llvm-project/commit/ce5e21868c22479df62ebd8884adc1bd7c964433.diff

[Lldb-commits] [PATCH] D92452: [lldb] Treat remote macOS debugging like any other remote darwin platform

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, jasonmolenda, clayborg. JDevlieghere added a project: LLDB. Herald added subscribers: krytarowski, mgorny. JDevlieghere requested review of this revision. Extract remote debugging logic from PlatformMacOSX and move it into

[Lldb-commits] [PATCH] D92249: [LLDB/Python] Fix segfault on Python scripted breakpoints

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92249/new/ https://reviews.llvm.org/D92249 _

[Lldb-commits] [PATCH] D92452: [lldb] Treat remote macOS debugging like any other remote darwin platform

jasonmolenda added a comment. Looks good overall, nice test. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformRemoteMacOSX.cpp:152 + } else if (idx == m_num_arm_arches + 3) { +arch.SetTriple("arm64e-apple-ios"); +return true; wouldn't these be a

[Lldb-commits] [PATCH] D92452: [lldb] Treat remote macOS debugging like any other remote darwin platform

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformRemoteMacOSX.cpp:152 + } else if (idx == m_num_arm_arches + 3) { +arch.SetTriple("arm64e-apple-ios"); +return true;

[Lldb-commits] [PATCH] D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote

omjavaid updated this revision to Diff 308863. omjavaid added a comment. Updated after incorporating suggested changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82857/new/ https://reviews.llvm.org/D82857 Files: lldb/source/Plugins/Process/Utility/DynamicRegisterInfo.cpp lldb/s

[Lldb-commits] [lldb] 9126ba2 - [lldb][NFC] Fix test file name in lang/cpp/non-type-template-param

Author: Raphael Isemann Date: 2020-12-02T08:41:53+01:00 New Revision: 9126ba25a3eeffa438e20d3a18abf70eb547789d URL: https://github.com/llvm/llvm-project/commit/9126ba25a3eeffa438e20d3a18abf70eb547789d DIFF: https://github.com/llvm/llvm-project/commit/9126ba25a3eeffa438e20d3a18abf70eb547789d.dif