[Lldb-commits] [PATCH] D92452: [lldb] Treat remote macOS debugging like any other remote darwin platform

jasonmolenda added inline comments. Comment at: lldb/test/API/commands/platform/sdk/main.c:4-6 + for (int i = 0; i != 10; ++i) { +sleep(10); + } JDevlieghere wrote: > clayborg wrote: > > You can call pause() which will stop and wait for a signal to be deliv

[Lldb-commits] [PATCH] D92601: [lldb] Refactor the Symbolicator initializer

JDevlieghere created this revision. JDevlieghere added a reviewer: jingham. JDevlieghere requested review of this revision. We found out that we have clients relying on the old signature of the Symbolicator initializer. Make the signature compatible again and provide a factory method to initiali

[Lldb-commits] [PATCH] D92603: [lldb] Recognize MachO cpu sub-type 2 as arm64

JDevlieghere created this revision. JDevlieghere added a reviewer: jasonmolenda. Herald added subscribers: pzheng, omjavaid, kristof.beyls. JDevlieghere requested review of this revision. Make sure we recognize cpu sub-type 2 as arm64. In reality it's arm64e, but we don't have the triple for that.

[Lldb-commits] [PATCH] D92603: [lldb] Recognize MachO cpu sub-type 2 as arm64

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Bien. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92603/new/ https://reviews.llvm.org/D92603 ___ lldb-commits mailing list l

[Lldb-commits] [lldb] 9d9959e - [lldb] Recognize MachO cpu sub-type 2 as arm64

Author: Jonas Devlieghere Date: 2020-12-03T13:31:31-08:00 New Revision: 9d9959eeacd777b9a4ea82a2f59c2bdec5f7 URL: https://github.com/llvm/llvm-project/commit/9d9959eeacd777b9a4ea82a2f59c2bdec5f7 DIFF: https://github.com/llvm/llvm-project/commit/9d9959eeacd777b9a4ea82a2f59c2bdec5f7.d

[Lldb-commits] [PATCH] D92603: [lldb] Recognize MachO cpu sub-type 2 as arm64

This revision was automatically updated to reflect the committed changes. Closed by commit rG9d9959eeacd7: [lldb] Recognize MachO cpu sub-type 2 as arm64 (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D91734: [FastISel] Flush local value map on every instruction

dblaikie added a comment. This causes several regressions in the gdb test suite we're running internally - the failures are: FAIL: gdb.base/break.exp: breakpoint at start of multi line while conditional FAIL: gdb.base/break.exp: breakpoint info FAIL: gdb.base/foll-exec.exp: step through ex

[Lldb-commits] [PATCH] D90789: [docs] Update DebuggingJITedCode page after fix in LLDB

sgraenitz added a comment. Does anyone have objections to this documentation update? Preview is here still: https://weliveindetail.github.io/docs-pub/html/DebuggingJITedCode.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90789/new/ https://revi

[Lldb-commits] [PATCH] D91734: [FastISel] Flush local value map on every instruction

probinson added a comment. The constant materialization (xorl) obviously does not belong in the prologue; I think the instruction ordering with the patch is preferable. But, clearly we'd rather not have it attributed to line 0, but the line it actually belongs to. I'll start looking into this.

[Lldb-commits] [PATCH] D91734: [FastISel] Flush local value map on every instruction

probinson added a comment. @rnk is correct that the phi's source location is propagating to the xorl. I modified the .ll file to put a different line number on the phi, and the xorl picked it up. This is clearly on the front-end to get right. If we want to get down to cases, there are other p

[Lldb-commits] [PATCH] D91734: [FastISel] Flush local value map on every instruction

probinson added a comment. Just for grins, change the `&&` to `||` and see what happens... The xorl becomes a movb $1 (no surprise there). But, that instruction no longer has line-0, instead it becomes part of the prologue. This tells me that the xorl had an explicit line 0, while the 'movb $1'

[Lldb-commits] [PATCH] D91734: [FastISel] Flush local value map on every instruction

probinson added a comment. > Sometihng like this seems plausible to me: Yes, I was playing with essentially that exact patch last night. It has no effect on the final assembly on its own, but combined with my patch it does. > (a more general fix (that would cover cases where the instruction re

[Lldb-commits] [PATCH] D91734: [FastISel] Flush local value map on every instruction

dblaikie added a comment. In D91734#2426897 , @rnk wrote: > I see. We should give that constant materialization a location. Yeah, likely - if this patch makes constant materialization local to the IR instruction - if there's a reasonable location the IR

[Lldb-commits] [PATCH] D91734: [FastISel] Flush local value map on every instruction

rnk added a comment. I see. We should give that constant materialization a location. It looks like it is coming from a phi node. The IR looks like this: %6 = icmp ne i32 %5, 0, !dbg !11 br i1 %6, label %7, label %10, !dbg !12 7:; preds

[Lldb-commits] [PATCH] D91734: [FastISel] Flush local value map on every instruction

dblaikie added a comment. Sometihng like this seems plausible to me: $ git diff diff --git clang/lib/CodeGen/CGExprScalar.cpp clang/lib/CodeGen/CGExprScalar.cpp index c906af8a4afa..c85ce46508a6 100644 --- clang/lib/CodeGen/CGExprScalar.cpp +++ clang/lib/CodeGen/CGExprScalar.cpp @@ -4

[Lldb-commits] [PATCH] D91734: [FastISel] Flush local value map on every instruction

probinson added a comment. See D92606 for a front-end patch to improve locations in the IR. That, plus reapplying this patch, should help out GDB. I haven't had a chance to run the suite myself with both patches applied and I'm basically off tomorrow, so if @d

[Lldb-commits] [PATCH] D91734: [FastISel] Flush local value map on every instruction

dblaikie added a comment. In D91734#2431247 , @probinson wrote: >> Sometihng like this seems plausible to me: > > Yes, I was playing with essentially that exact patch last night. It has no > effect on the final assembly on its own, but combined with my p

[Lldb-commits] [PATCH] D92601: [lldb] Refactor the Symbolicator initializer

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92601/new/ https://reviews.llvm.org/D92601 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [lldb] 99ea2c4 - [lldb] Refactor the Symbolicator initializer

Author: Jonas Devlieghere Date: 2020-12-03T14:31:59-08:00 New Revision: 99ea2c461d140c5a6b7da91061daa1cd9b3ec9b9 URL: https://github.com/llvm/llvm-project/commit/99ea2c461d140c5a6b7da91061daa1cd9b3ec9b9 DIFF: https://github.com/llvm/llvm-project/commit/99ea2c461d140c5a6b7da91061daa1cd9b3ec9b9.d

[Lldb-commits] [PATCH] D92601: [lldb] Refactor the Symbolicator initializer

This revision was automatically updated to reflect the committed changes. Closed by commit rG99ea2c461d14: [lldb] Refactor the Symbolicator initializer (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D92609: [lldb] Use the cpu sub type defines for llvm::MachO

JDevlieghere created this revision. JDevlieghere added a reviewer: jasonmolenda. JDevlieghere requested review of this revision. Use the cpu sub type enum values from llvm::MachO. Also format the table. https://reviews.llvm.org/D92609 Files: lldb/source/Utility/ArchSpec.cpp Index: lldb/sourc

[Lldb-commits] [PATCH] D92609: [lldb] Use the cpu sub type defines for llvm::MachO

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Nice cleanup. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92609/new/ https://reviews.llvm.org/D92609 ___ lldb-commits mailin

[Lldb-commits] [lldb] 54710b3 - [lldb] Use the cpu subtype enum values from llvm::MachO in ArchSpec (NFC)

Author: Jonas Devlieghere Date: 2020-12-03T15:10:18-08:00 New Revision: 54710b346ce063ee10292c45b9e154195eb45a40 URL: https://github.com/llvm/llvm-project/commit/54710b346ce063ee10292c45b9e154195eb45a40 DIFF: https://github.com/llvm/llvm-project/commit/54710b346ce063ee10292c45b9e154195eb45a40.d

[Lldb-commits] [PATCH] D92609: [lldb] Use the cpu sub type defines for llvm::MachO

JDevlieghere closed this revision. JDevlieghere added a comment. Put the wrong differential URL in the commit: 54710b346ce063ee10292c45b9e154195eb45a40 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92609/new/ https: