[Lldb-commits] [PATCH] D93926: [lldb] Don't remove the lldb.debugger var after exiting the interpreter

2020-12-29 Thread Nathan Lanza via Phabricator via lldb-commits
lanza updated this revision to Diff 314037. lanza added a comment. Herald added a subscriber: JDevlieghere. did it backwards Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93926/new/ https://reviews.llvm.org/D93926 Files:

[Lldb-commits] [PATCH] D93926: [lldb] Don't remove the lldb.debugger var after exiting the interpreter

2020-12-29 Thread Nathan Lanza via Phabricator via lldb-commits
lanza created this revision. lanza requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The debugger itself doesn't get stale between script prompt usages. Setting this to `None` also breaks users of the scripting API that used this property in

[Lldb-commits] [PATCH] D93874: [process] fix exec support on Linux

2020-12-29 Thread walter erquinigo via Phabricator via lldb-commits
wallace updated this revision to Diff 314035. wallace added a comment. nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93874/new/ https://reviews.llvm.org/D93874 Files: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp

[Lldb-commits] [PATCH] D93495: CrashReason: Add MTE tag check faults to the list of crash reasons.

2020-12-29 Thread Peter Collingbourne via Phabricator via lldb-commits
pcc added inline comments. Comment at: lldb/source/Plugins/Process/POSIX/CrashReason.cpp:62 +#ifndef SEGV_MTEAERR +#define SEGV_MTEAERR 8 +#endif emaste wrote: > emaste wrote: > > This should perhaps include an `#ifdef LINUX`(sp?) somehow, since 8 and 9 > > are

[Lldb-commits] [PATCH] D93495: CrashReason: Add MTE tag check faults to the list of crash reasons.

2020-12-29 Thread Peter Collingbourne via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7e5a187de313: CrashReason: Add MTE tag check faults to the list of crash reasons. (authored by pcc). Herald added a subscriber: krytarowski.

[Lldb-commits] [lldb] 7e5a187 - CrashReason: Add MTE tag check faults to the list of crash reasons.

2020-12-29 Thread Peter Collingbourne via lldb-commits
Author: Peter Collingbourne Date: 2020-12-29T14:36:50-08:00 New Revision: 7e5a187de31358741f9868cdee7b0c63c1343d8d URL: https://github.com/llvm/llvm-project/commit/7e5a187de31358741f9868cdee7b0c63c1343d8d DIFF:

[Lldb-commits] [PATCH] D93874: [process] fix exec support on Linux

2020-12-29 Thread walter erquinigo via Phabricator via lldb-commits
wallace updated this revision to Diff 313997. wallace added a comment. Updated the description of the diff. It was actually very easy to find a deterministic reproduction of the failure. And the diff is actually minimal now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D93895: Implement vAttachWait in lldb-server

2020-12-29 Thread Augusto Noronha via Phabricator via lldb-commits
augusto2112 updated this revision to Diff 313954. augusto2112 added a comment. Fix formatting issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93895/new/ https://reviews.llvm.org/D93895 Files:

[Lldb-commits] [PATCH] D93895: Implement vAttachWait in lldb-server

2020-12-29 Thread Augusto Noronha via Phabricator via lldb-commits
augusto2112 added a comment. Hi guys. I recently ran into an issue where I couldn't use --waitfor on Linux. I found out that there's a patch that adds the functionality which was only missing a test (https://reviews.llvm.org/D47879), so I decided to pick up from where it left. @labath I

[Lldb-commits] [PATCH] D93895: Implement vAttachWait in lldb-server

2020-12-29 Thread Augusto Noronha via Phabricator via lldb-commits
augusto2112 created this revision. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D93895 Files:

[Lldb-commits] [lldb] a0b68a2 - [lldb] Deduplicate some tests in TestLldbGdbServer

2020-12-29 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2020-12-29T09:37:01+01:00 New Revision: a0b68a2925fbe31f4b0af27677d55feaff6b1362 URL: https://github.com/llvm/llvm-project/commit/a0b68a2925fbe31f4b0af27677d55feaff6b1362 DIFF: https://github.com/llvm/llvm-project/commit/a0b68a2925fbe31f4b0af27677d55feaff6b1362.diff

[Lldb-commits] [PATCH] D93874: [process] fix exec support on Linux

2020-12-29 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. It seems Thread plans already have logic to handle "exec" events. It would be better to figure out why that logic is not sufficient instead of