[Lldb-commits] [PATCH] D94888: [lldb] Add -Wl, -rpath to make tests run with fresh built libc++

rupprecht added a comment. In D94888#2506140 , @labath wrote: > In D94888#2506000 , @MaskRay wrote: > >> In D94888#2505992 , @labath wrote: >> >>> It looks like this is

[Lldb-commits] [PATCH] D95110: [lldb] Upstream eCore_arm_arm64e enum value

This revision was automatically updated to reflect the committed changes. Closed by commit rGbaf6c2987e57: [lldb] Upstream eCore_arm_arm64e enum value in ArchSpec (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] baf6c29 - [lldb] Upstream eCore_arm_arm64e enum value in ArchSpec

Author: Jonas Devlieghere Date: 2021-01-20T19:39:47-08:00 New Revision: baf6c2987e576e319857c586120e98e917d8b47f URL: https://github.com/llvm/llvm-project/commit/baf6c2987e576e319857c586120e98e917d8b47f DIFF:

[Lldb-commits] [PATCH] D95110: [lldb] Upstream eCore_arm_arm64e enum value

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Looks good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95110/new/ https://reviews.llvm.org/D95110 ___ lldb-commits mailing

[Lldb-commits] [lldb] 98feb08 - Use CXX_SOURCES and point to the right source file.

Author: Jim Ingham Date: 2021-01-20T18:38:07-08:00 New Revision: 98feb08e449f179c3c5ccc6878c31cf16c160b06 URL: https://github.com/llvm/llvm-project/commit/98feb08e449f179c3c5ccc6878c31cf16c160b06 DIFF: https://github.com/llvm/llvm-project/commit/98feb08e449f179c3c5ccc6878c31cf16c160b06.diff

[Lldb-commits] [PATCH] D95110: [lldb] Upstream eCore_arm_arm64e enum value

JDevlieghere created this revision. JDevlieghere added a reviewer: jasonmolenda. Herald added subscribers: pzheng, kristof.beyls. JDevlieghere requested review of this revision. Upstream the `eCore_arm_arm64e` in ArchSpec. https://reviews.llvm.org/D95110 Files:

[Lldb-commits] [PATCH] D94846: Allow breakpoints to be set on C++11 inline initializers

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbff389120fa2: Fix a bug with setting breakpoints on C++11 inline

[Lldb-commits] [lldb] bff3891 - Fix a bug with setting breakpoints on C++11 inline initialization statements.

Author: Jim Ingham Date: 2021-01-20T17:58:34-08:00 New Revision: bff389120fa2368d123612449c938958cfd7f45e URL: https://github.com/llvm/llvm-project/commit/bff389120fa2368d123612449c938958cfd7f45e DIFF: https://github.com/llvm/llvm-project/commit/bff389120fa2368d123612449c938958cfd7f45e.diff

[Lldb-commits] [PATCH] D95100: [lldb/Commands] Fix short option collision for `process launch`

mib updated this revision to Diff 318072. mib added a comment. Changed short option to `-E|--environment` as @jingham suggested it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95100/new/ https://reviews.llvm.org/D95100 Files:

[Lldb-commits] [PATCH] D94937: [lldb] change SBStructuredData GetStringValue signature

tammela added a comment. In D94937#2511222 , @JDevlieghere wrote: > I replied before I actually tried to understand what your'e trying to > achieve, and it's still not entirely clear to me. I think what you need is > something similar like

[Lldb-commits] [PATCH] D95100: [lldb/Commands] Fix short option collision for `process launch`

jingham added a comment. We shouldn't lightly change options that are commonly used. But we haven't made a strong statement about this the way we do for API. I'm more concerned about people having to rewrite/build and distribute their code to accommodate a new lldb than having to learn a new

[Lldb-commits] [PATCH] D94937: [lldb] change SBStructuredData GetStringValue signature

JDevlieghere added a comment. I replied before I actually tried to understand what your'e trying to achieve, and it's still not entirely clear to me. I think what you need is something similar like `python-typemaps.swig` which helps swig understand `char**` types and such. For context,

[Lldb-commits] [PATCH] D95100: [lldb/Commands] Fix short option collision for `process launch`

JDevlieghere added a comment. @jingham should weigh in here, but I think we kind of guarantee (at least informally) that the command options to be stable. Is there an alternative way to fix this without breaking the existing option? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D95100: [lldb/Commands] Fix short option collision for `process launch`

mib created this revision. mib added reviewers: JDevlieghere, jingham, teemperor. Herald added a subscriber: dang. mib requested review of this revision. Herald added a project: LLDB. This patch changes the short option used in the CommandOptionsProcessLaunch for the `-v|--environment` command

[Lldb-commits] [PATCH] D94997: [lldb][lldb-vscode] Updated implementation of 'launch' and 'attach' requests to not create auxiliary target in case "launchCommands" and "attachCommands" are provided.

clayborg added a comment. In D94997#2509175 , @tatyana-krasnukha wrote: > D92164 was intended for fixing the > "settings set" issue, however, it revealed some deadlocks and data races, and > had to be reverted

[Lldb-commits] [PATCH] D94997: [lldb][lldb-vscode] Updated implementation of 'launch' and 'attach' requests to not create auxiliary target in case "launchCommands" and "attachCommands" are provided.

clayborg added a comment. In D94997#2510144 , @serhiy.redko wrote: > Thanks for review and your input, @clayborg > >> So I agree we need to fix the "settings set" issue as it surfaces a quirk in >> the order and number of targets we create. The main

[Lldb-commits] [PATCH] D94890: Makefile.rules: Avoid redundant .d generation (make restart) and inline archive rule to the only test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6afdf13ae4cc: Makefile.rules: Avoid redundant .d generation (make restart) and inline archive… (authored by MaskRay). Repository: rG LLVM Github

[Lldb-commits] [lldb] 6afdf13 - Makefile.rules: Avoid redundant .d generation (make restart) and inline archive rule to the only test

Author: Fangrui Song Date: 2021-01-20T14:22:33-08:00 New Revision: 6afdf13ae4ccf00296065960a0b311c87e6f8dd5 URL: https://github.com/llvm/llvm-project/commit/6afdf13ae4ccf00296065960a0b311c87e6f8dd5 DIFF: https://github.com/llvm/llvm-project/commit/6afdf13ae4ccf00296065960a0b311c87e6f8dd5.diff

[Lldb-commits] [PATCH] D94890: Makefile.rules: Avoid redundant .d generation (make restart) and inline archive rule to the only test

JDevlieghere accepted this revision. JDevlieghere added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94890/new/ https://reviews.llvm.org/D94890 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D94890: Makefile.rules: Avoid redundant .d generation (make restart) and inline archive rule to the only test

MaskRay updated this revision to Diff 318011. MaskRay marked an inline comment as done. MaskRay added a comment. $(RM) a.o b.o Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94890/new/ https://reviews.llvm.org/D94890 Files:

[Lldb-commits] [PATCH] D95059: [lldb/Commands] Refactor ProcessLaunchCommandOptions to use TableGen (NFC)

JDevlieghere added inline comments. Comment at: lldb/source/Commands/CommandOptionsProcessLaunch.h:1 +//===-- CommandOptionsProcessLaunch.h -===// +// Nit: header files should have the `-*- C++ -*-===//` at the

[Lldb-commits] [PATCH] D94890: Makefile.rules: Avoid redundant .d generation (make restart) and inline archive rule to the only test

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM with the inline comment addressed. Comment at: lldb/test/API/functionalities/archives/Makefile:11 +libfoo.a: a.o b.o + $(AR) $(ARFLAGS) $@ $^

[Lldb-commits] [PATCH] D94890: Makefile.rules: Avoid redundant .d generation (make restart) and inline archive rule to the only test

MaskRay updated this revision to Diff 317985. MaskRay retitled this revision from "Makefile.rules: Avoid redundant .d generation and make restart" to "Makefile.rules: Avoid redundant .d generation (make restart) and inline archive rule to the only test". MaskRay edited the summary of this

[Lldb-commits] [PATCH] D94890: Makefile.rules: Avoid redundant .d generation and make restart

MaskRay added a comment. In D94890#2510627 , @JDevlieghere wrote: > In D94890#2510446 , @MaskRay wrote: > >> Is this good? :) > > I think you forgot to update the patch? Ah, looks like you want to do inline

[Lldb-commits] [PATCH] D94890: Makefile.rules: Avoid redundant .d generation and make restart

MaskRay updated this revision to Diff 317983. MaskRay added a comment. Inline archive rule Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94890/new/ https://reviews.llvm.org/D94890 Files: lldb/packages/Python/lldbsuite/test/make/Makefile.rules

[Lldb-commits] [PATCH] D94890: Makefile.rules: Avoid redundant .d generation and make restart

JDevlieghere added a comment. In D94890#2510446 , @MaskRay wrote: > Is this good? :) I think you forgot to update the patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94890/new/

[Lldb-commits] [lldb] 8fc9b6c - [lldb/Commands] Align process launch --plugin with process attach (NFC)

Author: Med Ismail Bennani Date: 2021-01-20T21:01:23+01:00 New Revision: 8fc9b6c2c560fc5945ce2115de345efb1617d59d URL: https://github.com/llvm/llvm-project/commit/8fc9b6c2c560fc5945ce2115de345efb1617d59d DIFF:

Re: [Lldb-commits] [lldb] 079e664 - [lldb] Re-enable TestPlatformProcessConnect on macos

On Wed, Jan 20, 2021 at 2:51 PM Pavel Labath wrote: > On 20/01/2021 04:35, Eric Christopher wrote: > > +Jordan Rupprecht > > > > Interesting, we were using this internally to point to an lldb-server to > > test. I've disabled some tests at the moment, but I'm not

Re: [Lldb-commits] [lldb] 079e664 - [lldb] Re-enable TestPlatformProcessConnect on macos

On 20/01/2021 04:35, Eric Christopher wrote: +Jordan Rupprecht Interesting, we were using this internally to point to an lldb-server to test. I've disabled some tests at the moment, but I'm not sure it isn't entirely useful functionality :) -eric Yes, I

[Lldb-commits] [lldb] 599fdfc - Revert "[lldb] Re-enable TestPlatformProcessConnect on macos"

Author: Pavel Labath Date: 2021-01-20T20:49:03+01:00 New Revision: 599fdfc5db8f44582ee9bd05544769268ec9b4a3 URL: https://github.com/llvm/llvm-project/commit/599fdfc5db8f44582ee9bd05544769268ec9b4a3 DIFF: https://github.com/llvm/llvm-project/commit/599fdfc5db8f44582ee9bd05544769268ec9b4a3.diff

[Lldb-commits] [PATCH] D94890: Makefile.rules: Avoid redundant .d generation and make restart

MaskRay added a comment. Is this good? :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94890/new/ https://reviews.llvm.org/D94890 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D94997: [lldb][lldb-vscode] Updated implementation of 'launch' and 'attach' requests to not create auxiliary target in case "launchCommands" and "attachCommands" are provided.

aadsm added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:1558 + if (!launchCommands.empty()) { +// if "launchCommands" are provided, then they are expected to make the +// launch happen for launch requests and they replace the normal logic that

[Lldb-commits] [PATCH] D95059: [lldb/Commands] Refactor ProcessLaunchCommandOptions to use TableGen (NFC)

mib closed this revision. mib added a comment. Landed in 7169d3a315f4 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95059/new/ https://reviews.llvm.org/D95059

[Lldb-commits] [lldb] 7169d3a - [lldb/Commands] Refactor ProcessLaunchCommandOptions to use TableGen (NFC)

Author: Med Ismail Bennani Date: 2021-01-20T18:53:06+01:00 New Revision: 7169d3a315f4cdc19c4ab6b8f20c6f91b46ba9b8 URL: https://github.com/llvm/llvm-project/commit/7169d3a315f4cdc19c4ab6b8f20c6f91b46ba9b8 DIFF:

[Lldb-commits] [PATCH] D94997: [lldb][lldb-vscode] Updated implementation of 'launch' and 'attach' requests to not create auxiliary target in case "launchCommands" and "attachCommands" are provided.

serhiy.redko planned changes to this revision. serhiy.redko added a comment. Thanks for review and your input, @clayborg > So I agree we need to fix the "settings set" issue as it surfaces a quirk in > the order and number of targets we create. The main questions is if we care > that we don't

[Lldb-commits] [PATCH] D95059: [lldb/Commands] Refactor ProcessLaunchCommandOptions to use TableGen (NFC)

mib updated this revision to Diff 317914. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95059/new/ https://reviews.llvm.org/D95059 Files: lldb/include/lldb/Target/Process.h lldb/source/Commands/CMakeLists.txt

[Lldb-commits] [PATCH] D95059: [lldb/Commands] Refactor ProcessLaunchCommandOptions to use TableGen (NFC)

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95059/new/ https://reviews.llvm.org/D95059

[Lldb-commits] [PATCH] D95059: [lldb/Commands] Refactor ProcessLaunchCommandOptions to use TableGen (NFC)

mib updated this revision to Diff 317911. mib added a comment. Add header guards and split tablegen long description into multiple lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95059/new/ https://reviews.llvm.org/D95059 Files:

[Lldb-commits] [PATCH] D95059: [lldb/Commands] Refactor ProcessLaunchCommandOptions to use TableGen (NFC)

mib created this revision. mib added a reviewer: teemperor. Herald added subscribers: dang, mgorny. mib requested review of this revision. Herald added a project: LLDB. This patch refactors the current implementation of `ProcessLaunchCommandOptions` to be generated by TableGen. The patch also

[Lldb-commits] [PATCH] D93939: [elf-core] Improve reading memory from core file

djtodoro updated this revision to Diff 317873. djtodoro edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93939/new/ https://reviews.llvm.org/D93939 Files: lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp

[Lldb-commits] [PATCH] D94672: Implement vAttachOrWait

augusto2112 added a comment. @labath, @clayborg since both of you approved of it, I think this patch is ready to be merged, right? Could one of you do it? I don't have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94672/new/

[Lldb-commits] [PATCH] D94997: [lldb][lldb-vscode] Updated implementation of 'launch' and 'attach' requests to not create auxiliary target in case "launchCommands" and "attachCommands" are provided.

tatyana-krasnukha added a comment. D92164 was intended for fixing the "settings set" issue, however, it revealed some deadlocks and data races, and had to be reverted temporarily. Currently, I'm working on those multithreading issues and will submit a patch as

[Lldb-commits] [lldb] b3c260d - [lldb][docs] Expand CSS fix for LLDB doc tables

Author: Raphael Isemann Date: 2021-01-20T10:30:00+01:00 New Revision: b3c260d8fa07ed1202afdda9ca4c437a2a847080 URL: https://github.com/llvm/llvm-project/commit/b3c260d8fa07ed1202afdda9ca4c437a2a847080 DIFF:

[Lldb-commits] [PATCH] D94967: [lldb][docs] Filter out 'thisown' attribute and inheritance boilerplate

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c69ff4b03ab: [lldb][docs] Filter out thisown attribute and inheritance boilerplate (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM

[Lldb-commits] [lldb] 3c69ff4 - [lldb][docs] Filter out 'thisown' attribute and inheritance boilerplate

Author: Raphael Isemann Date: 2021-01-20T09:07:36+01:00 New Revision: 3c69ff4b03abaa3b7b80f4f3f2a1c1806e2d4495 URL: https://github.com/llvm/llvm-project/commit/3c69ff4b03abaa3b7b80f4f3f2a1c1806e2d4495 DIFF:

[Lldb-commits] [PATCH] D94991: [lldb][docs] Remove -webkit-hyphens in table cells so that table widths are correct on Safari

This revision was automatically updated to reflect the committed changes. Closed by commit rG7fce3b240b6b: [lldb][docs] Remove -webkit-hyphens in table cells so that table widths are… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG

[Lldb-commits] [lldb] 7fce3b2 - [lldb][docs] Remove -webkit-hyphens in table cells so that table widths are correct on Safari

Author: Raphael Isemann Date: 2021-01-20T09:05:28+01:00 New Revision: 7fce3b240b6b313b1becf19ddf3f2a904c34ced2 URL: https://github.com/llvm/llvm-project/commit/7fce3b240b6b313b1becf19ddf3f2a904c34ced2 DIFF: