[Lldb-commits] [PATCH] D91679: [trace][intel-pt] Implement trace start and trace stop

wallace added inline comments. Comment at: lldb/docs/lldb-gdb-remote.txt:278 +// "tids": [], +// "variant": "specificThreads" | "currentAndFutureThreads" | "process", +// "params": { clayborg wrote: > Seems like we don't need the "variant" here. If we

[Lldb-commits] [PATCH] D91679: [trace][intel-pt] Implement trace start and trace stop

clayborg added a comment. > The start and stop operations have 3 variants for now: > > - specificThreads: operate on specific threads (e.g. thread trace start 2 3 9) > - currentAndFutureThreads: operate of all threads including future ones (e.g. > thread trace start all) > - process: operate on

[Lldb-commits] [PATCH] D93951: [vscode] Improve runInTerminal and support linux

wallace added a comment. I'll send a diff tomorrow morning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93951/new/ https://reviews.llvm.org/D93951 ___ lldb-commits mailing list lldb-commits@lists.llvm.o

[Lldb-commits] [PATCH] D93951: [vscode] Improve runInTerminal and support linux

stella.stamenova added a comment. In D93951#2523886 , @wallace wrote: > @stella.stamenova , is that build a Debug or Release build? I think that will > help me determine why it's failing Release. It passed in Debug. Repository: rG LLVM Github Monorep

[Lldb-commits] [PATCH] D93951: [vscode] Improve runInTerminal and support linux

wallace added a comment. @stella.stamenova , is that build a Debug or Release build? I think that will help me determine why it's failing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93951/new/ https://reviews.llvm.org/D93951 ___

[Lldb-commits] [PATCH] D93951: [vscode] Improve runInTerminal and support linux

stella.stamenova added a comment. I am seeing this consistently fail on our internal Ubuntu bot: ERROR: test_missingArgInRunInTerminalLauncher (TestVSCode_runInTerminal.TestVSCode_runInTerminal) -- Traceback (most recent c

[Lldb-commits] [PATCH] D95008: Revert "Revert "Ignores functions that have a range starting outside of a code section""

stella.stamenova added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:775 + return dwarf_ast->ParseFunctionFromDWARF(comp_unit, die, + m_first_code_address); } This line does not b

[Lldb-commits] [PATCH] D95411: [lldb] Remove unused ThreadPlanStack::GetStackOfKind (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG90b8ae016bca: [lldb] Remove unused ThreadPlanStack::GetStackOfKind (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95411/new/